[jira] [Commented] (LUCENE-5097) Add utility method to Analyzer: public final TokenStream tokenStream(String fieldName,String text)
[ https://issues.apache.org/jira/browse/LUCENE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13702024#comment-13702024 ] Robert Muir commented on LUCENE-5097: - +1 Add utility method to Analyzer: public final TokenStream tokenStream(String fieldName,String text) -- Key: LUCENE-5097 URL: https://issues.apache.org/jira/browse/LUCENE-5097 Project: Lucene - Core Issue Type: Bug Components: modules/analysis Affects Versions: 4.3.1 Reporter: Uwe Schindler It might be a good idea to remove tons of useless code from tests: Most people use TokenStreams and Analyzers by only passing a String, wrapped by a StringReader. It would make life easier, if Analyzer would have an additional public (and final!!!) method that simply does the wrapping with StringReader by itsself. It might maybe not even needed to throw IOException (not sure) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5097) Add utility method to Analyzer: public final TokenStream tokenStream(String fieldName,String text)
[ https://issues.apache.org/jira/browse/LUCENE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13702026#comment-13702026 ] Uwe Schindler commented on LUCENE-5097: --- Another suggestion here: Currently we have a crazy reuseable reader in Field.java. This one could go away, instead the Analyzer would store a resuseable reader in TokenStreamComponents/the TS cache. Field.java would be simplier as it would just call this method to get the TS from a String field. Add utility method to Analyzer: public final TokenStream tokenStream(String fieldName,String text) -- Key: LUCENE-5097 URL: https://issues.apache.org/jira/browse/LUCENE-5097 Project: Lucene - Core Issue Type: Bug Components: modules/analysis Affects Versions: 4.3.1 Reporter: Uwe Schindler It might be a good idea to remove tons of useless code from tests: Most people use TokenStreams and Analyzers by only passing a String, wrapped by a StringReader. It would make life easier, if Analyzer would have an additional public (and final!!!) method that simply does the wrapping with StringReader by itsself. It might maybe not even needed to throw IOException (not sure) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5097) Add utility method to Analyzer: public final TokenStream tokenStream(String fieldName,String text)
[ https://issues.apache.org/jira/browse/LUCENE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13702081#comment-13702081 ] Robert Muir commented on LUCENE-5097: - I just took a quick glance and this looks fantastic Add utility method to Analyzer: public final TokenStream tokenStream(String fieldName,String text) -- Key: LUCENE-5097 URL: https://issues.apache.org/jira/browse/LUCENE-5097 Project: Lucene - Core Issue Type: Bug Components: modules/analysis Affects Versions: 4.3.1 Reporter: Uwe Schindler Attachments: LUCENE-5097.patch, LUCENE-5097.patch It might be a good idea to remove tons of useless code from tests: Most people use TokenStreams and Analyzers by only passing a String, wrapped by a StringReader. It would make life easier, if Analyzer would have an additional public (and final!!!) method that simply does the wrapping with StringReader by itsself. It might maybe not even needed to throw IOException (not sure) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5097) Add utility method to Analyzer: public final TokenStream tokenStream(String fieldName,String text)
[ https://issues.apache.org/jira/browse/LUCENE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13702178#comment-13702178 ] ASF subversion and git services commented on LUCENE-5097: - Commit 1500862 from [~thetaphi] [ https://svn.apache.org/r1500862 ] LUCENE-5097: Analyzer now has an additional tokenStream(String fieldName, String text) method, so wrapping by StringReader for common use is no longer needed. This method uses an internal reuseable reader, which was previously only used by the Field class. Add utility method to Analyzer: public final TokenStream tokenStream(String fieldName,String text) -- Key: LUCENE-5097 URL: https://issues.apache.org/jira/browse/LUCENE-5097 Project: Lucene - Core Issue Type: Bug Components: modules/analysis Affects Versions: 4.3.1 Reporter: Uwe Schindler Attachments: LUCENE-5097.patch, LUCENE-5097.patch, LUCENE-5097.patch It might be a good idea to remove tons of useless code from tests: Most people use TokenStreams and Analyzers by only passing a String, wrapped by a StringReader. It would make life easier, if Analyzer would have an additional public (and final!!!) method that simply does the wrapping with StringReader by itsself. It might maybe not even needed to throw IOException (not sure) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5097) Add utility method to Analyzer: public final TokenStream tokenStream(String fieldName,String text)
[ https://issues.apache.org/jira/browse/LUCENE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13702195#comment-13702195 ] ASF subversion and git services commented on LUCENE-5097: - Commit 1500864 from [~thetaphi] [ https://svn.apache.org/r1500864 ] Merged revision(s) 1500862 from lucene/dev/trunk: LUCENE-5097: Analyzer now has an additional tokenStream(String fieldName, String text) method, so wrapping by StringReader for common use is no longer needed. This method uses an internal reuseable reader, which was previously only used by the Field class. Add utility method to Analyzer: public final TokenStream tokenStream(String fieldName,String text) -- Key: LUCENE-5097 URL: https://issues.apache.org/jira/browse/LUCENE-5097 Project: Lucene - Core Issue Type: Bug Components: modules/analysis Affects Versions: 4.3.1 Reporter: Uwe Schindler Attachments: LUCENE-5097.patch, LUCENE-5097.patch, LUCENE-5097.patch It might be a good idea to remove tons of useless code from tests: Most people use TokenStreams and Analyzers by only passing a String, wrapped by a StringReader. It would make life easier, if Analyzer would have an additional public (and final!!!) method that simply does the wrapping with StringReader by itsself. It might maybe not even needed to throw IOException (not sure) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
