[jira] [Commented] (LUCENE-5325) Move ValueSource and FunctionValues under core/
[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15786058#comment-15786058
]
ASF subversion and git services commented on LUCENE-5325:
-
Commit a4335c0e9f01275c7d6e807813d9818b6e59d76e in lucene-solr's branch
refs/heads/master from [~romseygeek]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a4335c0 ]
LUCENE-5325: Add test for missing values in sorts
> Move ValueSource and FunctionValues under core/
> ---
>
> Key: LUCENE-5325
> URL: https://issues.apache.org/jira/browse/LUCENE-5325
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
>Reporter: Shai Erera
> Attachments: LUCENE-5325-6x-matchingbits.patch, LUCENE-5325-6x.patch,
> LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch,
> LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch
>
>
> Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs
> which exist under the queries/ module. That causes any module which wants to
> depend on these APIs (but not necessarily on any of their actual
> implementations!), to depend on the queries/ module. If we move these APIs
> under core/, we can eliminate these dependencies and add some mock impls for
> testing purposes.
> Quoting Robert from LUCENE-5298:
> {quote}
> we should eliminate the suggest/ dependencies on expressions and queries, the
> expressions/ on queries, the grouping/ dependency on queries, the spatial/
> dependency on queries, its a mess.
> {quote}
> To add to that list, facet/ should not depend on queries too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5325) Move ValueSource and FunctionValues under core/
[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15786057#comment-15786057
]
ASF subversion and git services commented on LUCENE-5325:
-
Commit 4e5a62140f4e90fc41fe91350c7787c8455f2887 in lucene-solr's branch
refs/heads/branch_6x from [~romseygeek]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4e5a621 ]
LUCENE-5325: Check for matching bits in NumericDocValues to XValues converter
> Move ValueSource and FunctionValues under core/
> ---
>
> Key: LUCENE-5325
> URL: https://issues.apache.org/jira/browse/LUCENE-5325
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
>Reporter: Shai Erera
> Attachments: LUCENE-5325-6x-matchingbits.patch, LUCENE-5325-6x.patch,
> LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch,
> LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch
>
>
> Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs
> which exist under the queries/ module. That causes any module which wants to
> depend on these APIs (but not necessarily on any of their actual
> implementations!), to depend on the queries/ module. If we move these APIs
> under core/, we can eliminate these dependencies and add some mock impls for
> testing purposes.
> Quoting Robert from LUCENE-5298:
> {quote}
> we should eliminate the suggest/ dependencies on expressions and queries, the
> expressions/ on queries, the grouping/ dependency on queries, the spatial/
> dependency on queries, its a mess.
> {quote}
> To add to that list, facet/ should not depend on queries too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5325) Move ValueSource and FunctionValues under core/
[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15785447#comment-15785447
]
David Smiley commented on LUCENE-5325:
--
A test for that would be good.
> Move ValueSource and FunctionValues under core/
> ---
>
> Key: LUCENE-5325
> URL: https://issues.apache.org/jira/browse/LUCENE-5325
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
>Reporter: Shai Erera
> Attachments: LUCENE-5325-6x-matchingbits.patch, LUCENE-5325-6x.patch,
> LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch,
> LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch
>
>
> Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs
> which exist under the queries/ module. That causes any module which wants to
> depend on these APIs (but not necessarily on any of their actual
> implementations!), to depend on the queries/ module. If we move these APIs
> under core/, we can eliminate these dependencies and add some mock impls for
> testing purposes.
> Quoting Robert from LUCENE-5298:
> {quote}
> we should eliminate the suggest/ dependencies on expressions and queries, the
> expressions/ on queries, the grouping/ dependency on queries, the spatial/
> dependency on queries, its a mess.
> {quote}
> To add to that list, facet/ should not depend on queries too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5325) Move ValueSource and FunctionValues under core/
[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15785326#comment-15785326
]
Adrien Grand commented on LUCENE-5325:
--
[~romseygeek] On the 6.x branch, I am confused why FieldValuesSource always
returns true for advanceExact, shouldn't it check docsWithField?
> Move ValueSource and FunctionValues under core/
> ---
>
> Key: LUCENE-5325
> URL: https://issues.apache.org/jira/browse/LUCENE-5325
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
>Reporter: Shai Erera
> Attachments: LUCENE-5325-6x.patch, LUCENE-5325.patch,
> LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch,
> LUCENE-5325.patch, LUCENE-5325.patch
>
>
> Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs
> which exist under the queries/ module. That causes any module which wants to
> depend on these APIs (but not necessarily on any of their actual
> implementations!), to depend on the queries/ module. If we move these APIs
> under core/, we can eliminate these dependencies and add some mock impls for
> testing purposes.
> Quoting Robert from LUCENE-5298:
> {quote}
> we should eliminate the suggest/ dependencies on expressions and queries, the
> expressions/ on queries, the grouping/ dependency on queries, the spatial/
> dependency on queries, its a mess.
> {quote}
> To add to that list, facet/ should not depend on queries too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5325) Move ValueSource and FunctionValues under core/
[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15785301#comment-15785301
]
David Smiley commented on LUCENE-5325:
--
Yay; thanks so much for this [~romseygeek]!
> Move ValueSource and FunctionValues under core/
> ---
>
> Key: LUCENE-5325
> URL: https://issues.apache.org/jira/browse/LUCENE-5325
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
>Reporter: Shai Erera
> Attachments: LUCENE-5325-6x.patch, LUCENE-5325.patch,
> LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch,
> LUCENE-5325.patch, LUCENE-5325.patch
>
>
> Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs
> which exist under the queries/ module. That causes any module which wants to
> depend on these APIs (but not necessarily on any of their actual
> implementations!), to depend on the queries/ module. If we move these APIs
> under core/, we can eliminate these dependencies and add some mock impls for
> testing purposes.
> Quoting Robert from LUCENE-5298:
> {quote}
> we should eliminate the suggest/ dependencies on expressions and queries, the
> expressions/ on queries, the grouping/ dependency on queries, the spatial/
> dependency on queries, its a mess.
> {quote}
> To add to that list, facet/ should not depend on queries too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5325) Move ValueSource and FunctionValues under core/
[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15785226#comment-15785226
]
ASF subversion and git services commented on LUCENE-5325:
-
Commit e2aa2b638468f8ed733be25f4dc86780b840 in lucene-solr's branch
refs/heads/branch_6x from [~romseygeek]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e2aa2b6 ]
LUCENE-5325: Add LongValuesSource and DoubleValuesSource in core
> Move ValueSource and FunctionValues under core/
> ---
>
> Key: LUCENE-5325
> URL: https://issues.apache.org/jira/browse/LUCENE-5325
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
>Reporter: Shai Erera
> Attachments: LUCENE-5325-6x.patch, LUCENE-5325.patch,
> LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch,
> LUCENE-5325.patch, LUCENE-5325.patch
>
>
> Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs
> which exist under the queries/ module. That causes any module which wants to
> depend on these APIs (but not necessarily on any of their actual
> implementations!), to depend on the queries/ module. If we move these APIs
> under core/, we can eliminate these dependencies and add some mock impls for
> testing purposes.
> Quoting Robert from LUCENE-5298:
> {quote}
> we should eliminate the suggest/ dependencies on expressions and queries, the
> expressions/ on queries, the grouping/ dependency on queries, the spatial/
> dependency on queries, its a mess.
> {quote}
> To add to that list, facet/ should not depend on queries too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5325) Move ValueSource and FunctionValues under core/
[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15785229#comment-15785229
]
ASF subversion and git services commented on LUCENE-5325:
-
Commit 3f24fd81c836982be96b9b60082b53177fffe504 in lucene-solr's branch
refs/heads/master from [~romseygeek]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3f24fd8 ]
LUCENE-5325: Add LongValuesSource and DoubleValuesSource in core
> Move ValueSource and FunctionValues under core/
> ---
>
> Key: LUCENE-5325
> URL: https://issues.apache.org/jira/browse/LUCENE-5325
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
>Reporter: Shai Erera
> Attachments: LUCENE-5325-6x.patch, LUCENE-5325.patch,
> LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch,
> LUCENE-5325.patch, LUCENE-5325.patch
>
>
> Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs
> which exist under the queries/ module. That causes any module which wants to
> depend on these APIs (but not necessarily on any of their actual
> implementations!), to depend on the queries/ module. If we move these APIs
> under core/, we can eliminate these dependencies and add some mock impls for
> testing purposes.
> Quoting Robert from LUCENE-5298:
> {quote}
> we should eliminate the suggest/ dependencies on expressions and queries, the
> expressions/ on queries, the grouping/ dependency on queries, the spatial/
> dependency on queries, its a mess.
> {quote}
> To add to that list, facet/ should not depend on queries too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5325) Move ValueSource and FunctionValues under core/
[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15785157#comment-15785157
]
Adrien Grand commented on LUCENE-5325:
--
+1
> Move ValueSource and FunctionValues under core/
> ---
>
> Key: LUCENE-5325
> URL: https://issues.apache.org/jira/browse/LUCENE-5325
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
>Reporter: Shai Erera
> Attachments: LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch,
> LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch
>
>
> Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs
> which exist under the queries/ module. That causes any module which wants to
> depend on these APIs (but not necessarily on any of their actual
> implementations!), to depend on the queries/ module. If we move these APIs
> under core/, we can eliminate these dependencies and add some mock impls for
> testing purposes.
> Quoting Robert from LUCENE-5298:
> {quote}
> we should eliminate the suggest/ dependencies on expressions and queries, the
> expressions/ on queries, the grouping/ dependency on queries, the spatial/
> dependency on queries, its a mess.
> {quote}
> To add to that list, facet/ should not depend on queries too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5325) Move ValueSource and FunctionValues under core/
[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15783518#comment-15783518
]
Adrien Grand commented on LUCENE-5325:
--
Thanks, it looks great. Some minor comments:
- Can you make the docs of advanceExact more explicit about the fact it cannot
go backwards?
- Can you remove the {{@Test}} annotations from the test case?
- The {{// force in order}} comment is outdated, scoring always goes in order
since 5.0. I think we can remove all this testing on BooleanQuery since it is
now no different from a TermQuery for sorting.
Otherwise +1
> Move ValueSource and FunctionValues under core/
> ---
>
> Key: LUCENE-5325
> URL: https://issues.apache.org/jira/browse/LUCENE-5325
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
>Reporter: Shai Erera
> Attachments: LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch,
> LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch
>
>
> Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs
> which exist under the queries/ module. That causes any module which wants to
> depend on these APIs (but not necessarily on any of their actual
> implementations!), to depend on the queries/ module. If we move these APIs
> under core/, we can eliminate these dependencies and add some mock impls for
> testing purposes.
> Quoting Robert from LUCENE-5298:
> {quote}
> we should eliminate the suggest/ dependencies on expressions and queries, the
> expressions/ on queries, the grouping/ dependency on queries, the spatial/
> dependency on queries, its a mess.
> {quote}
> To add to that list, facet/ should not depend on queries too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5325) Move ValueSource and FunctionValues under core/
[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15783071#comment-15783071
]
Adrien Grand commented on LUCENE-5325:
--
I am +1 in general, I think it's great that we are getting a cleaner values
source API! I left some comments about the current patch below:
- Should we rename advanceTo to advanceExact to be more consistent with the
doc values API? These methods seem to have the same contract.
- It seems to be that {{fromIntField}} could just delegate to
{{fromLongField}} all the time?
- Can we use {{LongUnaryOperator.identity()}} rather than {{(v) -> v}}
- {{// TODO make setScorer throw IOException?}} +1
- {{LongValuesSource.fromDoubleField}} looks a bit trappy to me since it
implicitly casts. Should we instead expect callers to call
{{DoubleValuesSource.fromDoubleField}} and then do the casting explicitly using
{{toLongValuesSource}}?
- Maybe we should not have the {{DoubleValues getValues(LeafReaderContext)}}
method (without a Scorer). I'm wondering it might be better to require callers
to pass null themselves when they know scores are not needed.
About the way we have access to scores, I'm wondering that things might be a
bit cleaner if we avoided mixing the values source and Scorer APIs by replacing
{{LongValues getValues(LeafReaderContext ctx, Scorer scorer)}} with
{{LongValues getValues(LeafReaderContext ctx, DoubleValues scores)}} in
addition to something like a {{DoubleValues fromScorer(Scorer scorer)}} method
on {{DoubleValuesSource}}?
In general I think we should also better document the contract of these APIs,
like what the expectations are for the scorer/scores when {{needsScores}}
returns {{false}} and what {{toDoubleValues}} and {{toLongValues}} do since not
all doubles can be represented as a long and vice-versa.
> Move ValueSource and FunctionValues under core/
> ---
>
> Key: LUCENE-5325
> URL: https://issues.apache.org/jira/browse/LUCENE-5325
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
>Reporter: Shai Erera
> Attachments: LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch,
> LUCENE-5325.patch, LUCENE-5325.patch
>
>
> Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs
> which exist under the queries/ module. That causes any module which wants to
> depend on these APIs (but not necessarily on any of their actual
> implementations!), to depend on the queries/ module. If we move these APIs
> under core/, we can eliminate these dependencies and add some mock impls for
> testing purposes.
> Quoting Robert from LUCENE-5298:
> {quote}
> we should eliminate the suggest/ dependencies on expressions and queries, the
> expressions/ on queries, the grouping/ dependency on queries, the spatial/
> dependency on queries, its a mess.
> {quote}
> To add to that list, facet/ should not depend on queries too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5325) Move ValueSource and FunctionValues under core/
[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15782914#comment-15782914
]
Alan Woodward commented on LUCENE-5325:
---
Any comments on the patch? I'll commit in the next couple of days if
everybody's happy.
> Move ValueSource and FunctionValues under core/
> ---
>
> Key: LUCENE-5325
> URL: https://issues.apache.org/jira/browse/LUCENE-5325
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
>Reporter: Shai Erera
> Attachments: LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch,
> LUCENE-5325.patch, LUCENE-5325.patch
>
>
> Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs
> which exist under the queries/ module. That causes any module which wants to
> depend on these APIs (but not necessarily on any of their actual
> implementations!), to depend on the queries/ module. If we move these APIs
> under core/, we can eliminate these dependencies and add some mock impls for
> testing purposes.
> Quoting Robert from LUCENE-5298:
> {quote}
> we should eliminate the suggest/ dependencies on expressions and queries, the
> expressions/ on queries, the grouping/ dependency on queries, the spatial/
> dependency on queries, its a mess.
> {quote}
> To add to that list, facet/ should not depend on queries too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5325) Move ValueSource and FunctionValues under core/
[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238874#comment-15238874
]
Robert Muir commented on LUCENE-5325:
-
I dont understand the problem, it seems to be unrelated to the api at hand.
Whether these double values come from scores, from the ABV of beers in the
refridgerator, etc, seems none of its concern. It should just be a per-doc api
for double values and nothing more?
> Move ValueSource and FunctionValues under core/
> ---
>
> Key: LUCENE-5325
> URL: https://issues.apache.org/jira/browse/LUCENE-5325
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
>Reporter: Shai Erera
> Attachments: LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch
>
>
> Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs
> which exist under the queries/ module. That causes any module which wants to
> depend on these APIs (but not necessarily on any of their actual
> implementations!), to depend on the queries/ module. If we move these APIs
> under core/, we can eliminate these dependencies and add some mock impls for
> testing purposes.
> Quoting Robert from LUCENE-5298:
> {quote}
> we should eliminate the suggest/ dependencies on expressions and queries, the
> expressions/ on queries, the grouping/ dependency on queries, the spatial/
> dependency on queries, its a mess.
> {quote}
> To add to that list, facet/ should not depend on queries too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5325) Move ValueSource and FunctionValues under core/
[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238072#comment-15238072
]
Alan Woodward commented on LUCENE-5325:
---
I'm going back and forth a bit on where scores should live.
TaxonomyFacetSumValueSource also allows access to scores, so we need to be able
to set a Scorer on an arbitrary DoubleValues instance there. However, once
setScorer appears on DoubleValues, that means we need to add it to the
long-valued equivalent (because we'll want to wrap one with another), so we
can't just use NumericDocValues.
> Move ValueSource and FunctionValues under core/
> ---
>
> Key: LUCENE-5325
> URL: https://issues.apache.org/jira/browse/LUCENE-5325
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
>Reporter: Shai Erera
> Attachments: LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch
>
>
> Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs
> which exist under the queries/ module. That causes any module which wants to
> depend on these APIs (but not necessarily on any of their actual
> implementations!), to depend on the queries/ module. If we move these APIs
> under core/, we can eliminate these dependencies and add some mock impls for
> testing purposes.
> Quoting Robert from LUCENE-5298:
> {quote}
> we should eliminate the suggest/ dependencies on expressions and queries, the
> expressions/ on queries, the grouping/ dependency on queries, the spatial/
> dependency on queries, its a mess.
> {quote}
> To add to that list, facet/ should not depend on queries too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5325) Move ValueSource and FunctionValues under core/
[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15237203#comment-15237203
]
Robert Muir commented on LUCENE-5325:
-
is there a way to move out the setScorer method? it seems like this one really
does not belong, e.g. should be at a higher level and this api should just have
the per-document get ? I like David's idea about separate boolean exists (or
simply have method to get the Bits for this at a higher level).
to me that is better, because then its up to the thing using it to determine
how null values should be treated. For example expressions/ could treat them as
NaN rather than 0, maybe that is more intuitive (especially with respect to
sorting).
> Move ValueSource and FunctionValues under core/
> ---
>
> Key: LUCENE-5325
> URL: https://issues.apache.org/jira/browse/LUCENE-5325
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
>Reporter: Shai Erera
> Attachments: LUCENE-5325.patch
>
>
> Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs
> which exist under the queries/ module. That causes any module which wants to
> depend on these APIs (but not necessarily on any of their actual
> implementations!), to depend on the queries/ module. If we move these APIs
> under core/, we can eliminate these dependencies and add some mock impls for
> testing purposes.
> Quoting Robert from LUCENE-5298:
> {quote}
> we should eliminate the suggest/ dependencies on expressions and queries, the
> expressions/ on queries, the grouping/ dependency on queries, the spatial/
> dependency on queries, its a mess.
> {quote}
> To add to that list, facet/ should not depend on queries too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5325) Move ValueSource and FunctionValues under core/
[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15237190#comment-15237190
]
David Smiley commented on LUCENE-5325:
--
bq. I've copied the exists() method from FunctionValues to DoubleValues, but
I'm not convinced we need it.
I think it is needed. Consider a ValueSource that wants to pick between the
value from a wrapped ValueSource, or if when that VS has no value, then return
the value from another (perhaps a constant default but could be anything). The
only way to get this and remove a FunctionValues.exists() method I see is
having some sort of BooleanValueSource that has implementations to check if a
DocValue's value exists. Then you could address the same use-cases, I think.
The patch looked alright but I didn't apply it to get a more thorough
impression. I certainly like the simplicity of it. And I like this
API/functionality moving to Core from Queries module -- it's very generic &
foundational.
> Move ValueSource and FunctionValues under core/
> ---
>
> Key: LUCENE-5325
> URL: https://issues.apache.org/jira/browse/LUCENE-5325
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
>Reporter: Shai Erera
> Attachments: LUCENE-5325.patch
>
>
> Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs
> which exist under the queries/ module. That causes any module which wants to
> depend on these APIs (but not necessarily on any of their actual
> implementations!), to depend on the queries/ module. If we move these APIs
> under core/, we can eliminate these dependencies and add some mock impls for
> testing purposes.
> Quoting Robert from LUCENE-5298:
> {quote}
> we should eliminate the suggest/ dependencies on expressions and queries, the
> expressions/ on queries, the grouping/ dependency on queries, the spatial/
> dependency on queries, its a mess.
> {quote}
> To add to that list, facet/ should not depend on queries too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5325) Move ValueSource and FunctionValues under core/
[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235835#comment-15235835
]
Hoss Man commented on LUCENE-5325:
--
bq. One of the issues I have with ValueSource is that it's inherently
type-unsafe - you have no way of saying what sort of value you want from a
ValueSource input.
This comment reminded me of a discussion I remember having a long time ago that
i started typing up a summary of in case it inspires folks, but then realized I
already filed as SOLR-6575 the last time someone mentioned something that
reminded me of it.
Might be some helpful ideas there if folks are looking to revamp & improve the
type specificity of the ValueSource APIs
> Move ValueSource and FunctionValues under core/
> ---
>
> Key: LUCENE-5325
> URL: https://issues.apache.org/jira/browse/LUCENE-5325
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
>Reporter: Shai Erera
>
> Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs
> which exist under the queries/ module. That causes any module which wants to
> depend on these APIs (but not necessarily on any of their actual
> implementations!), to depend on the queries/ module. If we move these APIs
> under core/, we can eliminate these dependencies and add some mock impls for
> testing purposes.
> Quoting Robert from LUCENE-5298:
> {quote}
> we should eliminate the suggest/ dependencies on expressions and queries, the
> expressions/ on queries, the grouping/ dependency on queries, the spatial/
> dependency on queries, its a mess.
> {quote}
> To add to that list, facet/ should not depend on queries too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5325) Move ValueSource and FunctionValues under core/
[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235708#comment-15235708
]
Yonik Seeley commented on LUCENE-5325:
--
bq. Like the multi-value aspect, which is in turn only used by a small piece of
Solr.
Indeed, multi-value VS needs to change!
> Move ValueSource and FunctionValues under core/
> ---
>
> Key: LUCENE-5325
> URL: https://issues.apache.org/jira/browse/LUCENE-5325
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
>Reporter: Shai Erera
>
> Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs
> which exist under the queries/ module. That causes any module which wants to
> depend on these APIs (but not necessarily on any of their actual
> implementations!), to depend on the queries/ module. If we move these APIs
> under core/, we can eliminate these dependencies and add some mock impls for
> testing purposes.
> Quoting Robert from LUCENE-5298:
> {quote}
> we should eliminate the suggest/ dependencies on expressions and queries, the
> expressions/ on queries, the grouping/ dependency on queries, the spatial/
> dependency on queries, its a mess.
> {quote}
> To add to that list, facet/ should not depend on queries too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5325) Move ValueSource and FunctionValues under core/
[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235703#comment-15235703
]
David Smiley commented on LUCENE-5325:
--
Definitely sounds great. I know what you mean by this having a lot of warts.
Like the multi-value aspect, which is in turn only used by a small piece of
Solr.
> Move ValueSource and FunctionValues under core/
> ---
>
> Key: LUCENE-5325
> URL: https://issues.apache.org/jira/browse/LUCENE-5325
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
>Reporter: Shai Erera
>
> Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs
> which exist under the queries/ module. That causes any module which wants to
> depend on these APIs (but not necessarily on any of their actual
> implementations!), to depend on the queries/ module. If we move these APIs
> under core/, we can eliminate these dependencies and add some mock impls for
> testing purposes.
> Quoting Robert from LUCENE-5298:
> {quote}
> we should eliminate the suggest/ dependencies on expressions and queries, the
> expressions/ on queries, the grouping/ dependency on queries, the spatial/
> dependency on queries, its a mess.
> {quote}
> To add to that list, facet/ should not depend on queries too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5325) Move ValueSource and FunctionValues under core/
[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235688#comment-15235688
]
Ryan Ernst commented on LUCENE-5325:
[~romseygeek] sounds like an interesting idea, a prototype patch sounds good.
> Move ValueSource and FunctionValues under core/
> ---
>
> Key: LUCENE-5325
> URL: https://issues.apache.org/jira/browse/LUCENE-5325
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
>Reporter: Shai Erera
>
> Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs
> which exist under the queries/ module. That causes any module which wants to
> depend on these APIs (but not necessarily on any of their actual
> implementations!), to depend on the queries/ module. If we move these APIs
> under core/, we can eliminate these dependencies and add some mock impls for
> testing purposes.
> Quoting Robert from LUCENE-5298:
> {quote}
> we should eliminate the suggest/ dependencies on expressions and queries, the
> expressions/ on queries, the grouping/ dependency on queries, the spatial/
> dependency on queries, its a mess.
> {quote}
> To add to that list, facet/ should not depend on queries too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5325) Move ValueSource and FunctionValues under core/
[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235324#comment-15235324
]
Alan Woodward commented on LUCENE-5325:
---
Some stuff I've been working on has touched this, and I think I have a possible
way forward. One of the issues I have with ValueSource is that it's inherently
type-unsafe - you have no way of saying what sort of value you want from a
ValueSource input. However, pretty much all the VS consumers we have only
actually use a single type: expressions uses doubleVal(), facet uses longVal()
for LongRange and doubleVal() for DoubleRange, function queries use floatVal(),
etc.
I propose we add a new set of abstract classes to the core search package,
exposing per-document Long, Double and BytesRef values. We add some simple
wrapper methods to the queries module to convert a ValueSource to a
LongValuesSource/DoubleValuesSource/BytesRefValuesSource. Then we can go
through each module and convert it to use the core classes instead of
ValueSource, one by one. This breaks things up into the subtasks Ryan was
talking about, and allows us to defer worrying about some of the wartier
aspects of the current ValueSource API (quite a few of which are only used by a
single module, and can be narrowed down to a module-specific subclass or
implementation).
I have the start of a patch for this, which I can upload if people think this
sounds like a good idea, cutting over expressions and facets.
> Move ValueSource and FunctionValues under core/
> ---
>
> Key: LUCENE-5325
> URL: https://issues.apache.org/jira/browse/LUCENE-5325
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
>Reporter: Shai Erera
>
> Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs
> which exist under the queries/ module. That causes any module which wants to
> depend on these APIs (but not necessarily on any of their actual
> implementations!), to depend on the queries/ module. If we move these APIs
> under core/, we can eliminate these dependencies and add some mock impls for
> testing purposes.
> Quoting Robert from LUCENE-5298:
> {quote}
> we should eliminate the suggest/ dependencies on expressions and queries, the
> expressions/ on queries, the grouping/ dependency on queries, the spatial/
> dependency on queries, its a mess.
> {quote}
> To add to that list, facet/ should not depend on queries too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5325) Move ValueSource and FunctionValues under core/
[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13817138#comment-13817138
]
Shai Erera commented on LUCENE-5325:
bq. Shai Erera, have you already started on this? If not I'd be happy to take
it on.
No, I haven't started any work yet and won't be able to work on it in the next
few weeks, so feel free to take it!
Move ValueSource and FunctionValues under core/
---
Key: LUCENE-5325
URL: https://issues.apache.org/jira/browse/LUCENE-5325
Project: Lucene - Core
Issue Type: Improvement
Components: core/search
Reporter: Shai Erera
Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs
which exist under the queries/ module. That causes any module which wants to
depend on these APIs (but not necessarily on any of their actual
implementations!), to depend on the queries/ module. If we move these APIs
under core/, we can eliminate these dependencies and add some mock impls for
testing purposes.
Quoting Robert from LUCENE-5298:
{quote}
we should eliminate the suggest/ dependencies on expressions and queries, the
expressions/ on queries, the grouping/ dependency on queries, the spatial/
dependency on queries, its a mess.
{quote}
To add to that list, facet/ should not depend on queries too.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5325) Move ValueSource and FunctionValues under core/
[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13816502#comment-13816502
]
Ryan Ernst commented on LUCENE-5325:
I began doing the move and refactorings discussed here, but this turned into a
very large change. After some discussion, I'm going to try creating smaller
subtasks. The first example is LUCENE-5335. There are a bunch more changes
like this we should make before doing the actual move.
Move ValueSource and FunctionValues under core/
---
Key: LUCENE-5325
URL: https://issues.apache.org/jira/browse/LUCENE-5325
Project: Lucene - Core
Issue Type: Improvement
Components: core/search
Reporter: Shai Erera
Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs
which exist under the queries/ module. That causes any module which wants to
depend on these APIs (but not necessarily on any of their actual
implementations!), to depend on the queries/ module. If we move these APIs
under core/, we can eliminate these dependencies and add some mock impls for
testing purposes.
Quoting Robert from LUCENE-5298:
{quote}
we should eliminate the suggest/ dependencies on expressions and queries, the
expressions/ on queries, the grouping/ dependency on queries, the spatial/
dependency on queries, its a mess.
{quote}
To add to that list, facet/ should not depend on queries too.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5325) Move ValueSource and FunctionValues under core/
[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812700#comment-13812700
]
Adrien Grand commented on LUCENE-5325:
--
I'm +1 for having these APIs in core, but I'd like us to do some cleanup before
integrating them into core. In particular:
- could we remove byteVal, shortVal, intVal and floatVal and only have longVal
and doubleVal to deal with numerics?
- could we improve the multi-valued APIs? Maybe something more like
SortedSetDocValues (setDocument/nextOrd)?
Move ValueSource and FunctionValues under core/
---
Key: LUCENE-5325
URL: https://issues.apache.org/jira/browse/LUCENE-5325
Project: Lucene - Core
Issue Type: Improvement
Components: core/search
Reporter: Shai Erera
Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs
which exist under the queries/ module. That causes any module which wants to
depend on these APIs (but not necessarily on any of their actual
implementations!), to depend on the queries/ module. If we move these APIs
under core/, we can eliminate these dependencies and add some mock impls for
testing purposes.
Quoting Robert from LUCENE-5298:
{quote}
we should eliminate the suggest/ dependencies on expressions and queries, the
expressions/ on queries, the grouping/ dependency on queries, the spatial/
dependency on queries, its a mess.
{quote}
To add to that list, facet/ should not depend on queries too.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5325) Move ValueSource and FunctionValues under core/
[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812909#comment-13812909
]
David Smiley commented on LUCENE-5325:
--
+1 to move ValueSource/FunctionValues to Core. I've certainly viewed it as a
core part of Lucene.
Adrien, by improve the multi-valued APIs, are you perhaps referring
ValueSource/FunctionValue's rather odd set of methods that take a 2nd parameter
which is an array to dump multiple values out into? MultiValueSource goes
along with this. I rather hate MultiValueSource and all those overloaded
methods -- I look forward to seeing a better design. The main problem with
MultiValueSource is that it's design is limited to all documents having a
constant number of values, it doesn't vary per document. Notice
MultiValueSource's dimension() takes no arguments -- it's result is effectively
constant.
Move ValueSource and FunctionValues under core/
---
Key: LUCENE-5325
URL: https://issues.apache.org/jira/browse/LUCENE-5325
Project: Lucene - Core
Issue Type: Improvement
Components: core/search
Reporter: Shai Erera
Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs
which exist under the queries/ module. That causes any module which wants to
depend on these APIs (but not necessarily on any of their actual
implementations!), to depend on the queries/ module. If we move these APIs
under core/, we can eliminate these dependencies and add some mock impls for
testing purposes.
Quoting Robert from LUCENE-5298:
{quote}
we should eliminate the suggest/ dependencies on expressions and queries, the
expressions/ on queries, the grouping/ dependency on queries, the spatial/
dependency on queries, its a mess.
{quote}
To add to that list, facet/ should not depend on queries too.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5325) Move ValueSource and FunctionValues under core/
[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812986#comment-13812986
]
Ryan Ernst commented on LUCENE-5325:
+1 for the APIs in the core.
[~shaie], have you already started on this? If not I'd be happy to take it on.
Move ValueSource and FunctionValues under core/
---
Key: LUCENE-5325
URL: https://issues.apache.org/jira/browse/LUCENE-5325
Project: Lucene - Core
Issue Type: Improvement
Components: core/search
Reporter: Shai Erera
Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs
which exist under the queries/ module. That causes any module which wants to
depend on these APIs (but not necessarily on any of their actual
implementations!), to depend on the queries/ module. If we move these APIs
under core/, we can eliminate these dependencies and add some mock impls for
testing purposes.
Quoting Robert from LUCENE-5298:
{quote}
we should eliminate the suggest/ dependencies on expressions and queries, the
expressions/ on queries, the grouping/ dependency on queries, the spatial/
dependency on queries, its a mess.
{quote}
To add to that list, facet/ should not depend on queries too.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5325) Move ValueSource and FunctionValues under core/
[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813012#comment-13813012
]
Adrien Grand commented on LUCENE-5325:
--
{quote}
Adrien, by improve the multi-valued APIs, are you perhaps referring
ValueSource/FunctionValue's rather odd set of methods that take a 2nd parameter
which is an array to dump multiple values out into? MultiValueSource goes along
with this. I rather hate MultiValueSource and all those overloaded methods – I
look forward to seeing a better design. The main problem with MultiValueSource
is that it's design is limited to all documents having a constant number of
values, it doesn't vary per document. Notice MultiValueSource's dimension()
takes no arguments – it's result is effectively constant.
{quote}
Exactly. :-)
Move ValueSource and FunctionValues under core/
---
Key: LUCENE-5325
URL: https://issues.apache.org/jira/browse/LUCENE-5325
Project: Lucene - Core
Issue Type: Improvement
Components: core/search
Reporter: Shai Erera
Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs
which exist under the queries/ module. That causes any module which wants to
depend on these APIs (but not necessarily on any of their actual
implementations!), to depend on the queries/ module. If we move these APIs
under core/, we can eliminate these dependencies and add some mock impls for
testing purposes.
Quoting Robert from LUCENE-5298:
{quote}
we should eliminate the suggest/ dependencies on expressions and queries, the
expressions/ on queries, the grouping/ dependency on queries, the spatial/
dependency on queries, its a mess.
{quote}
To add to that list, facet/ should not depend on queries too.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
