[jira] [Commented] (LUCENE-5528) Add context to AnalyzingInfixSuggester
[ https://issues.apache.org/jira/browse/LUCENE-5528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198145#comment-14198145 ] Arcadius Ahouansou commented on LUCENE-5528: Another alternative may be to have something like MapBytesRef,Boolean instead of SetBytesRef where the boolean indicates whether the entry is a SHOULD or a MUST Add context to AnalyzingInfixSuggester -- Key: LUCENE-5528 URL: https://issues.apache.org/jira/browse/LUCENE-5528 Project: Lucene - Core Issue Type: Improvement Reporter: Michael McCandless Assignee: Michael McCandless Fix For: 4.8, Trunk Attachments: LUCENE-5528-1.patch, LUCENE-5528-1.patch, LUCENE-5528-1.patch, LUCENE-5528-1.patch, LUCENE-5528.patch, LUCENE-5528.patch, contextInputIteratImpl.patch Spinoff from LUCENE-5350. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5528) Add context to AnalyzingInfixSuggester
[ https://issues.apache.org/jira/browse/LUCENE-5528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198260#comment-14198260 ] Michael McCandless commented on LUCENE-5528: Hi [~arcadius], I think it makes sense to give more control over how context is applied; could you open a new issue for this? Add context to AnalyzingInfixSuggester -- Key: LUCENE-5528 URL: https://issues.apache.org/jira/browse/LUCENE-5528 Project: Lucene - Core Issue Type: Improvement Reporter: Michael McCandless Assignee: Michael McCandless Fix For: 4.8, Trunk Attachments: LUCENE-5528-1.patch, LUCENE-5528-1.patch, LUCENE-5528-1.patch, LUCENE-5528-1.patch, LUCENE-5528.patch, LUCENE-5528.patch, contextInputIteratImpl.patch Spinoff from LUCENE-5350. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5528) Add context to AnalyzingInfixSuggester
[ https://issues.apache.org/jira/browse/LUCENE-5528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198545#comment-14198545 ] Arcadius Ahouansou commented on LUCENE-5528: Hi [~mikemccand]. The new issue is LUCENE-6050 Thanks. Add context to AnalyzingInfixSuggester -- Key: LUCENE-5528 URL: https://issues.apache.org/jira/browse/LUCENE-5528 Project: Lucene - Core Issue Type: Improvement Reporter: Michael McCandless Assignee: Michael McCandless Fix For: 4.8, Trunk Attachments: LUCENE-5528-1.patch, LUCENE-5528-1.patch, LUCENE-5528-1.patch, LUCENE-5528-1.patch, LUCENE-5528.patch, LUCENE-5528.patch, contextInputIteratImpl.patch Spinoff from LUCENE-5350. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5528) Add context to AnalyzingInfixSuggester
[
https://issues.apache.org/jira/browse/LUCENE-5528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14196155#comment-14196155
]
Arcadius Ahouansou commented on LUCENE-5528:
Hello [~mikemccand]
For the AnalazingInfixSuggester, does it make sens to have a new override for
the method lookup() with an additional param *allContextsRequired* , similar to
allTermsRequired
{code}
lookup(CharSequence key, SetBytesRef contexts, int num, boolean
allTermsRequired, boolean doHighlight, boolean allContextsRequired)
{code}
which will make it possible to have an AND behaviour for the contexts when
you have many contexts instead of the default OR?
This means that line
https://github.com/apache/lucene-solr/blob/trunk/lucene/suggest/src/java/org/apache/lucene/search/suggest/analyzing/AnalyzingInfixSuggester.java#L486
will now use *BooleanClause.Occur.SHOULD* or *BooleanClause.Occur.MUST*
depending on the value of the new param *allContextsRequired* ...
We currently have a use-case for this.
Thanks.
Arcadius.
Add context to AnalyzingInfixSuggester
--
Key: LUCENE-5528
URL: https://issues.apache.org/jira/browse/LUCENE-5528
Project: Lucene - Core
Issue Type: Improvement
Reporter: Michael McCandless
Assignee: Michael McCandless
Fix For: 4.8, Trunk
Attachments: LUCENE-5528-1.patch, LUCENE-5528-1.patch,
LUCENE-5528-1.patch, LUCENE-5528-1.patch, LUCENE-5528.patch,
LUCENE-5528.patch, contextInputIteratImpl.patch
Spinoff from LUCENE-5350.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5528) Add context to AnalyzingInfixSuggester
[ https://issues.apache.org/jira/browse/LUCENE-5528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944415#comment-13944415 ] Michael McCandless commented on LUCENE-5528: Thanks Areek, this looks great! I'll commit soon. Add context to AnalyzingInfixSuggester -- Key: LUCENE-5528 URL: https://issues.apache.org/jira/browse/LUCENE-5528 Project: Lucene - Core Issue Type: Improvement Reporter: Michael McCandless Assignee: Michael McCandless Fix For: 4.8, 5.0 Attachments: LUCENE-5528-1.patch, LUCENE-5528-1.patch, LUCENE-5528-1.patch, LUCENE-5528-1.patch, LUCENE-5528.patch, LUCENE-5528.patch, contextInputIteratImpl.patch Spinoff from LUCENE-5350. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5528) Add context to AnalyzingInfixSuggester
[ https://issues.apache.org/jira/browse/LUCENE-5528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1397#comment-1397 ] ASF subversion and git services commented on LUCENE-5528: - Commit 1580510 from [~mikemccand] in branch 'dev/trunk' [ https://svn.apache.org/r1580510 ] LUCENE-5528: add contexts to AnalyzingInfixSuggester Add context to AnalyzingInfixSuggester -- Key: LUCENE-5528 URL: https://issues.apache.org/jira/browse/LUCENE-5528 Project: Lucene - Core Issue Type: Improvement Reporter: Michael McCandless Assignee: Michael McCandless Fix For: 4.8, 5.0 Attachments: LUCENE-5528-1.patch, LUCENE-5528-1.patch, LUCENE-5528-1.patch, LUCENE-5528-1.patch, LUCENE-5528.patch, LUCENE-5528.patch, contextInputIteratImpl.patch Spinoff from LUCENE-5350. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5528) Add context to AnalyzingInfixSuggester
[ https://issues.apache.org/jira/browse/LUCENE-5528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944451#comment-13944451 ] ASF subversion and git services commented on LUCENE-5528: - Commit 1580517 from [~mikemccand] in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1580517 ] LUCENE-5528: add contexts to AnalyzingInfixSuggester Add context to AnalyzingInfixSuggester -- Key: LUCENE-5528 URL: https://issues.apache.org/jira/browse/LUCENE-5528 Project: Lucene - Core Issue Type: Improvement Reporter: Michael McCandless Assignee: Michael McCandless Fix For: 4.8, 5.0 Attachments: LUCENE-5528-1.patch, LUCENE-5528-1.patch, LUCENE-5528-1.patch, LUCENE-5528-1.patch, LUCENE-5528.patch, LUCENE-5528.patch, contextInputIteratImpl.patch Spinoff from LUCENE-5350. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5528) Add context to AnalyzingInfixSuggester
[ https://issues.apache.org/jira/browse/LUCENE-5528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944452#comment-13944452 ] ASF subversion and git services commented on LUCENE-5528: - Commit 1580518 from [~mikemccand] in branch 'dev/trunk' [ https://svn.apache.org/r1580518 ] LUCENE-5528: remove generics Add context to AnalyzingInfixSuggester -- Key: LUCENE-5528 URL: https://issues.apache.org/jira/browse/LUCENE-5528 Project: Lucene - Core Issue Type: Improvement Reporter: Michael McCandless Assignee: Michael McCandless Fix For: 4.8, 5.0 Attachments: LUCENE-5528-1.patch, LUCENE-5528-1.patch, LUCENE-5528-1.patch, LUCENE-5528-1.patch, LUCENE-5528.patch, LUCENE-5528.patch, contextInputIteratImpl.patch Spinoff from LUCENE-5350. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5528) Add context to AnalyzingInfixSuggester
[
https://issues.apache.org/jira/browse/LUCENE-5528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13943982#comment-13943982
]
Michael McCandless commented on LUCENE-5528:
Thanks Areek, new patch looks great! It's nice that
Document/ExpressionDictionary, and the wrapping InputIterators
(Sorted/Unsorted) handle contexts as well. I think it's close.
I noticed a lot of added but unused import import
org.apache.lucene.util.BytesRefIterator; lines.
Also, AnalyzingInfixSuggester calls InputIterator.contexts() regardless of
whether hasContexts return true or false; I think this is actually OK, but can
you update InputIterator's javadocs to state that this is allowed, and
contexts() is expected to return null even if hasContexts() had returned false?
Finally just a small whitespace issue: instead of:
{noformat}
if(iterator.hasContexts()) {
{noformat}
Can you do this:
{noformat}
if (iterator.hasContexts()) {
{noformat}
(i.e. just add space between if and (). Thanks!
Add context to AnalyzingInfixSuggester
--
Key: LUCENE-5528
URL: https://issues.apache.org/jira/browse/LUCENE-5528
Project: Lucene - Core
Issue Type: Improvement
Reporter: Michael McCandless
Assignee: Michael McCandless
Fix For: 4.8, 5.0
Attachments: LUCENE-5528-1.patch, LUCENE-5528-1.patch,
LUCENE-5528.patch, LUCENE-5528.patch, contextInputIteratImpl.patch
Spinoff from LUCENE-5350.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5528) Add context to AnalyzingInfixSuggester
[ https://issues.apache.org/jira/browse/LUCENE-5528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13943983#comment-13943983 ] Michael McCandless commented on LUCENE-5528: BTW I pushed this patch to the jirasearch production site (http://jirasearch.mikemccandless.com ) and it seems to be working very well! If you drill down on a specific project (Lucene, Solr, Tika) then the suggestions you see are only for that project. This also happens if you type the project name, e.g. lucene word shows only lucene issues/users containing word*, and tika word shows only tika issues/users with word* Nice to eat your own dog food ... Add context to AnalyzingInfixSuggester -- Key: LUCENE-5528 URL: https://issues.apache.org/jira/browse/LUCENE-5528 Project: Lucene - Core Issue Type: Improvement Reporter: Michael McCandless Assignee: Michael McCandless Fix For: 4.8, 5.0 Attachments: LUCENE-5528-1.patch, LUCENE-5528-1.patch, LUCENE-5528.patch, LUCENE-5528.patch, contextInputIteratImpl.patch Spinoff from LUCENE-5350. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5528) Add context to AnalyzingInfixSuggester
[ https://issues.apache.org/jira/browse/LUCENE-5528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13942929#comment-13942929 ] Michael McCandless commented on LUCENE-5528: bq. I will change the InputIterator contexts() api to return SetBytesRef then. Will get a patch up tomorrow. Thanks Areek! Add context to AnalyzingInfixSuggester -- Key: LUCENE-5528 URL: https://issues.apache.org/jira/browse/LUCENE-5528 Project: Lucene - Core Issue Type: Improvement Reporter: Michael McCandless Assignee: Michael McCandless Fix For: 4.8, 5.0 Attachments: LUCENE-5528-1.patch, LUCENE-5528.patch, LUCENE-5528.patch, contextInputIteratImpl.patch Spinoff from LUCENE-5350. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5528) Add context to AnalyzingInfixSuggester
[ https://issues.apache.org/jira/browse/LUCENE-5528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941472#comment-13941472 ] Areek Zillur commented on LUCENE-5528: -- That sounds good. I will change the InputIterator contexts() api to return SetBytesRef then. Will get a patch up tomorrow. Add context to AnalyzingInfixSuggester -- Key: LUCENE-5528 URL: https://issues.apache.org/jira/browse/LUCENE-5528 Project: Lucene - Core Issue Type: Improvement Reporter: Michael McCandless Assignee: Michael McCandless Fix For: 4.8, 5.0 Attachments: LUCENE-5528-1.patch, LUCENE-5528.patch, LUCENE-5528.patch, contextInputIteratImpl.patch Spinoff from LUCENE-5350. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5528) Add context to AnalyzingInfixSuggester
[ https://issues.apache.org/jira/browse/LUCENE-5528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13940381#comment-13940381 ] Michael McCandless commented on LUCENE-5528: Hmm, I think I prefer the simpler SetBytesRef? And e.g. one problem with BytesRefIterator is you can only iterate it once (we'd sort of need a BytesRefIterable I guess), which might be a hassle for some suggesters? Add context to AnalyzingInfixSuggester -- Key: LUCENE-5528 URL: https://issues.apache.org/jira/browse/LUCENE-5528 Project: Lucene - Core Issue Type: Improvement Reporter: Michael McCandless Assignee: Michael McCandless Fix For: 4.8, 5.0 Attachments: LUCENE-5528-1.patch, LUCENE-5528.patch, LUCENE-5528.patch, contextInputIteratImpl.patch Spinoff from LUCENE-5350. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5528) Add context to AnalyzingInfixSuggester
[ https://issues.apache.org/jira/browse/LUCENE-5528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13940038#comment-13940038 ] Areek Zillur commented on LUCENE-5528: -- I have a patch with contexts() returning BytesRefIterator rather than SetBytesRef, along with implementation for the contexts in all the InputIter implementation (except HighFreqInputIter and FileInputIter). Do you think It would make sense to have the context() return a BytesRefIterator instead? Add context to AnalyzingInfixSuggester -- Key: LUCENE-5528 URL: https://issues.apache.org/jira/browse/LUCENE-5528 Project: Lucene - Core Issue Type: Improvement Reporter: Michael McCandless Assignee: Michael McCandless Fix For: 4.8, 5.0 Attachments: LUCENE-5528.patch, LUCENE-5528.patch Spinoff from LUCENE-5350. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
