[jira] [Commented] (LUCENE-5911) Make MemoryIndex thread-safe for queries
[ https://issues.apache.org/jira/browse/LUCENE-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14182605#comment-14182605 ] ASF subversion and git services commented on LUCENE-5911: - Commit 1634034 from [~romseygeek] in branch 'dev/branches/lucene_solr_4_10' [ https://svn.apache.org/r1634034 ] LUCENE-5911: Add freeze() method to MemoryIndex to allow thread-safe searching Make MemoryIndex thread-safe for queries Key: LUCENE-5911 URL: https://issues.apache.org/jira/browse/LUCENE-5911 Project: Lucene - Core Issue Type: Improvement Reporter: Alan Woodward Assignee: Alan Woodward Priority: Minor Fix For: 5.0, Trunk Attachments: LUCENE-5911-2.patch, LUCENE-5911.patch, LUCENE-5911.patch We want to be able to run multiple queries at once over a MemoryIndex in luwak (see https://github.com/flaxsearch/luwak/commit/49a8fba5764020c2f0e4dc29d80d93abb0231191), but this isn't possible with the current implementation. However, looking at the code, it seems that it would be relatively simple to make MemoryIndex thread-safe for reads/queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5911) Make MemoryIndex thread-safe for queries
[ https://issues.apache.org/jira/browse/LUCENE-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14182608#comment-14182608 ] ASF subversion and git services commented on LUCENE-5911: - Commit 1634035 from [~romseygeek] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1634035 ] LUCENE-5911: Update 5x CHANGES.txt Make MemoryIndex thread-safe for queries Key: LUCENE-5911 URL: https://issues.apache.org/jira/browse/LUCENE-5911 Project: Lucene - Core Issue Type: Improvement Reporter: Alan Woodward Assignee: Alan Woodward Priority: Minor Fix For: 5.0, Trunk Attachments: LUCENE-5911-2.patch, LUCENE-5911.patch, LUCENE-5911.patch We want to be able to run multiple queries at once over a MemoryIndex in luwak (see https://github.com/flaxsearch/luwak/commit/49a8fba5764020c2f0e4dc29d80d93abb0231191), but this isn't possible with the current implementation. However, looking at the code, it seems that it would be relatively simple to make MemoryIndex thread-safe for reads/queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5911) Make MemoryIndex thread-safe for queries
[ https://issues.apache.org/jira/browse/LUCENE-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14182609#comment-14182609 ] ASF subversion and git services commented on LUCENE-5911: - Commit 1634036 from [~romseygeek] in branch 'dev/trunk' [ https://svn.apache.org/r1634036 ] LUCENE-5911: Update trunk CHANGES.txt Make MemoryIndex thread-safe for queries Key: LUCENE-5911 URL: https://issues.apache.org/jira/browse/LUCENE-5911 Project: Lucene - Core Issue Type: Improvement Reporter: Alan Woodward Assignee: Alan Woodward Priority: Minor Fix For: 5.0, Trunk Attachments: LUCENE-5911-2.patch, LUCENE-5911.patch, LUCENE-5911.patch We want to be able to run multiple queries at once over a MemoryIndex in luwak (see https://github.com/flaxsearch/luwak/commit/49a8fba5764020c2f0e4dc29d80d93abb0231191), but this isn't possible with the current implementation. However, looking at the code, it seems that it would be relatively simple to make MemoryIndex thread-safe for reads/queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5911) Make MemoryIndex thread-safe for queries
[ https://issues.apache.org/jira/browse/LUCENE-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14182735#comment-14182735 ] Michael McCandless commented on LUCENE-5911: I think this is too big a change to push into 4.10.x branch? That branch is for bug fixes only? Make MemoryIndex thread-safe for queries Key: LUCENE-5911 URL: https://issues.apache.org/jira/browse/LUCENE-5911 Project: Lucene - Core Issue Type: Improvement Reporter: Alan Woodward Assignee: Alan Woodward Priority: Minor Fix For: 4.10.2, 5.0, Trunk Attachments: LUCENE-5911-2.patch, LUCENE-5911.patch, LUCENE-5911.patch We want to be able to run multiple queries at once over a MemoryIndex in luwak (see https://github.com/flaxsearch/luwak/commit/49a8fba5764020c2f0e4dc29d80d93abb0231191), but this isn't possible with the current implementation. However, looking at the code, it seems that it would be relatively simple to make MemoryIndex thread-safe for reads/queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5911) Make MemoryIndex thread-safe for queries
[ https://issues.apache.org/jira/browse/LUCENE-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14182737#comment-14182737 ] Alan Woodward commented on LUCENE-5911: --- Is it? I thought we weren't doing a 4.11? Make MemoryIndex thread-safe for queries Key: LUCENE-5911 URL: https://issues.apache.org/jira/browse/LUCENE-5911 Project: Lucene - Core Issue Type: Improvement Reporter: Alan Woodward Assignee: Alan Woodward Priority: Minor Fix For: 4.10.2, 5.0, Trunk Attachments: LUCENE-5911-2.patch, LUCENE-5911.patch, LUCENE-5911.patch We want to be able to run multiple queries at once over a MemoryIndex in luwak (see https://github.com/flaxsearch/luwak/commit/49a8fba5764020c2f0e4dc29d80d93abb0231191), but this isn't possible with the current implementation. However, looking at the code, it seems that it would be relatively simple to make MemoryIndex thread-safe for reads/queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5911) Make MemoryIndex thread-safe for queries
[ https://issues.apache.org/jira/browse/LUCENE-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14182738#comment-14182738 ] Michael McCandless commented on LUCENE-5911: bq. I thought we weren't doing a 4.11? I don't think we are. The next feature release is going to be 5.0, hopefully soon... Make MemoryIndex thread-safe for queries Key: LUCENE-5911 URL: https://issues.apache.org/jira/browse/LUCENE-5911 Project: Lucene - Core Issue Type: Improvement Reporter: Alan Woodward Assignee: Alan Woodward Priority: Minor Fix For: 4.10.2, 5.0, Trunk Attachments: LUCENE-5911-2.patch, LUCENE-5911.patch, LUCENE-5911.patch We want to be able to run multiple queries at once over a MemoryIndex in luwak (see https://github.com/flaxsearch/luwak/commit/49a8fba5764020c2f0e4dc29d80d93abb0231191), but this isn't possible with the current implementation. However, looking at the code, it seems that it would be relatively simple to make MemoryIndex thread-safe for reads/queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5911) Make MemoryIndex thread-safe for queries
[ https://issues.apache.org/jira/browse/LUCENE-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14182775#comment-14182775 ] ASF subversion and git services commented on LUCENE-5911: - Commit 1634054 from [~romseygeek] in branch 'dev/branches/lucene_solr_4_10' [ https://svn.apache.org/r1634054 ] LUCENE-5911: Revert backport Make MemoryIndex thread-safe for queries Key: LUCENE-5911 URL: https://issues.apache.org/jira/browse/LUCENE-5911 Project: Lucene - Core Issue Type: Improvement Reporter: Alan Woodward Assignee: Alan Woodward Priority: Minor Fix For: 4.10.2, 5.0, Trunk Attachments: LUCENE-5911-2.patch, LUCENE-5911.patch, LUCENE-5911.patch We want to be able to run multiple queries at once over a MemoryIndex in luwak (see https://github.com/flaxsearch/luwak/commit/49a8fba5764020c2f0e4dc29d80d93abb0231191), but this isn't possible with the current implementation. However, looking at the code, it seems that it would be relatively simple to make MemoryIndex thread-safe for reads/queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5911) Make MemoryIndex thread-safe for queries
[ https://issues.apache.org/jira/browse/LUCENE-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14182779#comment-14182779 ] Michael McCandless commented on LUCENE-5911: Thanks Alan, I'll spin an RC now... Make MemoryIndex thread-safe for queries Key: LUCENE-5911 URL: https://issues.apache.org/jira/browse/LUCENE-5911 Project: Lucene - Core Issue Type: Improvement Reporter: Alan Woodward Assignee: Alan Woodward Priority: Minor Fix For: 5.0, Trunk Attachments: LUCENE-5911-2.patch, LUCENE-5911.patch, LUCENE-5911.patch We want to be able to run multiple queries at once over a MemoryIndex in luwak (see https://github.com/flaxsearch/luwak/commit/49a8fba5764020c2f0e4dc29d80d93abb0231191), but this isn't possible with the current implementation. However, looking at the code, it seems that it would be relatively simple to make MemoryIndex thread-safe for reads/queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5911) Make MemoryIndex thread-safe for queries
[ https://issues.apache.org/jira/browse/LUCENE-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14182771#comment-14182771 ] Alan Woodward commented on LUCENE-5911: --- OK, will revert. Make MemoryIndex thread-safe for queries Key: LUCENE-5911 URL: https://issues.apache.org/jira/browse/LUCENE-5911 Project: Lucene - Core Issue Type: Improvement Reporter: Alan Woodward Assignee: Alan Woodward Priority: Minor Fix For: 4.10.2, 5.0, Trunk Attachments: LUCENE-5911-2.patch, LUCENE-5911.patch, LUCENE-5911.patch We want to be able to run multiple queries at once over a MemoryIndex in luwak (see https://github.com/flaxsearch/luwak/commit/49a8fba5764020c2f0e4dc29d80d93abb0231191), but this isn't possible with the current implementation. However, looking at the code, it seems that it would be relatively simple to make MemoryIndex thread-safe for reads/queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5911) Make MemoryIndex thread-safe for queries
[ https://issues.apache.org/jira/browse/LUCENE-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178167#comment-14178167 ] ASF subversion and git services commented on LUCENE-5911: - Commit 1633321 from [~romseygeek] in branch 'dev/trunk' [ https://svn.apache.org/r1633321 ] LUCENE-5911: Remove cacheing of norms, calculate up front in freeze() Make MemoryIndex thread-safe for queries Key: LUCENE-5911 URL: https://issues.apache.org/jira/browse/LUCENE-5911 Project: Lucene - Core Issue Type: Improvement Reporter: Alan Woodward Assignee: Alan Woodward Priority: Minor Fix For: 5.0, Trunk Attachments: LUCENE-5911-2.patch, LUCENE-5911.patch, LUCENE-5911.patch We want to be able to run multiple queries at once over a MemoryIndex in luwak (see https://github.com/flaxsearch/luwak/commit/49a8fba5764020c2f0e4dc29d80d93abb0231191), but this isn't possible with the current implementation. However, looking at the code, it seems that it would be relatively simple to make MemoryIndex thread-safe for reads/queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5911) Make MemoryIndex thread-safe for queries
[ https://issues.apache.org/jira/browse/LUCENE-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178170#comment-14178170 ] ASF subversion and git services commented on LUCENE-5911: - Commit 1633322 from [~romseygeek] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1633322 ] LUCENE-5911: Remove cacheing of norms, calculate up front in freeze() Make MemoryIndex thread-safe for queries Key: LUCENE-5911 URL: https://issues.apache.org/jira/browse/LUCENE-5911 Project: Lucene - Core Issue Type: Improvement Reporter: Alan Woodward Assignee: Alan Woodward Priority: Minor Fix For: 5.0, Trunk Attachments: LUCENE-5911-2.patch, LUCENE-5911.patch, LUCENE-5911.patch We want to be able to run multiple queries at once over a MemoryIndex in luwak (see https://github.com/flaxsearch/luwak/commit/49a8fba5764020c2f0e4dc29d80d93abb0231191), but this isn't possible with the current implementation. However, looking at the code, it seems that it would be relatively simple to make MemoryIndex thread-safe for reads/queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5911) Make MemoryIndex thread-safe for queries
[ https://issues.apache.org/jira/browse/LUCENE-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14176208#comment-14176208 ] David Smiley commented on LUCENE-5911: -- +1 looks good. Make MemoryIndex thread-safe for queries Key: LUCENE-5911 URL: https://issues.apache.org/jira/browse/LUCENE-5911 Project: Lucene - Core Issue Type: Improvement Reporter: Alan Woodward Assignee: Alan Woodward Priority: Minor Fix For: 5.0, Trunk Attachments: LUCENE-5911-2.patch, LUCENE-5911.patch, LUCENE-5911.patch We want to be able to run multiple queries at once over a MemoryIndex in luwak (see https://github.com/flaxsearch/luwak/commit/49a8fba5764020c2f0e4dc29d80d93abb0231191), but this isn't possible with the current implementation. However, looking at the code, it seems that it would be relatively simple to make MemoryIndex thread-safe for reads/queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5911) Make MemoryIndex thread-safe for queries
[ https://issues.apache.org/jira/browse/LUCENE-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14172338#comment-14172338 ] Robert Muir commented on LUCENE-5911: - David: you are right. This caching is unnecessary in my opinion. Instead if the optional freeze() method is supposed to prepare internal structures for querying, I would have freeze() just prebuild, populate an ArrayListNumericDocValues (indexed by field number), by calling getNormValues() for each one. If you don't call freeze, this list is null, and it just returns a new one each time: not worth caching or anything for that case. Make MemoryIndex thread-safe for queries Key: LUCENE-5911 URL: https://issues.apache.org/jira/browse/LUCENE-5911 Project: Lucene - Core Issue Type: Improvement Reporter: Alan Woodward Assignee: Alan Woodward Priority: Minor Fix For: 5.0, Trunk Attachments: LUCENE-5911.patch, LUCENE-5911.patch We want to be able to run multiple queries at once over a MemoryIndex in luwak (see https://github.com/flaxsearch/luwak/commit/49a8fba5764020c2f0e4dc29d80d93abb0231191), but this isn't possible with the current implementation. However, looking at the code, it seems that it would be relatively simple to make MemoryIndex thread-safe for reads/queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5911) Make MemoryIndex thread-safe for queries
[ https://issues.apache.org/jira/browse/LUCENE-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14171941#comment-14171941 ] David Smiley commented on LUCENE-5911: -- I see that getNormValues() caches the norms and doesn't use synchronization, so it's not thread-safe yet. Make MemoryIndex thread-safe for queries Key: LUCENE-5911 URL: https://issues.apache.org/jira/browse/LUCENE-5911 Project: Lucene - Core Issue Type: Improvement Reporter: Alan Woodward Assignee: Alan Woodward Priority: Minor Fix For: 5.0, Trunk Attachments: LUCENE-5911.patch, LUCENE-5911.patch We want to be able to run multiple queries at once over a MemoryIndex in luwak (see https://github.com/flaxsearch/luwak/commit/49a8fba5764020c2f0e4dc29d80d93abb0231191), but this isn't possible with the current implementation. However, looking at the code, it seems that it would be relatively simple to make MemoryIndex thread-safe for reads/queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5911) Make MemoryIndex thread-safe for queries
[ https://issues.apache.org/jira/browse/LUCENE-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14151738#comment-14151738 ] ASF subversion and git services commented on LUCENE-5911: - Commit 1628194 from [~rcmuir] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1628194 ] LUCENE-5911: fix compile Make MemoryIndex thread-safe for queries Key: LUCENE-5911 URL: https://issues.apache.org/jira/browse/LUCENE-5911 Project: Lucene - Core Issue Type: Improvement Reporter: Alan Woodward Assignee: Alan Woodward Priority: Minor Fix For: 5.0, Trunk Attachments: LUCENE-5911.patch, LUCENE-5911.patch We want to be able to run multiple queries at once over a MemoryIndex in luwak (see https://github.com/flaxsearch/luwak/commit/49a8fba5764020c2f0e4dc29d80d93abb0231191), but this isn't possible with the current implementation. However, looking at the code, it seems that it would be relatively simple to make MemoryIndex thread-safe for reads/queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5911) Make MemoryIndex thread-safe for queries
[ https://issues.apache.org/jira/browse/LUCENE-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14151568#comment-14151568 ] ASF subversion and git services commented on LUCENE-5911: - Commit 1628154 from [~romseygeek] in branch 'dev/trunk' [ https://svn.apache.org/r1628154 ] LUCENE-5911: Add MemoryIndex.freeze() to allow for thread-safe searching Make MemoryIndex thread-safe for queries Key: LUCENE-5911 URL: https://issues.apache.org/jira/browse/LUCENE-5911 Project: Lucene - Core Issue Type: Improvement Reporter: Alan Woodward Priority: Minor Attachments: LUCENE-5911.patch, LUCENE-5911.patch We want to be able to run multiple queries at once over a MemoryIndex in luwak (see https://github.com/flaxsearch/luwak/commit/49a8fba5764020c2f0e4dc29d80d93abb0231191), but this isn't possible with the current implementation. However, looking at the code, it seems that it would be relatively simple to make MemoryIndex thread-safe for reads/queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5911) Make MemoryIndex thread-safe for queries
[ https://issues.apache.org/jira/browse/LUCENE-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14151569#comment-14151569 ] ASF subversion and git services commented on LUCENE-5911: - Commit 1628155 from [~romseygeek] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1628155 ] LUCENE-5911: Add MemoryIndex.freeze() to allow for thread-safe searching Make MemoryIndex thread-safe for queries Key: LUCENE-5911 URL: https://issues.apache.org/jira/browse/LUCENE-5911 Project: Lucene - Core Issue Type: Improvement Reporter: Alan Woodward Priority: Minor Attachments: LUCENE-5911.patch, LUCENE-5911.patch We want to be able to run multiple queries at once over a MemoryIndex in luwak (see https://github.com/flaxsearch/luwak/commit/49a8fba5764020c2f0e4dc29d80d93abb0231191), but this isn't possible with the current implementation. However, looking at the code, it seems that it would be relatively simple to make MemoryIndex thread-safe for reads/queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5911) Make MemoryIndex thread-safe for queries
[ https://issues.apache.org/jira/browse/LUCENE-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14143856#comment-14143856 ] Simon Willnauer commented on LUCENE-5911: - +1 to freeze Make MemoryIndex thread-safe for queries Key: LUCENE-5911 URL: https://issues.apache.org/jira/browse/LUCENE-5911 Project: Lucene - Core Issue Type: Improvement Reporter: Alan Woodward Priority: Minor Attachments: LUCENE-5911.patch, LUCENE-5911.patch We want to be able to run multiple queries at once over a MemoryIndex in luwak (see https://github.com/flaxsearch/luwak/commit/49a8fba5764020c2f0e4dc29d80d93abb0231191), but this isn't possible with the current implementation. However, looking at the code, it seems that it would be relatively simple to make MemoryIndex thread-safe for reads/queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5911) Make MemoryIndex thread-safe for queries
[ https://issues.apache.org/jira/browse/LUCENE-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14138708#comment-14138708 ] Alan Woodward commented on LUCENE-5911: --- Do you mean add a publish() method to MemoryIndex? There's no easy way of getting sortTerms() to run on all the fields outside of calling toString() at the moment, unless I'm missing something. Make MemoryIndex thread-safe for queries Key: LUCENE-5911 URL: https://issues.apache.org/jira/browse/LUCENE-5911 Project: Lucene - Core Issue Type: Improvement Reporter: Alan Woodward Priority: Minor Attachments: LUCENE-5911.patch We want to be able to run multiple queries at once over a MemoryIndex in luwak (see https://github.com/flaxsearch/luwak/commit/49a8fba5764020c2f0e4dc29d80d93abb0231191), but this isn't possible with the current implementation. However, looking at the code, it seems that it would be relatively simple to make MemoryIndex thread-safe for reads/queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5911) Make MemoryIndex thread-safe for queries
[ https://issues.apache.org/jira/browse/LUCENE-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14139015#comment-14139015 ] Simon Willnauer commented on LUCENE-5911: - I don't see how you can make this actually faster though... I don't think you can gain anything here really. I'd maybe add a method that allows you to sort all of them and use that before you pass the MemoryIndex to the search threads? Make MemoryIndex thread-safe for queries Key: LUCENE-5911 URL: https://issues.apache.org/jira/browse/LUCENE-5911 Project: Lucene - Core Issue Type: Improvement Reporter: Alan Woodward Priority: Minor Attachments: LUCENE-5911.patch We want to be able to run multiple queries at once over a MemoryIndex in luwak (see https://github.com/flaxsearch/luwak/commit/49a8fba5764020c2f0e4dc29d80d93abb0231191), but this isn't possible with the current implementation. However, looking at the code, it seems that it would be relatively simple to make MemoryIndex thread-safe for reads/queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5911) Make MemoryIndex thread-safe for queries
[ https://issues.apache.org/jira/browse/LUCENE-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14139026#comment-14139026 ] Yonik Seeley commented on LUCENE-5911: -- It feels like sortTerms is an implementation detail that should not be exposed to the user. +1 to this patch to make things thread-safe. Make MemoryIndex thread-safe for queries Key: LUCENE-5911 URL: https://issues.apache.org/jira/browse/LUCENE-5911 Project: Lucene - Core Issue Type: Improvement Reporter: Alan Woodward Priority: Minor Attachments: LUCENE-5911.patch We want to be able to run multiple queries at once over a MemoryIndex in luwak (see https://github.com/flaxsearch/luwak/commit/49a8fba5764020c2f0e4dc29d80d93abb0231191), but this isn't possible with the current implementation. However, looking at the code, it seems that it would be relatively simple to make MemoryIndex thread-safe for reads/queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5911) Make MemoryIndex thread-safe for queries
[ https://issues.apache.org/jira/browse/LUCENE-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14139134#comment-14139134 ] Alan Woodward commented on LUCENE-5911: --- Adding synchronized is a bit brute-force though. The lazy-sorting bit is presumably for situations like highlighting where you want to index a single document and run only a couple of queries over it as quickly as possible. So maybe the answer is to have a derived class, ThreadSafeMemoryIndex, which sorts the terms in the Info constructor. That way if you want to use this in a lazily-instantiated way you continue to use MemoryIndex, but luwak (and the percolator) would use TSMI instead. I'll work on a patch. Make MemoryIndex thread-safe for queries Key: LUCENE-5911 URL: https://issues.apache.org/jira/browse/LUCENE-5911 Project: Lucene - Core Issue Type: Improvement Reporter: Alan Woodward Priority: Minor Attachments: LUCENE-5911.patch We want to be able to run multiple queries at once over a MemoryIndex in luwak (see https://github.com/flaxsearch/luwak/commit/49a8fba5764020c2f0e4dc29d80d93abb0231191), but this isn't possible with the current implementation. However, looking at the code, it seems that it would be relatively simple to make MemoryIndex thread-safe for reads/queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5911) Make MemoryIndex thread-safe for queries
[ https://issues.apache.org/jira/browse/LUCENE-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14137159#comment-14137159 ] Alan Woodward commented on LUCENE-5911: --- We're running some tests on this at the moment to see if adding in the synchronization slows things down noticeably. Anybody have any comments? [~simonw] or [~martijn.v.groningen]? Make MemoryIndex thread-safe for queries Key: LUCENE-5911 URL: https://issues.apache.org/jira/browse/LUCENE-5911 Project: Lucene - Core Issue Type: Improvement Reporter: Alan Woodward Priority: Minor Attachments: LUCENE-5911.patch We want to be able to run multiple queries at once over a MemoryIndex in luwak (see https://github.com/flaxsearch/luwak/commit/49a8fba5764020c2f0e4dc29d80d93abb0231191), but this isn't possible with the current implementation. However, looking at the code, it seems that it would be relatively simple to make MemoryIndex thread-safe for reads/queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5911) Make MemoryIndex thread-safe for queries
[ https://issues.apache.org/jira/browse/LUCENE-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14138002#comment-14138002 ] Simon Willnauer commented on LUCENE-5911: - I don't understand why you not just simply calling sortTerms before you publish the MemoryIndex for querying? no need to sync this here at all no? Make MemoryIndex thread-safe for queries Key: LUCENE-5911 URL: https://issues.apache.org/jira/browse/LUCENE-5911 Project: Lucene - Core Issue Type: Improvement Reporter: Alan Woodward Priority: Minor Attachments: LUCENE-5911.patch We want to be able to run multiple queries at once over a MemoryIndex in luwak (see https://github.com/flaxsearch/luwak/commit/49a8fba5764020c2f0e4dc29d80d93abb0231191), but this isn't possible with the current implementation. However, looking at the code, it seems that it would be relatively simple to make MemoryIndex thread-safe for reads/queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
