[jira] [Commented] (LUCENE-6709) Add RandomAccessOrds support to UninvertedReader's SortedSetDocValues impl (DocTermOrds.Iterator)
[ https://issues.apache.org/jira/browse/LUCENE-6709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517053#comment-16517053 ] David Smiley commented on LUCENE-6709: -- Out of curiosity I looked closer here. This issue ought to be re-titled because, for one thing, RandomAccessOrds doesn't exist anymore as of LUCENE-7407 (Lucene 7.0). SortedSetSelector _used to_ demand that the input sortedSet implement RandomAccessOrds but the current code has no equivalent constraint. This suggests maybe things will "just work" if perhaps the the check in TrieField that Hoss pointed out were removed. Indeed, I did that and the test Hoss said which used to fail now passes. > Add RandomAccessOrds support to UninvertedReader's SortedSetDocValues impl > (DocTermOrds.Iterator) > - > > Key: LUCENE-6709 > URL: https://issues.apache.org/jira/browse/LUCENE-6709 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Hoss Man >Priority: Major > > UninvertedReader's SortedSetDocValues impl doesn't implement the > RandomAccessOrds API, so it can't be used with SortedSetSelector. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6709) Add RandomAccessOrds support to UninvertedReader's SortedSetDocValues impl (DocTermOrds.Iterator)
[ https://issues.apache.org/jira/browse/LUCENE-6709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516074#comment-16516074 ] Erick Erickson commented on LUCENE-6709: OK, my mistake. Somehow I thought AwaitsFix were run too. Ignore me. Sorry for the noise. > Add RandomAccessOrds support to UninvertedReader's SortedSetDocValues impl > (DocTermOrds.Iterator) > - > > Key: LUCENE-6709 > URL: https://issues.apache.org/jira/browse/LUCENE-6709 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Hoss Man >Priority: Major > > UninvertedReader's SortedSetDocValues impl doesn't implement the > RandomAccessOrds API, so it can't be used with SortedSetSelector. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6709) Add RandomAccessOrds support to UninvertedReader's SortedSetDocValues impl (DocTermOrds.Iterator)
[
https://issues.apache.org/jira/browse/LUCENE-6709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516062#comment-16516062
]
Hoss Man commented on LUCENE-6709:
--
I don't understand your question...
* the tests that i know of that mention LUCENE-6709 are Solr tests marked
AwaitsFix - not BadApple, so they aren't run by any jenkins job that i know of
(even on the BadApple jenkins job results they are listed as "skipped")
* when i try to run some of them manually with something like {{ant test
-Dtests.awaitsfix=true -Dtestcase=TestMinMaxOnMultiValuedField
-Dtests.method=testIntFieldCache}} i do in fact see failures depending on the
randomization of points vs trie fields
** this limitation that UninvertedReader's SortedSetDocValues doesn't work
with SortedSetSelector doesn't affect Points fields since they don't use
SortedSetDocValues
** you can force it to fail everytime w/something like this: {{ant test
-Dtests.awaitsfix=true -Dtestcase=TestMinMaxOnMultiValuedField
-Dtests.method=testIntFieldCache -Dsolr.tests.use.numeric.points=false}}
* even if the underlying functionality requested in LUCENE-6709 had been
added/fixed to UninvertedReader w/o updating those tests, they still wouldn''t
start automatically working, since the Affected solr field types have explicit
error checks that would prevent that could from being usable until they were
removed...
{noformat}
$ grep -A 5 LUCENE-6709 ./src/java/org/apache/solr/schema/TrieField.java
// See LUCENE-6709
if (! field.hasDocValues()) {
throw new SolrException(SolrException.ErrorCode.BAD_REQUEST,
"docValues='true' is required to select '" +
choice.toString() +
"' value from multivalued field ("+
field.getName() +") at query time");
}
{noformat}
> Add RandomAccessOrds support to UninvertedReader's SortedSetDocValues impl
> (DocTermOrds.Iterator)
> -
>
> Key: LUCENE-6709
> URL: https://issues.apache.org/jira/browse/LUCENE-6709
> Project: Lucene - Core
> Issue Type: Improvement
>Reporter: Hoss Man
>Priority: Major
>
> UninvertedReader's SortedSetDocValues impl doesn't implement the
> RandomAccessOrds API, so it can't be used with SortedSetSelector.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6709) Add RandomAccessOrds support to UninvertedReader's SortedSetDocValues impl (DocTermOrds.Iterator)
[ https://issues.apache.org/jira/browse/LUCENE-6709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516010#comment-16516010 ] Erick Erickson commented on LUCENE-6709: [~hossman]These tests haven't failed since early April, should they still be AwaitsFix? > Add RandomAccessOrds support to UninvertedReader's SortedSetDocValues impl > (DocTermOrds.Iterator) > - > > Key: LUCENE-6709 > URL: https://issues.apache.org/jira/browse/LUCENE-6709 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Hoss Man >Priority: Major > > UninvertedReader's SortedSetDocValues impl doesn't implement the > RandomAccessOrds API, so it can't be used with SortedSetSelector. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6709) Add RandomAccessOrds support to UninvertedReader's SortedSetDocValues impl (DocTermOrds.Iterator)
[ https://issues.apache.org/jira/browse/LUCENE-6709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14648077#comment-14648077 ] Hoss Man commented on LUCENE-6709: -- NOTE: I have no idea if/how feasible this is, i mainly just wanted to file it as an open issue for linking as a blocker to some other issues. Add RandomAccessOrds support to UninvertedReader's SortedSetDocValues impl (DocTermOrds.Iterator) - Key: LUCENE-6709 URL: https://issues.apache.org/jira/browse/LUCENE-6709 Project: Lucene - Core Issue Type: Improvement Reporter: Hoss Man UninvertedReader's SortedSetDocValues impl doesn't implement the RandomAccessOrds API, so it can't be used with SortedSetSelector. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
