[jira] [Commented] (LUCENE-6898) Avoid reading last stored field value when StoredFieldVisitor.Status.NO
[ https://issues.apache.org/jira/browse/LUCENE-6898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013316#comment-15013316 ] Adrien Grand commented on LUCENE-6898: -- +1 For the record, this would only help if the last stored field value is larger than 16KB. Otherwise we're just skipping over data that is already decompressed. > Avoid reading last stored field value when StoredFieldVisitor.Status.NO > --- > > Key: LUCENE-6898 > URL: https://issues.apache.org/jira/browse/LUCENE-6898 > Project: Lucene - Core > Issue Type: Improvement > Components: core/codecs >Reporter: David Smiley >Assignee: David Smiley >Priority: Minor > Attachments: LUCENE-6898.patch > > > CompressingStoredFieldsReader.visitDocument (line 597) loops through the > fields in the input while consulting the StoredFieldVisitor on what to do. > There is a small optimization that could be done on the last loop iteration. > If the visitor returns Status.NO then it should be treated as equivalent to > Status.STOP. As it is now, it will call skipField() which reads needless > bytes from the DataInput that won't be used. > With this optimization in place, it is advisable to put the largest text > field last in sequence -- something the user or search platform (e.g. > ES/Solr) could do. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6898) Avoid reading last stored field value when StoredFieldVisitor.Status.NO
[ https://issues.apache.org/jira/browse/LUCENE-6898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014570#comment-15014570 ] ASF subversion and git services commented on LUCENE-6898: - Commit 1715299 from [~dsmiley] in branch 'dev/trunk' [ https://svn.apache.org/r1715299 ] LUCENE-6898: Don't fully read the last stored field value from disk if the StoredFieldVisitor doesn't want it. > Avoid reading last stored field value when StoredFieldVisitor.Status.NO > --- > > Key: LUCENE-6898 > URL: https://issues.apache.org/jira/browse/LUCENE-6898 > Project: Lucene - Core > Issue Type: Improvement > Components: core/codecs >Reporter: David Smiley >Assignee: David Smiley >Priority: Minor > Attachments: LUCENE-6898.patch > > > CompressingStoredFieldsReader.visitDocument (line 597) loops through the > fields in the input while consulting the StoredFieldVisitor on what to do. > There is a small optimization that could be done on the last loop iteration. > If the visitor returns Status.NO then it should be treated as equivalent to > Status.STOP. As it is now, it will call skipField() which reads needless > bytes from the DataInput that won't be used. > With this optimization in place, it is advisable to put the largest text > field last in sequence -- something the user or search platform (e.g. > ES/Solr) could do. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6898) Avoid reading last stored field value when StoredFieldVisitor.Status.NO
[ https://issues.apache.org/jira/browse/LUCENE-6898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014577#comment-15014577 ] ASF subversion and git services commented on LUCENE-6898: - Commit 1715300 from [~dsmiley] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1715300 ] LUCENE-6898: Don't fully read the last stored field value from disk if the StoredFieldVisitor doesn't want it. > Avoid reading last stored field value when StoredFieldVisitor.Status.NO > --- > > Key: LUCENE-6898 > URL: https://issues.apache.org/jira/browse/LUCENE-6898 > Project: Lucene - Core > Issue Type: Improvement > Components: core/codecs >Reporter: David Smiley >Assignee: David Smiley >Priority: Minor > Attachments: LUCENE-6898.patch > > > CompressingStoredFieldsReader.visitDocument (line 597) loops through the > fields in the input while consulting the StoredFieldVisitor on what to do. > There is a small optimization that could be done on the last loop iteration. > If the visitor returns Status.NO then it should be treated as equivalent to > Status.STOP. As it is now, it will call skipField() which reads needless > bytes from the DataInput that won't be used. > With this optimization in place, it is advisable to put the largest text > field last in sequence -- something the user or search platform (e.g. > ES/Solr) could do. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6898) Avoid reading last stored field value when StoredFieldVisitor.Status.NO
[ https://issues.apache.org/jira/browse/LUCENE-6898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011979#comment-15011979 ] David Smiley commented on LUCENE-6898: -- I plan to commit this tomorrow at about this time. > Avoid reading last stored field value when StoredFieldVisitor.Status.NO > --- > > Key: LUCENE-6898 > URL: https://issues.apache.org/jira/browse/LUCENE-6898 > Project: Lucene - Core > Issue Type: Improvement > Components: core/codecs >Reporter: David Smiley >Assignee: David Smiley >Priority: Minor > Attachments: LUCENE-6898.patch > > > CompressingStoredFieldsReader.visitDocument (line 597) loops through the > fields in the input while consulting the StoredFieldVisitor on what to do. > There is a small optimization that could be done on the last loop iteration. > If the visitor returns Status.NO then it should be treated as equivalent to > Status.STOP. As it is now, it will call skipField() which reads needless > bytes from the DataInput that won't be used. > With this optimization in place, it is advisable to put the largest text > field last in sequence -- something the user or search platform (e.g. > ES/Solr) could do. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
