[jira] [Commented] (LUCENE-7086) SlowCompositeReaderWrapper does not support point values

2016-04-26 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/LUCENE-7086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257820#comment-15257820
 ] 

Andrés de la Peña commented on LUCENE-7086:
---

Yes, it seems to be. I have also created 
[LUCENE-7255|https://issues.apache.org/jira/browse/LUCENE-7255] for the problem 
with paging with {{EarlyTerminatingSortingCollector}}. 

> SlowCompositeReaderWrapper does not support point values
> 
>
> Key: LUCENE-7086
> URL: https://issues.apache.org/jira/browse/LUCENE-7086
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Adrien Grand
>Assignee: Michael McCandless
> Fix For: master, 6.0
>
> Attachments: LUCENE-7086.patch, LUCENE-7086.patch
>
>
> SlowCompositeReaderWrapper.getPointValues always returns null. I think this 
> is trappy and we should either implement it or throw an 
> UnsupportedOperationException instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-7086) SlowCompositeReaderWrapper does not support point values

2016-04-23 Thread Michael McCandless (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-7086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15255368#comment-15255368
 ] 

Michael McCandless commented on LUCENE-7086:


I think LUCENE-6766 is maybe the path forward here.

> SlowCompositeReaderWrapper does not support point values
> 
>
> Key: LUCENE-7086
> URL: https://issues.apache.org/jira/browse/LUCENE-7086
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Adrien Grand
>Assignee: Michael McCandless
> Fix For: master, 6.0
>
> Attachments: LUCENE-7086.patch, LUCENE-7086.patch
>
>
> SlowCompositeReaderWrapper.getPointValues always returns null. I think this 
> is trappy and we should either implement it or throw an 
> UnsupportedOperationException instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-7086) SlowCompositeReaderWrapper does not support point values

2016-04-23 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/LUCENE-7086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15255284#comment-15255284
 ] 

Andrés de la Peña commented on LUCENE-7086:
---

Yes, it is a pity. In [our particular use 
case|https://github.com/Stratio/cassandra-lucene-index], we can't renounce to 
the huge performance improvements due to the usage of 
{{EarlyTerminatingSortingCollector}}. Now that the numeric fields have 
disappeared, I guess that we don't have other option than using numeric doc 
values if we want to upgrade to Lucene 6.0.0. Should we open a new ticket for 
fixing this incompatibility within {{SortingMergePolicy}} and point fields, or 
is it covered by any other ticket? We can't wait to use the amazing point 
fields!

It would also be good to take a look to [the problems paging over search 
results|http://permalink.gmane.org/gmane.comp.jakarta.lucene.user/60076] with 
{{EarlyTerminatingSortingCollector}}.

> SlowCompositeReaderWrapper does not support point values
> 
>
> Key: LUCENE-7086
> URL: https://issues.apache.org/jira/browse/LUCENE-7086
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Adrien Grand
>Assignee: Michael McCandless
> Fix For: master, 6.0
>
> Attachments: LUCENE-7086.patch, LUCENE-7086.patch
>
>
> SlowCompositeReaderWrapper.getPointValues always returns null. I think this 
> is trappy and we should either implement it or throw an 
> UnsupportedOperationException instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-7086) SlowCompositeReaderWrapper does not support point values

2016-04-23 Thread Michael McCandless (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-7086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15255256#comment-15255256
 ] 

Michael McCandless commented on LUCENE-7086:


bq. it seems that this makes SortingMergePolicy (which uses 
SlowCompositeReaderWrapper) incompatible with point fields

Yes, unfortunately ... so currently you cannot do index-time sorting if you 
index points.  I agree that sucks and we need to fix it ... though I don't 
understand why index-time sorting needs to use the inefficient 
{{SlowCompositeReaderWrapper}} ... it is the last place in Lucene that relies 
on it.

> SlowCompositeReaderWrapper does not support point values
> 
>
> Key: LUCENE-7086
> URL: https://issues.apache.org/jira/browse/LUCENE-7086
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Adrien Grand
>Assignee: Michael McCandless
> Fix For: master, 6.0
>
> Attachments: LUCENE-7086.patch, LUCENE-7086.patch
>
>
> SlowCompositeReaderWrapper.getPointValues always returns null. I think this 
> is trappy and we should either implement it or throw an 
> UnsupportedOperationException instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-7086) SlowCompositeReaderWrapper does not support point values

2016-04-18 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/LUCENE-7086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245923#comment-15245923
 ] 

Andrés de la Peña commented on LUCENE-7086:
---

[~mikemccand], it seems that this makes {{SortingMergePolicy}} (which uses 
{{SlowCompositeReaderWrapper}}) incompatible with point fields, even if the 
{{Sort}} used by the merge policy doesn't contain points. Should the users 
choose between point fields and index sorting? Is there any way to make both 
compatible? 

> SlowCompositeReaderWrapper does not support point values
> 
>
> Key: LUCENE-7086
> URL: https://issues.apache.org/jira/browse/LUCENE-7086
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Adrien Grand
>Assignee: Michael McCandless
> Fix For: master, 6.0
>
> Attachments: LUCENE-7086.patch, LUCENE-7086.patch
>
>
> SlowCompositeReaderWrapper.getPointValues always returns null. I think this 
> is trappy and we should either implement it or throw an 
> UnsupportedOperationException instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-7086) SlowCompositeReaderWrapper does not support point values

2016-03-26 Thread Michael McCandless (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-7086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212897#comment-15212897
 ] 

Michael McCandless commented on LUCENE-7086:


bq. Even if the strategy is filtering out points, shouldn't that be done in 
this class?

I don't think so.

I think filtering away points should be a very explicit choice on the part of 
the user, not something that's silently done by default: that kind of leniency 
only leads to problems, and was in fact the original reason for opening this 
issue.

And exactly how the filtering should happen is not obvious / schema dependent: 
should any field that has points be completely removed?  Or should the field be 
kept when it has other things (doc values, postings), only suppressing that it 
has points?  When those points fields are removed, should other fields also be 
removed?

A user who has indexed points yet also wants to use this slow class needs to 
work out how they want to hide their indexed points.

bq. The Javadoc doesn't even warn that this class won't work if your index 
contains point fields.

+1 to update the javadocs making this clearer.

> SlowCompositeReaderWrapper does not support point values
> 
>
> Key: LUCENE-7086
> URL: https://issues.apache.org/jira/browse/LUCENE-7086
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Adrien Grand
>Assignee: Michael McCandless
> Fix For: master, 6.0
>
> Attachments: LUCENE-7086.patch, LUCENE-7086.patch
>
>
> SlowCompositeReaderWrapper.getPointValues always returns null. I think this 
> is trappy and we should either implement it or throw an 
> UnsupportedOperationException instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-7086) SlowCompositeReaderWrapper does not support point values

2016-03-25 Thread Yonik Seeley (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-7086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212637#comment-15212637
 ] 

Yonik Seeley commented on LUCENE-7086:
--

Even if the strategy is filtering out points, shouldn't that be done *in* this 
class?
Otherwise this class becomes useless on it's own since indexes w/o point fields 
will be few and far between.  The Javadoc doesn't even warn that this class 
won't work if your index contains point fields. It's a trap waiting for later 
until one does add the first point field.

> SlowCompositeReaderWrapper does not support point values
> 
>
> Key: LUCENE-7086
> URL: https://issues.apache.org/jira/browse/LUCENE-7086
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Adrien Grand
>Assignee: Michael McCandless
> Fix For: master, 6.0
>
> Attachments: LUCENE-7086.patch, LUCENE-7086.patch
>
>
> SlowCompositeReaderWrapper.getPointValues always returns null. I think this 
> is trappy and we should either implement it or throw an 
> UnsupportedOperationException instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-7086) SlowCompositeReaderWrapper does not support point values

2016-03-25 Thread Michael McCandless (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-7086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212616#comment-15212616
 ] 

Michael McCandless commented on LUCENE-7086:


bq. Seems like it would be nicer to throw an exception when asking for a merged 
Point field instead?

I think doing it lazily is dangerous: you present an inconsistent reader to 
Lucene which claims to have point values (via its {{getFieldInfos}}), but then 
throws an exception when you ask for them.  This was causing problems in my 
original patch ... it was discusses above.

I think it's better to filter the incoming readers to hide any fields that have 
point values from the {{FieldInfos}}?

> SlowCompositeReaderWrapper does not support point values
> 
>
> Key: LUCENE-7086
> URL: https://issues.apache.org/jira/browse/LUCENE-7086
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Adrien Grand
>Assignee: Michael McCandless
> Fix For: master, 6.0
>
> Attachments: LUCENE-7086.patch, LUCENE-7086.patch
>
>
> SlowCompositeReaderWrapper.getPointValues always returns null. I think this 
> is trappy and we should either implement it or throw an 
> UnsupportedOperationException instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-7086) SlowCompositeReaderWrapper does not support point values

2016-03-25 Thread Yonik Seeley (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-7086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212318#comment-15212318
 ] 

Yonik Seeley commented on LUCENE-7086:
--

This patch is really unfriendly since it throws an exception if you have Point 
fields in your index, even if you don't use them through this wrapper!
Since pretty much every index will have Point fields from now on, this means 
that SlowCompositeReaderWrapper will pretty much never work alone.

Seems like it would be nicer to throw an exception when asking for a merged 
Point field instead?

> SlowCompositeReaderWrapper does not support point values
> 
>
> Key: LUCENE-7086
> URL: https://issues.apache.org/jira/browse/LUCENE-7086
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Adrien Grand
>Assignee: Michael McCandless
> Fix For: master, 6.0
>
> Attachments: LUCENE-7086.patch, LUCENE-7086.patch
>
>
> SlowCompositeReaderWrapper.getPointValues always returns null. I think this 
> is trappy and we should either implement it or throw an 
> UnsupportedOperationException instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-7086) SlowCompositeReaderWrapper does not support point values

2016-03-10 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-7086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190074#comment-15190074
 ] 

ASF subversion and git services commented on LUCENE-7086:
-

Commit c34272da21023f1960d354539a0ec8232b7bfb6f in lucene-solr's branch 
refs/heads/branch_6_0 from Mike McCandless
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c34272d ]

LUCENE-7086: move SlowCompositeReaderWrapper to misc module, and throw clear 
exc if you try to use in with points

Squashed commits:

commit e26b065c71388407bc6725256ca43d7bb30dee29
Author: Mike McCandless 
Date:   Thu Mar 10 14:16:45 2016 -0500

simplify the checking for incoming points

commit b7254376dcb398c7739aab4544118bb4526961d5
Merge: 8ec82a0 d35d569
Author: Mike McCandless 
Date:   Thu Mar 10 14:05:24 2016 -0500

Merge branch 'master' into slow_wrapper

Conflicts:
lucene/misc/src/test/org/apache/lucene/uninverting/TestFieldCache.java

lucene/misc/src/test/org/apache/lucene/uninverting/TestFieldCacheReopen.java

commit 8ec82a0d9a0dd946d96da20962bb2ea95758edbe
Author: Mike McCandless 
Date:   Thu Mar 10 13:56:25 2016 -0500

LUCENE-7086: move SlowCompositeReaderWrapper to misc module


> SlowCompositeReaderWrapper does not support point values
> 
>
> Key: LUCENE-7086
> URL: https://issues.apache.org/jira/browse/LUCENE-7086
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Adrien Grand
>Assignee: Michael McCandless
> Attachments: LUCENE-7086.patch, LUCENE-7086.patch
>
>
> SlowCompositeReaderWrapper.getPointValues always returns null. I think this 
> is trappy and we should either implement it or throw an 
> UnsupportedOperationException instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-7086) SlowCompositeReaderWrapper does not support point values

2016-03-10 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-7086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190075#comment-15190075
 ] 

ASF subversion and git services commented on LUCENE-7086:
-

Commit c34272da21023f1960d354539a0ec8232b7bfb6f in lucene-solr's branch 
refs/heads/branch_6_0 from Mike McCandless
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c34272d ]

LUCENE-7086: move SlowCompositeReaderWrapper to misc module, and throw clear 
exc if you try to use in with points

Squashed commits:

commit e26b065c71388407bc6725256ca43d7bb30dee29
Author: Mike McCandless 
Date:   Thu Mar 10 14:16:45 2016 -0500

simplify the checking for incoming points

commit b7254376dcb398c7739aab4544118bb4526961d5
Merge: 8ec82a0 d35d569
Author: Mike McCandless 
Date:   Thu Mar 10 14:05:24 2016 -0500

Merge branch 'master' into slow_wrapper

Conflicts:
lucene/misc/src/test/org/apache/lucene/uninverting/TestFieldCache.java

lucene/misc/src/test/org/apache/lucene/uninverting/TestFieldCacheReopen.java

commit 8ec82a0d9a0dd946d96da20962bb2ea95758edbe
Author: Mike McCandless 
Date:   Thu Mar 10 13:56:25 2016 -0500

LUCENE-7086: move SlowCompositeReaderWrapper to misc module


> SlowCompositeReaderWrapper does not support point values
> 
>
> Key: LUCENE-7086
> URL: https://issues.apache.org/jira/browse/LUCENE-7086
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Adrien Grand
>Assignee: Michael McCandless
> Attachments: LUCENE-7086.patch, LUCENE-7086.patch
>
>
> SlowCompositeReaderWrapper.getPointValues always returns null. I think this 
> is trappy and we should either implement it or throw an 
> UnsupportedOperationException instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-7086) SlowCompositeReaderWrapper does not support point values

2016-03-10 Thread Uwe Schindler (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-7086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190045#comment-15190045
 ] 

Uwe Schindler commented on LUCENE-7086:
---

Thanks Mike! I think that is fine now. I hope this also reduces SlowWrapper 
usage in Solr once PointValues are used there.

> SlowCompositeReaderWrapper does not support point values
> 
>
> Key: LUCENE-7086
> URL: https://issues.apache.org/jira/browse/LUCENE-7086
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Adrien Grand
>Assignee: Michael McCandless
> Attachments: LUCENE-7086.patch, LUCENE-7086.patch
>
>
> SlowCompositeReaderWrapper.getPointValues always returns null. I think this 
> is trappy and we should either implement it or throw an 
> UnsupportedOperationException instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-7086) SlowCompositeReaderWrapper does not support point values

2016-03-10 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-7086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190021#comment-15190021
 ] 

ASF subversion and git services commented on LUCENE-7086:
-

Commit 7927a3101e1f446939bfa311968346ddd57c29f3 in lucene-solr's branch 
refs/heads/branch_6x from Mike McCandless
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7927a31 ]

LUCENE-7086: move SlowCompositeReaderWrapper to misc module, and throw clear 
exc if you try to use in with points

Squashed commits:

commit e26b065c71388407bc6725256ca43d7bb30dee29
Author: Mike McCandless 
Date:   Thu Mar 10 14:16:45 2016 -0500

simplify the checking for incoming points

commit b7254376dcb398c7739aab4544118bb4526961d5
Merge: 8ec82a0 d35d569
Author: Mike McCandless 
Date:   Thu Mar 10 14:05:24 2016 -0500

Merge branch 'master' into slow_wrapper

Conflicts:
lucene/misc/src/test/org/apache/lucene/uninverting/TestFieldCache.java

lucene/misc/src/test/org/apache/lucene/uninverting/TestFieldCacheReopen.java

commit 8ec82a0d9a0dd946d96da20962bb2ea95758edbe
Author: Mike McCandless 
Date:   Thu Mar 10 13:56:25 2016 -0500

LUCENE-7086: move SlowCompositeReaderWrapper to misc module


> SlowCompositeReaderWrapper does not support point values
> 
>
> Key: LUCENE-7086
> URL: https://issues.apache.org/jira/browse/LUCENE-7086
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Adrien Grand
>Assignee: Michael McCandless
> Attachments: LUCENE-7086.patch, LUCENE-7086.patch
>
>
> SlowCompositeReaderWrapper.getPointValues always returns null. I think this 
> is trappy and we should either implement it or throw an 
> UnsupportedOperationException instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-7086) SlowCompositeReaderWrapper does not support point values

2016-03-10 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-7086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190020#comment-15190020
 ] 

ASF subversion and git services commented on LUCENE-7086:
-

Commit 7927a3101e1f446939bfa311968346ddd57c29f3 in lucene-solr's branch 
refs/heads/branch_6x from Mike McCandless
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7927a31 ]

LUCENE-7086: move SlowCompositeReaderWrapper to misc module, and throw clear 
exc if you try to use in with points

Squashed commits:

commit e26b065c71388407bc6725256ca43d7bb30dee29
Author: Mike McCandless 
Date:   Thu Mar 10 14:16:45 2016 -0500

simplify the checking for incoming points

commit b7254376dcb398c7739aab4544118bb4526961d5
Merge: 8ec82a0 d35d569
Author: Mike McCandless 
Date:   Thu Mar 10 14:05:24 2016 -0500

Merge branch 'master' into slow_wrapper

Conflicts:
lucene/misc/src/test/org/apache/lucene/uninverting/TestFieldCache.java

lucene/misc/src/test/org/apache/lucene/uninverting/TestFieldCacheReopen.java

commit 8ec82a0d9a0dd946d96da20962bb2ea95758edbe
Author: Mike McCandless 
Date:   Thu Mar 10 13:56:25 2016 -0500

LUCENE-7086: move SlowCompositeReaderWrapper to misc module


> SlowCompositeReaderWrapper does not support point values
> 
>
> Key: LUCENE-7086
> URL: https://issues.apache.org/jira/browse/LUCENE-7086
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Adrien Grand
>Assignee: Michael McCandless
> Attachments: LUCENE-7086.patch, LUCENE-7086.patch
>
>
> SlowCompositeReaderWrapper.getPointValues always returns null. I think this 
> is trappy and we should either implement it or throw an 
> UnsupportedOperationException instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-7086) SlowCompositeReaderWrapper does not support point values

2016-03-10 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-7086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189942#comment-15189942
 ] 

ASF subversion and git services commented on LUCENE-7086:
-

Commit 7523ca116276fbcf03bfa630c859c4a58f77add4 in lucene-solr's branch 
refs/heads/master from Mike McCandless
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7523ca1 ]

LUCENE-7086: move SlowCompositeReaderWrapper to misc module, and throw clear 
exc if you try to use in with points

Squashed commits:

commit e26b065c71388407bc6725256ca43d7bb30dee29
Author: Mike McCandless 
Date:   Thu Mar 10 14:16:45 2016 -0500

simplify the checking for incoming points

commit b7254376dcb398c7739aab4544118bb4526961d5
Merge: 8ec82a0 d35d569
Author: Mike McCandless 
Date:   Thu Mar 10 14:05:24 2016 -0500

Merge branch 'master' into slow_wrapper

Conflicts:
lucene/misc/src/test/org/apache/lucene/uninverting/TestFieldCache.java

lucene/misc/src/test/org/apache/lucene/uninverting/TestFieldCacheReopen.java

commit 8ec82a0d9a0dd946d96da20962bb2ea95758edbe
Author: Mike McCandless 
Date:   Thu Mar 10 13:56:25 2016 -0500

LUCENE-7086: move SlowCompositeReaderWrapper to misc module


> SlowCompositeReaderWrapper does not support point values
> 
>
> Key: LUCENE-7086
> URL: https://issues.apache.org/jira/browse/LUCENE-7086
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Adrien Grand
>Assignee: Michael McCandless
> Attachments: LUCENE-7086.patch, LUCENE-7086.patch
>
>
> SlowCompositeReaderWrapper.getPointValues always returns null. I think this 
> is trappy and we should either implement it or throw an 
> UnsupportedOperationException instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-7086) SlowCompositeReaderWrapper does not support point values

2016-03-10 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-7086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189941#comment-15189941
 ] 

ASF subversion and git services commented on LUCENE-7086:
-

Commit 7523ca116276fbcf03bfa630c859c4a58f77add4 in lucene-solr's branch 
refs/heads/master from Mike McCandless
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7523ca1 ]

LUCENE-7086: move SlowCompositeReaderWrapper to misc module, and throw clear 
exc if you try to use in with points

Squashed commits:

commit e26b065c71388407bc6725256ca43d7bb30dee29
Author: Mike McCandless 
Date:   Thu Mar 10 14:16:45 2016 -0500

simplify the checking for incoming points

commit b7254376dcb398c7739aab4544118bb4526961d5
Merge: 8ec82a0 d35d569
Author: Mike McCandless 
Date:   Thu Mar 10 14:05:24 2016 -0500

Merge branch 'master' into slow_wrapper

Conflicts:
lucene/misc/src/test/org/apache/lucene/uninverting/TestFieldCache.java

lucene/misc/src/test/org/apache/lucene/uninverting/TestFieldCacheReopen.java

commit 8ec82a0d9a0dd946d96da20962bb2ea95758edbe
Author: Mike McCandless 
Date:   Thu Mar 10 13:56:25 2016 -0500

LUCENE-7086: move SlowCompositeReaderWrapper to misc module


> SlowCompositeReaderWrapper does not support point values
> 
>
> Key: LUCENE-7086
> URL: https://issues.apache.org/jira/browse/LUCENE-7086
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Adrien Grand
>Assignee: Michael McCandless
> Attachments: LUCENE-7086.patch, LUCENE-7086.patch
>
>
> SlowCompositeReaderWrapper.getPointValues always returns null. I think this 
> is trappy and we should either implement it or throw an 
> UnsupportedOperationException instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-7086) SlowCompositeReaderWrapper does not support point values

2016-03-10 Thread Robert Muir (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-7086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189848#comment-15189848
 ] 

Robert Muir commented on LUCENE-7086:
-

+1, nice cleanup. now we can write tests for points without fear :)

> SlowCompositeReaderWrapper does not support point values
> 
>
> Key: LUCENE-7086
> URL: https://issues.apache.org/jira/browse/LUCENE-7086
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Adrien Grand
>Assignee: Michael McCandless
> Attachments: LUCENE-7086.patch, LUCENE-7086.patch
>
>
> SlowCompositeReaderWrapper.getPointValues always returns null. I think this 
> is trappy and we should either implement it or throw an 
> UnsupportedOperationException instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-7086) SlowCompositeReaderWrapper does not support point values

2016-03-10 Thread Michael McCandless (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-7086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189779#comment-15189779
 ] 

Michael McCandless commented on LUCENE-7086:


bq. Why not support PointValues from SCRW – a Multi implementation? I wonder if 
it might be trappy for SCRW to handle everything else yet not this.

Well, merging point values on the fly is somewhat tricky ... e.g. see
how SegmentMerge does it (NOT on the fly).  And since this is a
completely new feature, new code will have to be written to use it,
and that new code can work per segment ... there are many examples
(the point queries, the tests) showing how.  Finally, this solution
isn't trappy (after this fix): you get a clear exception saying it's
not supported, and you can always wrap your reader to hide its point
values if you want to slow wrap everything else.


> SlowCompositeReaderWrapper does not support point values
> 
>
> Key: LUCENE-7086
> URL: https://issues.apache.org/jira/browse/LUCENE-7086
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Adrien Grand
>Assignee: Michael McCandless
> Attachments: LUCENE-7086.patch, LUCENE-7086.patch
>
>
> SlowCompositeReaderWrapper.getPointValues always returns null. I think this 
> is trappy and we should either implement it or throw an 
> UnsupportedOperationException instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-7086) SlowCompositeReaderWrapper does not support point values

2016-03-10 Thread David Smiley (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-7086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189514#comment-15189514
 ] 

David Smiley commented on LUCENE-7086:
--

Why not support PointValues from SCRW -- a Multi implementation?  I wonder if 
it might be trappy for SCRW to handle everything else yet not this.

> SlowCompositeReaderWrapper does not support point values
> 
>
> Key: LUCENE-7086
> URL: https://issues.apache.org/jira/browse/LUCENE-7086
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Adrien Grand
>Assignee: Michael McCandless
> Attachments: LUCENE-7086.patch
>
>
> SlowCompositeReaderWrapper.getPointValues always returns null. I think this 
> is trappy and we should either implement it or throw an 
> UnsupportedOperationException instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-7086) SlowCompositeReaderWrapper does not support point values

2016-03-10 Thread Uwe Schindler (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-7086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189479#comment-15189479
 ] 

Uwe Schindler commented on LUCENE-7086:
---

bq. If the UOE is thrown at wrap time then the behavior is sane and can return 
null. So the nocommit/ugly changes in MergeState can be reverted.

Yeah, this is better! I think we just need to check if there are any point 
values in the sub readers and throw UOE (but with a message, please!).

> SlowCompositeReaderWrapper does not support point values
> 
>
> Key: LUCENE-7086
> URL: https://issues.apache.org/jira/browse/LUCENE-7086
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Adrien Grand
>Assignee: Michael McCandless
> Attachments: LUCENE-7086.patch
>
>
> SlowCompositeReaderWrapper.getPointValues always returns null. I think this 
> is trappy and we should either implement it or throw an 
> UnsupportedOperationException instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-7086) SlowCompositeReaderWrapper does not support point values

2016-03-10 Thread Robert Muir (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-7086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189462#comment-15189462
 ] 

Robert Muir commented on LUCENE-7086:
-

If the UOE is thrown at wrap time then the behavior is sane and can return 
null. So the nocommit/ugly changes in MergeState can be reverted.

> SlowCompositeReaderWrapper does not support point values
> 
>
> Key: LUCENE-7086
> URL: https://issues.apache.org/jira/browse/LUCENE-7086
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Adrien Grand
>Assignee: Michael McCandless
> Attachments: LUCENE-7086.patch
>
>
> SlowCompositeReaderWrapper.getPointValues always returns null. I think this 
> is trappy and we should either implement it or throw an 
> UnsupportedOperationException instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-7086) SlowCompositeReaderWrapper does not support point values

2016-03-09 Thread Michael McCandless (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-7086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15187659#comment-15187659
 ] 

Michael McCandless commented on LUCENE-7086:


Thanks [~jpountz], I'll fix it to throw UOE.

> SlowCompositeReaderWrapper does not support point values
> 
>
> Key: LUCENE-7086
> URL: https://issues.apache.org/jira/browse/LUCENE-7086
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Adrien Grand
>Assignee: Michael McCandless
>
> SlowCompositeReaderWrapper.getPointValues always returns null. I think this 
> is trappy and we should either implement it or throw an 
> UnsupportedOperationException instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-7086) SlowCompositeReaderWrapper does not support point values

2016-03-09 Thread David Smiley (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-7086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15187314#comment-15187314
 ] 

David Smiley commented on LUCENE-7086:
--

Sounds serious.

> SlowCompositeReaderWrapper does not support point values
> 
>
> Key: LUCENE-7086
> URL: https://issues.apache.org/jira/browse/LUCENE-7086
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Adrien Grand
>
> SlowCompositeReaderWrapper.getPointValues always returns null. I think this 
> is trappy and we should either implement it or throw an 
> UnsupportedOperationException instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org