[jira] [Commented] (LUCENE-7206) nest child query explain into ToParentBlockJoinQuery.BlockJoinScorer.explain(int)
[
https://issues.apache.org/jira/browse/LUCENE-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331820#comment-15331820
]
Mikhail Khludnev commented on LUCENE-7206:
--
Just a note, current approach might be too slow, it explains all children and
then pickups one of these explanation. For short blocks it's ok, but for longer
ones the two phase algorithm makes sense: find appropriate child (min/max or
so), and explain it only after that.
I prefer to keep it as a reminder, let's raise an issue if someone bother about
it too.
> nest child query explain into
> ToParentBlockJoinQuery.BlockJoinScorer.explain(int)
> -
>
> Key: LUCENE-7206
> URL: https://issues.apache.org/jira/browse/LUCENE-7206
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/query/scoring
>Affects Versions: 6.0
>Reporter: Mikhail Khludnev
> Labels: newbie, newdev
> Fix For: 6.1, master (7.0)
>
> Attachments: LUCENE-7206-one-child-with-tests.patch,
> LUCENE-7206-test.patch, LUCENE-7206.diff
>
>
> Now to parent query match is explained with {{Score based on child doc range
> from .. to .. }} that's quite useless.
> It's proposed to nest child query match explanation from the first matching
> child document into parent explain.
> WDYT?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7206) nest child query explain into ToParentBlockJoinQuery.BlockJoinScorer.explain(int)
[
https://issues.apache.org/jira/browse/LUCENE-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300026#comment-15300026
]
ASF subversion and git services commented on LUCENE-7206:
-
Commit d29ab1e81279c87c57b5c83a635275ad00b9c896 in lucene-solr's branch
refs/heads/master from [~martijn.v.groningen]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d29ab1e ]
LUCENE-7206: Improve the ToParentBlockJoinQuery's explain by including the
explain of the best matching child doc
> nest child query explain into
> ToParentBlockJoinQuery.BlockJoinScorer.explain(int)
> -
>
> Key: LUCENE-7206
> URL: https://issues.apache.org/jira/browse/LUCENE-7206
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/query/scoring
>Affects Versions: 6.0
>Reporter: Mikhail Khludnev
> Labels: newbie, newdev
> Attachments: LUCENE-7206-one-child-with-tests.patch,
> LUCENE-7206-test.patch, LUCENE-7206.diff
>
>
> Now to parent query match is explained with {{Score based on child doc range
> from .. to .. }} that's quite useless.
> It's proposed to nest child query match explanation from the first matching
> child document into parent explain.
> WDYT?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7206) nest child query explain into ToParentBlockJoinQuery.BlockJoinScorer.explain(int)
[
https://issues.apache.org/jira/browse/LUCENE-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300025#comment-15300025
]
ASF subversion and git services commented on LUCENE-7206:
-
Commit af98f35d21c0ab3e03bfe45a2ce980d7c574a8a0 in lucene-solr's branch
refs/heads/branch_6x from [~martijn.v.groningen]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=af98f35 ]
LUCENE-7206: Improve the ToParentBlockJoinQuery's explain by including the
explain of the best matching child doc
> nest child query explain into
> ToParentBlockJoinQuery.BlockJoinScorer.explain(int)
> -
>
> Key: LUCENE-7206
> URL: https://issues.apache.org/jira/browse/LUCENE-7206
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/query/scoring
>Affects Versions: 6.0
>Reporter: Mikhail Khludnev
> Labels: newbie, newdev
> Attachments: LUCENE-7206-one-child-with-tests.patch,
> LUCENE-7206-test.patch, LUCENE-7206.diff
>
>
> Now to parent query match is explained with {{Score based on child doc range
> from .. to .. }} that's quite useless.
> It's proposed to nest child query match explanation from the first matching
> child document into parent explain.
> WDYT?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7206) nest child query explain into ToParentBlockJoinQuery.BlockJoinScorer.explain(int)
[
https://issues.apache.org/jira/browse/LUCENE-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299976#comment-15299976
]
Martijn van Groningen commented on LUCENE-7206:
---
Ilya: Thanks! This looks good. I'll push this shortly.
> nest child query explain into
> ToParentBlockJoinQuery.BlockJoinScorer.explain(int)
> -
>
> Key: LUCENE-7206
> URL: https://issues.apache.org/jira/browse/LUCENE-7206
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/query/scoring
>Affects Versions: 6.0
>Reporter: Mikhail Khludnev
> Labels: newbie, newdev
> Attachments: LUCENE-7206-one-child-with-tests.patch,
> LUCENE-7206-test.patch, LUCENE-7206.diff
>
>
> Now to parent query match is explained with {{Score based on child doc range
> from .. to .. }} that's quite useless.
> It's proposed to nest child query match explanation from the first matching
> child document into parent explain.
> WDYT?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7206) nest child query explain into ToParentBlockJoinQuery.BlockJoinScorer.explain(int)
[
https://issues.apache.org/jira/browse/LUCENE-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291119#comment-15291119
]
Ilya Kasnacheev commented on LUCENE-7206:
-
NB: It should perhaps be
childWeight.explain(context, childDoc - context.docBase);
in the original patch in order for this to work over multiple segments.
> nest child query explain into
> ToParentBlockJoinQuery.BlockJoinScorer.explain(int)
> -
>
> Key: LUCENE-7206
> URL: https://issues.apache.org/jira/browse/LUCENE-7206
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/query/scoring
>Affects Versions: 6.0
>Reporter: Mikhail Khludnev
> Labels: newbie, newdev
> Attachments: LUCENE-7206-test.patch, LUCENE-7206.diff
>
>
> Now to parent query match is explained with {{Score based on child doc range
> from .. to .. }} that's quite useless.
> It's proposed to nest child query match explanation from the first matching
> child document into parent explain.
> WDYT?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7206) nest child query explain into ToParentBlockJoinQuery.BlockJoinScorer.explain(int)
[
https://issues.apache.org/jira/browse/LUCENE-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15247989#comment-15247989
]
Martijn van Groningen commented on LUCENE-7206:
---
bq. Now, it explains every matched child, perhaps it should be limited to one
with best score.
Yes, I think we should limit it to the best matching child document, otherwise
the explain (which without this change can already be large) may explode with
the amount of child document explanations.]
Would be great to also add a test, which checks the child doc explanations are
actually there.
> nest child query explain into
> ToParentBlockJoinQuery.BlockJoinScorer.explain(int)
> -
>
> Key: LUCENE-7206
> URL: https://issues.apache.org/jira/browse/LUCENE-7206
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/query/scoring
>Affects Versions: 6.0
>Reporter: Mikhail Khludnev
> Labels: newbie, newdev
> Attachments: LUCENE-7206.diff
>
>
> Now to parent query match is explained with {{Score based on child doc range
> from .. to .. }} that's quite useless.
> It's proposed to nest child query match explanation from the first matching
> child document into parent explain.
> WDYT?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7206) nest child query explain into ToParentBlockJoinQuery.BlockJoinScorer.explain(int)
[
https://issues.apache.org/jira/browse/LUCENE-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238963#comment-15238963
]
Martijn van Groningen commented on LUCENE-7206:
---
+1 I think including the first child explain makes sense. Perhaps instead of
'child docid x to y' matches, we can just include the number of child docs
matched (total_matches)?
> nest child query explain into
> ToParentBlockJoinQuery.BlockJoinScorer.explain(int)
> -
>
> Key: LUCENE-7206
> URL: https://issues.apache.org/jira/browse/LUCENE-7206
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/query/scoring
>Affects Versions: 6.0
>Reporter: Mikhail Khludnev
> Labels: newbie, newdev
>
> Now to parent query match is explained with {{Score based on child doc range
> from .. to .. }} that's quite useless.
> It's proposed to nest child query match explanation from the first matching
> child document into parent explain.
> WDYT?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
