[jira] [Commented] (LUCENE-7276) Add an optional reason to the MatchNoDocsQuery
[ https://issues.apache.org/jira/browse/LUCENE-7276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367998#comment-15367998 ] ASF subversion and git services commented on LUCENE-7276: - Commit df2207c5dcf379af25d12ef3b3cd7f44bad4fdff in lucene-solr's branch refs/heads/branch_6x from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=df2207c ] LUCENE-7276: MatchNoDocsQuery now inclues an optional reason for why it was used > Add an optional reason to the MatchNoDocsQuery > -- > > Key: LUCENE-7276 > URL: https://issues.apache.org/jira/browse/LUCENE-7276 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Reporter: Ferenczi Jim >Priority: Minor > Labels: patch > Attachments: LUCENE-7276.patch, LUCENE-7276.patch, LUCENE-7276.patch, > LUCENE-7276.patch, LUCENE-7276.patch, LUCENE-7276.patch > > > It's sometimes difficult to debug a query that results in a MatchNoDocsQuery. > The MatchNoDocsQuery is always rewritten in an empty boolean query. > This patch adds an optional reason and implements a weight in order to keep > track of the reason why the query did not match any document. The reason is > printed on toString and when an explanation for noMatch is asked. > For instance the query: > new MatchNoDocsQuery("Field not found").toString() > => 'MatchNoDocsQuery["field 'title' not found"]' -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7276) Add an optional reason to the MatchNoDocsQuery
[ https://issues.apache.org/jira/browse/LUCENE-7276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367995#comment-15367995 ] ASF subversion and git services commented on LUCENE-7276: - Commit cbbc505268e8fa994fa21383ed49a91b2e923f66 in lucene-solr's branch refs/heads/master from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cbbc505 ] LUCENE-7276: MatchNoDocsQuery now inclues an optional reason for why it was used > Add an optional reason to the MatchNoDocsQuery > -- > > Key: LUCENE-7276 > URL: https://issues.apache.org/jira/browse/LUCENE-7276 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Reporter: Ferenczi Jim >Priority: Minor > Labels: patch > Attachments: LUCENE-7276.patch, LUCENE-7276.patch, LUCENE-7276.patch, > LUCENE-7276.patch, LUCENE-7276.patch, LUCENE-7276.patch > > > It's sometimes difficult to debug a query that results in a MatchNoDocsQuery. > The MatchNoDocsQuery is always rewritten in an empty boolean query. > This patch adds an optional reason and implements a weight in order to keep > track of the reason why the query did not match any document. The reason is > printed on toString and when an explanation for noMatch is asked. > For instance the query: > new MatchNoDocsQuery("Field not found").toString() > => 'MatchNoDocsQuery["field 'title' not found"]' -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7276) Add an optional reason to the MatchNoDocsQuery
[ https://issues.apache.org/jira/browse/LUCENE-7276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15329556#comment-15329556 ] David Smiley commented on LUCENE-7276: -- bq. don't think we have ever, nor should we ever, make a guarantee that MatchNoDocsQuery.toString would somehow round-trip through a query parser back to itself, and so I think we are free to improve it here/now. Yeah, +1 > Add an optional reason to the MatchNoDocsQuery > -- > > Key: LUCENE-7276 > URL: https://issues.apache.org/jira/browse/LUCENE-7276 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Reporter: Ferenczi Jim >Priority: Minor > Labels: patch > Attachments: LUCENE-7276.patch, LUCENE-7276.patch, LUCENE-7276.patch, > LUCENE-7276.patch, LUCENE-7276.patch > > > It's sometimes difficult to debug a query that results in a MatchNoDocsQuery. > The MatchNoDocsQuery is always rewritten in an empty boolean query. > This patch adds an optional reason and implements a weight in order to keep > track of the reason why the query did not match any document. The reason is > printed on toString and when an explanation for noMatch is asked. > For instance the query: > new MatchNoDocsQuery("Field not found").toString() > => 'MatchNoDocsQuery["field 'title' not found"]' -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7276) Add an optional reason to the MatchNoDocsQuery
[ https://issues.apache.org/jira/browse/LUCENE-7276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15329065#comment-15329065 ] Adrien Grand commented on LUCENE-7276: -- bq. I don't think we have ever, nor should we ever, make a guarantee that MatchNoDocsQuery.toString would somehow round-trip through a query parser back to itself, and so I think we are free to improve it here/now. +1 > Add an optional reason to the MatchNoDocsQuery > -- > > Key: LUCENE-7276 > URL: https://issues.apache.org/jira/browse/LUCENE-7276 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Reporter: Ferenczi Jim >Priority: Minor > Labels: patch > Attachments: LUCENE-7276.patch, LUCENE-7276.patch, LUCENE-7276.patch, > LUCENE-7276.patch, LUCENE-7276.patch > > > It's sometimes difficult to debug a query that results in a MatchNoDocsQuery. > The MatchNoDocsQuery is always rewritten in an empty boolean query. > This patch adds an optional reason and implements a weight in order to keep > track of the reason why the query did not match any document. The reason is > printed on toString and when an explanation for noMatch is asked. > For instance the query: > new MatchNoDocsQuery("Field not found").toString() > => 'MatchNoDocsQuery["field 'title' not found"]' -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7276) Add an optional reason to the MatchNoDocsQuery
[ https://issues.apache.org/jira/browse/LUCENE-7276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15328351#comment-15328351 ] Michael McCandless commented on LUCENE-7276: I don't think we have ever, nor should we ever, make a guarantee that {{MatchNoDocsQuery.toString}} would somehow round-trip through a query parser back to itself, and so I think we are free to improve it here/now. A right not exercised is soon forgotten. > Add an optional reason to the MatchNoDocsQuery > -- > > Key: LUCENE-7276 > URL: https://issues.apache.org/jira/browse/LUCENE-7276 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Reporter: Ferenczi Jim >Priority: Minor > Labels: patch > Attachments: LUCENE-7276.patch, LUCENE-7276.patch, LUCENE-7276.patch, > LUCENE-7276.patch, LUCENE-7276.patch > > > It's sometimes difficult to debug a query that results in a MatchNoDocsQuery. > The MatchNoDocsQuery is always rewritten in an empty boolean query. > This patch adds an optional reason and implements a weight in order to keep > track of the reason why the query did not match any document. The reason is > printed on toString and when an explanation for noMatch is asked. > For instance the query: > new MatchNoDocsQuery("Field not found").toString() > => 'MatchNoDocsQuery["field 'title' not found"]' -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7276) Add an optional reason to the MatchNoDocsQuery
[ https://issues.apache.org/jira/browse/LUCENE-7276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15328347#comment-15328347 ] Michael McCandless commented on LUCENE-7276: Wow thank you for digging on this [~jim.ferenczi] ... I've been meaning to get back to this issue, and if we can fix that scoring issue (separately) that will make it much easier. > Add an optional reason to the MatchNoDocsQuery > -- > > Key: LUCENE-7276 > URL: https://issues.apache.org/jira/browse/LUCENE-7276 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Reporter: Ferenczi Jim >Priority: Minor > Labels: patch > Attachments: LUCENE-7276.patch, LUCENE-7276.patch, LUCENE-7276.patch, > LUCENE-7276.patch, LUCENE-7276.patch > > > It's sometimes difficult to debug a query that results in a MatchNoDocsQuery. > The MatchNoDocsQuery is always rewritten in an empty boolean query. > This patch adds an optional reason and implements a weight in order to keep > track of the reason why the query did not match any document. The reason is > printed on toString and when an explanation for noMatch is asked. > For instance the query: > new MatchNoDocsQuery("Field not found").toString() > => 'MatchNoDocsQuery["field 'title' not found"]' -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7276) Add an optional reason to the MatchNoDocsQuery
[ https://issues.apache.org/jira/browse/LUCENE-7276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15327946#comment-15327946 ] Ferenczi Jim commented on LUCENE-7276: -- ?? Somehow the test is angry that the rewritten query scores differently from the original ... so somehow the fact that we no longer rewrite to an empty BQ is changing something ... I'll dig. ?? I tried to find a reason and I think I found something interesting. The change is related to the normalization factor and the fact that those queries are boosted. When you use a boolean query with no clause the normalization factor is 0, when the matchnodocs query is used the normalization factor is 1 (BooleanWeight.getValueForNormalization and ConstantScoreWeight.getValueForNormalization). This part of the query is supposed to return no documents so it should be ok to ignore it when the query norm is computed. Though for the distributed case where results are merged from different shards there is no guarantee that the rewrite will be the same among the shards. I think we can get rid of the matchnodocsquery vs empty boolean query difference if we change the return value of BooleanWeight.getValueForNormalization to be 1 (instead of 0) when there is no clause. https://issues.apache.org/jira/browse/LUCENE-7337 > Add an optional reason to the MatchNoDocsQuery > -- > > Key: LUCENE-7276 > URL: https://issues.apache.org/jira/browse/LUCENE-7276 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Reporter: Ferenczi Jim >Priority: Minor > Labels: patch > Attachments: LUCENE-7276.patch, LUCENE-7276.patch, LUCENE-7276.patch, > LUCENE-7276.patch, LUCENE-7276.patch > > > It's sometimes difficult to debug a query that results in a MatchNoDocsQuery. > The MatchNoDocsQuery is always rewritten in an empty boolean query. > This patch adds an optional reason and implements a weight in order to keep > track of the reason why the query did not match any document. The reason is > printed on toString and when an explanation for noMatch is asked. > For instance the query: > new MatchNoDocsQuery("Field not found").toString() > => 'MatchNoDocsQuery["field 'title' not found"]' -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7276) Add an optional reason to the MatchNoDocsQuery
[ https://issues.apache.org/jira/browse/LUCENE-7276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318751#comment-15318751 ] Adrien Grand commented on LUCENE-7276: -- bq. Is anyone besides me worried about this? Do we have other queries that return a "human but not query-parser consumable" string? Even though this is something you should not rely on, I suspect many users do... I think David is right that changing the toString representation should probably be master-only. However, we should still be able to put the reason in the explanation in 6.x? > Add an optional reason to the MatchNoDocsQuery > -- > > Key: LUCENE-7276 > URL: https://issues.apache.org/jira/browse/LUCENE-7276 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Reporter: Ferenczi Jim >Priority: Minor > Labels: patch > Attachments: LUCENE-7276.patch, LUCENE-7276.patch, LUCENE-7276.patch, > LUCENE-7276.patch, LUCENE-7276.patch > > > It's sometimes difficult to debug a query that results in a MatchNoDocsQuery. > The MatchNoDocsQuery is always rewritten in an empty boolean query. > This patch adds an optional reason and implements a weight in order to keep > track of the reason why the query did not match any document. The reason is > printed on toString and when an explanation for noMatch is asked. > For instance the query: > new MatchNoDocsQuery("Field not found").toString() > => 'MatchNoDocsQuery["field 'title' not found"]' -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7276) Add an optional reason to the MatchNoDocsQuery
[ https://issues.apache.org/jira/browse/LUCENE-7276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318531#comment-15318531 ] David Smiley commented on LUCENE-7276: -- I can understand if you feel you want to break up the issue for whatever reason, and to be cautious about backwards-compatibility (thus delaying parts of this issue to 7.0?) I don't think we should have guarantees that a Query.toString() will be parseable by Lucene's classic QueryParser. That is not the case today for many queries, but for the common core queries, it's probably true. And good point that if some app out there depends on this behavior, we might not want to introduce the change in 6.x of BooleanQuery optimizing to MatchNoDocsQuery. > Add an optional reason to the MatchNoDocsQuery > -- > > Key: LUCENE-7276 > URL: https://issues.apache.org/jira/browse/LUCENE-7276 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Reporter: Ferenczi Jim >Priority: Minor > Labels: patch > Attachments: LUCENE-7276.patch, LUCENE-7276.patch, LUCENE-7276.patch, > LUCENE-7276.patch, LUCENE-7276.patch > > > It's sometimes difficult to debug a query that results in a MatchNoDocsQuery. > The MatchNoDocsQuery is always rewritten in an empty boolean query. > This patch adds an optional reason and implements a weight in order to keep > track of the reason why the query did not match any document. The reason is > printed on toString and when an explanation for noMatch is asked. > For instance the query: > new MatchNoDocsQuery("Field not found").toString() > => 'MatchNoDocsQuery["field 'title' not found"]' -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7276) Add an optional reason to the MatchNoDocsQuery
[ https://issues.apache.org/jira/browse/LUCENE-7276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318332#comment-15318332 ] Michael McCandless commented on LUCENE-7276: I'm going to break this up into separate steps ... the current patch combines too many things: changing {{MatchNoDocsQuery.toString}}, adding a reason to it, changing it to return its own {{Weight}} instead of rewriting to BQ, changing BQ to rewrite to it when there are no clauses. I'll start by fixing {{MatchNoDocsQuery.toString()}} to simply return "MatchNoDocsQuery". But even that small change is not easy: it is something of a break in our normal policy for a {{Query.toString}} in that today queries try to have a {{.toString}} which when sent back through a query parser would parse back to an equivalent query instance. E.g., a {{PhraseQuery}} instance's {{toString}} would be {{"foo bar"}}, which most query parsers would parse back into an equivalent query. The Python world handles this situation nicely, by having two separate functions: {{repr}} makes a string which when eval'd (parsed and executed by Python) turns back into the same object, whereas {{str}} makes a pretty thing that humans can understand. But Lucene has no such separation ... and our {{Query.toString}} is more like {{repr}} now. Is anyone besides me worried about this? Do we have other queries that return a "human but not query-parser consumable" string? > Add an optional reason to the MatchNoDocsQuery > -- > > Key: LUCENE-7276 > URL: https://issues.apache.org/jira/browse/LUCENE-7276 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Reporter: Ferenczi Jim >Priority: Minor > Labels: patch > Attachments: LUCENE-7276.patch, LUCENE-7276.patch, LUCENE-7276.patch, > LUCENE-7276.patch > > > It's sometimes difficult to debug a query that results in a MatchNoDocsQuery. > The MatchNoDocsQuery is always rewritten in an empty boolean query. > This patch adds an optional reason and implements a weight in order to keep > track of the reason why the query did not match any document. The reason is > printed on toString and when an explanation for noMatch is asked. > For instance the query: > new MatchNoDocsQuery("Field not found").toString() > => 'MatchNoDocsQuery["field 'title' not found"]' -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7276) Add an optional reason to the MatchNoDocsQuery
[ https://issues.apache.org/jira/browse/LUCENE-7276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316547#comment-15316547 ] Michael McCandless commented on LUCENE-7276: It definitely is odd, and I don't like it, but I don't know how else to make the test happy on this weird corner case. I will put a comment attempting to explain the situation. > Add an optional reason to the MatchNoDocsQuery > -- > > Key: LUCENE-7276 > URL: https://issues.apache.org/jira/browse/LUCENE-7276 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Reporter: Ferenczi Jim >Priority: Minor > Labels: patch > Attachments: LUCENE-7276.patch, LUCENE-7276.patch, LUCENE-7276.patch, > LUCENE-7276.patch > > > It's sometimes difficult to debug a query that results in a MatchNoDocsQuery. > The MatchNoDocsQuery is always rewritten in an empty boolean query. > This patch adds an optional reason and implements a weight in order to keep > track of the reason why the query did not match any document. The reason is > printed on toString and when an explanation for noMatch is asked. > For instance the query: > new MatchNoDocsQuery("Field not found").toString() > => 'MatchNoDocsQuery["field 'title' not found"]' -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7276) Add an optional reason to the MatchNoDocsQuery
[ https://issues.apache.org/jira/browse/LUCENE-7276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316164#comment-15316164 ] David Smiley commented on LUCENE-7276: -- bq. Somehow the test is angry that the rewritten query scores differently from the original ... so somehow the fact that we no longer rewrite to an empty BQ is changing something bq. New patch, fixing the test failure by wrapping in a BoostQuery with boost 0.0 in BQ when it rewrites! Hmm; this feels odd. If it needs to stay then it would be helpful to add some comments where this occurs to explain; I don't really get it. Do you think it might make sense to remove the wrapping BoostQuery for 7.0? Thanks. And nice addition Jim! > Add an optional reason to the MatchNoDocsQuery > -- > > Key: LUCENE-7276 > URL: https://issues.apache.org/jira/browse/LUCENE-7276 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Reporter: Ferenczi Jim >Priority: Minor > Labels: patch > Attachments: LUCENE-7276.patch, LUCENE-7276.patch, LUCENE-7276.patch, > LUCENE-7276.patch > > > It's sometimes difficult to debug a query that results in a MatchNoDocsQuery. > The MatchNoDocsQuery is always rewritten in an empty boolean query. > This patch adds an optional reason and implements a weight in order to keep > track of the reason why the query did not match any document. The reason is > printed on toString and when an explanation for noMatch is asked. > For instance the query: > new MatchNoDocsQuery("Field not found").toString() > => 'MatchNoDocsQuery["field 'title' not found"]' -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7276) Add an optional reason to the MatchNoDocsQuery
[ https://issues.apache.org/jira/browse/LUCENE-7276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15314145#comment-15314145 ] Michael McCandless commented on LUCENE-7276: Thanks [~jim.ferenczi], this looks great, I'll commit this soon. > Add an optional reason to the MatchNoDocsQuery > -- > > Key: LUCENE-7276 > URL: https://issues.apache.org/jira/browse/LUCENE-7276 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Reporter: Ferenczi Jim >Priority: Minor > Labels: patch > Attachments: LUCENE-7276.patch > > > It's sometimes difficult to debug a query that results in a MatchNoDocsQuery. > The MatchNoDocsQuery is always rewritten in an empty boolean query. > This patch adds an optional reason and implements a weight in order to keep > track of the reason why the query did not match any document. The reason is > printed on toString and when an explanation for noMatch is asked. > For instance the query: > new MatchNoDocsQuery("Field not found").toString() > => 'MatchNoDocsQuery["field 'title' not found"]' -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7276) Add an optional reason to the MatchNoDocsQuery
[ https://issues.apache.org/jira/browse/LUCENE-7276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15312093#comment-15312093 ] Christoph Buescher commented on LUCENE-7276: +1 > Add an optional reason to the MatchNoDocsQuery > -- > > Key: LUCENE-7276 > URL: https://issues.apache.org/jira/browse/LUCENE-7276 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Reporter: Ferenczi Jim >Priority: Minor > Labels: patch > Attachments: LUCENE-7276.patch > > > It's sometimes difficult to debug a query that results in a MatchNoDocsQuery. > The MatchNoDocsQuery is always rewritten in an empty boolean query. > This patch adds an optional reason and implements a weight in order to keep > track of the reason why the query did not match any document. The reason is > printed on toString and when an explanation for noMatch is asked. > For instance the query: > new MatchNoDocsQuery("Field not found").toString() > => 'MatchNoDocsQuery["field 'title' not found"]' -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7276) Add an optional reason to the MatchNoDocsQuery
[ https://issues.apache.org/jira/browse/LUCENE-7276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15312081#comment-15312081 ] Martijn van Groningen commented on LUCENE-7276: --- +1 > Add an optional reason to the MatchNoDocsQuery > -- > > Key: LUCENE-7276 > URL: https://issues.apache.org/jira/browse/LUCENE-7276 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Reporter: Ferenczi Jim >Priority: Minor > Labels: patch > Attachments: LUCENE-7276.patch > > > It's sometimes difficult to debug a query that results in a MatchNoDocsQuery. > The MatchNoDocsQuery is always rewritten in an empty boolean query. > This patch adds an optional reason and implements a weight in order to keep > track of the reason why the query did not match any document. The reason is > printed on toString and when an explanation for noMatch is asked. > For instance the query: > new MatchNoDocsQuery("Field not found").toString() > => 'MatchNoDocsQuery["field 'title' not found"]' -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org