[jira] [Commented] (LUCENE-7325) GeoPointInBBoxQuery no longer includes boundaries?
[
https://issues.apache.org/jira/browse/LUCENE-7325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15325166#comment-15325166
]
Michael McCandless commented on LUCENE-7325:
Thanks [~nknize].
> GeoPointInBBoxQuery no longer includes boundaries?
> --
>
> Key: LUCENE-7325
> URL: https://issues.apache.org/jira/browse/LUCENE-7325
> Project: Lucene - Core
> Issue Type: Bug
>Affects Versions: 6.1
>Reporter: Michael McCandless
>Priority: Blocker
> Attachments: LUCENE-7325.patch, LUCENE-7325.patch
>
>
> {{GeoPointInBBoxQuery}} is supposed to include boundaries, and it does in 5.x
> and 6.0, but in 6.1 something broke.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7325) GeoPointInBBoxQuery no longer includes boundaries?
[
https://issues.apache.org/jira/browse/LUCENE-7325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324886#comment-15324886
]
Nicholas Knize commented on LUCENE-7325:
I moved the bug fix to LUCENE-7331 since its not technically related to this
issue. I think we can go ahead and close this as a non-issue?
> GeoPointInBBoxQuery no longer includes boundaries?
> --
>
> Key: LUCENE-7325
> URL: https://issues.apache.org/jira/browse/LUCENE-7325
> Project: Lucene - Core
> Issue Type: Bug
>Affects Versions: 6.1
>Reporter: Michael McCandless
>Priority: Blocker
> Attachments: LUCENE-7325.patch, LUCENE-7325.patch
>
>
> {{GeoPointInBBoxQuery}} is supposed to include boundaries, and it does in 5.x
> and 6.0, but in 6.1 something broke.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7325) GeoPointInBBoxQuery no longer includes boundaries?
[
https://issues.apache.org/jira/browse/LUCENE-7325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324700#comment-15324700
]
Nicholas Knize commented on LUCENE-7325:
{noformat}
[junit4] 2> NOTE: reproduce with: ant test -Dtestcase=TestGeoPointQuery
-Dtests.method=testRandomMedium -Dtests.seed=3254B65F0C8C1F93 -Dtests.slow=true
-Dtests.locale=th-TH -Dtests.timezone=Etc/GMT -Dtests.asserts=true
-Dtests.file.encoding=ISO-8859-1
[junit4] ERROR 0.35s J0 | TestGeoPointQuery.testRandomMedium <<<
[junit4]> Throwable #1: java.lang.IllegalArgumentException: Illegal
shift value, must be 32..63; got shift=0
{noformat}
> GeoPointInBBoxQuery no longer includes boundaries?
> --
>
> Key: LUCENE-7325
> URL: https://issues.apache.org/jira/browse/LUCENE-7325
> Project: Lucene - Core
> Issue Type: Bug
>Affects Versions: 6.1
>Reporter: Michael McCandless
>Priority: Blocker
> Attachments: LUCENE-7325.patch, LUCENE-7325.patch
>
>
> {{GeoPointInBBoxQuery}} is supposed to include boundaries, and it does in 5.x
> and 6.0, but in 6.1 something broke.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7325) GeoPointInBBoxQuery no longer includes boundaries?
[
https://issues.apache.org/jira/browse/LUCENE-7325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324658#comment-15324658
]
Michael McCandless commented on LUCENE-7325:
bq. It was uncovered after Robert suggested removing GeoPointTestUtil. After
that bug is fixed all tests pass w/ GeoTestUtil.
OK, thanks for the explanation. When that bug strikes what exception do you
see?
> GeoPointInBBoxQuery no longer includes boundaries?
> --
>
> Key: LUCENE-7325
> URL: https://issues.apache.org/jira/browse/LUCENE-7325
> Project: Lucene - Core
> Issue Type: Bug
>Affects Versions: 6.1
>Reporter: Michael McCandless
>Priority: Blocker
> Attachments: LUCENE-7325.patch, LUCENE-7325.patch
>
>
> {{GeoPointInBBoxQuery}} is supposed to include boundaries, and it does in 5.x
> and 6.0, but in 6.1 something broke.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7325) GeoPointInBBoxQuery no longer includes boundaries?
[
https://issues.apache.org/jira/browse/LUCENE-7325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324654#comment-15324654
]
Nicholas Knize commented on LUCENE-7325:
Thanks [~mikemccand]!
bq. Can you add an explicit test case showing that bug?
sure thing. It was uncovered after Robert suggested removing
{{GeoPointTestUtil}}. After that bug is fixed all tests pass w/ {{GeoTestUtil}}.
bq. I see no comment there?
Sorry, the first issue comment in LUCENE-7166.
> GeoPointInBBoxQuery no longer includes boundaries?
> --
>
> Key: LUCENE-7325
> URL: https://issues.apache.org/jira/browse/LUCENE-7325
> Project: Lucene - Core
> Issue Type: Bug
>Affects Versions: 6.1
>Reporter: Michael McCandless
>Priority: Blocker
> Attachments: LUCENE-7325.patch, LUCENE-7325.patch
>
>
> {{GeoPointInBBoxQuery}} is supposed to include boundaries, and it does in 5.x
> and 6.0, but in 6.1 something broke.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7325) GeoPointInBBoxQuery no longer includes boundaries?
[
https://issues.apache.org/jira/browse/LUCENE-7325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324584#comment-15324584
]
Michael McCandless commented on LUCENE-7325:
bq. The attached patch fixes a bug in GeoPointPrefixTermsEnum and removes
GeoPointTestUtil from TestGeoPointQuery.
I'm a little confused: the patch fixes a different bug, that was uncovered by
improving testing here by removing {{GeoPointTestUtil}}? Can you add an
explicit test case showing that bug?
bq. Specifically, This change which Robert's comment explains quite nicely.
I see no comment there? Maybe the link isn't working for me ... the link seems
to take me to a local diff where we no longer quantize the values at query time.
bq. The fix (mentioned in the comment) is to move to the stable 64 bit encoding
in LUCENE-7186. But GeoPointField will need bwc with the 62 bit encoding
But, today, {{GeoPointField}} is still using 62 bit encoding right? (And, yes,
switching to 64 bit will need back compat!).
+1 for the test improvement (removing {{GeoPointTestUtil}}), but it's maybe
good news it doesn't provoke new failures ;)
And it looks like my test is invalid! So just remove it! And I agree this
should not be a blocker anymore.
> GeoPointInBBoxQuery no longer includes boundaries?
> --
>
> Key: LUCENE-7325
> URL: https://issues.apache.org/jira/browse/LUCENE-7325
> Project: Lucene - Core
> Issue Type: Bug
>Affects Versions: 6.1
>Reporter: Michael McCandless
>Priority: Blocker
> Attachments: LUCENE-7325.patch, LUCENE-7325.patch
>
>
> {{GeoPointInBBoxQuery}} is supposed to include boundaries, and it does in 5.x
> and 6.0, but in 6.1 something broke.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7325) GeoPointInBBoxQuery no longer includes boundaries?
[
https://issues.apache.org/jira/browse/LUCENE-7325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324435#comment-15324435
]
Nicholas Knize commented on LUCENE-7325:
Yes [~jpountz]! Your understanding is correct. And the test suite pre-quantizes
the test data, which is why Mike's simple boundary test fails and the test
suite doesn't. I ran Mike's test w/ LatLonPoint and it fails with the same
quantization error. So this is behaving as expected. +1 for not blocking 6.1.
If there are no objections I will go ahead and commit the simple
{{GeoPointPrefixTermsEnum}} bug fix in the attached patch, and remove the
{{GeoPointTestUtil}} from the GeoPointPrefix tests. We should then be OK to
close this issue since we already have one for 64 bit quantization in
{{GeoPointField}}.
> GeoPointInBBoxQuery no longer includes boundaries?
> --
>
> Key: LUCENE-7325
> URL: https://issues.apache.org/jira/browse/LUCENE-7325
> Project: Lucene - Core
> Issue Type: Bug
>Affects Versions: 6.1
>Reporter: Michael McCandless
>Priority: Blocker
> Attachments: LUCENE-7325.patch, LUCENE-7325.patch
>
>
> {{GeoPointInBBoxQuery}} is supposed to include boundaries, and it does in 5.x
> and 6.0, but in 6.1 something broke.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7325) GeoPointInBBoxQuery no longer includes boundaries?
[
https://issues.apache.org/jira/browse/LUCENE-7325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324039#comment-15324039
]
Adrien Grand commented on LUCENE-7325:
--
Is my understanding correct that there will be accuracy issues due to
quantization anyways, and the bug was just hidden before because we also
quantized the search-time values? But it had accuracy issues as well since it
was more likely to consider some lat/lon points as matching even though they
were outside of the bbox, if quantization rounded to the same values.
If yes, then I am not sure this should be a blocker. This is probably even
making things easier to reason about since the rounding is happening only once
(at index time).
> GeoPointInBBoxQuery no longer includes boundaries?
> --
>
> Key: LUCENE-7325
> URL: https://issues.apache.org/jira/browse/LUCENE-7325
> Project: Lucene - Core
> Issue Type: Bug
>Affects Versions: 6.1
>Reporter: Michael McCandless
>Priority: Blocker
> Attachments: LUCENE-7325.patch, LUCENE-7325.patch
>
>
> {{GeoPointInBBoxQuery}} is supposed to include boundaries, and it does in 5.x
> and 6.0, but in 6.1 something broke.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7325) GeoPointInBBoxQuery no longer includes boundaries?
[
https://issues.apache.org/jira/browse/LUCENE-7325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322668#comment-15322668
]
Michael McCandless commented on LUCENE-7325:
bq. If this is removed you will see them.
+1 to remove {{GeoPointTestUtil}} ... we need stronger testing here, to prevent
regressions like this.
> GeoPointInBBoxQuery no longer includes boundaries?
> --
>
> Key: LUCENE-7325
> URL: https://issues.apache.org/jira/browse/LUCENE-7325
> Project: Lucene - Core
> Issue Type: Bug
>Affects Versions: 6.1
>Reporter: Michael McCandless
>Priority: Blocker
> Attachments: LUCENE-7325.patch
>
>
> {{GeoPointInBBoxQuery}} is supposed to include boundaries, and it does in 5.x
> and 6.0, but in 6.1 something broke.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7325) GeoPointInBBoxQuery no longer includes boundaries?
[
https://issues.apache.org/jira/browse/LUCENE-7325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322667#comment-15322667
]
Michael McCandless commented on LUCENE-7325:
I think we should fix this for 6.1.0.
> GeoPointInBBoxQuery no longer includes boundaries?
> --
>
> Key: LUCENE-7325
> URL: https://issues.apache.org/jira/browse/LUCENE-7325
> Project: Lucene - Core
> Issue Type: Bug
>Affects Versions: 6.1
>Reporter: Michael McCandless
>Priority: Blocker
> Attachments: LUCENE-7325.patch
>
>
> {{GeoPointInBBoxQuery}} is supposed to include boundaries, and it does in 5.x
> and 6.0, but in 6.1 something broke.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7325) GeoPointInBBoxQuery no longer includes boundaries?
[
https://issues.apache.org/jira/browse/LUCENE-7325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322663#comment-15322663
]
Robert Muir commented on LUCENE-7325:
-
Note we already have a test and it will fail if you enable the new RNG for
geopoint (LUCENE-7185).
Other tests fail too, thats still not fixed. GeoPoint hacks around this with a
"GeoPointTestUtil" at the moment. If this is removed you will see them.
> GeoPointInBBoxQuery no longer includes boundaries?
> --
>
> Key: LUCENE-7325
> URL: https://issues.apache.org/jira/browse/LUCENE-7325
> Project: Lucene - Core
> Issue Type: Bug
>Affects Versions: 6.1
>Reporter: Michael McCandless
> Attachments: LUCENE-7325.patch
>
>
> {{GeoPointInBBoxQuery}} is supposed to include boundaries, and it does in 5.x
> and 6.0, but in 6.1 something broke.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
