[jira] [Commented] (LUCENE-7501) Do not encode the split dimension in the index in the 1D case
[ https://issues.apache.org/jira/browse/LUCENE-7501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15630966#comment-15630966 ] ASF subversion and git services commented on LUCENE-7501: - Commit 69e654b3737a97fea7ffc9f57c8fad5e85f72452 in lucene-solr's branch refs/heads/apiv2 from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=69e654b ] LUCENE-7501: fix back-compat bug; add test > Do not encode the split dimension in the index in the 1D case > - > > Key: LUCENE-7501 > URL: https://issues.apache.org/jira/browse/LUCENE-7501 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Blocker > Fix For: master (7.0), 6.3 > > Attachments: LUCENE-7501.patch, LUCENE-7501.patch, LUCENE-7501.patch > > > When there is a single dimension, the split dimension is always 0, so we do > not need to encode it in the index of the BKD tree. This would be 33% memory > saving for half floats, 20% for ints/floats, 11% for longs/doubles and 6% for > ip addresses. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7501) Do not encode the split dimension in the index in the 1D case
[ https://issues.apache.org/jira/browse/LUCENE-7501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628474#comment-15628474 ] Michael McCandless commented on LUCENE-7501: Hmm I'm not sure why the commit bot doesn't show my push to branch_6_3, but I did push the fix there too! > Do not encode the split dimension in the index in the 1D case > - > > Key: LUCENE-7501 > URL: https://issues.apache.org/jira/browse/LUCENE-7501 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Blocker > Fix For: master (7.0), 6.3 > > Attachments: LUCENE-7501.patch, LUCENE-7501.patch, LUCENE-7501.patch > > > When there is a single dimension, the split dimension is always 0, so we do > not need to encode it in the index of the BKD tree. This would be 33% memory > saving for half floats, 20% for ints/floats, 11% for longs/doubles and 6% for > ip addresses. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7501) Do not encode the split dimension in the index in the 1D case
[ https://issues.apache.org/jira/browse/LUCENE-7501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628461#comment-15628461 ] ASF subversion and git services commented on LUCENE-7501: - Commit 69e654b3737a97fea7ffc9f57c8fad5e85f72452 in lucene-solr's branch refs/heads/master from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=69e654b ] LUCENE-7501: fix back-compat bug; add test > Do not encode the split dimension in the index in the 1D case > - > > Key: LUCENE-7501 > URL: https://issues.apache.org/jira/browse/LUCENE-7501 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Blocker > Fix For: master (7.0), 6.3 > > Attachments: LUCENE-7501.patch, LUCENE-7501.patch, LUCENE-7501.patch > > > When there is a single dimension, the split dimension is always 0, so we do > not need to encode it in the index of the BKD tree. This would be 33% memory > saving for half floats, 20% for ints/floats, 11% for longs/doubles and 6% for > ip addresses. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7501) Do not encode the split dimension in the index in the 1D case
[ https://issues.apache.org/jira/browse/LUCENE-7501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628372#comment-15628372 ] ASF subversion and git services commented on LUCENE-7501: - Commit 35f3cd9bd95607983fa4704c66f61bf59cd40860 in lucene-solr's branch refs/heads/branch_6x from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=35f3cd9 ] LUCENE-7501: fix back-compat bug; add test > Do not encode the split dimension in the index in the 1D case > - > > Key: LUCENE-7501 > URL: https://issues.apache.org/jira/browse/LUCENE-7501 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Blocker > Fix For: master (7.0), 6.3 > > Attachments: LUCENE-7501.patch, LUCENE-7501.patch, LUCENE-7501.patch > > > When there is a single dimension, the split dimension is always 0, so we do > not need to encode it in the index of the BKD tree. This would be 33% memory > saving for half floats, 20% for ints/floats, 11% for longs/doubles and 6% for > ip addresses. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7501) Do not encode the split dimension in the index in the 1D case
[ https://issues.apache.org/jira/browse/LUCENE-7501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628344#comment-15628344 ] Adrien Grand commented on LUCENE-7501: -- +1 > Do not encode the split dimension in the index in the 1D case > - > > Key: LUCENE-7501 > URL: https://issues.apache.org/jira/browse/LUCENE-7501 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Blocker > Fix For: master (7.0), 6.3 > > Attachments: LUCENE-7501.patch, LUCENE-7501.patch, LUCENE-7501.patch > > > When there is a single dimension, the split dimension is always 0, so we do > not need to encode it in the index of the BKD tree. This would be 33% memory > saving for half floats, 20% for ints/floats, 11% for longs/doubles and 6% for > ip addresses. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7501) Do not encode the split dimension in the index in the 1D case
[ https://issues.apache.org/jira/browse/LUCENE-7501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628008#comment-15628008 ] Adrien Grand commented on LUCENE-7501: -- The patch looks good, thanks for looking into it. To be safe, maybe we should undo the change on the 6.3 branch and apply your patch to master/6.x? > Do not encode the split dimension in the index in the 1D case > - > > Key: LUCENE-7501 > URL: https://issues.apache.org/jira/browse/LUCENE-7501 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Blocker > Fix For: master (7.0), 6.3 > > Attachments: LUCENE-7501.patch, LUCENE-7501.patch > > > When there is a single dimension, the split dimension is always 0, so we do > not need to encode it in the index of the BKD tree. This would be 33% memory > saving for half floats, 20% for ints/floats, 11% for longs/doubles and 6% for > ip addresses. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7501) Do not encode the split dimension in the index in the 1D case
[ https://issues.apache.org/jira/browse/LUCENE-7501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15627021#comment-15627021 ] Michael McCandless commented on LUCENE-7501: I think we have to fix this for 6.3.0. > Do not encode the split dimension in the index in the 1D case > - > > Key: LUCENE-7501 > URL: https://issues.apache.org/jira/browse/LUCENE-7501 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Blocker > Fix For: master (7.0), 6.3 > > Attachments: LUCENE-7501.patch > > > When there is a single dimension, the split dimension is always 0, so we do > not need to encode it in the index of the BKD tree. This would be 33% memory > saving for half floats, 20% for ints/floats, 11% for longs/doubles and 6% for > ip addresses. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7501) Do not encode the split dimension in the index in the 1D case
[ https://issues.apache.org/jira/browse/LUCENE-7501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15585452#comment-15585452 ] ASF subversion and git services commented on LUCENE-7501: - Commit e8360714fae8bac3c705297641a735ed33cf47f9 in lucene-solr's branch refs/heads/master from [~jpountz] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e836071 ] LUCENE-7501: BKDReader should not store the split dimension explicitly in the 1D case. > Do not encode the split dimension in the index in the 1D case > - > > Key: LUCENE-7501 > URL: https://issues.apache.org/jira/browse/LUCENE-7501 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Minor > Attachments: LUCENE-7501.patch > > > When there is a single dimension, the split dimension is always 0, so we do > not need to encode it in the index of the BKD tree. This would be 33% memory > saving for half floats, 20% for ints/floats, 11% for longs/doubles and 6% for > ip addresses. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7501) Do not encode the split dimension in the index in the 1D case
[ https://issues.apache.org/jira/browse/LUCENE-7501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15585437#comment-15585437 ] ASF subversion and git services commented on LUCENE-7501: - Commit e6d225603aad24a7420f395ecd3dffc17fddf62c in lucene-solr's branch refs/heads/branch_6x from [~jpountz] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e6d2256 ] LUCENE-7501: BKDReader should not store the split dimension explicitly in the 1D case. > Do not encode the split dimension in the index in the 1D case > - > > Key: LUCENE-7501 > URL: https://issues.apache.org/jira/browse/LUCENE-7501 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Minor > Attachments: LUCENE-7501.patch > > > When there is a single dimension, the split dimension is always 0, so we do > not need to encode it in the index of the BKD tree. This would be 33% memory > saving for half floats, 20% for ints/floats, 11% for longs/doubles and 6% for > ip addresses. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7501) Do not encode the split dimension in the index in the 1D case
[ https://issues.apache.org/jira/browse/LUCENE-7501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15584952#comment-15584952 ] Michael McCandless commented on LUCENE-7501: +1, most excellent! > Do not encode the split dimension in the index in the 1D case > - > > Key: LUCENE-7501 > URL: https://issues.apache.org/jira/browse/LUCENE-7501 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Minor > Attachments: LUCENE-7501.patch > > > When there is a single dimension, the split dimension is always 0, so we do > not need to encode it in the index of the BKD tree. This would be 33% memory > saving for half floats, 20% for ints/floats, 11% for longs/doubles and 6% for > ip addresses. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
