[jira] [Commented] (LUCENE-7609) Refactor expressions module to use DoubleValuesSource
[ https://issues.apache.org/jira/browse/LUCENE-7609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15811099#comment-15811099 ] ASF subversion and git services commented on LUCENE-7609: - Commit 1e55c5effee994856033ce115daabb2e12c91459 in lucene-solr's branch refs/heads/branch_6x from [~romseygeek] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1e55c5e ] LUCENE-7609: Add explicit dependency on queries to suggester This was previously included transitively through expressions, but expressions no longer depends on queries > Refactor expressions module to use DoubleValuesSource > - > > Key: LUCENE-7609 > URL: https://issues.apache.org/jira/browse/LUCENE-7609 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Fix For: 6.4 > > Attachments: LUCENE-7609.patch, LUCENE-7609.patch > > > With DoubleValuesSource in core, we can refactor the expressions module to > use these instead of ValueSource, and remove the dependency of expressions on > the queries module in master. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7609) Refactor expressions module to use DoubleValuesSource
[ https://issues.apache.org/jira/browse/LUCENE-7609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15807383#comment-15807383 ] ASF subversion and git services commented on LUCENE-7609: - Commit 8b055382d6c88acaed9fe472a038c7ee6b35c016 in lucene-solr's branch refs/heads/master from [~romseygeek] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8b05538 ] LUCENE-7609: Refactor expressions module to use DoubleValuesSource > Refactor expressions module to use DoubleValuesSource > - > > Key: LUCENE-7609 > URL: https://issues.apache.org/jira/browse/LUCENE-7609 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward > Attachments: LUCENE-7609.patch, LUCENE-7609.patch > > > With DoubleValuesSource in core, we can refactor the expressions module to > use these instead of ValueSource, and remove the dependency of expressions on > the queries module in master. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7609) Refactor expressions module to use DoubleValuesSource
[ https://issues.apache.org/jira/browse/LUCENE-7609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15807379#comment-15807379 ] ASF subversion and git services commented on LUCENE-7609: - Commit 776087eef48dbeba639b94b574f806b7265a7ffe in lucene-solr's branch refs/heads/branch_6x from [~romseygeek] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=776087e ] LUCENE-7609: Refactor expressions module to use DoubleValuesSource > Refactor expressions module to use DoubleValuesSource > - > > Key: LUCENE-7609 > URL: https://issues.apache.org/jira/browse/LUCENE-7609 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward > Attachments: LUCENE-7609.patch, LUCENE-7609.patch > > > With DoubleValuesSource in core, we can refactor the expressions module to > use these instead of ValueSource, and remove the dependency of expressions on > the queries module in master. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7609) Refactor expressions module to use DoubleValuesSource
[ https://issues.apache.org/jira/browse/LUCENE-7609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799061#comment-15799061 ] Adrien Grand commented on LUCENE-7609: -- Also this change seems to be changing expression values to not have a value if any of the sub sources does not have a value while in the past it looks like all documents would have a value and we would treat sub sources that do not have a value as zero. I think we should either preserve this behaviour or document the new one? > Refactor expressions module to use DoubleValuesSource > - > > Key: LUCENE-7609 > URL: https://issues.apache.org/jira/browse/LUCENE-7609 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward > Attachments: LUCENE-7609.patch > > > With DoubleValuesSource in core, we can refactor the expressions module to > use these instead of ValueSource, and remove the dependency of expressions on > the queries module in master. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7609) Refactor expressions module to use DoubleValuesSource
[
https://issues.apache.org/jira/browse/LUCENE-7609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799047#comment-15799047
]
Adrien Grand commented on LUCENE-7609:
--
bq. The dependency on queries is kept for the moment, and the ValueSource
versions of methods deprecated; these will be removed in a subsequent patch.
Why didn't you remove them in this patch? This change is breaking anyway, so
maybe we should make things clean right away? For instance, I'm looking at the
deprecated {{SimpleBindings.getValueSource}} which is not expected to be called
by users of the expression module, so maybe we should remove it now?
> Refactor expressions module to use DoubleValuesSource
> -
>
> Key: LUCENE-7609
> URL: https://issues.apache.org/jira/browse/LUCENE-7609
> Project: Lucene - Core
> Issue Type: Improvement
>Reporter: Alan Woodward
> Attachments: LUCENE-7609.patch
>
>
> With DoubleValuesSource in core, we can refactor the expressions module to
> use these instead of ValueSource, and remove the dependency of expressions on
> the queries module in master.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
