[jira] [Commented] (LUCENE-7612) Remove suggester dependency on misc

2017-01-03 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795140#comment-15795140
 ] 

ASF subversion and git services commented on LUCENE-7612:
-

Commit 77828f764c84bbe97571c8679ab523163d2da0e5 in lucene-solr's branch 
refs/heads/branch_6x from [~romseygeek]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=77828f7 ]

LUCENE-7612: Remove suggester dependency on misc


> Remove suggester dependency on misc
> ---
>
> Key: LUCENE-7612
> URL: https://issues.apache.org/jira/browse/LUCENE-7612
> Project: Lucene - Core
>  Issue Type: Improvement
>Reporter: Alan Woodward
>Assignee: Alan Woodward
> Attachments: LUCENE-7612.patch
>
>
> AnalyzingInfixSuggester uses IndexSorter, which was in the misc module when 
> the dependency was added in LUCENE-5477.  IndexSorter is in core now, though, 
> so this dependency can be removed.
> {{lucene/misc/src/java/org/apache/lucene/index/Sorter.java}} became 
> {{lucene/core/src/java/org/apache/lucene/index/Sorter.java}} as part of 
> LUCENE-6766



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-7612) Remove suggester dependency on misc

2017-01-03 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795139#comment-15795139
 ] 

ASF subversion and git services commented on LUCENE-7612:
-

Commit f3306786a13bda596a60cada45406e6f6a88724f in lucene-solr's branch 
refs/heads/master from [~romseygeek]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f330678 ]

LUCENE-7612: Remove suggester dependency on misc


> Remove suggester dependency on misc
> ---
>
> Key: LUCENE-7612
> URL: https://issues.apache.org/jira/browse/LUCENE-7612
> Project: Lucene - Core
>  Issue Type: Improvement
>Reporter: Alan Woodward
>Assignee: Alan Woodward
> Attachments: LUCENE-7612.patch
>
>
> AnalyzingInfixSuggester uses IndexSorter, which was in the misc module when 
> the dependency was added in LUCENE-5477.  IndexSorter is in core now, though, 
> so this dependency can be removed.
> {{lucene/misc/src/java/org/apache/lucene/index/Sorter.java}} became 
> {{lucene/core/src/java/org/apache/lucene/index/Sorter.java}} as part of 
> LUCENE-6766



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-7612) Remove suggester dependency on misc

2016-12-31 Thread Michael McCandless (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15789322#comment-15789322
 ] 

Michael McCandless commented on LUCENE-7612:


+1 to remove the stale dep ... thanks [~romseygeek]!

> Remove suggester dependency on misc
> ---
>
> Key: LUCENE-7612
> URL: https://issues.apache.org/jira/browse/LUCENE-7612
> Project: Lucene - Core
>  Issue Type: Improvement
>Reporter: Alan Woodward
>Assignee: Alan Woodward
> Attachments: LUCENE-7612.patch
>
>
> AnalyzingInfixSuggester uses IndexSorter, which was in the misc module when 
> the dependency was added in LUCENE-5477.  IndexSorter is in core now, though, 
> so this dependency can be removed.
> {{lucene/misc/src/java/org/apache/lucene/index/Sorter.java}} became 
> {{lucene/core/src/java/org/apache/lucene/index/Sorter.java}} as part of 
> LUCENE-6766



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-7612) Remove suggester dependency on misc

2016-12-30 Thread Christine Poerschke (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15787821#comment-15787821
 ] 

Christine Poerschke commented on LUCENE-7612:
-

bq. ... I think the maven and eclipse templates will pick this up automatically?

Yes, for maven that looks to be the case, not sure about eclipse though.

{code}
ant clean-maven-build
ant get-maven-poms
cp maven-build/lucene/suggest/pom.xml before-lucene-suggest-pom.xml

git apply LUCENE-7612.patch

ant clean-maven-build
ant get-maven-poms
cp maven-build/lucene/suggest/pom.xml after-lucene-suggest-pom.xml

diff -c before-lucene-suggest-pom.xml after-lucene-suggest-pom.xml
...
  
  
org.apache.lucene
-   lucene-misc
- 
- 
-   org.apache.lucene
lucene-queries
  
...
{code}

> Remove suggester dependency on misc
> ---
>
> Key: LUCENE-7612
> URL: https://issues.apache.org/jira/browse/LUCENE-7612
> Project: Lucene - Core
>  Issue Type: Improvement
>Reporter: Alan Woodward
>Assignee: Alan Woodward
> Attachments: LUCENE-7612.patch
>
>
> AnalyzingInfixSuggester uses IndexSorter, which was in the misc module when 
> the dependency was added in LUCENE-5477.  IndexSorter is in core now, though, 
> so this dependency can be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org