[jira] [Commented] (LUCENE-7681) Remove LegacyDocValues implementations from MemoryIndex
[ https://issues.apache.org/jira/browse/LUCENE-7681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871556#comment-15871556 ] ASF subversion and git services commented on LUCENE-7681: - Commit 7a8c59dd86ae8788b61047aad7f2bc159733e604 in lucene-solr's branch refs/heads/master from [~romseygeek] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7a8c59d ] LUCENE-7681: Remove LegacyDocValues implementations from MemoryIndex > Remove LegacyDocValues implementations from MemoryIndex > --- > > Key: LUCENE-7681 > URL: https://issues.apache.org/jira/browse/LUCENE-7681 > Project: Lucene - Core > Issue Type: Improvement >Affects Versions: master (7.0) >Reporter: Alan Woodward >Assignee: Alan Woodward >Priority: Minor > Fix For: master (7.0) > > Attachments: LUCENE-7681.patch > > > MemoryIndex in master is using the LegacyDocValue wrappers. We should > replace these with plain 7.0-style iterators instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7681) Remove LegacyDocValues implementations from MemoryIndex
[ https://issues.apache.org/jira/browse/LUCENE-7681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861231#comment-15861231 ] Martijn van Groningen commented on LUCENE-7681: --- +1 looks good! > Remove LegacyDocValues implementations from MemoryIndex > --- > > Key: LUCENE-7681 > URL: https://issues.apache.org/jira/browse/LUCENE-7681 > Project: Lucene - Core > Issue Type: Improvement >Affects Versions: master (7.0) >Reporter: Alan Woodward >Assignee: Alan Woodward >Priority: Minor > Attachments: LUCENE-7681.patch > > > MemoryIndex in master is using the LegacyDocValue wrappers. We should > replace these with plain 7.0-style iterators instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7681) Remove LegacyDocValues implementations from MemoryIndex
[ https://issues.apache.org/jira/browse/LUCENE-7681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15859521#comment-15859521 ] Adrien Grand commented on LUCENE-7681: -- That works for me, thanks for the explanations! > Remove LegacyDocValues implementations from MemoryIndex > --- > > Key: LUCENE-7681 > URL: https://issues.apache.org/jira/browse/LUCENE-7681 > Project: Lucene - Core > Issue Type: Improvement >Affects Versions: master (7.0) >Reporter: Alan Woodward >Assignee: Alan Woodward >Priority: Minor > Attachments: LUCENE-7681.patch > > > MemoryIndex in master is using the LegacyDocValue wrappers. We should > replace these with plain 7.0-style iterators instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7681) Remove LegacyDocValues implementations from MemoryIndex
[
https://issues.apache.org/jira/browse/LUCENE-7681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15859384#comment-15859384
]
Alan Woodward commented on LUCENE-7681:
---
bq. Is the norm really computed lazily?
It is if you don't call freeze, which I hope to remove for 7.0.
re advanceExact, I don't think that applies here, because DV fields in
MemoryIndex will always have a value? Unless I'm misunderstanding you. If you
call {{advanceExact(0)}}, then docId() will return 0, but if you call it with
any other value then it will return {{NO_MORE_DOCS}}.
> Remove LegacyDocValues implementations from MemoryIndex
> ---
>
> Key: LUCENE-7681
> URL: https://issues.apache.org/jira/browse/LUCENE-7681
> Project: Lucene - Core
> Issue Type: Improvement
>Affects Versions: master (7.0)
>Reporter: Alan Woodward
>Assignee: Alan Woodward
>Priority: Minor
> Attachments: LUCENE-7681.patch
>
>
> MemoryIndex in master is using the LegacyDocValue wrappers. We should
> replace these with plain 7.0-style iterators instead.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7681) Remove LegacyDocValues implementations from MemoryIndex
[
https://issues.apache.org/jira/browse/LUCENE-7681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856451#comment-15856451
]
Adrien Grand commented on LUCENE-7681:
--
+1 for using the new iterator API!
Is the norm really computed lazily? I see a call to {{getNormDocValues}} in
{{freeze()}} which makes me think it is computed up-front.
Also I think the {{advanceExact}} impls do not honor the contract that docId()
returns {{target}} after {{advanceExact(target)}} has been called, regardless
of whether the document had a value for that doc (however, since target needs
to be a valid docID, it may only be 0 in the case of MemoryIndex).
> Remove LegacyDocValues implementations from MemoryIndex
> ---
>
> Key: LUCENE-7681
> URL: https://issues.apache.org/jira/browse/LUCENE-7681
> Project: Lucene - Core
> Issue Type: Improvement
>Affects Versions: master (7.0)
>Reporter: Alan Woodward
>Assignee: Alan Woodward
>Priority: Minor
> Attachments: LUCENE-7681.patch
>
>
> MemoryIndex in master is using the LegacyDocValue wrappers. We should
> replace these with plain 7.0-style iterators instead.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
