[jira] [Commented] (LUCENE-7725) it should be possible to run "ant precommit" with java9
[
https://issues.apache.org/jira/browse/LUCENE-7725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892682#comment-15892682
]
Uwe Schindler commented on LUCENE-7725:
---
bq. Stay tuned.
Not working :-(
> it should be possible to run "ant precommit" with java9
> ---
>
> Key: LUCENE-7725
> URL: https://issues.apache.org/jira/browse/LUCENE-7725
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Hoss Man
> Labels: Java9
>
> Eventually we'll want to be sure that {{ant precommit}} works even if you are
> using java9.
> This is currently not possible because the ECJ (Eclipse JDT based) javadoc
> linter we use doesn't work on java9 -- so we're blocked on that, and the
> build.xml explicitly fails fast. (The fail fast logic in build.xml can
> currently be bypassed via a {{-Dis.jenkins.build=true}} system prop)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7725) it should be possible to run "ant precommit" with java9
[
https://issues.apache.org/jira/browse/LUCENE-7725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892676#comment-15892676
]
Uwe Schindler commented on LUCENE-7725:
---
FYI, I also changed the Markdown converter from pegdown to flexmark: LUCENE-7727
You can now build documentation with Java 9. I did not yet try linting with our
own python-based linter...
> it should be possible to run "ant precommit" with java9
> ---
>
> Key: LUCENE-7725
> URL: https://issues.apache.org/jira/browse/LUCENE-7725
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Hoss Man
> Labels: Java9
>
> Eventually we'll want to be sure that {{ant precommit}} works even if you are
> using java9.
> This is currently not possible because the ECJ (Eclipse JDT based) javadoc
> linter we use doesn't work on java9 -- so we're blocked on that, and the
> build.xml explicitly fails fast. (The fail fast logic in build.xml can
> currently be bypassed via a {{-Dis.jenkins.build=true}} system prop)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7725) it should be possible to run "ant precommit" with java9
[
https://issues.apache.org/jira/browse/LUCENE-7725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892670#comment-15892670
]
Uwe Schindler commented on LUCENE-7725:
---
I have no full overview of all bugs (same like you). There is not much visible
activity around ECJ and Java 9. I am currently trying the latest ECJ version...
Stay tuned.
> it should be possible to run "ant precommit" with java9
> ---
>
> Key: LUCENE-7725
> URL: https://issues.apache.org/jira/browse/LUCENE-7725
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Hoss Man
> Labels: Java9
>
> Eventually we'll want to be sure that {{ant precommit}} works even if you are
> using java9.
> This is currently not possible because the ECJ (Eclipse JDT based) javadoc
> linter we use doesn't work on java9 -- so we're blocked on that, and the
> build.xml explicitly fails fast. (The fail fast logic in build.xml can
> currently be bypassed via a {{-Dis.jenkins.build=true}} system prop)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7725) it should be possible to run "ant precommit" with java9
[
https://issues.apache.org/jira/browse/LUCENE-7725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891221#comment-15891221
]
Uwe Schindler commented on LUCENE-7725:
---
BTW: If you try to run ECJ with current Java 9, it fails horribly with 24667
errors on Lucene-Core :-) Last one is most funny:
{noformat}
[ecj-lint] 24667. ERROR in C:\Users\Uwe
Schindler\Projects\lucene\trunk-lusolr1\lucene\core\src\java\org\apache\lucene\util\packed\PagedMutable.java
(at line 66)
[ecj-lint] @Override
[ecj-lint]
[ecj-lint] Override cannot be resolved to a type
{noformat}
This is because ECJ cannot find the JAR file with the runtime classes (rt.jar).
We have to wait for a new version (see above).
> it should be possible to run "ant precommit" with java9
> ---
>
> Key: LUCENE-7725
> URL: https://issues.apache.org/jira/browse/LUCENE-7725
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Hoss Man
> Labels: Java9
>
> Eventually we'll want to be sure that {{ant precommit}} works even if you are
> using java9.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7725) it should be possible to run "ant precommit" with java9
[
https://issues.apache.org/jira/browse/LUCENE-7725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891215#comment-15891215
]
Uwe Schindler commented on LUCENE-7725:
---
We (Robert and I) added the hard fail, because we wanted to prevent anybody
from running precommit and missing the extra checks, just because they ran Java
9. In any case, if you run precommit, you should really, really only do that on
Java 8. Because that's the version we compile against.
Nevertheless, we can remove the hard fail and just print the warning. But I'd
not be happy.
So the fix is: {{ant precommit -Dis.jenkins.build=true}}
> it should be possible to run "ant precommit" with java9
> ---
>
> Key: LUCENE-7725
> URL: https://issues.apache.org/jira/browse/LUCENE-7725
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Hoss Man
> Labels: Java9
>
> Eventually we'll want to be sure that {{ant precommit}} works even if you are
> using java9.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7725) it should be possible to run "ant precommit" with java9
[
https://issues.apache.org/jira/browse/LUCENE-7725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891212#comment-15891212
]
Uwe Schindler commented on LUCENE-7725:
---
Hi,
this target explains it:
{code:xml}
{code}
> it should be possible to run "ant precommit" with java9
> ---
>
> Key: LUCENE-7725
> URL: https://issues.apache.org/jira/browse/LUCENE-7725
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Hoss Man
> Labels: Java9
>
> Eventually we'll want to be sure that {{ant precommit}} works even if you are
> using java9.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7725) it should be possible to run "ant precommit" with java9
[
https://issues.apache.org/jira/browse/LUCENE-7725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891173#comment-15891173
]
Hoss Man commented on LUCENE-7725:
--
bq. Btw, you can run precommit also with Java 9 if you set an extra build
property to activate "Jenkins mode".
really? what exactly does that look like?
we should document that here as a workaround.
> it should be possible to run "ant precommit" with java9
> ---
>
> Key: LUCENE-7725
> URL: https://issues.apache.org/jira/browse/LUCENE-7725
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Hoss Man
> Labels: Java9
>
> Eventually we'll want to be sure that {{ant precommit}} works even if you are
> using java9.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7725) it should be possible to run "ant precommit" with java9
[
https://issues.apache.org/jira/browse/LUCENE-7725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891148#comment-15891148
]
Uwe Schindler commented on LUCENE-7725:
---
I can take this issue, but we have to wait for Java 9 to come out until ECJ
works.
Btw, you can run precommit also with Java 9 if you set an extra build property
to activate "Jenkins mode".
> it should be possible to run "ant precommit" with java9
> ---
>
> Key: LUCENE-7725
> URL: https://issues.apache.org/jira/browse/LUCENE-7725
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Hoss Man
> Labels: Java9
>
> Eventually we'll want to be sure that {{ant precommit}} works even if you are
> using java9.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7725) it should be possible to run "ant precommit" with java9
[
https://issues.apache.org/jira/browse/LUCENE-7725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891138#comment-15891138
]
Uwe Schindler commented on LUCENE-7725:
---
The problem was Javadocs and it's linter. In addition, current ECJ cannot
handle the missing rt.jar. There is work going on to release a new version
that's able to handle Java 9.
> it should be possible to run "ant precommit" with java9
> ---
>
> Key: LUCENE-7725
> URL: https://issues.apache.org/jira/browse/LUCENE-7725
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Hoss Man
> Labels: Java9
>
> Eventually we'll want to be sure that {{ant precommit}} works even if you are
> using java9.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7725) it should be possible to run "ant precommit" with java9
[
https://issues.apache.org/jira/browse/LUCENE-7725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891063#comment-15891063
]
Hoss Man commented on LUCENE-7725:
--
Currently precommit on master with java9 fails because...
{noformat}
-ecj-javadoc-lint-unsupported:
BUILD FAILED
/home/hossman/lucene/dev/lucene/common-build.xml:1993: Linting documentation
with ECJ is not supported on this Java version (9).
{noformat}
...i haven't dug into this enough to figure out if there is a genuine problem
running ECJ on java9, or if it's just an overly aggressive version restriction
in the build file.
> it should be possible to run "ant precommit" with java9
> ---
>
> Key: LUCENE-7725
> URL: https://issues.apache.org/jira/browse/LUCENE-7725
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Hoss Man
> Labels: Java9
>
> Eventually we'll want to be sure that {{ant precommit}} works even if you are
> using java9.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
