[jira] [Commented] (LUCENE-7838) Add a knn classifier based on fuzzy like this
[ https://issues.apache.org/jira/browse/LUCENE-7838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067962#comment-16067962 ] Tommaso Teofili commented on LUCENE-7838: - I've removed the dependency on the sandbox module and created a dedicated version of FLT named NearestFuzzyQuery in org.apache.lucene.classification.utils package. The goal now is to refine NearestFuzzyQuery in order to get better classification results and remove some specifics of FLT. > Add a knn classifier based on fuzzy like this > - > > Key: LUCENE-7838 > URL: https://issues.apache.org/jira/browse/LUCENE-7838 > Project: Lucene - Core > Issue Type: Bug > Components: modules/classification >Reporter: Tommaso Teofili >Assignee: Tommaso Teofili > Fix For: master (7.0) > > > FLT mixes fuzzy and MLT, in the context of Lucene based classification it > might be useful to add such a fuzziness to a dedicated KNN classifier (based > on FLT queries). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7838) Add a knn classifier based on fuzzy like this
[ https://issues.apache.org/jira/browse/LUCENE-7838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067957#comment-16067957 ] ASF subversion and git services commented on LUCENE-7838: - Commit 92e460389dc9b0af83c445cb029e3a51799a37dc in lucene-solr's branch refs/heads/master from [~teofili] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=92e4603 ] LUCENE-7838 - removed dep from sandbox, created a minimal FLT version specific for knn classification > Add a knn classifier based on fuzzy like this > - > > Key: LUCENE-7838 > URL: https://issues.apache.org/jira/browse/LUCENE-7838 > Project: Lucene - Core > Issue Type: Bug > Components: modules/classification >Reporter: Tommaso Teofili >Assignee: Tommaso Teofili > Fix For: master (7.0) > > > FLT mixes fuzzy and MLT, in the context of Lucene based classification it > might be useful to add such a fuzziness to a dedicated KNN classifier (based > on FLT queries). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7838) Add a knn classifier based on fuzzy like this
[ https://issues.apache.org/jira/browse/LUCENE-7838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031313#comment-16031313 ] Tommaso Teofili commented on LUCENE-7838: - as per related thread on dev@ I'll drop the dependency over the sandbox module which is indeed not appropriate. If possible I'd like to keep the classifier but I'd not just copy paste the FLT code from sandbox to classification therefore it'll take a bit of time to tweak it as needed. > Add a knn classifier based on fuzzy like this > - > > Key: LUCENE-7838 > URL: https://issues.apache.org/jira/browse/LUCENE-7838 > Project: Lucene - Core > Issue Type: Bug > Components: modules/classification >Reporter: Tommaso Teofili >Assignee: Tommaso Teofili > Fix For: master (7.0) > > > FLT mixes fuzzy and MLT, in the context of Lucene based classification it > might be useful to add such a fuzziness to a dedicated KNN classifier (based > on FLT queries). -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7838) Add a knn classifier based on fuzzy like this
[ https://issues.apache.org/jira/browse/LUCENE-7838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029939#comment-16029939 ] David Smiley commented on LUCENE-7838: -- bq. CHANGES.txt: I guess I need to be clearer. Why _isn't_ there a CHANGES.txt entry? Beyond mentioning what the title says, mentioning the new dependency would be appropriate (required IMO). bq. patch Nevermind; you were going the CTR path (which I welcome) instead of RTC. CTR is outside our defacto norms of behavior here. Maybe I should follow suit and we will try to change that :-) > Add a knn classifier based on fuzzy like this > - > > Key: LUCENE-7838 > URL: https://issues.apache.org/jira/browse/LUCENE-7838 > Project: Lucene - Core > Issue Type: Bug > Components: modules/classification >Reporter: Tommaso Teofili >Assignee: Tommaso Teofili > Fix For: master (7.0) > > > FLT mixes fuzzy and MLT, in the context of Lucene based classification it > might be useful to add such a fuzziness to a dedicated KNN classifier (based > on FLT queries). -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7838) Add a knn classifier based on fuzzy like this
[
https://issues.apache.org/jira/browse/LUCENE-7838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029210#comment-16029210
]
Adrien Grand commented on LUCENE-7838:
--
I agree with David we should be careful about adding new dependencies.
Otherwise things can quickly become hairy, eg. because of circular
dependencies, or because pulling a single module would pull most other modules
through transitive dependencies, which defeats the purpose of having modules.
Dependeng on sandbox makes it ever worse since the barrier for adding/removing
code is supposed to be low, yet this new dependency means that special care
needs to be taken if we want to remove {{FuzzyLikeThis}}.
> Add a knn classifier based on fuzzy like this
> -
>
> Key: LUCENE-7838
> URL: https://issues.apache.org/jira/browse/LUCENE-7838
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/classification
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: master (7.0)
>
>
> FLT mixes fuzzy and MLT, in the context of Lucene based classification it
> might be useful to add such a fuzziness to a dedicated KNN classifier (based
> on FLT queries).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7838) Add a knn classifier based on fuzzy like this
[
https://issues.apache.org/jira/browse/LUCENE-7838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027295#comment-16027295
]
Tommaso Teofili commented on LUCENE-7838:
-
bq. you added a dependency on the sandbox module from another module. That's
quite surprising to me... I don't think that's legit?
why? As soon as we provide releases of lucene-sandbox I assume we expect people
and other modules to use it.
bq. New inter-module dependencies (of any kind) I think should also deserve
communication on the JIRA issue and I don't see any mention here.
Since this is only impacting master branch I had thought there was no need to
explicitly mention that; on the other hand {{FuzzyLikeThisQuery}} lives in
sandbox therefore I had assumed there was no need to explicitly specify that in
the issue.
bq. I also don't see a CHANGES.txt entry
right, there's no such entry.
bq. I don't see a patch file either but I admit I welcome that
I'm not sure I get your point here, would you have expected a patch ?
> Add a knn classifier based on fuzzy like this
> -
>
> Key: LUCENE-7838
> URL: https://issues.apache.org/jira/browse/LUCENE-7838
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/classification
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: master (7.0)
>
>
> FLT mixes fuzzy and MLT, in the context of Lucene based classification it
> might be useful to add such a fuzziness to a dedicated KNN classifier (based
> on FLT queries).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7838) Add a knn classifier based on fuzzy like this
[ https://issues.apache.org/jira/browse/LUCENE-7838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016713#comment-16016713 ] ASF subversion and git services commented on LUCENE-7838: - Commit d30d012c7c2f9de46a32d7e9eda3b17c51a7fa04 in lucene-solr's branch refs/heads/master from Tomas Fernandez Lobbe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d30d012 ] SOLR-10042, LUCENE-7838: Fix precommit > Add a knn classifier based on fuzzy like this > - > > Key: LUCENE-7838 > URL: https://issues.apache.org/jira/browse/LUCENE-7838 > Project: Lucene - Core > Issue Type: Bug > Components: modules/classification >Reporter: Tommaso Teofili >Assignee: Tommaso Teofili > Fix For: master (7.0) > > > FLT mixes fuzzy and MLT, in the context of Lucene based classification it > might be useful to add such a fuzziness to a dedicated KNN classifier (based > on FLT queries). -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7838) Add a knn classifier based on fuzzy like this
[ https://issues.apache.org/jira/browse/LUCENE-7838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015848#comment-16015848 ] ASF subversion and git services commented on LUCENE-7838: - Commit c9bdce937a52e80174ce22f4e82a02da736b56c4 in lucene-solr's branch refs/heads/master from [~jpountz] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c9bdce9 ] LUCENE-7838: Remove unused imports. > Add a knn classifier based on fuzzy like this > - > > Key: LUCENE-7838 > URL: https://issues.apache.org/jira/browse/LUCENE-7838 > Project: Lucene - Core > Issue Type: Bug > Components: modules/classification >Reporter: Tommaso Teofili >Assignee: Tommaso Teofili > Fix For: master (7.0) > > > FLT mixes fuzzy and MLT, in the context of Lucene based classification it > might be useful to add such a fuzziness to a dedicated KNN classifier (based > on FLT queries). -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7838) Add a knn classifier based on fuzzy like this
[ https://issues.apache.org/jira/browse/LUCENE-7838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015690#comment-16015690 ] ASF subversion and git services commented on LUCENE-7838: - Commit c53d19e7b2b15fe2d9d38be3a1137339336a7f23 in lucene-solr's branch refs/heads/master from [~teofili] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c53d19e ] LUCENE-7838 - removed unused import > Add a knn classifier based on fuzzy like this > - > > Key: LUCENE-7838 > URL: https://issues.apache.org/jira/browse/LUCENE-7838 > Project: Lucene - Core > Issue Type: Bug > Components: modules/classification >Reporter: Tommaso Teofili >Assignee: Tommaso Teofili > Fix For: master (7.0) > > > FLT mixes fuzzy and MLT, in the context of Lucene based classification it > might be useful to add such a fuzziness to a dedicated KNN classifier (based > on FLT queries). -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7838) Add a knn classifier based on fuzzy like this
[ https://issues.apache.org/jira/browse/LUCENE-7838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015684#comment-16015684 ] ASF subversion and git services commented on LUCENE-7838: - Commit bd9e32d358399af7c31e732314e1ef1dd89bcfa1 in lucene-solr's branch refs/heads/master from [~teofili] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=bd9e32d ] LUCENE-7838 - added knn classifier based on flt > Add a knn classifier based on fuzzy like this > - > > Key: LUCENE-7838 > URL: https://issues.apache.org/jira/browse/LUCENE-7838 > Project: Lucene - Core > Issue Type: Bug > Components: modules/classification >Reporter: Tommaso Teofili >Assignee: Tommaso Teofili > Fix For: master (7.0) > > > FLT mixes fuzzy and MLT, in the context of Lucene based classification it > might be useful to add such a fuzziness to a dedicated KNN classifier (based > on FLT queries). -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
