[jira] [Commented] (LUCENE-7922) Remove packed FST support?
[
https://issues.apache.org/jira/browse/LUCENE-7922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119794#comment-16119794
]
Dawid Weiss commented on LUCENE-7922:
-
I'd love to. :) I don't have much time these days, unfortunately.
But wait. I do have a contribution: we can remove the 'node' field which isn't
used anywhere. :)
> Remove packed FST support?
> --
>
> Key: LUCENE-7922
> URL: https://issues.apache.org/jira/browse/LUCENE-7922
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
> Attachments: node.patch
>
>
> I've been looking at the FST code we have today. Complex to read, even more
> complex to modify. I think it could benefit if we cleaned it up a bit (there
> are a few issues out there already that mention this).
> The first baby step would be to remove the "packed" representation of FSTs --
> I searched the codebase and I don't see a single place where {{pack}} would
> actually be {{true}}. The overhead associated with node packing seems to be
> not worth it in practice (since most FSTs are already fairly small).
> It'd be a breaking API change, but it's probably something worth undertaking
> for 7.0, unless I'm missing some use cases.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7922) Remove packed FST support?
[
https://issues.apache.org/jira/browse/LUCENE-7922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119787#comment-16119787
]
Michael McCandless commented on LUCENE-7922:
But please keep looking for simplifications!
> Remove packed FST support?
> --
>
> Key: LUCENE-7922
> URL: https://issues.apache.org/jira/browse/LUCENE-7922
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>
> I've been looking at the FST code we have today. Complex to read, even more
> complex to modify. I think it could benefit if we cleaned it up a bit (there
> are a few issues out there already that mention this).
> The first baby step would be to remove the "packed" representation of FSTs --
> I searched the codebase and I don't see a single place where {{pack}} would
> actually be {{true}}. The overhead associated with node packing seems to be
> not worth it in practice (since most FSTs are already fairly small).
> It'd be a breaking API change, but it's probably something worth undertaking
> for 7.0, unless I'm missing some use cases.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
