[jira] [Commented] (LUCENE-7928) Change LatLonPointDistanceQuery and LatLonPointInPolygonQuery visibility to public
[ https://issues.apache.org/jira/browse/LUCENE-7928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123311#comment-16123311 ] Robert Muir commented on LUCENE-7928: - But this unnecessarily raises the surface area of the API, which makes it more confusing for users trying to figure the stuff out. This was part of the design of the whole API here, to have the most minimal surface area possible so that we'd have spatial stuff that was straightforward. I don't think we should make such changes for expert cases, at the expense of the typical case. I'm -1 to making this stuff public. > Change LatLonPointDistanceQuery and LatLonPointInPolygonQuery visibility to > public > -- > > Key: LUCENE-7928 > URL: https://issues.apache.org/jira/browse/LUCENE-7928 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Martijn van Groningen >Priority: Minor > Fix For: master (8.0), 7.1 > > Attachments: LUCENE_7928.patch > > > Changing the visibility of these classes to public can be useful for > accessing the getters (which are already public) to allow custom post > processing of the query instances. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7928) Change LatLonPointDistanceQuery and LatLonPointInPolygonQuery visibility to public
[ https://issues.apache.org/jira/browse/LUCENE-7928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123309#comment-16123309 ] Martijn van Groningen commented on LUCENE-7928: --- I agree that these queries should only be constructed via their factory methods, that is why the constructors are package protected. I like these two classes to be public to access the getters, which is useful for query processing. (which is what the percolator and luwak both do) > Change LatLonPointDistanceQuery and LatLonPointInPolygonQuery visibility to > public > -- > > Key: LUCENE-7928 > URL: https://issues.apache.org/jira/browse/LUCENE-7928 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Martijn van Groningen >Priority: Minor > Fix For: master (8.0), 7.1 > > Attachments: LUCENE_7928.patch > > > Changing the visibility of these classes to public can be useful for > accessing the getters (which are already public) to allow custom post > processing of the query instances. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7928) Change LatLonPointDistanceQuery and LatLonPointInPolygonQuery visibility to public
[ https://issues.apache.org/jira/browse/LUCENE-7928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123293#comment-16123293 ] Robert Muir commented on LUCENE-7928: - I don't think these classes shoudl be public, they are an implementation detail. To create such queries, use LatLonPoint.newXXX() methods. > Change LatLonPointDistanceQuery and LatLonPointInPolygonQuery visibility to > public > -- > > Key: LUCENE-7928 > URL: https://issues.apache.org/jira/browse/LUCENE-7928 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Martijn van Groningen >Priority: Minor > Fix For: master (8.0), 7.1 > > Attachments: LUCENE_7928.patch > > > Changing the visibility of these classes to public can be useful for > accessing the getters (which are already public) to allow custom post > processing of the query instances. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
