[jira] [Commented] (LUCENE-8055) MemoryIndex.MemoryDocValuesIterator returns 2 document instead of 1

2017-11-21 Thread Erick Erickson (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-8055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261437#comment-16261437
 ] 

Erick Erickson commented on LUCENE-8055:


[~dsmiley] Hmmm, somehow I had it in my mind that some of the randomizing would 
use MemoryIndex, but actually, you know, _looking_ at the code it appears not 
to be true, never mind...

> MemoryIndex.MemoryDocValuesIterator returns 2 document instead of 1
> ---
>
> Key: LUCENE-8055
> URL: https://issues.apache.org/jira/browse/LUCENE-8055
> Project: Lucene - Core
>  Issue Type: Bug
>  Components: modules/other
>Reporter: Simon Willnauer
>Assignee: Simon Willnauer
> Fix For: master (8.0), 7.2, 7.1.1
>
> Attachments: LUCENE-8055.patch
>
>
> If there is a DV field in the MemoryIndex the 
> `MemoryIndex.MemoryDocValuesIterator` will return 2 documents instead of 1. 
> Simple off by one error and no tests. I have a patch ready for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-8055) MemoryIndex.MemoryDocValuesIterator returns 2 document instead of 1

2017-11-21 Thread David Smiley (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-8055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261388#comment-16261388
 ] 

David Smiley commented on LUCENE-8055:
--

MemoryIndex is mainly used by some of the highlighters, and they don't put 
docValues in it.  So I would be very surprised to learn if some Solr test is 
related to this.  At least I assume [~erickerickson] you are talking about Solr 
test failures.

> MemoryIndex.MemoryDocValuesIterator returns 2 document instead of 1
> ---
>
> Key: LUCENE-8055
> URL: https://issues.apache.org/jira/browse/LUCENE-8055
> Project: Lucene - Core
>  Issue Type: Bug
>  Components: modules/other
>Reporter: Simon Willnauer
>Assignee: Simon Willnauer
> Fix For: master (8.0), 7.2, 7.1.1
>
> Attachments: LUCENE-8055.patch
>
>
> If there is a DV field in the MemoryIndex the 
> `MemoryIndex.MemoryDocValuesIterator` will return 2 documents instead of 1. 
> Simple off by one error and no tests. I have a patch ready for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-8055) MemoryIndex.MemoryDocValuesIterator returns 2 document instead of 1

2017-11-21 Thread Erick Erickson (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-8055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261087#comment-16261087
 ] 

Erick Erickson commented on LUCENE-8055:


[~simonw] Yes, I'm thinking about ones that have been hanging around for a long 
time but don't reproduce reliably. I keep meaning to look at them "when time 
permits". Siiighh. If I'm _really_ lucky some of them will magically have gone 
away ;).

> MemoryIndex.MemoryDocValuesIterator returns 2 document instead of 1
> ---
>
> Key: LUCENE-8055
> URL: https://issues.apache.org/jira/browse/LUCENE-8055
> Project: Lucene - Core
>  Issue Type: Bug
>  Components: modules/other
>Reporter: Simon Willnauer
>Assignee: Simon Willnauer
> Fix For: master (8.0), 7.2, 7.1.1
>
> Attachments: LUCENE-8055.patch
>
>
> If there is a DV field in the MemoryIndex the 
> `MemoryIndex.MemoryDocValuesIterator` will return 2 documents instead of 1. 
> Simple off by one error and no tests. I have a patch ready for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-8055) MemoryIndex.MemoryDocValuesIterator returns 2 document instead of 1

2017-11-21 Thread Simon Willnauer (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-8055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261031#comment-16261031
 ] 

Simon Willnauer commented on LUCENE-8055:
-

[~erickerickson] just to be sure, you are talking about preexisting test issues?

> MemoryIndex.MemoryDocValuesIterator returns 2 document instead of 1
> ---
>
> Key: LUCENE-8055
> URL: https://issues.apache.org/jira/browse/LUCENE-8055
> Project: Lucene - Core
>  Issue Type: Bug
>  Components: modules/other
>Reporter: Simon Willnauer
>Assignee: Simon Willnauer
> Fix For: master (8.0), 7.2, 7.1.1
>
> Attachments: LUCENE-8055.patch
>
>
> If there is a DV field in the MemoryIndex the 
> `MemoryIndex.MemoryDocValuesIterator` will return 2 documents instead of 1. 
> Simple off by one error and no tests. I have a patch ready for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-8055) MemoryIndex.MemoryDocValuesIterator returns 2 document instead of 1

2017-11-21 Thread Erick Erickson (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-8055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261029#comment-16261029
 ] 

Erick Erickson commented on LUCENE-8055:


Hmm, I wonder if this is behind some of the test failures? I've never looked at 
whether some of the errors that are finding doc counts off were using 
memoryindex. Just saw a test failure go by for testGroupingDVOnly that might 
possibly be related.

> MemoryIndex.MemoryDocValuesIterator returns 2 document instead of 1
> ---
>
> Key: LUCENE-8055
> URL: https://issues.apache.org/jira/browse/LUCENE-8055
> Project: Lucene - Core
>  Issue Type: Bug
>  Components: modules/other
>Reporter: Simon Willnauer
>Assignee: Simon Willnauer
> Fix For: master (8.0), 7.2, 7.1.1
>
> Attachments: LUCENE-8055.patch
>
>
> If there is a DV field in the MemoryIndex the 
> `MemoryIndex.MemoryDocValuesIterator` will return 2 documents instead of 1. 
> Simple off by one error and no tests. I have a patch ready for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-8055) MemoryIndex.MemoryDocValuesIterator returns 2 document instead of 1

2017-11-21 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-8055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260722#comment-16260722
 ] 

ASF subversion and git services commented on LUCENE-8055:
-

Commit a14972d7ae2357ab7150909332a04c9a1a94474c in lucene-solr's branch 
refs/heads/master from [~simonw]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a14972d ]

LUCENE-8055: MemoryIndex.MemoryDocValuesIterator returns 2 documents instead of 
1

Fixes a bug if there is a DV field in the MemoryIndex the
`MemoryIndex.MemoryDocValuesIterator` will return 2 documents instead of 1.


> MemoryIndex.MemoryDocValuesIterator returns 2 document instead of 1
> ---
>
> Key: LUCENE-8055
> URL: https://issues.apache.org/jira/browse/LUCENE-8055
> Project: Lucene - Core
>  Issue Type: Bug
>  Components: modules/other
>Reporter: Simon Willnauer
>Assignee: Simon Willnauer
> Fix For: master (8.0), 7.2, 7.1.1
>
> Attachments: LUCENE-8055.patch
>
>
> If there is a DV field in the MemoryIndex the 
> `MemoryIndex.MemoryDocValuesIterator` will return 2 documents instead of 1. 
> Simple off by one error and no tests. I have a patch ready for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-8055) MemoryIndex.MemoryDocValuesIterator returns 2 document instead of 1

2017-11-21 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-8055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260721#comment-16260721
 ] 

ASF subversion and git services commented on LUCENE-8055:
-

Commit e445dd62f3172d3dc9c5ca9b930bf59e574402f0 in lucene-solr's branch 
refs/heads/branch_7x from [~simonw]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e445dd6 ]

LUCENE-8055: MemoryIndex.MemoryDocValuesIterator returns 2 documents instead of 
1

Fixes a bug if there is a DV field in the MemoryIndex the
`MemoryIndex.MemoryDocValuesIterator` will return 2 documents instead of 1.


> MemoryIndex.MemoryDocValuesIterator returns 2 document instead of 1
> ---
>
> Key: LUCENE-8055
> URL: https://issues.apache.org/jira/browse/LUCENE-8055
> Project: Lucene - Core
>  Issue Type: Bug
>  Components: modules/other
>Reporter: Simon Willnauer
>Assignee: Simon Willnauer
> Fix For: master (8.0), 7.2, 7.1.1
>
> Attachments: LUCENE-8055.patch
>
>
> If there is a DV field in the MemoryIndex the 
> `MemoryIndex.MemoryDocValuesIterator` will return 2 documents instead of 1. 
> Simple off by one error and no tests. I have a patch ready for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-8055) MemoryIndex.MemoryDocValuesIterator returns 2 document instead of 1

2017-11-21 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-8055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260720#comment-16260720
 ] 

ASF subversion and git services commented on LUCENE-8055:
-

Commit a6e968b55bd744171c8e5238438ed351d96634d2 in lucene-solr's branch 
refs/heads/branch_7_1 from [~simonw]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a6e968b ]

LUCENE-8055: MemoryIndex.MemoryDocValuesIterator returns 2 documents instead of 
1

Fixes a bug if there is a DV field in the MemoryIndex the
`MemoryIndex.MemoryDocValuesIterator` will return 2 documents instead of 1.


> MemoryIndex.MemoryDocValuesIterator returns 2 document instead of 1
> ---
>
> Key: LUCENE-8055
> URL: https://issues.apache.org/jira/browse/LUCENE-8055
> Project: Lucene - Core
>  Issue Type: Bug
>  Components: modules/other
>Reporter: Simon Willnauer
>Assignee: Simon Willnauer
> Fix For: master (8.0), 7.2, 7.1.1
>
> Attachments: LUCENE-8055.patch
>
>
> If there is a DV field in the MemoryIndex the 
> `MemoryIndex.MemoryDocValuesIterator` will return 2 documents instead of 1. 
> Simple off by one error and no tests. I have a patch ready for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-8055) MemoryIndex.MemoryDocValuesIterator returns 2 document instead of 1

2017-11-21 Thread Dawid Weiss (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-8055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260583#comment-16260583
 ] 

Dawid Weiss commented on LUCENE-8055:
-

+1. The MemoryIndex had some serious memory problems! :)

> MemoryIndex.MemoryDocValuesIterator returns 2 document instead of 1
> ---
>
> Key: LUCENE-8055
> URL: https://issues.apache.org/jira/browse/LUCENE-8055
> Project: Lucene - Core
>  Issue Type: Bug
>  Components: modules/other
>Reporter: Simon Willnauer
>Assignee: Simon Willnauer
> Fix For: master (8.0), 7.2, 7.1.1
>
> Attachments: LUCENE-8055.patch
>
>
> If there is a DV field in the MemoryIndex the 
> `MemoryIndex.MemoryDocValuesIterator` will return 2 documents instead of 1. 
> Simple off by one error and no tests. I have a patch ready for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-8055) MemoryIndex.MemoryDocValuesIterator returns 2 document instead of 1

2017-11-21 Thread Martijn van Groningen (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-8055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260581#comment-16260581
 ] 

Martijn van Groningen commented on LUCENE-8055:
---

+1 thanks [~simonw]!

> MemoryIndex.MemoryDocValuesIterator returns 2 document instead of 1
> ---
>
> Key: LUCENE-8055
> URL: https://issues.apache.org/jira/browse/LUCENE-8055
> Project: Lucene - Core
>  Issue Type: Bug
>  Components: modules/other
>Reporter: Simon Willnauer
>Assignee: Simon Willnauer
> Fix For: master (8.0), 7.2, 7.1.1
>
> Attachments: LUCENE-8055.patch
>
>
> It there is a DV field in the MemoryIndex the 
> `MemoryIndex.MemoryDocValuesIterator` will return 2 documents instead of 1. 
> Simple off by one error and no tests. I have a patch ready for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-8055) MemoryIndex.MemoryDocValuesIterator returns 2 document instead of 1

2017-11-21 Thread Alan Woodward (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-8055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260580#comment-16260580
 ] 

Alan Woodward commented on LUCENE-8055:
---

+1.  Oops

> MemoryIndex.MemoryDocValuesIterator returns 2 document instead of 1
> ---
>
> Key: LUCENE-8055
> URL: https://issues.apache.org/jira/browse/LUCENE-8055
> Project: Lucene - Core
>  Issue Type: Bug
>  Components: modules/other
>Reporter: Simon Willnauer
>Assignee: Simon Willnauer
> Fix For: master (8.0), 7.2, 7.1.1
>
> Attachments: LUCENE-8055.patch
>
>
> It there is a DV field in the MemoryIndex the 
> `MemoryIndex.MemoryDocValuesIterator` will return 2 documents instead of 1. 
> Simple off by one error and no tests. I have a patch ready for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org