[jira] [Commented] (LUCENE-8117) advanceExact does not work on sorted numeric dvs with Lucene54DocValuesProducer
[ https://issues.apache.org/jira/browse/LUCENE-8117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312993#comment-16312993 ] ASF subversion and git services commented on LUCENE-8117: - Commit 420461337070b3316634e5ac16a5b65cc99e8f87 in lucene-solr's branch refs/heads/branch_7_2 from [~jimczi] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4204613 ] LUCENE-8117: Fix advanceExact on SortedNumericDocValues produced by Lucene54DocValues. > advanceExact does not work on sorted numeric dvs with > Lucene54DocValuesProducer > > > Key: LUCENE-8117 > URL: https://issues.apache.org/jira/browse/LUCENE-8117 > Project: Lucene - Core > Issue Type: Bug >Affects Versions: 7.2 >Reporter: Jim Ferenczi > Fix For: 7.3, 7.2.1 > > Attachments: LUCENE-8117.patch > > > DocValues are iterators now so old doc values (produced with > Lucene54DocValues) also implements advance and advanceExact. Though sorted > numerics produced by Lucene54DocValues are not working as expected when > advanceExact is used. > In such case, the docValueCount is as expected but the values returned by the > iterator for the document are invalid. This is due to a bug in the > implementation of advanceExact in the producer that does not set the offset > of the current doc when the function is used. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8117) advanceExact does not work on sorted numeric dvs with Lucene54DocValuesProducer
[ https://issues.apache.org/jira/browse/LUCENE-8117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312991#comment-16312991 ] ASF subversion and git services commented on LUCENE-8117: - Commit 0b417545774e7b0a93aaab16ece0d50836b729d9 in lucene-solr's branch refs/heads/branch_7x from [~jimczi] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0b41754 ] LUCENE-8117: Fix advanceExact on SortedNumericDocValues produced by Lucene54DocValues. > advanceExact does not work on sorted numeric dvs with > Lucene54DocValuesProducer > > > Key: LUCENE-8117 > URL: https://issues.apache.org/jira/browse/LUCENE-8117 > Project: Lucene - Core > Issue Type: Bug >Affects Versions: 7.2 >Reporter: Jim Ferenczi > Attachments: LUCENE-8117.patch > > > DocValues are iterators now so old doc values (produced with > Lucene54DocValues) also implements advance and advanceExact. Though sorted > numerics produced by Lucene54DocValues are not working as expected when > advanceExact is used. > In such case, the docValueCount is as expected but the values returned by the > iterator for the document are invalid. This is due to a bug in the > implementation of advanceExact in the producer that does not set the offset > of the current doc when the function is used. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8117) advanceExact does not work on sorted numeric dvs with Lucene54DocValuesProducer
[ https://issues.apache.org/jira/browse/LUCENE-8117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311874#comment-16311874 ] Adrien Grand commented on LUCENE-8117: -- +1 patch looks good, great catch! I see we had some tests in CheckIndex for advanceExact, but they only check whether the return value is expected, not whether we then produce the expected values. Probably something we should look into beefing up, I'm now wondering some other codecs could have similar issues. > advanceExact does not work on sorted numeric dvs with > Lucene54DocValuesProducer > > > Key: LUCENE-8117 > URL: https://issues.apache.org/jira/browse/LUCENE-8117 > Project: Lucene - Core > Issue Type: Bug >Affects Versions: 7.2 >Reporter: Jim Ferenczi > Attachments: LUCENE-8117.patch > > > DocValues are iterators now so old doc values (produced with > Lucene54DocValues) also implements advance and advanceExact. Though sorted > numerics produced by Lucene54DocValues are not working as expected when > advanceExact is used. > In such case, the docValueCount is as expected but the values returned by the > iterator for the document are invalid. This is due to a bug in the > implementation of advanceExact in the producer that does not set the offset > of the current doc when the function is used. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8117) advanceExact does not work on sorted numeric dvs with Lucene54DocValuesProducer
[ https://issues.apache.org/jira/browse/LUCENE-8117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311836#comment-16311836 ] Jim Ferenczi commented on LUCENE-8117: -- This issue is only on 7x (where advanceExact has been added) since it is not possible to use an index with Lucene54DocValuesProducer in 8x. > advanceExact does not work on sorted numeric dvs with > Lucene54DocValuesProducer > > > Key: LUCENE-8117 > URL: https://issues.apache.org/jira/browse/LUCENE-8117 > Project: Lucene - Core > Issue Type: Bug >Affects Versions: 7.2 >Reporter: Jim Ferenczi > Attachments: LUCENE-8117.patch > > > DocValues are iterators now so old doc values (produced with > Lucene54DocValues) also implements advance and advanceExact. Though sorted > numerics produced by Lucene54DocValues are not working as expected when > advanceExact is used. > In such case, the docValueCount is as expected but the values returned by the > iterator for the document are invalid. This is due to a bug in the > implementation of advanceExact in the producer that does not set the offset > of the current doc when the function is used. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
