[jira] [Commented] (LUCENE-8314) AssertingScorer should check that scores are needed when advanceShallow and getMaxScore are called

2018-05-16 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/LUCENE-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477639#comment-16477639
 ] 

ASF subversion and git services commented on LUCENE-8314:
-

Commit 6d69824a6b3637ff1586d1dcc8fe60335ae04063 in lucene-solr's branch 
refs/heads/master from [~jpountz]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6d69824 ]

LUCENE-8314: More checks on AssertingScorer.


> AssertingScorer should check that scores are needed when advanceShallow and 
> getMaxScore are called
> --
>
> Key: LUCENE-8314
> URL: https://issues.apache.org/jira/browse/LUCENE-8314
> Project: Lucene - Core
>  Issue Type: Improvement
>Reporter: Adrien Grand
>Priority: Major
> Attachments: LUCENE-8314.patch
>
>
> We already do this for score().



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (LUCENE-8314) AssertingScorer should check that scores are needed when advanceShallow and getMaxScore are called

2018-05-16 Thread Adrien Grand (JIRA)

[ 
https://issues.apache.org/jira/browse/LUCENE-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477024#comment-16477024
 ] 

Adrien Grand commented on LUCENE-8314:
--

Here is a patch.

> AssertingScorer should check that scores are needed when advanceShallow and 
> getMaxScore are called
> --
>
> Key: LUCENE-8314
> URL: https://issues.apache.org/jira/browse/LUCENE-8314
> Project: Lucene - Core
>  Issue Type: Improvement
>Reporter: Adrien Grand
>Priority: Major
> Attachments: LUCENE-8314.patch
>
>
> We already do this for score().



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org