[jira] [Commented] (LUCENE-8324) Unreferenced files of dropped segments should be released
[
https://issues.apache.org/jira/browse/LUCENE-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492689#comment-16492689
]
ASF subversion and git services commented on LUCENE-8324:
-
Commit 9a560563d8f8fb68e71ddba313f974b8bc345643 in lucene-solr's branch
refs/heads/branch_7x from [~jpountz]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9a56056 ]
LUCENE-8324: Make test pass with ExtraFS.
> Unreferenced files of dropped segments should be released
> -
>
> Key: LUCENE-8324
> URL: https://issues.apache.org/jira/browse/LUCENE-8324
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/index
>Affects Versions: 7.4, master (8.0)
>Reporter: Nhat Nguyen
>Priority: Major
> Attachments: LUCENE-8324.patch, release-files.patch
>
>
> {quote} This has the side-effect that flushed segments that are 100% hard
> deleted are also
> cleaned up right after they are flushed, previously these segments were
> sticking
> around for a while until they got picked for a merge or received another
> delete.{quote}
>
> Since LUCENE-8253, a fully deleted segment is dropped immediately when it's
> flushed, however, its files might be kept around even after a commit. In
> other words, we may have unreferenced files which are retained by Deleter.
> I am not entirely sure if we should fix this but it's nice to have a
> consistent content between current files and commit points as before.
> I attached a failed test for this.
> /cc [~simonw]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8324) Unreferenced files of dropped segments should be released
[
https://issues.apache.org/jira/browse/LUCENE-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492690#comment-16492690
]
ASF subversion and git services commented on LUCENE-8324:
-
Commit f8ae144054b67cc65be655e5fb95391cfab26362 in lucene-solr's branch
refs/heads/master from [~jpountz]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f8ae144 ]
LUCENE-8324: Make test pass with ExtraFS.
> Unreferenced files of dropped segments should be released
> -
>
> Key: LUCENE-8324
> URL: https://issues.apache.org/jira/browse/LUCENE-8324
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/index
>Affects Versions: 7.4, master (8.0)
>Reporter: Nhat Nguyen
>Priority: Major
> Attachments: LUCENE-8324.patch, release-files.patch
>
>
> {quote} This has the side-effect that flushed segments that are 100% hard
> deleted are also
> cleaned up right after they are flushed, previously these segments were
> sticking
> around for a while until they got picked for a merge or received another
> delete.{quote}
>
> Since LUCENE-8253, a fully deleted segment is dropped immediately when it's
> flushed, however, its files might be kept around even after a commit. In
> other words, we may have unreferenced files which are retained by Deleter.
> I am not entirely sure if we should fix this but it's nice to have a
> consistent content between current files and commit points as before.
> I attached a failed test for this.
> /cc [~simonw]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8324) Unreferenced files of dropped segments should be released
[
https://issues.apache.org/jira/browse/LUCENE-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486755#comment-16486755
]
ASF subversion and git services commented on LUCENE-8324:
-
Commit 3ed9f98ed8083716e24bf0aa5d72138da2d8b518 in lucene-solr's branch
refs/heads/branch_7x from [~simonw]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3ed9f98 ]
LUCENE-8324: Fix test to exclude the write.lock in expected files
> Unreferenced files of dropped segments should be released
> -
>
> Key: LUCENE-8324
> URL: https://issues.apache.org/jira/browse/LUCENE-8324
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/index
>Affects Versions: 7.4, master (8.0)
>Reporter: Nhat Nguyen
>Priority: Major
> Attachments: LUCENE-8324.patch, release-files.patch
>
>
> {quote} This has the side-effect that flushed segments that are 100% hard
> deleted are also
> cleaned up right after they are flushed, previously these segments were
> sticking
> around for a while until they got picked for a merge or received another
> delete.{quote}
>
> Since LUCENE-8253, a fully deleted segment is dropped immediately when it's
> flushed, however, its files might be kept around even after a commit. In
> other words, we may have unreferenced files which are retained by Deleter.
> I am not entirely sure if we should fix this but it's nice to have a
> consistent content between current files and commit points as before.
> I attached a failed test for this.
> /cc [~simonw]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8324) Unreferenced files of dropped segments should be released
[
https://issues.apache.org/jira/browse/LUCENE-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486753#comment-16486753
]
ASF subversion and git services commented on LUCENE-8324:
-
Commit 14a7cd1159bacec38fc1efc8a772f3fbd2abc6ed in lucene-solr's branch
refs/heads/master from [~simonw]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=14a7cd1 ]
LUCENE-8324: Fix test to exclude the write.lock in expected files
> Unreferenced files of dropped segments should be released
> -
>
> Key: LUCENE-8324
> URL: https://issues.apache.org/jira/browse/LUCENE-8324
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/index
>Affects Versions: 7.4, master (8.0)
>Reporter: Nhat Nguyen
>Priority: Major
> Attachments: LUCENE-8324.patch, release-files.patch
>
>
> {quote} This has the side-effect that flushed segments that are 100% hard
> deleted are also
> cleaned up right after they are flushed, previously these segments were
> sticking
> around for a while until they got picked for a merge or received another
> delete.{quote}
>
> Since LUCENE-8253, a fully deleted segment is dropped immediately when it's
> flushed, however, its files might be kept around even after a commit. In
> other words, we may have unreferenced files which are retained by Deleter.
> I am not entirely sure if we should fix this but it's nice to have a
> consistent content between current files and commit points as before.
> I attached a failed test for this.
> /cc [~simonw]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8324) Unreferenced files of dropped segments should be released
[
https://issues.apache.org/jira/browse/LUCENE-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483044#comment-16483044
]
Nhat Nguyen commented on LUCENE-8324:
-
Thanks [~simonw] and [~mikemccand]
> Unreferenced files of dropped segments should be released
> -
>
> Key: LUCENE-8324
> URL: https://issues.apache.org/jira/browse/LUCENE-8324
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/index
>Affects Versions: 7.4, master (8.0)
>Reporter: Nhat Nguyen
>Priority: Major
> Attachments: LUCENE-8324.patch, release-files.patch
>
>
> {quote} This has the side-effect that flushed segments that are 100% hard
> deleted are also
> cleaned up right after they are flushed, previously these segments were
> sticking
> around for a while until they got picked for a merge or received another
> delete.{quote}
>
> Since LUCENE-8253, a fully deleted segment is dropped immediately when it's
> flushed, however, its files might be kept around even after a commit. In
> other words, we may have unreferenced files which are retained by Deleter.
> I am not entirely sure if we should fix this but it's nice to have a
> consistent content between current files and commit points as before.
> I attached a failed test for this.
> /cc [~simonw]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8324) Unreferenced files of dropped segments should be released
[
https://issues.apache.org/jira/browse/LUCENE-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482885#comment-16482885
]
ASF subversion and git services commented on LUCENE-8324:
-
Commit 2ce53791d3205efff5eb12d0d24911b3ea31abe3 in lucene-solr's branch
refs/heads/master from [~simonw]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2ce5379 ]
LUCENE-8324: Checkpoint after fully deletes segment is dropped on flush
> Unreferenced files of dropped segments should be released
> -
>
> Key: LUCENE-8324
> URL: https://issues.apache.org/jira/browse/LUCENE-8324
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/index
>Affects Versions: 7.4, master (8.0)
>Reporter: Nhat Nguyen
>Priority: Major
> Attachments: LUCENE-8324.patch, release-files.patch
>
>
> {quote} This has the side-effect that flushed segments that are 100% hard
> deleted are also
> cleaned up right after they are flushed, previously these segments were
> sticking
> around for a while until they got picked for a merge or received another
> delete.{quote}
>
> Since LUCENE-8253, a fully deleted segment is dropped immediately when it's
> flushed, however, its files might be kept around even after a commit. In
> other words, we may have unreferenced files which are retained by Deleter.
> I am not entirely sure if we should fix this but it's nice to have a
> consistent content between current files and commit points as before.
> I attached a failed test for this.
> /cc [~simonw]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8324) Unreferenced files of dropped segments should be released
[
https://issues.apache.org/jira/browse/LUCENE-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482874#comment-16482874
]
ASF subversion and git services commented on LUCENE-8324:
-
Commit cc2ee2305001a49536886653d2133ee1a3b51b82 in lucene-solr's branch
refs/heads/branch_7x from [~simonw]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cc2ee23 ]
LUCENE-8324: Checkpoint after fully deletes segment is dropped on flush
> Unreferenced files of dropped segments should be released
> -
>
> Key: LUCENE-8324
> URL: https://issues.apache.org/jira/browse/LUCENE-8324
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/index
>Affects Versions: 7.4, master (8.0)
>Reporter: Nhat Nguyen
>Priority: Major
> Attachments: LUCENE-8324.patch, release-files.patch
>
>
> {quote} This has the side-effect that flushed segments that are 100% hard
> deleted are also
> cleaned up right after they are flushed, previously these segments were
> sticking
> around for a while until they got picked for a merge or received another
> delete.{quote}
>
> Since LUCENE-8253, a fully deleted segment is dropped immediately when it's
> flushed, however, its files might be kept around even after a commit. In
> other words, we may have unreferenced files which are retained by Deleter.
> I am not entirely sure if we should fix this but it's nice to have a
> consistent content between current files and commit points as before.
> I attached a failed test for this.
> /cc [~simonw]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8324) Unreferenced files of dropped segments should be released
[
https://issues.apache.org/jira/browse/LUCENE-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482797#comment-16482797
]
Michael McCandless commented on LUCENE-8324:
+1
> Unreferenced files of dropped segments should be released
> -
>
> Key: LUCENE-8324
> URL: https://issues.apache.org/jira/browse/LUCENE-8324
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/index
>Affects Versions: 7.4, master (8.0)
>Reporter: Nhat Nguyen
>Priority: Major
> Attachments: LUCENE-8324.patch, release-files.patch
>
>
> {quote} This has the side-effect that flushed segments that are 100% hard
> deleted are also
> cleaned up right after they are flushed, previously these segments were
> sticking
> around for a while until they got picked for a merge or received another
> delete.{quote}
>
> Since LUCENE-8253, a fully deleted segment is dropped immediately when it's
> flushed, however, its files might be kept around even after a commit. In
> other words, we may have unreferenced files which are retained by Deleter.
> I am not entirely sure if we should fix this but it's nice to have a
> consistent content between current files and commit points as before.
> I attached a failed test for this.
> /cc [~simonw]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8324) Unreferenced files of dropped segments should be released
[
https://issues.apache.org/jira/browse/LUCENE-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481941#comment-16481941
]
Simon Willnauer commented on LUCENE-8324:
-
[~dnhatn] good catch. there was a checkpoint missing. I mean it's not a massive
issue but we should do it for correctness. It's also a testing lag we are
filling here now.
> Unreferenced files of dropped segments should be released
> -
>
> Key: LUCENE-8324
> URL: https://issues.apache.org/jira/browse/LUCENE-8324
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/index
>Affects Versions: 7.4, master (8.0)
>Reporter: Nhat Nguyen
>Priority: Major
> Attachments: LUCENE-8324.patch, release-files.patch
>
>
> {quote} This has the side-effect that flushed segments that are 100% hard
> deleted are also
> cleaned up right after they are flushed, previously these segments were
> sticking
> around for a while until they got picked for a merge or received another
> delete.{quote}
>
> Since LUCENE-8253, a fully deleted segment is dropped immediately when it's
> flushed, however, its files might be kept around even after a commit. In
> other words, we may have unreferenced files which are retained by Deleter.
> I am not entirely sure if we should fix this but it's nice to have a
> consistent content between current files and commit points as before.
> I attached a failed test for this.
> /cc [~simonw]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8324) Unreferenced files of dropped segments should be released
[
https://issues.apache.org/jira/browse/LUCENE-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481828#comment-16481828
]
Nhat Nguyen commented on LUCENE-8324:
-
[~simonw] Here are steps to reproduce:
1. Index some docs then flush an uncommitted segment
2. Make a fully deleted segment: index a doc then delete it
3. Flush (not commit) the second segment - this segment should be dropped
4. Commit
I think we should release the dropped segment in either step 3 or step 4.
> Unreferenced files of dropped segments should be released
> -
>
> Key: LUCENE-8324
> URL: https://issues.apache.org/jira/browse/LUCENE-8324
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/index
>Affects Versions: 7.4, master (8.0)
>Reporter: Nhat Nguyen
>Priority: Major
> Attachments: release-files.patch
>
>
> {quote} This has the side-effect that flushed segments that are 100% hard
> deleted are also
> cleaned up right after they are flushed, previously these segments were
> sticking
> around for a while until they got picked for a merge or received another
> delete.{quote}
>
> Since LUCENE-8253, a fully deleted segment is dropped immediately when it's
> flushed, however, its files might be kept around even after a commit. In
> other words, we may have unreferenced files which are retained by Deleter.
> I am not entirely sure if we should fix this but it's nice to have a
> consistent content between current files and commit points as before.
> I attached a failed test for this.
> /cc [~simonw]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
