[jira] [Commented] (LUCENE-8535) Should we drop support for highlighting block-join queries
[ https://issues.apache.org/jira/browse/LUCENE-8535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658727#comment-16658727 ] ASF subversion and git services commented on LUCENE-8535: - Commit 5a4fd86cce57586dd14fb8f11f9b170b121eebc4 in lucene-solr's branch refs/heads/jira/http2 from [~simonw] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5a4fd86 ] LUCENE-8535: Drop out of the box Block-Join highlight support Highlighter doesn't support ToParent and ToChildBlockJoinQuery out of the box anymore. In oder to highlight on Block-Join Queries a custom WeightedSpanTermExtractor should be used. > Should we drop support for highlighting block-join queries > -- > > Key: LUCENE-8535 > URL: https://issues.apache.org/jira/browse/LUCENE-8535 > Project: Lucene - Core > Issue Type: Improvement >Affects Versions: master (8.0) >Reporter: Simon Willnauer >Priority: Major > Fix For: master (8.0) > > Time Spent: 50m > Remaining Estimate: 0h > > This is a spin-off from LUCENE-6572. We currently depend on the block-join > module which is due to the fact that we try to highlight the queries wrapped > by the block join queries. The current discussion on LUCENE-6572 mentioned > that this doesn't make much sense from an highlighting perspecitve and if we > should drop support for it. Lucene 8.0 would be a good time to do so. > Thoughts? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8535) Should we drop support for highlighting block-join queries
[ https://issues.apache.org/jira/browse/LUCENE-8535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655192#comment-16655192 ] ASF subversion and git services commented on LUCENE-8535: - Commit 5a4fd86cce57586dd14fb8f11f9b170b121eebc4 in lucene-solr's branch refs/heads/master from [~simonw] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5a4fd86 ] LUCENE-8535: Drop out of the box Block-Join highlight support Highlighter doesn't support ToParent and ToChildBlockJoinQuery out of the box anymore. In oder to highlight on Block-Join Queries a custom WeightedSpanTermExtractor should be used. > Should we drop support for highlighting block-join queries > -- > > Key: LUCENE-8535 > URL: https://issues.apache.org/jira/browse/LUCENE-8535 > Project: Lucene - Core > Issue Type: Improvement >Affects Versions: master (8.0) >Reporter: Simon Willnauer >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > This is a spin-off from LUCENE-6572. We currently depend on the block-join > module which is due to the fact that we try to highlight the queries wrapped > by the block join queries. The current discussion on LUCENE-6572 mentioned > that this doesn't make much sense from an highlighting perspecitve and if we > should drop support for it. Lucene 8.0 would be a good time to do so. > Thoughts? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
