[jira] [Commented] (LUCENE-8588) Replace usage of deprecated RAMOutputStream
[
https://issues.apache.org/jira/browse/LUCENE-8588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708780#comment-16708780
]
Shai Erera commented on LUCENE-8588:
[~dweiss] thanks for pointing that out. I will not commit that change then. I
pushed a commit that closes the DirReader in the test and one that fixes a
typo. Thanks!
> Replace usage of deprecated RAMOutputStream
> ---
>
> Key: LUCENE-8588
> URL: https://issues.apache.org/jira/browse/LUCENE-8588
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
>Reporter: Shai Erera
>Assignee: Shai Erera
>Priority: Trivial
> Attachments: LUCENE-8588.patch
>
>
> While reviewing code in {{FrozenBufferedUpdates}} I noticed that it uses the
> deprecated {{RAMOutputStream}}. This issue fixes it. Separately we should
> reduce the usage of that class, so that we can really remove it.
>
> Besides that, while running tests I hit a test failure which at first I
> thought was related to this change, but then noticed that the test doesn't
> close the DirectoryReader (I run tests on Windows), so that fix is included
> in this patch too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8588) Replace usage of deprecated RAMOutputStream
[
https://issues.apache.org/jira/browse/LUCENE-8588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708574#comment-16708574
]
Dawid Weiss commented on LUCENE-8588:
-
Link to the parent issue that removes all RAMDirectory cruft across the
codebase. I have a branch for this, it'll create conflicts if you remove some
bits separately.
> Replace usage of deprecated RAMOutputStream
> ---
>
> Key: LUCENE-8588
> URL: https://issues.apache.org/jira/browse/LUCENE-8588
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
>Reporter: Shai Erera
>Assignee: Shai Erera
>Priority: Trivial
> Attachments: LUCENE-8588.patch
>
>
> While reviewing code in {{FrozenBufferedUpdates}} I noticed that it uses the
> deprecated {{RAMOutputStream}}. This issue fixes it. Separately we should
> reduce the usage of that class, so that we can really remove it.
>
> Besides that, while running tests I hit a test failure which at first I
> thought was related to this change, but then noticed that the test doesn't
> close the DirectoryReader (I run tests on Windows), so that fix is included
> in this patch too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8588) Replace usage of deprecated RAMOutputStream
[
https://issues.apache.org/jira/browse/LUCENE-8588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708572#comment-16708572
]
Dawid Weiss commented on LUCENE-8588:
-
Hi Shai, please don't remove it yet. There's a bulk issue that removes all
usages of Ram*Stream and RAMDirectory all across the codebase. The consensus
was that we don't do it until 8.x is cut. I'll link the original issue where
this is discussed.
> Replace usage of deprecated RAMOutputStream
> ---
>
> Key: LUCENE-8588
> URL: https://issues.apache.org/jira/browse/LUCENE-8588
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
>Reporter: Shai Erera
>Assignee: Shai Erera
>Priority: Trivial
> Attachments: LUCENE-8588.patch
>
>
> While reviewing code in {{FrozenBufferedUpdates}} I noticed that it uses the
> deprecated {{RAMOutputStream}}. This issue fixes it. Separately we should
> reduce the usage of that class, so that we can really remove it.
>
> Besides that, while running tests I hit a test failure which at first I
> thought was related to this change, but then noticed that the test doesn't
> close the DirectoryReader (I run tests on Windows), so that fix is included
> in this patch too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
