[jira] [Commented] (LUCENE-8638) Remove deprecated code in master
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925655#comment-16925655 ] David Smiley commented on LUCENE-8638: -- The branch doesn't pass precommit now because javadocs in LuceneTestCase refer to the getBaseTempDirForTestClass you removed. > Remove deprecated code in master > > > Key: LUCENE-8638 > URL: https://issues.apache.org/jira/browse/LUCENE-8638 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward >Priority: Major > Fix For: master (9.0) > > > There are a number of deprecations in master that should be removed. This > issue is to keep track of deprecations as a whole, some individual > deprecations may require their own issues. > > Work on this issue should be pushed to the `master-deprecations` branch on > gitbox -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8638) Remove deprecated code in master
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763915#comment-16763915 ] Nikolay Khitrin commented on LUCENE-8638: - [~romseygeek], I've tried to remove JavaCC generated deprecations by ant regexps as a part of backporting current code changes to ant javacc tasks (LUCENE-8684 for deprecations, LUCENE-8683 for backports). It isn't best way to do it, but there is a lot of ant-based replacements in generated code already present in our build files. > Remove deprecated code in master > > > Key: LUCENE-8638 > URL: https://issues.apache.org/jira/browse/LUCENE-8638 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward >Priority: Major > Fix For: master (9.0) > > > There are a number of deprecations in master that should be removed. This > issue is to keep track of deprecations as a whole, some individual > deprecations may require their own issues. > > Work on this issue should be pushed to the `master-deprecations` branch on > gitbox -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8638) Remove deprecated code in master
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759646#comment-16759646 ] David Smiley commented on LUCENE-8638: -- I'm confused about the master/9.0 fix-version; shouldn't we be getting rid of deprecations for the benefit of 8.0? There were deprecated before 8.0 after all. > Remove deprecated code in master > > > Key: LUCENE-8638 > URL: https://issues.apache.org/jira/browse/LUCENE-8638 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward >Priority: Major > Fix For: master (9.0) > > > There are a number of deprecations in master that should be removed. This > issue is to keep track of deprecations as a whole, some individual > deprecations may require their own issues. > > Work on this issue should be pushed to the `master-deprecations` branch on > gitbox -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8638) Remove deprecated code in master
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750983#comment-16750983 ] Alan Woodward commented on LUCENE-8638: --- I opened LUCENE-8657 for deprecations in CharsRef > Remove deprecated code in master > > > Key: LUCENE-8638 > URL: https://issues.apache.org/jira/browse/LUCENE-8638 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward >Priority: Major > Fix For: master (9.0) > > > There are a number of deprecations in master that should be removed. This > issue is to keep track of deprecations as a whole, some individual > deprecations may require their own issues. > > Work on this issue should be pushed to the `master-deprecations` branch on > gitbox -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8638) Remove deprecated code in master
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750191#comment-16750191 ] Alan Woodward commented on LUCENE-8638: --- I opened LUCENE-8656 for deprecations in FuzzyQuery > Remove deprecated code in master > > > Key: LUCENE-8638 > URL: https://issues.apache.org/jira/browse/LUCENE-8638 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward >Priority: Major > Fix For: master (9.0) > > > There are a number of deprecations in master that should be removed. This > issue is to keep track of deprecations as a whole, some individual > deprecations may require their own issues. > > Work on this issue should be pushed to the `master-deprecations` branch on > gitbox -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8638) Remove deprecated code in master
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742996#comment-16742996 ] Dawid Weiss commented on LUCENE-8638: - I'll do that. I'm testing the first batch of removals and changes. If it passes, I'll commit to master. > Remove deprecated code in master > > > Key: LUCENE-8638 > URL: https://issues.apache.org/jira/browse/LUCENE-8638 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward >Priority: Major > Fix For: master (9.0) > > > There are a number of deprecations in master that should be removed. This > issue is to keep track of deprecations as a whole, some individual > deprecations may require their own issues. > > Work on this issue should be pushed to the `master-deprecations` branch on > gitbox -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8638) Remove deprecated code in master
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742986#comment-16742986 ] Alan Woodward commented on LUCENE-8638: --- Let's commit it to master separately and let CI work on it. I'll periodically merge master back into this deprecations branch anyway to keep things up-to-date. > Remove deprecated code in master > > > Key: LUCENE-8638 > URL: https://issues.apache.org/jira/browse/LUCENE-8638 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward >Priority: Major > Fix For: master (9.0) > > > There are a number of deprecations in master that should be removed. This > issue is to keep track of deprecations as a whole, some individual > deprecations may require their own issues. > > Work on this issue should be pushed to the `master-deprecations` branch on > gitbox -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8638) Remove deprecated code in master
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742982#comment-16742982 ] Dawid Weiss commented on LUCENE-8638: - I'm working on RAMDirectory deprecations. It's a large patch. Do we want to put some ordering to it so that people don't get too many collisions? I have it on a private branch and could commit to master today. > Remove deprecated code in master > > > Key: LUCENE-8638 > URL: https://issues.apache.org/jira/browse/LUCENE-8638 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward >Priority: Major > Fix For: master (9.0) > > > There are a number of deprecations in master that should be removed. This > issue is to keep track of deprecations as a whole, some individual > deprecations may require their own issues. > > Work on this issue should be pushed to the `master-deprecations` branch on > gitbox -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8638) Remove deprecated code in master
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742970#comment-16742970 ] Alan Woodward commented on LUCENE-8638: --- Of the deprecations that I haven't removed from the branch yet: * WordDelimiterFilter, SynonymFilter, JaspellLookup and LegacyBM25Similarity are all referred to from Solr, so we can deal with those in the related Solr issue * [~dweiss] was planning on dealing with the RAMDirectory deprecations, I think? * FuzzyQuery changed from taking a float to taking an int a long time ago, but queryparsers still allow floats to be passed in and use the deprecated conversion methods. This probably needs its own issue as I think we'll need some separate deprecations in the various queryparsers to properly remove this. * CharsRef has a deprecated Comparator which is still used in a couple of places. The equivalent BytesRef comparator was removed in LUCENE-7053, so we may be able to just get rid of this and use CharsRef.compareTo(), but I want more eyes on it to be sure - pinging [~thetaphi] and [~rcmuir ] for input on this one. * The Memory Codec still has a bunch of bridging code between the old random-access docvalues implementation and the newer iterative API. This should be simple enough to rewrite, but I vaguely remember some discussion about removing it entirely so I want to double check we want to keep this code before I spend any time refactoring it. * ClasspathResourceLoader has a deprecated constructor using the ThreadContext classloader. This was deprecated in LUCENE-7883 but it's still used in a couple of places, so I'd like some input from [~thetaphi] as to what it should be replaced with * FixBrokenOffsetsFilter was added as a stopgap to help cut over token filters that potentially produce backwards offsets. We don't have any filters in core or analysis that require this any more, so the question is do we leave it in to help the writers of custom token filters, or do we remove it and tell people not to write broken code? > Remove deprecated code in master > > > Key: LUCENE-8638 > URL: https://issues.apache.org/jira/browse/LUCENE-8638 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward >Priority: Major > Fix For: master (9.0) > > > There are a number of deprecations in master that should be removed. This > issue is to keep track of deprecations as a whole, some individual > deprecations may require their own issues. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8638) Remove deprecated code in master
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742958#comment-16742958 ] Alan Woodward commented on LUCENE-8638: --- The following files contain deprecated methods or classes. We can strike them off as they are fixed and pushed to the `master-deprecations` branch. lucene/analysis/common/src/java/org/apache/lucene/analysis/synonym/SynonymFilter.java:110:@Deprecated lucene/analysis/common/src/java/org/apache/lucene/analysis/synonym/SynonymFilterFactory.java:82:@Deprecated lucene/analysis/common/src/java/org/apache/lucene/analysis/util/FilesystemResourceLoader.java:55: @Deprecated lucene/analysis/common/src/java/org/apache/lucene/analysis/util/ClasspathResourceLoader.java:44: @Deprecated lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/FixBrokenOffsetsFilter.java:31:@Deprecated lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/WordDelimiterFilter.java:95:@Deprecated lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/WordDelimiterFilterFactory.java:58:@Deprecated lucene/codecs/src/java/org/apache/lucene/codecs/memory/LegacyBinaryDocValues.java:28:@Deprecated lucene/codecs/src/java/org/apache/lucene/codecs/memory/LegacySortedSetDocValues.java:36:@Deprecated lucene/codecs/src/java/org/apache/lucene/codecs/memory/LegacyNumericDocValuesWrapper.java:30:@Deprecated lucene/codecs/src/java/org/apache/lucene/codecs/memory/LegacySortedNumericDocValuesWrapper.java:29:@Deprecated lucene/codecs/src/java/org/apache/lucene/codecs/memory/LegacyDocValuesIterables.java:47: @Deprecated lucene/codecs/src/java/org/apache/lucene/codecs/memory/LegacyDocValuesIterables.java:76: @Deprecated lucene/codecs/src/java/org/apache/lucene/codecs/memory/LegacyDocValuesIterables.java:105: @Deprecated lucene/codecs/src/java/org/apache/lucene/codecs/memory/LegacyDocValuesIterables.java:152: @Deprecated lucene/codecs/src/java/org/apache/lucene/codecs/memory/LegacyDocValuesIterables.java:207: @Deprecated lucene/codecs/src/java/org/apache/lucene/codecs/memory/LegacyDocValuesIterables.java:271: @Deprecated lucene/codecs/src/java/org/apache/lucene/codecs/memory/LegacyDocValuesIterables.java:319: @Deprecated lucene/codecs/src/java/org/apache/lucene/codecs/memory/LegacyDocValuesIterables.java:383: @Deprecated lucene/codecs/src/java/org/apache/lucene/codecs/memory/LegacyDocValuesIterables.java:438: @Deprecated lucene/codecs/src/java/org/apache/lucene/codecs/memory/LegacyDocValuesIterables.java:489: @Deprecated lucene/codecs/src/java/org/apache/lucene/codecs/memory/LegacySortedSetDocValuesWrapper.java:30:@Deprecated lucene/codecs/src/java/org/apache/lucene/codecs/memory/LegacySortedNumericDocValues.java:27:@Deprecated lucene/codecs/src/java/org/apache/lucene/codecs/memory/LegacySortedDocValues.java:34:@Deprecated lucene/codecs/src/java/org/apache/lucene/codecs/memory/LegacyBinaryDocValuesWrapper.java:31:@Deprecated lucene/codecs/src/java/org/apache/lucene/codecs/memory/LegacySortedDocValuesWrapper.java:30:@Deprecated lucene/codecs/src/java/org/apache/lucene/codecs/memory/LegacyNumericDocValues.java:26:@Deprecated -lucene/core/src/test/org/apache/lucene/analysis/TestToken.java:31:@Deprecated- - undeprecated and moved to test-framework tests -lucene/core/src/java/org/apache/lucene/util/SloppyMath.java:75: @Deprecated- -lucene/core/src/java/org/apache/lucene/util/IOUtils.java:426: @Deprecated- -lucene/core/src/java/org/apache/lucene/util/IOUtils.java:438: @Deprecated- lucene/core/src/java/org/apache/lucene/util/CharsRef.java:145: @Deprecated lucene/core/src/java/org/apache/lucene/util/CharsRef.java:149: @Deprecated lucene/core/src/java/org/apache/lucene/util/CharsRef.java:155: @Deprecated -lucene/core/src/java/org/apache/lucene/util/Version.java:39: @Deprecated- -lucene/core/src/java/org/apache/lucene/util/Version.java:75: @Deprecated- -lucene/core/src/java/org/apache/lucene/util/Constants.java:96: @Deprecated- -lucene/core/src/java/org/apache/lucene/util/Constants.java:103: @Deprecated- lucene/core/src/java/org/apache/lucene/search/FuzzyQuery.java:217: @Deprecated lucene/core/src/java/org/apache/lucene/search/FuzzyQuery.java:229: @Deprecated lucene/core/src/java/org/apache/lucene/store/RAMOutputStream.java:37:@Deprecated lucene/core/src/java/org/apache/lucene/store/RAMInputStream.java:33:@Deprecated lucene/core/src/java/org/apache/lucene/store/RAMDirectory.java:57:@Deprecated lucene/core/src/java/org/apache/lucene/store/RAMFile.java:33:@Deprecated -lucene/expressions/src/java/org/apache/lucene/expressions/js/JavascriptParser.java:43: @Deprecated- -lucene/expressions/src/java/org/apache/lucene/expressions/js/JavascriptParser.java:60: @Deprecated- -lucene/expressions/src/java/org/apache/lucene/expressions/js/JavascriptLexer.java:50: @Deprecated-
