[jira] [Commented] (LUCENE-8758) Class Field levelN is not populated correctly in QuadPrefixTree
[ https://issues.apache.org/jira/browse/LUCENE-8758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919588#comment-16919588 ] ASF subversion and git services commented on LUCENE-8758: - Commit f3b2358bc73b688341920d1753aecc39e6a9494a in lucene-solr's branch refs/heads/branch_8x from Amish Shah [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=f3b2358 ] LUCENE-8758 Remove unused fields in QuadPrefixTree (cherry picked from commit ea67d9c8c65c6c883ef2ebb3c061fcc6b251a360) > Class Field levelN is not populated correctly in QuadPrefixTree > --- > > Key: LUCENE-8758 > URL: https://issues.apache.org/jira/browse/LUCENE-8758 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial-extras >Affects Versions: 4.0, 5.0, 6.0, 7.0, 8.0 >Reporter: Dominic Page >Assignee: David Smiley >Priority: Trivial > Labels: beginner > Fix For: 8.x > > Attachments: LUCENE-8758.patch > > > QuadPrefixTree in Lucene prepopulates these arrays: > {{levelW = new double[maxLevels];}} > {{levelH = new double[maxLevels];}} > {{*levelS = new int[maxLevels];*}} > {{*levelN = new int[maxLevels];*}} > Like this > {{for (int i = 1; i < levelW.length; i++) {}} > {{ levelW[i] = levelW[i - 1] / 2.0;}} > {{ levelH[i] = levelH[i - 1] / 2.0;}} > {{ *levelS[i] = levelS[i - 1] * 2;*}} > {{ *levelN[i] = levelN[i - 1] * 4;*}} > {{}}} > The field > {{levelN[]}} > overflows after level 14 = 1073741824 where maxLevels is limited to > {{MAX_LEVELS_POSSIBLE = 50;}} > The field levelN appears not to be used anywhere. Likewise, the field > {{levelS[] }} > is only used in the > {{printInfo}} > method. I would propose either to remove both > {{levelN[],}}{{levelS[]}} > or to change the datatype > {{levelN = new long[maxLevels];}} -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8758) Class Field levelN is not populated correctly in QuadPrefixTree
[ https://issues.apache.org/jira/browse/LUCENE-8758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919581#comment-16919581 ] ASF subversion and git services commented on LUCENE-8758: - Commit ea67d9c8c65c6c883ef2ebb3c061fcc6b251a360 in lucene-solr's branch refs/heads/master from Amish Shah [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=ea67d9c ] LUCENE-8758 Remove unused fields in QuadPrefixTree > Class Field levelN is not populated correctly in QuadPrefixTree > --- > > Key: LUCENE-8758 > URL: https://issues.apache.org/jira/browse/LUCENE-8758 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial-extras >Affects Versions: 4.0, 5.0, 6.0, 7.0, 8.0 >Reporter: Dominic Page >Assignee: David Smiley >Priority: Trivial > Labels: beginner > Fix For: 8.x > > Attachments: LUCENE-8758.patch > > > QuadPrefixTree in Lucene prepopulates these arrays: > {{levelW = new double[maxLevels];}} > {{levelH = new double[maxLevels];}} > {{*levelS = new int[maxLevels];*}} > {{*levelN = new int[maxLevels];*}} > Like this > {{for (int i = 1; i < levelW.length; i++) {}} > {{ levelW[i] = levelW[i - 1] / 2.0;}} > {{ levelH[i] = levelH[i - 1] / 2.0;}} > {{ *levelS[i] = levelS[i - 1] * 2;*}} > {{ *levelN[i] = levelN[i - 1] * 4;*}} > {{}}} > The field > {{levelN[]}} > overflows after level 14 = 1073741824 where maxLevels is limited to > {{MAX_LEVELS_POSSIBLE = 50;}} > The field levelN appears not to be used anywhere. Likewise, the field > {{levelS[] }} > is only used in the > {{printInfo}} > method. I would propose either to remove both > {{levelN[],}}{{levelS[]}} > or to change the datatype > {{levelN = new long[maxLevels];}} -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8758) Class Field levelN is not populated correctly in QuadPrefixTree
[ https://issues.apache.org/jira/browse/LUCENE-8758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918958#comment-16918958 ] Lucene/Solr QA commented on LUCENE-8758: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 42s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green} 0m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Check forbidden APIs {color} | {color:green} 0m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Validate source patterns {color} | {color:green} 0m 35s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 18s{color} | {color:green} spatial-extras in the patch passed. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 5m 14s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | LUCENE-8758 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12978887/LUCENE-8758.patch | | Optional Tests | compile javac unit ratsources checkforbiddenapis validatesourcepatterns | | uname | Linux lucene1-us-west 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | ant | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh | | git revision | master / 6dea678439 | | ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 | | Default Java | LTS | | Test Results | https://builds.apache.org/job/PreCommit-LUCENE-Build/203/testReport/ | | modules | C: lucene/spatial-extras U: lucene/spatial-extras | | Console output | https://builds.apache.org/job/PreCommit-LUCENE-Build/203/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > Class Field levelN is not populated correctly in QuadPrefixTree > --- > > Key: LUCENE-8758 > URL: https://issues.apache.org/jira/browse/LUCENE-8758 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial-extras >Affects Versions: 4.0, 5.0, 6.0, 7.0, 8.0 >Reporter: Dominic Page >Assignee: David Smiley >Priority: Trivial > Labels: beginner > Fix For: 8.x > > Attachments: LUCENE-8758.patch > > > QuadPrefixTree in Lucene prepopulates these arrays: > {{levelW = new double[maxLevels];}} > {{levelH = new double[maxLevels];}} > {{*levelS = new int[maxLevels];*}} > {{*levelN = new int[maxLevels];*}} > Like this > {{for (int i = 1; i < levelW.length; i++) {}} > {{ levelW[i] = levelW[i - 1] / 2.0;}} > {{ levelH[i] = levelH[i - 1] / 2.0;}} > {{ *levelS[i] = levelS[i - 1] * 2;*}} > {{ *levelN[i] = levelN[i - 1] * 4;*}} > {{}}} > The field > {{levelN[]}} > overflows after level 14 = 1073741824 where maxLevels is limited to > {{MAX_LEVELS_POSSIBLE = 50;}} > The field levelN appears not to be used anywhere. Likewise, the field > {{levelS[] }} > is only used in the > {{printInfo}} > method. I would propose either to remove both > {{levelN[],}}{{levelS[]}} > or to change the datatype > {{levelN = new long[maxLevels];}} -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8758) Class Field levelN is not populated correctly in QuadPrefixTree
[ https://issues.apache.org/jira/browse/LUCENE-8758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918554#comment-16918554 ] Amish Shah commented on LUCENE-8758: [^LUCENE-8758.patch] Here is the patch that removes the levelN and levelS fields from QuadPrefixTree. Please review and let me know if I need to make any changes. Thanks! > Class Field levelN is not populated correctly in QuadPrefixTree > --- > > Key: LUCENE-8758 > URL: https://issues.apache.org/jira/browse/LUCENE-8758 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial-extras >Affects Versions: 4.0, 5.0, 6.0, 7.0, 8.0 >Reporter: Dominic Page >Priority: Trivial > Labels: beginner > Fix For: 8.x > > Attachments: LUCENE-8758.patch > > > QuadPrefixTree in Lucene prepopulates these arrays: > {{levelW = new double[maxLevels];}} > {{levelH = new double[maxLevels];}} > {{*levelS = new int[maxLevels];*}} > {{*levelN = new int[maxLevels];*}} > Like this > {{for (int i = 1; i < levelW.length; i++) {}} > {{ levelW[i] = levelW[i - 1] / 2.0;}} > {{ levelH[i] = levelH[i - 1] / 2.0;}} > {{ *levelS[i] = levelS[i - 1] * 2;*}} > {{ *levelN[i] = levelN[i - 1] * 4;*}} > {{}}} > The field > {{levelN[]}} > overflows after level 14 = 1073741824 where maxLevels is limited to > {{MAX_LEVELS_POSSIBLE = 50;}} > The field levelN appears not to be used anywhere. Likewise, the field > {{levelS[] }} > is only used in the > {{printInfo}} > method. I would propose either to remove both > {{levelN[],}}{{levelS[]}} > or to change the datatype > {{levelN = new long[maxLevels];}} -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8758) Class Field levelN is not populated correctly in QuadPrefixTree
[ https://issues.apache.org/jira/browse/LUCENE-8758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915422#comment-16915422 ] David Smiley commented on LUCENE-8758: -- Go for it! > Class Field levelN is not populated correctly in QuadPrefixTree > --- > > Key: LUCENE-8758 > URL: https://issues.apache.org/jira/browse/LUCENE-8758 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial-extras >Affects Versions: 4.0, 5.0, 6.0, 7.0, 8.0 >Reporter: Dominic Page >Priority: Trivial > Labels: beginner > Fix For: 8.x > > > QuadPrefixTree in Lucene prepopulates these arrays: > {{levelW = new double[maxLevels];}} > {{levelH = new double[maxLevels];}} > {{*levelS = new int[maxLevels];*}} > {{*levelN = new int[maxLevels];*}} > Like this > {{for (int i = 1; i < levelW.length; i++) {}} > {{ levelW[i] = levelW[i - 1] / 2.0;}} > {{ levelH[i] = levelH[i - 1] / 2.0;}} > {{ *levelS[i] = levelS[i - 1] * 2;*}} > {{ *levelN[i] = levelN[i - 1] * 4;*}} > {{}}} > The field > {{levelN[]}} > overflows after level 14 = 1073741824 where maxLevels is limited to > {{MAX_LEVELS_POSSIBLE = 50;}} > The field levelN appears not to be used anywhere. Likewise, the field > {{levelS[] }} > is only used in the > {{printInfo}} > method. I would propose either to remove both > {{levelN[],}}{{levelS[]}} > or to change the datatype > {{levelN = new long[maxLevels];}} -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8758) Class Field levelN is not populated correctly in QuadPrefixTree
[ https://issues.apache.org/jira/browse/LUCENE-8758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915276#comment-16915276 ] Amish Shah commented on LUCENE-8758: Hi, can I take a shot at this? > Class Field levelN is not populated correctly in QuadPrefixTree > --- > > Key: LUCENE-8758 > URL: https://issues.apache.org/jira/browse/LUCENE-8758 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial-extras >Affects Versions: 4.0, 5.0, 6.0, 7.0, 8.0 >Reporter: Dominic Page >Priority: Trivial > Labels: beginner > Fix For: 8.x > > > QuadPrefixTree in Lucene prepopulates these arrays: > {{levelW = new double[maxLevels];}} > {{levelH = new double[maxLevels];}} > {{*levelS = new int[maxLevels];*}} > {{*levelN = new int[maxLevels];*}} > Like this > {{for (int i = 1; i < levelW.length; i++) {}} > {{ levelW[i] = levelW[i - 1] / 2.0;}} > {{ levelH[i] = levelH[i - 1] / 2.0;}} > {{ *levelS[i] = levelS[i - 1] * 2;*}} > {{ *levelN[i] = levelN[i - 1] * 4;*}} > {{}}} > The field > {{levelN[]}} > overflows after level 14 = 1073741824 where maxLevels is limited to > {{MAX_LEVELS_POSSIBLE = 50;}} > The field levelN appears not to be used anywhere. Likewise, the field > {{levelS[] }} > is only used in the > {{printInfo}} > method. I would propose either to remove both > {{levelN[],}}{{levelS[]}} > or to change the datatype > {{levelN = new long[maxLevels];}} -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8758) Class Field levelN is not populated correctly in QuadPrefixTree
[ https://issues.apache.org/jira/browse/LUCENE-8758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815114#comment-16815114 ] Ignacio Vera commented on LUCENE-8758: -- +1 to remove those arrays. They do not seem to be used and their content is buggy. That info can be deducted from the level anyway. > Class Field levelN is not populated correctly in QuadPrefixTree > --- > > Key: LUCENE-8758 > URL: https://issues.apache.org/jira/browse/LUCENE-8758 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial-extras >Affects Versions: 4.0, 5.0, 6.0, 7.0, 8.0 >Reporter: Dominic Page >Priority: Trivial > Labels: beginner > Fix For: 8.x > > > QuadPrefixTree in Lucene prepopulates these arrays: > {{levelW = new double[maxLevels];}} > {{levelH = new double[maxLevels];}} > {{*levelS = new int[maxLevels];*}} > {{*levelN = new int[maxLevels];*}} > Like this > {{for (int i = 1; i < levelW.length; i++) {}} > {{ levelW[i] = levelW[i - 1] / 2.0;}} > {{ levelH[i] = levelH[i - 1] / 2.0;}} > {{ *levelS[i] = levelS[i - 1] * 2;*}} > {{ *levelN[i] = levelN[i - 1] * 4;*}} > {{}}} > The field > {{levelN[]}} > overflows after level 14 = 1073741824 where maxLevels is limited to > {{MAX_LEVELS_POSSIBLE = 50;}} > The field levelN appears not to be used anywhere. Likewise, the field > {{levelS[] }} > is only used in the > {{printInfo}} > method. I would propose either to remove both > {{levelN[],}}{{levelS[]}} > or to change the datatype > {{levelN = new long[maxLevels];}} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org