[jira] [Commented] (LUCENE-8844) Bump FST Version (to 7)
[ https://issues.apache.org/jira/browse/LUCENE-8844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861358#comment-16861358 ] David Smiley commented on LUCENE-8844: -- I think you can mark this issue Resolved & Fixed for 8.2. > Bump FST Version (to 7) > --- > > Key: LUCENE-8844 > URL: https://issues.apache.org/jira/browse/LUCENE-8844 > Project: Lucene - Core > Issue Type: Bug >Reporter: Mike Sokolov >Assignee: Mike Sokolov >Priority: Major > > In LUCENE-8781, we changed the FST encoding but did not bump the version > number we write in its header. The change was backwards-compatible (new > readers can still read old FSTs), but not forwards-compatible: older readers > would exhibit strange behavior if they attempted to read one of these newer > format FSTs. > It would be much better if readers could catch such errors and notify in a > sensible way, and we have version checking that does that; we just need to > increase the VERSION_CURRENT constant. > Also, ~[~dsmiley] points out the CHANGES.txt entries for LUCENE-8781 should > be moved to the 8.2.0 section since that change was backported. I think we > can clean that up at the same time since it's version-related. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8844) Bump FST Version (to 7)
[ https://issues.apache.org/jira/browse/LUCENE-8844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859260#comment-16859260 ] ASF subversion and git services commented on LUCENE-8844: - Commit e85c6e6429956aade155eb29aee7adc3f79e4bc6 in lucene-solr's branch refs/heads/master from Michael Sokolov [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=e85c6e6 ] LUCENE-8844: bump FST version and fix related CHANGES entry > Bump FST Version (to 7) > --- > > Key: LUCENE-8844 > URL: https://issues.apache.org/jira/browse/LUCENE-8844 > Project: Lucene - Core > Issue Type: Bug >Reporter: Mike Sokolov >Assignee: Mike Sokolov >Priority: Major > > In LUCENE-8781, we changed the FST encoding but did not bump the version > number we write in its header. The change was backwards-compatible (new > readers can still read old FSTs), but not forwards-compatible: older readers > would exhibit strange behavior if they attempted to read one of these newer > format FSTs. > It would be much better if readers could catch such errors and notify in a > sensible way, and we have version checking that does that; we just need to > increase the VERSION_CURRENT constant. > Also, ~[~dsmiley] points out the CHANGES.txt entries for LUCENE-8781 should > be moved to the 8.2.0 section since that change was backported. I think we > can clean that up at the same time since it's version-related. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8844) Bump FST Version (to 7)
[ https://issues.apache.org/jira/browse/LUCENE-8844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859229#comment-16859229 ] ASF subversion and git services commented on LUCENE-8844: - Commit a8478c790aeb888e165670b3329188d3d5290ffd in lucene-solr's branch refs/heads/branch_8x from Michael Sokolov [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=a8478c7 ] LUCENE-8844: bump FST version and fix related CHANGES entry > Bump FST Version (to 7) > --- > > Key: LUCENE-8844 > URL: https://issues.apache.org/jira/browse/LUCENE-8844 > Project: Lucene - Core > Issue Type: Bug >Reporter: Mike Sokolov >Assignee: Mike Sokolov >Priority: Major > > In LUCENE-8781, we changed the FST encoding but did not bump the version > number we write in its header. The change was backwards-compatible (new > readers can still read old FSTs), but not forwards-compatible: older readers > would exhibit strange behavior if they attempted to read one of these newer > format FSTs. > It would be much better if readers could catch such errors and notify in a > sensible way, and we have version checking that does that; we just need to > increase the VERSION_CURRENT constant. > Also, ~[~dsmiley] points out the CHANGES.txt entries for LUCENE-8781 should > be moved to the 8.2.0 section since that change was backported. I think we > can clean that up at the same time since it's version-related. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
