[jira] [Commented] (LUCENE-8894) Add APIs to tokenizer/charfilter/tokenfilter factories to get their SPI names from concrete classes
[
https://issues.apache.org/jira/browse/LUCENE-8894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16886041#comment-16886041
]
Tomoko Uchida commented on LUCENE-8894:
---
Hi [~ivera],
thanks for caring that, the changes for LUCENE-8874, LUCENE-8894, and
LUCENE-8778 should be moved to under Lucene 8.3.0. The branch_8x's CHANGES.txt
is correct.
Seems the Lucene 8.3.0 section does not exist yet in the master branch, so I
just delay editing that for now.
> Add APIs to tokenizer/charfilter/tokenfilter factories to get their SPI names
> from concrete classes
> ---
>
> Key: LUCENE-8894
> URL: https://issues.apache.org/jira/browse/LUCENE-8894
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
>Reporter: Tomoko Uchida
>Assignee: Tomoko Uchida
>Priority: Minor
> Fix For: master (9.0), 8.2
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently, reflection tricks are needed to obtain SPI name (this is now
> stored in static NAME fields in each factory class) from a concrete factory
> class. While it is easy to implement that logic, it would be much better to
> provide unified APIs to get SPI name from a factory class. In other words,
> the APIs would provide "inverse" operation of {{lookupClass(String)}} method.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8894) Add APIs to tokenizer/charfilter/tokenfilter factories to get their SPI names from concrete classes
[
https://issues.apache.org/jira/browse/LUCENE-8894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16886022#comment-16886022
]
Ignacio Vera commented on LUCENE-8894:
--
In master the entry in CHANGES.txt is in Lucene 9.0.0 bit from branch_8x the
entry is under Lucene 8.3.0, is that correct?
> Add APIs to tokenizer/charfilter/tokenfilter factories to get their SPI names
> from concrete classes
> ---
>
> Key: LUCENE-8894
> URL: https://issues.apache.org/jira/browse/LUCENE-8894
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
>Reporter: Tomoko Uchida
>Assignee: Tomoko Uchida
>Priority: Minor
> Fix For: master (9.0), 8.2
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently, reflection tricks are needed to obtain SPI name (this is now
> stored in static NAME fields in each factory class) from a concrete factory
> class. While it is easy to implement that logic, it would be much better to
> provide unified APIs to get SPI name from a factory class. In other words,
> the APIs would provide "inverse" operation of {{lookupClass(String)}} method.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8894) Add APIs to tokenizer/charfilter/tokenfilter factories to get their SPI names from concrete classes
[
https://issues.apache.org/jira/browse/LUCENE-8894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875638#comment-16875638
]
ASF subversion and git services commented on LUCENE-8894:
-
Commit 7e05bd717309088d3b35cba6be0f70fd14b3c8d0 in lucene-solr's branch
refs/heads/branch_8x from Tomoko Uchida
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=7e05bd7 ]
LUCENE-8894: Add APIs to tokenizer/charfilter/tokenfilter factories to get
their SPI names from concrete classes
> Add APIs to tokenizer/charfilter/tokenfilter factories to get their SPI names
> from concrete classes
> ---
>
> Key: LUCENE-8894
> URL: https://issues.apache.org/jira/browse/LUCENE-8894
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
>Reporter: Tomoko Uchida
>Assignee: Tomoko Uchida
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, reflection tricks are needed to obtain SPI name (this is now
> stored in static NAME fields in each factory class) from a concrete factory
> class. While it is easy to implement that logic, it would be much better to
> provide unified APIs to get SPI name from a factory class. In other words,
> the APIs would provide "inverse" operation of {{lookupClass(String)}} method.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8894) Add APIs to tokenizer/charfilter/tokenfilter factories to get their SPI names from concrete classes
[
https://issues.apache.org/jira/browse/LUCENE-8894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875637#comment-16875637
]
ASF subversion and git services commented on LUCENE-8894:
-
Commit 7ac77ce4418c06d01af97663230b00c1b4b44d22 in lucene-solr's branch
refs/heads/master from Tomoko Uchida
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=7ac77ce ]
LUCENE-8894: Add APIs to tokenizer/charfilter/tokenfilter factories to get
their SPI names from concrete classes
> Add APIs to tokenizer/charfilter/tokenfilter factories to get their SPI names
> from concrete classes
> ---
>
> Key: LUCENE-8894
> URL: https://issues.apache.org/jira/browse/LUCENE-8894
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
>Reporter: Tomoko Uchida
>Assignee: Tomoko Uchida
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, reflection tricks are needed to obtain SPI name (this is now
> stored in static NAME fields in each factory class) from a concrete factory
> class. While it is easy to implement that logic, it would be much better to
> provide unified APIs to get SPI name from a factory class. In other words,
> the APIs would provide "inverse" operation of {{lookupClass(String)}} method.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8894) Add APIs to tokenizer/charfilter/tokenfilter factories to get their SPI names from concrete classes
[
https://issues.apache.org/jira/browse/LUCENE-8894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875428#comment-16875428
]
Tomoko Uchida commented on LUCENE-8894:
---
I've opened a pull request for this issue.
I think it's a trivial change - move the SPI name lookup logic to
{{AbstractAnalysisFactory}} from {{AnalysisSPILoader}} and call it from
{{TokenizerFactory}}, {{CharFilterFactory}}, and {{TokenFilterFactory}}. I will
commit it to the ASF repo's master and branch_8x in a few days if there are no
comments or objections.
> Add APIs to tokenizer/charfilter/tokenfilter factories to get their SPI names
> from concrete classes
> ---
>
> Key: LUCENE-8894
> URL: https://issues.apache.org/jira/browse/LUCENE-8894
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
>Reporter: Tomoko Uchida
>Assignee: Tomoko Uchida
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, reflection tricks are needed to obtain SPI name (this is now
> stored in static NAME fields in each factory class) from a concrete factory
> class. While it is easy to implement that logic, it would be much better to
> provide unified APIs to get SPI name from a factory class. In other words,
> the APIs would provide "inverse" operation of {{lookupClass(String)}} method.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
