[jira] [Commented] (LUCENE-8938) Replace try-fail-catch test patterns
[
https://issues.apache.org/jira/browse/LUCENE-8938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895460#comment-16895460
]
ASF subversion and git services commented on LUCENE-8938:
-
Commit b82d345e2831a805bd0027289199d4e5935fa7c4 in lucene-solr's branch
refs/heads/branch_8x from Munendra S N
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=b82d345 ]
LUCENE-8938: use expectThrows() to verify the ex thrown in tests
> Replace try-fail-catch test patterns
>
>
> Key: LUCENE-8938
> URL: https://issues.apache.org/jira/browse/LUCENE-8938
> Project: Lucene - Core
> Issue Type: Test
>Reporter: Munendra S N
>Assignee: Munendra S N
>Priority: Major
> Attachments: LUCENE-8938.patch
>
>
> Replace try-fail-catch test patterns with {{expectThrows}} wherever possible.
> This is spawned from SOLR-12555
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8938) Replace try-fail-catch test patterns
[
https://issues.apache.org/jira/browse/LUCENE-8938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895453#comment-16895453
]
ASF subversion and git services commented on LUCENE-8938:
-
Commit 70a8deb0abedd42aec86b10a8da2676737853514 in lucene-solr's branch
refs/heads/master from Munendra S N
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=70a8deb ]
LUCENE-8938: use expectThrows() to verify the ex thrown in tests
> Replace try-fail-catch test patterns
>
>
> Key: LUCENE-8938
> URL: https://issues.apache.org/jira/browse/LUCENE-8938
> Project: Lucene - Core
> Issue Type: Test
>Reporter: Munendra S N
>Assignee: Munendra S N
>Priority: Major
> Attachments: LUCENE-8938.patch
>
>
> Replace try-fail-catch test patterns with {{expectThrows}} wherever possible.
> This is spawned from SOLR-12555
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8938) Replace try-fail-catch test patterns
[
https://issues.apache.org/jira/browse/LUCENE-8938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895439#comment-16895439
]
Lucene/Solr QA commented on LUCENE-8938:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 24 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
34s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 0m 39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 0m 39s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 5m
15s{color} | {color:green} common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 16m
34s{color} | {color:green} core in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
38s{color} | {color:green} join in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
28s{color} | {color:green} queryparser in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
29s{color} | {color:green} replicator in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
14s{color} | {color:green} sandbox in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
17s{color} | {color:green} suggest in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
4s{color} | {color:green} test-framework in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 38m 10s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | LUCENE-8938 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12976090/LUCENE-8938.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / b8289abeeb |
| ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 |
| Default Java | LTS |
| Test Results |
https://builds.apache.org/job/PreCommit-LUCENE-Build/200/testReport/ |
| modules | C: lucene/analysis/common lucene/core lucene/join
lucene/queryparser lucene/replicator lucene/sandbox lucene/suggest
lucene/test-framework U: lucene |
| Console output |
https://builds.apache.org/job/PreCommit-LUCENE-Build/200/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Replace try-fail-catch test patterns
>
>
> Key: LUCENE-8938
> URL: https://issues.apache.org/jira/browse/LUCENE-8938
> Project: Lucene - Core
> Issue Type: Test
>Reporter: Munendra S N
>Assignee: Munendra S N
>Priority: Major
> Attachments: LUCENE-8938.patch
>
>
> Replace try-fail-catch test patterns with {{expectThrows}} wherever possible.
> This is spawned from SOLR-12555
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8938) Replace try-fail-catch test patterns
[
https://issues.apache.org/jira/browse/LUCENE-8938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894962#comment-16894962
]
Munendra S N commented on LUCENE-8938:
--
[^LUCENE-8938.patch]
I have used {{expectThrowsAnyof}} when multiple exceptions can be thrown
> Replace try-fail-catch test patterns
>
>
> Key: LUCENE-8938
> URL: https://issues.apache.org/jira/browse/LUCENE-8938
> Project: Lucene - Core
> Issue Type: Test
>Reporter: Munendra S N
>Assignee: Munendra S N
>Priority: Major
> Attachments: LUCENE-8938.patch
>
>
> Replace try-fail-catch test patterns with {{expectThrows}} wherever possible.
> This is spawned from SOLR-12555
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
