[jira] [Commented] (SOLR-10152) PostingsSolrHighlighter support for CustomSeparatorBreakIterator (LUCENE-6485)
[ https://issues.apache.org/jira/browse/SOLR-10152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891481#comment-15891481 ] ASF subversion and git services commented on SOLR-10152: Commit a607a2c6cfdeb191b3da4474e87d4242b1270fd1 in lucene-solr's branch refs/heads/branch_6x from [~dsmiley] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a607a2c ] SOLR-10153: (and SOLR-10152): UH & PH: Add hl.bs.type=SEPARATOR with new param hl.bs.separator (cherry picked from commit d1d73bf) > PostingsSolrHighlighter support for CustomSeparatorBreakIterator (LUCENE-6485) > -- > > Key: SOLR-10152 > URL: https://issues.apache.org/jira/browse/SOLR-10152 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: highlighter >Reporter: Amrit Sarkar > Attachments: SOLR-10152.patch > > > Lucene 5.3 added a CustomSeparatorBreakIterator (see LUCENE-6485) > SOLR-10152.patch uploaded which incorporates CustomSeparatorBreakIterator in > PostingsSolrHighlighter. > - added a new request param option to specify which separator char to use. > *customSeparatorChar*. > - changed PostingsSolrHighlighter.getBreakIterator to check > HighlightParams.BS_TYPE first. > - if type=='CUSTOM', look for the new separator param, in getBreakIterator, > validate it's a single char, & skip locale parsing. > - 'WHOLE' option moved from parseBreakIterator to getBreakIterator, as it > doesn't depend on locale. > Changes made in: > * HighlightParams.java > * PostingsSolrHighlighter.java > * test cases added in TestPostingsSolrHighlighter -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10152) PostingsSolrHighlighter support for CustomSeparatorBreakIterator (LUCENE-6485)
[ https://issues.apache.org/jira/browse/SOLR-10152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891478#comment-15891478 ] ASF subversion and git services commented on SOLR-10152: Commit d1d73bfbea3db4adead960fae3597bec7647fba6 in lucene-solr's branch refs/heads/master from [~dsmiley] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d1d73bf ] SOLR-10153: (and SOLR-10152): UH & PH: Add hl.bs.type=SEPARATOR with new param hl.bs.separator > PostingsSolrHighlighter support for CustomSeparatorBreakIterator (LUCENE-6485) > -- > > Key: SOLR-10152 > URL: https://issues.apache.org/jira/browse/SOLR-10152 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: highlighter >Reporter: Amrit Sarkar > Attachments: SOLR-10152.patch > > > Lucene 5.3 added a CustomSeparatorBreakIterator (see LUCENE-6485) > SOLR-10152.patch uploaded which incorporates CustomSeparatorBreakIterator in > PostingsSolrHighlighter. > - added a new request param option to specify which separator char to use. > *customSeparatorChar*. > - changed PostingsSolrHighlighter.getBreakIterator to check > HighlightParams.BS_TYPE first. > - if type=='CUSTOM', look for the new separator param, in getBreakIterator, > validate it's a single char, & skip locale parsing. > - 'WHOLE' option moved from parseBreakIterator to getBreakIterator, as it > doesn't depend on locale. > Changes made in: > * HighlightParams.java > * PostingsSolrHighlighter.java > * test cases added in TestPostingsSolrHighlighter -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10152) PostingsSolrHighlighter support for CustomSeparatorBreakIterator (LUCENE-6485)
[ https://issues.apache.org/jira/browse/SOLR-10152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15890240#comment-15890240 ] David Smiley commented on SOLR-10152: - Yes. (continue discussion on SOLR-1053 please). I'll commit both issues together. > PostingsSolrHighlighter support for CustomSeparatorBreakIterator (LUCENE-6485) > -- > > Key: SOLR-10152 > URL: https://issues.apache.org/jira/browse/SOLR-10152 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: highlighter >Reporter: Amrit Sarkar > Attachments: SOLR-10152.patch > > > Lucene 5.3 added a CustomSeparatorBreakIterator (see LUCENE-6485) > SOLR-10152.patch uploaded which incorporates CustomSeparatorBreakIterator in > PostingsSolrHighlighter. > - added a new request param option to specify which separator char to use. > *customSeparatorChar*. > - changed PostingsSolrHighlighter.getBreakIterator to check > HighlightParams.BS_TYPE first. > - if type=='CUSTOM', look for the new separator param, in getBreakIterator, > validate it's a single char, & skip locale parsing. > - 'WHOLE' option moved from parseBreakIterator to getBreakIterator, as it > doesn't depend on locale. > Changes made in: > * HighlightParams.java > * PostingsSolrHighlighter.java > * test cases added in TestPostingsSolrHighlighter -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10152) PostingsSolrHighlighter support for CustomSeparatorBreakIterator (LUCENE-6485)
[ https://issues.apache.org/jira/browse/SOLR-10152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889716#comment-15889716 ] Amrit Sarkar commented on SOLR-10152: - Just a follow up David, Are we planning to include this feature in near future? If not, can you let me know what portion needs improvement or the use-case is not that useful. > PostingsSolrHighlighter support for CustomSeparatorBreakIterator (LUCENE-6485) > -- > > Key: SOLR-10152 > URL: https://issues.apache.org/jira/browse/SOLR-10152 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: highlighter >Reporter: Amrit Sarkar > Attachments: SOLR-10152.patch > > > Lucene 5.3 added a CustomSeparatorBreakIterator (see LUCENE-6485) > SOLR-10152.patch uploaded which incorporates CustomSeparatorBreakIterator in > PostingsSolrHighlighter. > - added a new request param option to specify which separator char to use. > *customSeparatorChar*. > - changed PostingsSolrHighlighter.getBreakIterator to check > HighlightParams.BS_TYPE first. > - if type=='CUSTOM', look for the new separator param, in getBreakIterator, > validate it's a single char, & skip locale parsing. > - 'WHOLE' option moved from parseBreakIterator to getBreakIterator, as it > doesn't depend on locale. > Changes made in: > * HighlightParams.java > * PostingsSolrHighlighter.java > * test cases added in TestPostingsSolrHighlighter -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10152) PostingsSolrHighlighter support for CustomSeparatorBreakIterator (LUCENE-6485)
[ https://issues.apache.org/jira/browse/SOLR-10152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877522#comment-15877522 ] Amrit Sarkar commented on SOLR-10152: - Mr Smiley, The Former. It was really straightforward configuring CustomSeparatorBreakIterator in PostingsSolrHighlighter. I understand UnifiedSolrHighlighter is the most flexible one in terms of configuration compared to other three available( including the default). As PostingsSolrHighlighter is the ancestor, I thought it would be better if this particular configuration is also backported. I will let you and others in the community decide if it is. Thank you for your feedback. > PostingsSolrHighlighter support for CustomSeparatorBreakIterator (LUCENE-6485) > -- > > Key: SOLR-10152 > URL: https://issues.apache.org/jira/browse/SOLR-10152 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: highlighter >Reporter: Amrit Sarkar > Attachments: SOLR-10152.patch > > > Lucene 5.3 added a CustomSeparatorBreakIterator (see LUCENE-6485) > SOLR-10152.patch uploaded which incorporates CustomSeparatorBreakIterator in > PostingsSolrHighlighter. > - added a new request param option to specify which separator char to use. > *customSeparatorChar*. > - changed PostingsSolrHighlighter.getBreakIterator to check > HighlightParams.BS_TYPE first. > - if type=='CUSTOM', look for the new separator param, in getBreakIterator, > validate it's a single char, & skip locale parsing. > - 'WHOLE' option moved from parseBreakIterator to getBreakIterator, as it > doesn't depend on locale. > Changes made in: > * HighlightParams.java > * PostingsSolrHighlighter.java > * test cases added in TestPostingsSolrHighlighter -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10152) PostingsSolrHighlighter support for CustomSeparatorBreakIterator (LUCENE-6485)
[ https://issues.apache.org/jira/browse/SOLR-10152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877494#comment-15877494 ] David Smiley commented on SOLR-10152: - +1 looks fine. Did you contribute this simply because, after having done the UnifiedHighlighter, doing this was easy since it's almost the same code so might as well, or do you actually use the PostingsHighlighter over the UnifiedHighlighter? If the latter I'd like to hear how the UH isn't meeting your needs. The UnifiedHighlighter is essentially an evolved version of the PostingsHighlighter. > PostingsSolrHighlighter support for CustomSeparatorBreakIterator (LUCENE-6485) > -- > > Key: SOLR-10152 > URL: https://issues.apache.org/jira/browse/SOLR-10152 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: highlighter >Reporter: Amrit Sarkar > Attachments: SOLR-10152.patch > > > Lucene 5.3 added a CustomSeparatorBreakIterator (see LUCENE-6485) > SOLR-10152.patch uploaded which incorporates CustomSeparatorBreakIterator in > PostingsSolrHighlighter. > - added a new request param option to specify which separator char to use. > *customSeparatorChar*. > - changed PostingsSolrHighlighter.getBreakIterator to check > HighlightParams.BS_TYPE first. > - if type=='CUSTOM', look for the new separator param, in getBreakIterator, > validate it's a single char, & skip locale parsing. > - 'WHOLE' option moved from parseBreakIterator to getBreakIterator, as it > doesn't depend on locale. > Changes made in: > * HighlightParams.java > * PostingsSolrHighlighter.java > * test cases added in TestPostingsSolrHighlighter -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
