[jira] [Commented] (SOLR-10243) Fix TestExtractionDateUtil.testParseDate sporadic failures
[
https://issues.apache.org/jira/browse/SOLR-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555832#comment-16555832
]
ASF subversion and git services commented on SOLR-10243:
Commit 0d7b2f43623c0a7f8b9bf7e6f2b38f611c3bd607 in lucene-solr's branch
refs/heads/branch_7x from [~dsmiley]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0d7b2f4 ]
SOLR-10243: Apply @AwaitsFix on TestExtractionDateUtil.testParseDate to be
fixed by SOLR-12593
(cherry picked from commit 528e8bc)
> Fix TestExtractionDateUtil.testParseDate sporadic failures
> --
>
> Key: SOLR-10243
> URL: https://issues.apache.org/jira/browse/SOLR-10243
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - Solr Cell (Tika extraction)
>Reporter: David Smiley
>Assignee: David Smiley
>Priority: Minor
> Attachments: SimpleDateFormatTimeZoneBug.java
>
>
> Jenkins test failure:
> {{ant test -Dtestcase=TestExtractionDateUtil -Dtests.method=testParseDate
> -Dtests.seed=B72AC4792F31F74B -Dtests.slow=true -Dtests.locale=lv
> -Dtests.timezone=America/Metlakatla -Dtests.asserts=true
> -Dtests.file.encoding=UTF-8}} It reproduces on 6x for me but not master.
> I reviewed this briefly and there seems to be a locale assumption in the test.
> 1 tests failed.
> FAILED:
> org.apache.solr.handler.extraction.TestExtractionDateUtil.testParseDate
> Error Message:
> Incorrect parsed timestamp: 1226583351000 != 1226579751000 (Thu Nov 13
> 04:35:51 AKST 2008)
> Stack Trace:
> java.lang.AssertionError: Incorrect parsed timestamp: 1226583351000 !=
> 1226579751000 (Thu Nov 13 04:35:51 AKST 2008)
> at
> __randomizedtesting.SeedInfo.seed([B72AC4792F31F74B:FD33BC4C549880FE]:0)
> at org.junit.Assert.fail(Assert.java:93)
> at org.junit.Assert.assertTrue(Assert.java:43)
> at
> org.apache.solr.handler.extraction.TestExtractionDateUtil.assertParsedDate(TestExtractionDateUtil.java:59)
> at
> org.apache.solr.handler.extraction.TestExtractionDateUtil.testParseDate(TestExtractionDateUtil.java:54)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10243) Fix TestExtractionDateUtil.testParseDate sporadic failures
[
https://issues.apache.org/jira/browse/SOLR-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555814#comment-16555814
]
ASF subversion and git services commented on SOLR-10243:
Commit 528e8bceac2e1ffcba33b6eb630a52329b34756e in lucene-solr's branch
refs/heads/master from [~dsmiley]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=528e8bc ]
SOLR-10243: Apply @AwaitsFix on TestExtractionDateUtil.testParseDate to be
fixed by SOLR-12593
> Fix TestExtractionDateUtil.testParseDate sporadic failures
> --
>
> Key: SOLR-10243
> URL: https://issues.apache.org/jira/browse/SOLR-10243
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - Solr Cell (Tika extraction)
>Reporter: David Smiley
>Assignee: David Smiley
>Priority: Minor
> Attachments: SimpleDateFormatTimeZoneBug.java
>
>
> Jenkins test failure:
> {{ant test -Dtestcase=TestExtractionDateUtil -Dtests.method=testParseDate
> -Dtests.seed=B72AC4792F31F74B -Dtests.slow=true -Dtests.locale=lv
> -Dtests.timezone=America/Metlakatla -Dtests.asserts=true
> -Dtests.file.encoding=UTF-8}} It reproduces on 6x for me but not master.
> I reviewed this briefly and there seems to be a locale assumption in the test.
> 1 tests failed.
> FAILED:
> org.apache.solr.handler.extraction.TestExtractionDateUtil.testParseDate
> Error Message:
> Incorrect parsed timestamp: 1226583351000 != 1226579751000 (Thu Nov 13
> 04:35:51 AKST 2008)
> Stack Trace:
> java.lang.AssertionError: Incorrect parsed timestamp: 1226583351000 !=
> 1226579751000 (Thu Nov 13 04:35:51 AKST 2008)
> at
> __randomizedtesting.SeedInfo.seed([B72AC4792F31F74B:FD33BC4C549880FE]:0)
> at org.junit.Assert.fail(Assert.java:93)
> at org.junit.Assert.assertTrue(Assert.java:43)
> at
> org.apache.solr.handler.extraction.TestExtractionDateUtil.assertParsedDate(TestExtractionDateUtil.java:59)
> at
> org.apache.solr.handler.extraction.TestExtractionDateUtil.testParseDate(TestExtractionDateUtil.java:54)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10243) Fix TestExtractionDateUtil.testParseDate sporadic failures
[
https://issues.apache.org/jira/browse/SOLR-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548098#comment-16548098
]
David Smiley commented on SOLR-10243:
-
SOLR-12561 replaces the API, adds tests, and thus fixes the problem. If
SOLR-12561 doesn't land on 7x then I can mark this test method @Ignored for 7x.
> Fix TestExtractionDateUtil.testParseDate sporadic failures
> --
>
> Key: SOLR-10243
> URL: https://issues.apache.org/jira/browse/SOLR-10243
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - Solr Cell (Tika extraction)
>Reporter: David Smiley
>Assignee: David Smiley
>Priority: Minor
> Attachments: SimpleDateFormatTimeZoneBug.java
>
>
> Jenkins test failure:
> {{ant test -Dtestcase=TestExtractionDateUtil -Dtests.method=testParseDate
> -Dtests.seed=B72AC4792F31F74B -Dtests.slow=true -Dtests.locale=lv
> -Dtests.timezone=America/Metlakatla -Dtests.asserts=true
> -Dtests.file.encoding=UTF-8}} It reproduces on 6x for me but not master.
> I reviewed this briefly and there seems to be a locale assumption in the test.
> 1 tests failed.
> FAILED:
> org.apache.solr.handler.extraction.TestExtractionDateUtil.testParseDate
> Error Message:
> Incorrect parsed timestamp: 1226583351000 != 1226579751000 (Thu Nov 13
> 04:35:51 AKST 2008)
> Stack Trace:
> java.lang.AssertionError: Incorrect parsed timestamp: 1226583351000 !=
> 1226579751000 (Thu Nov 13 04:35:51 AKST 2008)
> at
> __randomizedtesting.SeedInfo.seed([B72AC4792F31F74B:FD33BC4C549880FE]:0)
> at org.junit.Assert.fail(Assert.java:93)
> at org.junit.Assert.assertTrue(Assert.java:43)
> at
> org.apache.solr.handler.extraction.TestExtractionDateUtil.assertParsedDate(TestExtractionDateUtil.java:59)
> at
> org.apache.solr.handler.extraction.TestExtractionDateUtil.testParseDate(TestExtractionDateUtil.java:54)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10243) Fix TestExtractionDateUtil.testParseDate sporadic failures
[
https://issues.apache.org/jira/browse/SOLR-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534147#comment-16534147
]
David Smiley commented on SOLR-10243:
-
The bug was accepted into the bug parade:
https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8206372
> Fix TestExtractionDateUtil.testParseDate sporadic failures
> --
>
> Key: SOLR-10243
> URL: https://issues.apache.org/jira/browse/SOLR-10243
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - Solr Cell (Tika extraction)
>Reporter: David Smiley
>Assignee: David Smiley
>Priority: Minor
> Attachments: SimpleDateFormatTimeZoneBug.java
>
>
> Jenkins test failure:
> {{ant test -Dtestcase=TestExtractionDateUtil -Dtests.method=testParseDate
> -Dtests.seed=B72AC4792F31F74B -Dtests.slow=true -Dtests.locale=lv
> -Dtests.timezone=America/Metlakatla -Dtests.asserts=true
> -Dtests.file.encoding=UTF-8}} It reproduces on 6x for me but not master.
> I reviewed this briefly and there seems to be a locale assumption in the test.
> 1 tests failed.
> FAILED:
> org.apache.solr.handler.extraction.TestExtractionDateUtil.testParseDate
> Error Message:
> Incorrect parsed timestamp: 1226583351000 != 1226579751000 (Thu Nov 13
> 04:35:51 AKST 2008)
> Stack Trace:
> java.lang.AssertionError: Incorrect parsed timestamp: 1226583351000 !=
> 1226579751000 (Thu Nov 13 04:35:51 AKST 2008)
> at
> __randomizedtesting.SeedInfo.seed([B72AC4792F31F74B:FD33BC4C549880FE]:0)
> at org.junit.Assert.fail(Assert.java:93)
> at org.junit.Assert.assertTrue(Assert.java:43)
> at
> org.apache.solr.handler.extraction.TestExtractionDateUtil.assertParsedDate(TestExtractionDateUtil.java:59)
> at
> org.apache.solr.handler.extraction.TestExtractionDateUtil.testParseDate(TestExtractionDateUtil.java:54)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10243) Fix TestExtractionDateUtil.testParseDate sporadic failures
[
https://issues.apache.org/jira/browse/SOLR-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526604#comment-16526604
]
David Smiley commented on SOLR-10243:
-
After spending the better part of a day debugging into the bowls of
SimpleDateFormat, I believe I found a JDK bug. I filled it to Oracle's Java bug
parade, which gave me internal review ID 9055824 and I'll be reached again in
the future after Oracle makes some decision on it. Here's the bug summary
description:
{quote}If SimpleDateFormat is configured with a pattern that allows for an
ambiguous timezone (like AKST in English Locale), and if that timezone is an
alias for the current platform/default timezone (such as America/Metlakatla),
then the input is parsed using the platform/default timezone. The objective of
many server Java applications is to be able to parse dates/times insensitive to
whatever the platform time zone may be but in this case it seems impossible.
My analysis using a debugger is that SimpleDateFormat line 1683 (of
subParseZoneString) contains what appears to be an optimization to avoid a
brute force time zone table lookup. This optimization is triggered when the
default time zone has a matching zone alias.
This bug was found in a randomized test for Apache Solr's "extraction" contrib
module: https://issues.apache.org/jira/browse/SOLR-10243
{quote}
I'll attach a demo source file that illustrates the problem.
w.r.t. Solr, I propose switching to the java.time API for this functionality.
> Fix TestExtractionDateUtil.testParseDate sporadic failures
> --
>
> Key: SOLR-10243
> URL: https://issues.apache.org/jira/browse/SOLR-10243
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: David Smiley
>Assignee: David Smiley
>Priority: Major
>
> Jenkins test failure:
> {{ant test -Dtestcase=TestExtractionDateUtil -Dtests.method=testParseDate
> -Dtests.seed=B72AC4792F31F74B -Dtests.slow=true -Dtests.locale=lv
> -Dtests.timezone=America/Metlakatla -Dtests.asserts=true
> -Dtests.file.encoding=UTF-8}} It reproduces on 6x for me but not master.
> I reviewed this briefly and there seems to be a locale assumption in the test.
> 1 tests failed.
> FAILED:
> org.apache.solr.handler.extraction.TestExtractionDateUtil.testParseDate
> Error Message:
> Incorrect parsed timestamp: 1226583351000 != 1226579751000 (Thu Nov 13
> 04:35:51 AKST 2008)
> Stack Trace:
> java.lang.AssertionError: Incorrect parsed timestamp: 1226583351000 !=
> 1226579751000 (Thu Nov 13 04:35:51 AKST 2008)
> at
> __randomizedtesting.SeedInfo.seed([B72AC4792F31F74B:FD33BC4C549880FE]:0)
> at org.junit.Assert.fail(Assert.java:93)
> at org.junit.Assert.assertTrue(Assert.java:43)
> at
> org.apache.solr.handler.extraction.TestExtractionDateUtil.assertParsedDate(TestExtractionDateUtil.java:59)
> at
> org.apache.solr.handler.extraction.TestExtractionDateUtil.testParseDate(TestExtractionDateUtil.java:54)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10243) Fix TestExtractionDateUtil.testParseDate sporadic failures
[
https://issues.apache.org/jira/browse/SOLR-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16460037#comment-16460037
]
Steve Rowe commented on SOLR-10243:
---
Another recent reproducing failure, from
[https://jenkins.thetaphi.de/job/Lucene-Solr-master-Solaris/1822/]:
{noformat}
Checking out Revision e3a98171744e25f446c3c6d5df41a3f65a54737c
(refs/remotes/origin/master)
[...]
[junit4] 2> NOTE: reproduce with: ant test
-Dtestcase=TestExtractionDateUtil -Dtests.method=testParseDate
-Dtests.seed=79065E512B0EB1FA -Dtests.slow=true -Dtests.locale=sk
-Dtests.timezone=America/Metlakatla -Dtests.asserts=true
-Dtests.file.encoding=UTF-8
[junit4] FAILURE 0.09s J1 | TestExtractionDateUtil.testParseDate <<<
[junit4]> Throwable #1: java.lang.AssertionError: Incorrect parsed
timestamp: 1226583351000 != 1226579751000 (Thu Nov 13 04:35:51 AKST 2008)
[junit4]>at
__randomizedtesting.SeedInfo.seed([79065E512B0EB1FA:331F266450A7C64F]:0)
[junit4]>at
org.apache.solr.handler.extraction.TestExtractionDateUtil.assertParsedDate(TestExtractionDateUtil.java:59)
[junit4]>at
org.apache.solr.handler.extraction.TestExtractionDateUtil.testParseDate(TestExtractionDateUtil.java:54)
[junit4]>at java.lang.Thread.run(Thread.java:748)
[junit4] 2> NOTE: test params are: codec=Asserting(Lucene70): {},
docValues:{}, maxPointsInLeafNode=1611, maxMBSortInHeap=6.381790188035722,
sim=Asserting(org.apache.lucene.search.similarities.AssertingSimilarity@10525726),
locale=sk, timezone=America/Metlakatla
[junit4] 2> NOTE: SunOS 5.11 amd64/Oracle Corporation 1.8.0_162
(64-bit)/cpus=3,threads=1,free=63548536,total=97320960
{noformat}
> Fix TestExtractionDateUtil.testParseDate sporadic failures
> --
>
> Key: SOLR-10243
> URL: https://issues.apache.org/jira/browse/SOLR-10243
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: David Smiley
>Priority: Major
>
> Jenkins test failure:
> {{ant test -Dtestcase=TestExtractionDateUtil -Dtests.method=testParseDate
> -Dtests.seed=B72AC4792F31F74B -Dtests.slow=true -Dtests.locale=lv
> -Dtests.timezone=America/Metlakatla -Dtests.asserts=true
> -Dtests.file.encoding=UTF-8}} It reproduces on 6x for me but not master.
> I reviewed this briefly and there seems to be a locale assumption in the test.
> 1 tests failed.
> FAILED:
> org.apache.solr.handler.extraction.TestExtractionDateUtil.testParseDate
> Error Message:
> Incorrect parsed timestamp: 1226583351000 != 1226579751000 (Thu Nov 13
> 04:35:51 AKST 2008)
> Stack Trace:
> java.lang.AssertionError: Incorrect parsed timestamp: 1226583351000 !=
> 1226579751000 (Thu Nov 13 04:35:51 AKST 2008)
> at
> __randomizedtesting.SeedInfo.seed([B72AC4792F31F74B:FD33BC4C549880FE]:0)
> at org.junit.Assert.fail(Assert.java:93)
> at org.junit.Assert.assertTrue(Assert.java:43)
> at
> org.apache.solr.handler.extraction.TestExtractionDateUtil.assertParsedDate(TestExtractionDateUtil.java:59)
> at
> org.apache.solr.handler.extraction.TestExtractionDateUtil.testParseDate(TestExtractionDateUtil.java:54)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10243) Fix TestExtractionDateUtil.testParseDate sporadic failures
[
https://issues.apache.org/jira/browse/SOLR-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280523#comment-16280523
]
Steve Rowe commented on SOLR-10243:
---
Another recent reproducing failure, from
[https://jenkins.thetaphi.de/job/Lucene-Solr-master-Windows/7039/]:
{noformat}
Checking out Revision ae9cc726a41d70c0b41b89e9fdcc11322cbe4599
(refs/remotes/origin/master)
[...]
[junit4] Suite: org.apache.solr.handler.extraction.TestExtractionDateUtil
[junit4] 2> NOTE: reproduce with: ant test
-Dtestcase=TestExtractionDateUtil -Dtests.method=testParseDate
-Dtests.seed=A656E57C0473E60B -Dtests.slow=true
-Dtests.locale=th-TH-u-nu-thai-x-lvariant-TH
-Dtests.timezone=America/Metlakatla -Dtests.asserts=true
-Dtests.file.encoding=ISO-8859-1
[junit4] FAILURE 0.03s J1 | TestExtractionDateUtil.testParseDate <<<
[junit4]> Throwable #1: java.lang.AssertionError: Incorrect parsed
timestamp: 1226583351000 != 1226579751000 (Thu Nov 13 04:35:51 AKST 2008)
[junit4]>at
__randomizedtesting.SeedInfo.seed([A656E57C0473E60B:EC4F9D497FDA91BE]:0)
[junit4]>at
org.apache.solr.handler.extraction.TestExtractionDateUtil.assertParsedDate(TestExtractionDateUtil.java:59)
[junit4]>at
org.apache.solr.handler.extraction.TestExtractionDateUtil.testParseDate(TestExtractionDateUtil.java:54)
[junit4]>at java.lang.Thread.run(Thread.java:748)
[junit4] 2> NOTE: test params are: codec=Asserting(Lucene70),
sim=Asserting(org.apache.lucene.search.similarities.AssertingSimilarity@1e107b8),
locale=th-TH-u-nu-thai-x-lvariant-TH, timezone=America/Metlakatla
[junit4] 2> NOTE: Windows 10 10.0 x86/Oracle Corporation 1.8.0_144
(32-bit)/cpus=3,threads=1,free=50406992,total=67108864
{noformat}
> Fix TestExtractionDateUtil.testParseDate sporadic failures
> --
>
> Key: SOLR-10243
> URL: https://issues.apache.org/jira/browse/SOLR-10243
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: David Smiley
>
> Jenkins test failure:
> {{ant test -Dtestcase=TestExtractionDateUtil -Dtests.method=testParseDate
> -Dtests.seed=B72AC4792F31F74B -Dtests.slow=true -Dtests.locale=lv
> -Dtests.timezone=America/Metlakatla -Dtests.asserts=true
> -Dtests.file.encoding=UTF-8}} It reproduces on 6x for me but not master.
> I reviewed this briefly and there seems to be a locale assumption in the test.
> 1 tests failed.
> FAILED:
> org.apache.solr.handler.extraction.TestExtractionDateUtil.testParseDate
> Error Message:
> Incorrect parsed timestamp: 1226583351000 != 1226579751000 (Thu Nov 13
> 04:35:51 AKST 2008)
> Stack Trace:
> java.lang.AssertionError: Incorrect parsed timestamp: 1226583351000 !=
> 1226579751000 (Thu Nov 13 04:35:51 AKST 2008)
> at
> __randomizedtesting.SeedInfo.seed([B72AC4792F31F74B:FD33BC4C549880FE]:0)
> at org.junit.Assert.fail(Assert.java:93)
> at org.junit.Assert.assertTrue(Assert.java:43)
> at
> org.apache.solr.handler.extraction.TestExtractionDateUtil.assertParsedDate(TestExtractionDateUtil.java:59)
> at
> org.apache.solr.handler.extraction.TestExtractionDateUtil.testParseDate(TestExtractionDateUtil.java:54)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
