[jira] [Commented] (SOLR-10394) search.grouping.Command rename: getSortWithinGroup --> getWithinGroupSort

2017-04-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-10394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975525#comment-15975525
 ] 

ASF GitHub Bot commented on SOLR-10394:
---

Github user jitka18 commented on the issue:

https://github.com/apache/lucene-solr/pull/189
  
Hi, Christine.  I accepted your pull request and will update my branch from
the  master later today.   Will also take a look at the tests in DQCCST.

Thanks,
Judith

On Wed, Apr 19, 2017 at 1:19 PM, Christine Poerschke <
notificati...@github.com> wrote:

> Hi Judith - thanks for adding me to the collaborator list. I've added one
> more commit to the jitka18#1
>  request and would suggest
> something along the following lines as the next steps:
>
>- to review jitka18#1 
>and if it looks good merge it into your jira/solr-6203 branch and/or 
add
>comments on the pull request
>- to merge the latest master (at the time) into the jira/solr-6203
>working branch
>** this will give some merge conflicts that need to be resolved
>** this will somewhat reduce the scope and complexity of the changes
>for the working branch since SOLR-10394 part-2 renames will be picked 
up
>from the latest master
>- to see if new code duplication in 
DistributedQueryComponentCustomSortTest
>can be reduced further, this will not just reduce the amount of code 
but
>will (i think) also help with clarity i.e. what is being tested
>
> How does that sound? Any questions, please let me know. - Christine
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> ,
> or mute the thread
> 

> .
>



> search.grouping.Command rename: getSortWithinGroup --> getWithinGroupSort
> -
>
> Key: SOLR-10394
> URL: https://issues.apache.org/jira/browse/SOLR-10394
> Project: Solr
>  Issue Type: Task
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Fix For: 6.6, master (7.0)
>
> Attachments: SOLR-10394-part2.patch, SOLR-10394.patch
>
>
> The class is marked _@lucene.experimental_ and SOLR-9660 previously included 
> sortSpecWithinGroup to withinGroupSortSpec renaming for GroupSpecification; 
> the rename proposed here is in line with that.
> Motivation for the change is to reduce group-sort vs. within-group-sort 
> confusion, generally and specifically in SOLR-6203.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-10394) search.grouping.Command rename: getSortWithinGroup --> getWithinGroupSort

2017-04-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-10394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975438#comment-15975438
 ] 

ASF GitHub Bot commented on SOLR-10394:
---

Github user cpoerschke commented on the issue:

https://github.com/apache/lucene-solr/pull/189
  
Hi Judith - thanks for adding me to the collaborator list. I've added one 
more commit to the https://github.com/jitka18/lucene-solr/pull/1 request and 
would suggest something along the following lines as the next steps:
* to review https://github.com/jitka18/lucene-solr/pull/1 and if it looks 
good merge it into your jira/solr-6203 branch and/or add comments on the pull 
request
* to merge the latest master (at the time) into the jira/solr-6203 working 
branch
** this will give some merge conflicts that need to be resolved
** this will somewhat reduce the scope and complexity of the changes for 
the working branch since SOLR-10394 part-2 renames will be picked up from the 
latest master
* to see if new code duplication in DistributedQueryComponentCustomSortTest 
can be reduced further, this will not just reduce the amount of code but will 
(i think) also help with clarity i.e. what is being tested

How does that sound? Any questions, please let me know. - Christine


> search.grouping.Command rename: getSortWithinGroup --> getWithinGroupSort
> -
>
> Key: SOLR-10394
> URL: https://issues.apache.org/jira/browse/SOLR-10394
> Project: Solr
>  Issue Type: Task
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Attachments: SOLR-10394-part2.patch, SOLR-10394.patch
>
>
> The class is marked _@lucene.experimental_ and SOLR-9660 previously included 
> sortSpecWithinGroup to withinGroupSortSpec renaming for GroupSpecification; 
> the rename proposed here is in line with that.
> Motivation for the change is to reduce group-sort vs. within-group-sort 
> confusion, generally and specifically in SOLR-6203.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-10394) search.grouping.Command rename: getSortWithinGroup --> getWithinGroupSort

2017-04-19 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-10394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974836#comment-15974836
 ] 

ASF subversion and git services commented on SOLR-10394:


Commit 4b30834bc8a5f1744594d8c6ff1bad05d3691655 in lucene-solr's branch 
refs/heads/branch_6x from [~cpoerschke]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4b30834 ]

SOLR-10394: a few more essentially non-public sortWithinGroup to 
withinGroupSort renames

Resolved Conflict:

solr/core/src/java/org/apache/solr/search/grouping/distributed/command/TopGroupsFieldCommand.java


> search.grouping.Command rename: getSortWithinGroup --> getWithinGroupSort
> -
>
> Key: SOLR-10394
> URL: https://issues.apache.org/jira/browse/SOLR-10394
> Project: Solr
>  Issue Type: Task
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Attachments: SOLR-10394-part2.patch, SOLR-10394.patch
>
>
> The class is marked _@lucene.experimental_ and SOLR-9660 previously included 
> sortSpecWithinGroup to withinGroupSortSpec renaming for GroupSpecification; 
> the rename proposed here is in line with that.
> Motivation for the change is to reduce group-sort vs. within-group-sort 
> confusion, generally and specifically in SOLR-6203.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-10394) search.grouping.Command rename: getSortWithinGroup --> getWithinGroupSort

2017-04-19 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-10394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974554#comment-15974554
 ] 

ASF subversion and git services commented on SOLR-10394:


Commit 323c972922c5d2e272ef4558cf725e5d9ccef623 in lucene-solr's branch 
refs/heads/master from [~cpoerschke]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=323c972 ]

SOLR-10394: a few more essentially non-public sortWithinGroup to 
withinGroupSort renames


> search.grouping.Command rename: getSortWithinGroup --> getWithinGroupSort
> -
>
> Key: SOLR-10394
> URL: https://issues.apache.org/jira/browse/SOLR-10394
> Project: Solr
>  Issue Type: Task
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Attachments: SOLR-10394-part2.patch, SOLR-10394.patch
>
>
> The class is marked _@lucene.experimental_ and SOLR-9660 previously included 
> sortSpecWithinGroup to withinGroupSortSpec renaming for GroupSpecification; 
> the rename proposed here is in line with that.
> Motivation for the change is to reduce group-sort vs. within-group-sort 
> confusion, generally and specifically in SOLR-6203.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-10394) search.grouping.Command rename: getSortWithinGroup --> getWithinGroupSort

2017-04-04 Thread Christine Poerschke (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-10394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15955262#comment-15955262
 ] 

Christine Poerschke commented on SOLR-10394:


Committed to master and branch_6x this afternoon, not sure why the ASF Bot 
didn't add an update here (my git was also hanging when pushing).
* master: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/05749d06
* branch_6x: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/bec07b0a

> search.grouping.Command rename: getSortWithinGroup --> getWithinGroupSort
> -
>
> Key: SOLR-10394
> URL: https://issues.apache.org/jira/browse/SOLR-10394
> Project: Solr
>  Issue Type: Task
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Attachments: SOLR-10394.patch
>
>
> The class is marked _@lucene.experimental_ and SOLR-9660 previously included 
> sortSpecWithinGroup to withinGroupSortSpec renaming for GroupSpecification; 
> the rename proposed here is in line with that.
> Motivation for the change is to reduce group-sort vs. within-group-sort 
> confusion, generally and specifically in SOLR-6203.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org