[jira] [Commented] (SOLR-10396) Implement trigger support for nodeLost event type
[ https://issues.apache.org/jira/browse/SOLR-10396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975832#comment-15975832 ] Cao Manh Dat commented on SOLR-10396: - Thanks [~shalinmangar] for review the patch. Committed to branch https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;a=commit;h=81e0f801f5145052cb25c533b134f4f5dcba972b > Implement trigger support for nodeLost event type > - > > Key: SOLR-10396 > URL: https://issues.apache.org/jira/browse/SOLR-10396 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Reporter: Shalin Shekhar Mangar >Assignee: Cao Manh Dat > Labels: autoscaling > Fix For: master (7.0) > > Attachments: SOLR-10396.patch > > > Implement support for 'nodeLost' event type in triggers. This kind of trigger > is fired when a node goes away (i.e. no longer live) and does not comes back > within a configured amount of time. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10396) Implement trigger support for nodeLost event type
[
https://issues.apache.org/jira/browse/SOLR-10396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974520#comment-15974520
]
Shalin Shekhar Mangar commented on SOLR-10396:
--
One more thing, in NodeAddedTrigger:
{code}
return AutoScaling.EventType.valueOf((String) properties.get("event"));
{code}
should be:
{code}
return
AutoScaling.EventType.valueOf(properties.get("event").toString().toUpperCase(Locale.ROOT));
{code}
It is a bug in NodeAddedTrigger also that I found while implementing SOLR-10496.
> Implement trigger support for nodeLost event type
> -
>
> Key: SOLR-10396
> URL: https://issues.apache.org/jira/browse/SOLR-10396
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Cao Manh Dat
> Labels: autoscaling
> Fix For: master (7.0)
>
> Attachments: SOLR-10396.patch
>
>
> Implement support for 'nodeLost' event type in triggers. This kind of trigger
> is fired when a node goes away (i.e. no longer live) and does not comes back
> within a configured amount of time.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10396) Implement trigger support for nodeLost event type
[
https://issues.apache.org/jira/browse/SOLR-10396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974514#comment-15974514
]
Shalin Shekhar Mangar commented on SOLR-10396:
--
There's a comment in the NodeLostTriggerTest which says:
{quote}
// add a new node but remove it before the waitFor period expires
// and assert that the trigger doesn't fire at all
{quote}
I think that should be the other way round? i.e. we want to remove a node but
add it back before the waitFor expires.
Rest looks good to me. +1 to commit to autoscaling branch.
> Implement trigger support for nodeLost event type
> -
>
> Key: SOLR-10396
> URL: https://issues.apache.org/jira/browse/SOLR-10396
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Cao Manh Dat
> Labels: autoscaling
> Fix For: master (7.0)
>
> Attachments: SOLR-10396.patch
>
>
> Implement support for 'nodeLost' event type in triggers. This kind of trigger
> is fired when a node goes away (i.e. no longer live) and does not comes back
> within a configured amount of time.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
