[jira] [Commented] (SOLR-10619) Optimize using cache for DQ.peek(), DQ.poll() in case of single-consumer
[ https://issues.apache.org/jira/browse/SOLR-10619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002157#comment-16002157 ] Cao Manh Dat commented on SOLR-10619: - [~dragonsinth] The patch LGTM, I will commit the patch soon. > Optimize using cache for DQ.peek(), DQ.poll() in case of single-consumer > > > Key: SOLR-10619 > URL: https://issues.apache.org/jira/browse/SOLR-10619 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Cao Manh Dat >Assignee: Cao Manh Dat > Attachments: SOLR-10619-dragonsinth.patch, SOLR-10619.patch, > SOLR-10619.patch, SOLR-10619.patch, SOLR-10619.patch > > > Right now, for every time childWatcher is kicked off. We refetch all children > of DQ's node. It is a wasted in case of single consumer. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10619) Optimize using cache for DQ.peek(), DQ.poll() in case of single-consumer
[ https://issues.apache.org/jira/browse/SOLR-10619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002139#comment-16002139 ] Shalin Shekhar Mangar commented on SOLR-10619: -- +1 LGTM > Optimize using cache for DQ.peek(), DQ.poll() in case of single-consumer > > > Key: SOLR-10619 > URL: https://issues.apache.org/jira/browse/SOLR-10619 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Cao Manh Dat >Assignee: Cao Manh Dat > Attachments: SOLR-10619-dragonsinth.patch, SOLR-10619.patch, > SOLR-10619.patch, SOLR-10619.patch, SOLR-10619.patch > > > Right now, for every time childWatcher is kicked off. We refetch all children > of DQ's node. It is a wasted in case of single consumer. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10619) Optimize using cache for DQ.peek(), DQ.poll() in case of single-consumer
[ https://issues.apache.org/jira/browse/SOLR-10619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002053#comment-16002053 ] Scott Blum commented on SOLR-10619: --- [~caomanhdat] Okay, I see what's going on here. Your change looks good. Although... I think maybe we should change peekElements so that it only forces a refresh if it's going to have to block? > Optimize using cache for DQ.peek(), DQ.poll() in case of single-consumer > > > Key: SOLR-10619 > URL: https://issues.apache.org/jira/browse/SOLR-10619 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Cao Manh Dat >Assignee: Cao Manh Dat > Attachments: SOLR-10619.patch, SOLR-10619.patch, SOLR-10619.patch, > SOLR-10619.patch > > > Right now, for every time childWatcher is kicked off. We refetch all children > of DQ's node. It is a wasted in case of single consumer. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10619) Optimize using cache for DQ.peek(), DQ.poll() in case of single-consumer
[ https://issues.apache.org/jira/browse/SOLR-10619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002013#comment-16002013 ] Scott Blum commented on SOLR-10619: --- Hmm lemme take a look. Maybe that test should just have different expectations? > Optimize using cache for DQ.peek(), DQ.poll() in case of single-consumer > > > Key: SOLR-10619 > URL: https://issues.apache.org/jira/browse/SOLR-10619 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Cao Manh Dat >Assignee: Cao Manh Dat > Attachments: SOLR-10619.patch, SOLR-10619.patch, SOLR-10619.patch, > SOLR-10619.patch > > > Right now, for every time childWatcher is kicked off. We refetch all children > of DQ's node. It is a wasted in case of single consumer. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
