[jira] [Commented] (SOLR-11182) Solr doesn't log IOException if a shard split fails

2017-08-03 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-11182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113141#comment-16113141
 ] 

ASF subversion and git services commented on SOLR-11182:


Commit 1f00dff0994c499f3d7051c3f76ba7603654b4e9 in lucene-solr's branch 
refs/heads/branch_7_0 from [~varunthacker]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1f00dff ]

SOLR-11182: A split shard failure on IOException should be logged


> Solr doesn't log IOException if a shard split fails
> ---
>
> Key: SOLR-11182
> URL: https://issues.apache.org/jira/browse/SOLR-11182
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Affects Versions: 6.5, 6.6
>Reporter: Varun Thacker
>Assignee: Varun Thacker
> Fix For: 7.0
>
> Attachments: SOLR-11182.patch
>
>
> During a split shard operation the last message I see in the Solr logs was 
> this
> {code}
> date time INFO  (parallelCoreAdminExecutor... SPLIT) [   ] 
> o.a.s.u.SolrIndexWriter Calling setCommitData with 
> IW:org.apache.solr.update.SolrIndexWriter@hex
> {code}
> But the split never completed according the the request status API.
> {code}
> ...
>   "Operation splitshard caused exception:": 
> "org.apache.solr.common.SolrException:org.apache.solr.common.SolrException",
>   "exception": {
> "msg": null,
> "rspCode": 500
>   }
> {code}
> {{SolrIndexSplitter#split}} throws an IOException and in 
> DirectUpdateHandler2#split we catch it but never log an exception. We should 
> log the error and also throw it ?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-11182) Solr doesn't log IOException if a shard split fails

2017-08-03 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-11182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113138#comment-16113138
 ] 

ASF subversion and git services commented on SOLR-11182:


Commit a13a966a01013d5376fe466040302ea56c0b77c3 in lucene-solr's branch 
refs/heads/branch_7x from [~varunthacker]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a13a966 ]

SOLR-11182: A split shard failure on IOException should be logged


> Solr doesn't log IOException if a shard split fails
> ---
>
> Key: SOLR-11182
> URL: https://issues.apache.org/jira/browse/SOLR-11182
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Varun Thacker
>Assignee: Varun Thacker
> Attachments: SOLR-11182.patch
>
>
> During a split shard operation the last message I see in the Solr logs was 
> this
> {code}
> date time INFO  (parallelCoreAdminExecutor... SPLIT) [   ] 
> o.a.s.u.SolrIndexWriter Calling setCommitData with 
> IW:org.apache.solr.update.SolrIndexWriter@hex
> {code}
> But the split never completed according the the request status API.
> {code}
> ...
>   "Operation splitshard caused exception:": 
> "org.apache.solr.common.SolrException:org.apache.solr.common.SolrException",
>   "exception": {
> "msg": null,
> "rspCode": 500
>   }
> {code}
> {{SolrIndexSplitter#split}} throws an IOException and in 
> DirectUpdateHandler2#split we catch it but never log an exception. We should 
> log the error and also throw it ?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-11182) Solr doesn't log IOException if a shard split fails

2017-08-03 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-11182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113137#comment-16113137
 ] 

ASF subversion and git services commented on SOLR-11182:


Commit 8cd2942e354687b6f655ef831d5d525d63dd46a8 in lucene-solr's branch 
refs/heads/master from [~varunthacker]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8cd2942 ]

SOLR-11182: A split shard failure on IOException should be logged


> Solr doesn't log IOException if a shard split fails
> ---
>
> Key: SOLR-11182
> URL: https://issues.apache.org/jira/browse/SOLR-11182
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Varun Thacker
>Assignee: Varun Thacker
> Attachments: SOLR-11182.patch
>
>
> During a split shard operation the last message I see in the Solr logs was 
> this
> {code}
> date time INFO  (parallelCoreAdminExecutor... SPLIT) [   ] 
> o.a.s.u.SolrIndexWriter Calling setCommitData with 
> IW:org.apache.solr.update.SolrIndexWriter@hex
> {code}
> But the split never completed according the the request status API.
> {code}
> ...
>   "Operation splitshard caused exception:": 
> "org.apache.solr.common.SolrException:org.apache.solr.common.SolrException",
>   "exception": {
> "msg": null,
> "rspCode": 500
>   }
> {code}
> {{SolrIndexSplitter#split}} throws an IOException and in 
> DirectUpdateHandler2#split we catch it but never log an exception. We should 
> log the error and also throw it ?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-11182) Solr doesn't log IOException if a shard split fails

2017-08-03 Thread Shalin Shekhar Mangar (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-11182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112314#comment-16112314
 ] 

Shalin Shekhar Mangar commented on SOLR-11182:
--

+1 LGTM

> Solr doesn't log IOException if a shard split fails
> ---
>
> Key: SOLR-11182
> URL: https://issues.apache.org/jira/browse/SOLR-11182
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Varun Thacker
>Assignee: Varun Thacker
> Attachments: SOLR-11182.patch
>
>
> During a split shard operation the last message I see in the Solr logs was 
> this
> {code}
> date time INFO  (parallelCoreAdminExecutor... SPLIT) [   ] 
> o.a.s.u.SolrIndexWriter Calling setCommitData with 
> IW:org.apache.solr.update.SolrIndexWriter@hex
> {code}
> But the split never completed according the the request status API.
> {code}
> ...
>   "Operation splitshard caused exception:": 
> "org.apache.solr.common.SolrException:org.apache.solr.common.SolrException",
>   "exception": {
> "msg": null,
> "rspCode": 500
>   }
> {code}
> {{SolrIndexSplitter#split}} throws an IOException and in 
> DirectUpdateHandler2#split we catch it but never log an exception. We should 
> log the error and also throw it ?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-11182) Solr doesn't log IOException if a shard split fails

2017-08-02 Thread Shalin Shekhar Mangar (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-11182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112106#comment-16112106
 ] 

Shalin Shekhar Mangar commented on SOLR-11182:
--

This was introduced in SOLR- in 6.5. We should let the exception propagate 
up.

> Solr doesn't log IOException if a shard split fails
> ---
>
> Key: SOLR-11182
> URL: https://issues.apache.org/jira/browse/SOLR-11182
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Varun Thacker
>Assignee: Varun Thacker
>
> During a split shard operation the last message I see in the Solr logs was 
> this
> {code}
> date time INFO  (parallelCoreAdminExecutor... SPLIT) [   ] 
> o.a.s.u.SolrIndexWriter Calling setCommitData with 
> IW:org.apache.solr.update.SolrIndexWriter@hex
> {code}
> But the split never completed according the the request status API.
> {code}
> ...
>   "Operation splitshard caused exception:": 
> "org.apache.solr.common.SolrException:org.apache.solr.common.SolrException",
>   "exception": {
> "msg": null,
> "rspCode": 500
>   }
> {code}
> {{SolrIndexSplitter#split}} throws an IOException and in 
> DirectUpdateHandler2#split we catch it but never log an exception. We should 
> log the error and also throw it ?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org