[jira] [Commented] (SOLR-11714) AddReplicaSuggester endless loop
[
https://issues.apache.org/jira/browse/SOLR-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339480#comment-16339480
]
ASF subversion and git services commented on SOLR-11714:
Commit af9706cb89335a5aa04f9bcae0c2558a61803b50 in lucene-solr's branch
refs/heads/branch_7x from [~shalinmangar]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=af9706c ]
SOLR-11714: Remove todo now that this issue has been fixed
(cherry picked from commit 09f903e)
> AddReplicaSuggester endless loop
>
>
> Key: SOLR-11714
> URL: https://issues.apache.org/jira/browse/SOLR-11714
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: AutoScaling
>Affects Versions: 7.2, master (8.0)
>Reporter: Andrzej Bialecki
>Assignee: Andrzej Bialecki
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: 7.2-disable-search-rate-trigger.diff, SOLR-11714.diff,
> SOLR-11714.patch
>
>
> {{SearchRateTrigger}} events are processed by {{ComputePlanAction}} and
> depending on the condition either a MoveReplicaSuggester or
> AddReplicaSuggester is selected.
> When {{AddReplicaSuggester}} is selected there's currently a bug in master,
> due to an API change (Hint.COLL_SHARD should be used instead of Hint.COLL).
> However, after fixing that bug {{ComputePlanAction}} goes into an endless
> loop because the suggester endlessly keeps creating new operations.
> Please see the patch that fixes the Hint.COLL_SHARD issue and modifies the
> unit test to illustrate this failure.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11714) AddReplicaSuggester endless loop
[
https://issues.apache.org/jira/browse/SOLR-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339474#comment-16339474
]
ASF subversion and git services commented on SOLR-11714:
Commit 09f903ef8dd7d294b1f5b1cf7023b28a58277d25 in lucene-solr's branch
refs/heads/master from [~shalinmangar]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=09f903e ]
SOLR-11714: Remove todo now that this issue has been fixed
> AddReplicaSuggester endless loop
>
>
> Key: SOLR-11714
> URL: https://issues.apache.org/jira/browse/SOLR-11714
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: AutoScaling
>Affects Versions: 7.2, master (8.0)
>Reporter: Andrzej Bialecki
>Assignee: Andrzej Bialecki
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: 7.2-disable-search-rate-trigger.diff, SOLR-11714.diff,
> SOLR-11714.patch
>
>
> {{SearchRateTrigger}} events are processed by {{ComputePlanAction}} and
> depending on the condition either a MoveReplicaSuggester or
> AddReplicaSuggester is selected.
> When {{AddReplicaSuggester}} is selected there's currently a bug in master,
> due to an API change (Hint.COLL_SHARD should be used instead of Hint.COLL).
> However, after fixing that bug {{ComputePlanAction}} goes into an endless
> loop because the suggester endlessly keeps creating new operations.
> Please see the patch that fixes the Hint.COLL_SHARD issue and modifies the
> unit test to illustrate this failure.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11714) AddReplicaSuggester endless loop
[
https://issues.apache.org/jira/browse/SOLR-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337767#comment-16337767
]
ASF subversion and git services commented on SOLR-11714:
Commit fba5114b78de2eb84b5ae71745a6eb670ca4ad33 in lucene-solr's branch
refs/heads/branch_7x from [~ab]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fba5114 ]
SOLR-11714: AddReplicaSuggester / ComputePlanAction infinite loop.
> AddReplicaSuggester endless loop
>
>
> Key: SOLR-11714
> URL: https://issues.apache.org/jira/browse/SOLR-11714
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: AutoScaling
>Affects Versions: 7.2, master (8.0)
>Reporter: Andrzej Bialecki
>Assignee: Andrzej Bialecki
>Priority: Major
> Attachments: 7.2-disable-search-rate-trigger.diff, SOLR-11714.diff,
> SOLR-11714.patch
>
>
> {{SearchRateTrigger}} events are processed by {{ComputePlanAction}} and
> depending on the condition either a MoveReplicaSuggester or
> AddReplicaSuggester is selected.
> When {{AddReplicaSuggester}} is selected there's currently a bug in master,
> due to an API change (Hint.COLL_SHARD should be used instead of Hint.COLL).
> However, after fixing that bug {{ComputePlanAction}} goes into an endless
> loop because the suggester endlessly keeps creating new operations.
> Please see the patch that fixes the Hint.COLL_SHARD issue and modifies the
> unit test to illustrate this failure.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11714) AddReplicaSuggester endless loop
[
https://issues.apache.org/jira/browse/SOLR-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337558#comment-16337558
]
ASF subversion and git services commented on SOLR-11714:
Commit fa511a0a6f7e9f395aef853b1da7908d88be9f9a in lucene-solr's branch
refs/heads/master from [~ab]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fa511a0 ]
SOLR-11714: AddReplicaSuggester / ComputePlanAction infinite loop.
> AddReplicaSuggester endless loop
>
>
> Key: SOLR-11714
> URL: https://issues.apache.org/jira/browse/SOLR-11714
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: AutoScaling
>Affects Versions: 7.2, master (8.0)
>Reporter: Andrzej Bialecki
>Assignee: Andrzej Bialecki
>Priority: Major
> Attachments: 7.2-disable-search-rate-trigger.diff, SOLR-11714.diff,
> SOLR-11714.patch
>
>
> {{SearchRateTrigger}} events are processed by {{ComputePlanAction}} and
> depending on the condition either a MoveReplicaSuggester or
> AddReplicaSuggester is selected.
> When {{AddReplicaSuggester}} is selected there's currently a bug in master,
> due to an API change (Hint.COLL_SHARD should be used instead of Hint.COLL).
> However, after fixing that bug {{ComputePlanAction}} goes into an endless
> loop because the suggester endlessly keeps creating new operations.
> Please see the patch that fixes the Hint.COLL_SHARD issue and modifies the
> unit test to illustrate this failure.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11714) AddReplicaSuggester endless loop
[
https://issues.apache.org/jira/browse/SOLR-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327270#comment-16327270
]
Shalin Shekhar Mangar commented on SOLR-11714:
--
+1 LGTM. I reviewed the diff directly because I couldn't apply the patch
cleanly on latest master.
> AddReplicaSuggester endless loop
>
>
> Key: SOLR-11714
> URL: https://issues.apache.org/jira/browse/SOLR-11714
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: AutoScaling
>Affects Versions: 7.2, master (8.0)
>Reporter: Andrzej Bialecki
>Assignee: Andrzej Bialecki
>Priority: Major
> Attachments: 7.2-disable-search-rate-trigger.diff, SOLR-11714.diff,
> SOLR-11714.patch
>
>
> {{SearchRateTrigger}} events are processed by {{ComputePlanAction}} and
> depending on the condition either a MoveReplicaSuggester or
> AddReplicaSuggester is selected.
> When {{AddReplicaSuggester}} is selected there's currently a bug in master,
> due to an API change (Hint.COLL_SHARD should be used instead of Hint.COLL).
> However, after fixing that bug {{ComputePlanAction}} goes into an endless
> loop because the suggester endlessly keeps creating new operations.
> Please see the patch that fixes the Hint.COLL_SHARD issue and modifies the
> unit test to illustrate this failure.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11714) AddReplicaSuggester endless loop
[
https://issues.apache.org/jira/browse/SOLR-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318606#comment-16318606
]
Andrzej Bialecki commented on SOLR-11714:
--
After discussing this with Noble it seems that the best way to solve this is to
allow some triggers to calculate the list of expected changes (eg. a list of
COLL_SHARD replicas to add), and then explicitly iterate in
{{ComputePlanAction}} as many times as needed to consume the list of these
changes, and initializing suggesters with one change at a time (which would
eventually result in calculating up to the same number of ops, though some of
them may be null).
> AddReplicaSuggester endless loop
>
>
> Key: SOLR-11714
> URL: https://issues.apache.org/jira/browse/SOLR-11714
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: AutoScaling
>Affects Versions: 7.2, master (8.0)
>Reporter: Andrzej Bialecki
>Assignee: Noble Paul
> Attachments: 7.2-disable-search-rate-trigger.diff, SOLR-11714.diff
>
>
> {{SearchRateTrigger}} events are processed by {{ComputePlanAction}} and
> depending on the condition either a MoveReplicaSuggester or
> AddReplicaSuggester is selected.
> When {{AddReplicaSuggester}} is selected there's currently a bug in master,
> due to an API change (Hint.COLL_SHARD should be used instead of Hint.COLL).
> However, after fixing that bug {{ComputePlanAction}} goes into an endless
> loop because the suggester endlessly keeps creating new operations.
> Please see the patch that fixes the Hint.COLL_SHARD issue and modifies the
> unit test to illustrate this failure.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11714) AddReplicaSuggester endless loop
[
https://issues.apache.org/jira/browse/SOLR-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318375#comment-16318375
]
Noble Paul commented on SOLR-11714:
---
How does the suggester know what is the impact of the last operation on the
search rate on a given node? It's not predictable. Getting multiple suggestions
is not any more useful than the current approach.
> AddReplicaSuggester endless loop
>
>
> Key: SOLR-11714
> URL: https://issues.apache.org/jira/browse/SOLR-11714
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: AutoScaling
>Affects Versions: 7.2, master (8.0)
>Reporter: Andrzej Bialecki
>Assignee: Noble Paul
> Attachments: 7.2-disable-search-rate-trigger.diff, SOLR-11714.diff
>
>
> {{SearchRateTrigger}} events are processed by {{ComputePlanAction}} and
> depending on the condition either a MoveReplicaSuggester or
> AddReplicaSuggester is selected.
> When {{AddReplicaSuggester}} is selected there's currently a bug in master,
> due to an API change (Hint.COLL_SHARD should be used instead of Hint.COLL).
> However, after fixing that bug {{ComputePlanAction}} goes into an endless
> loop because the suggester endlessly keeps creating new operations.
> Please see the patch that fixes the Hint.COLL_SHARD issue and modifies the
> unit test to illustrate this failure.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11714) AddReplicaSuggester endless loop
[
https://issues.apache.org/jira/browse/SOLR-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318349#comment-16318349
]
Andrzej Bialecki commented on SOLR-11714:
--
Ok, I see that now.
The logic in {{ComputePlanAction}} for handling {{searchRate}} events will end
up quite complex, due to the limitations of Suggester API (returning just one
op at a time) - eg. {{AddReplicaSuggester}} will need to be initialized
differently in each loop, otherwise it would keep adding replicas to the first
hot shard and ignore the others… For now this logic need to be put in
{{ComputePlanAction}} - but if we changed the {{Suggester.getSuggestion}} to be
able to return multiple suggestions, and changed
{{AddReplicaSuggester.getSuggestions()}} to return suggestions for all hints,
then we could move this complicated logic to {{SearchRateTrigger}}. WDYT?
> AddReplicaSuggester endless loop
>
>
> Key: SOLR-11714
> URL: https://issues.apache.org/jira/browse/SOLR-11714
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: AutoScaling
>Affects Versions: 7.2, master (8.0)
>Reporter: Andrzej Bialecki
>Assignee: Noble Paul
> Attachments: 7.2-disable-search-rate-trigger.diff, SOLR-11714.diff
>
>
> {{SearchRateTrigger}} events are processed by {{ComputePlanAction}} and
> depending on the condition either a MoveReplicaSuggester or
> AddReplicaSuggester is selected.
> When {{AddReplicaSuggester}} is selected there's currently a bug in master,
> due to an API change (Hint.COLL_SHARD should be used instead of Hint.COLL).
> However, after fixing that bug {{ComputePlanAction}} goes into an endless
> loop because the suggester endlessly keeps creating new operations.
> Please see the patch that fixes the Hint.COLL_SHARD issue and modifies the
> unit test to illustrate this failure.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11714) AddReplicaSuggester endless loop
[
https://issues.apache.org/jira/browse/SOLR-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316399#comment-16316399
]
Noble Paul commented on SOLR-11714:
---
There is no means for the Policy framework to decide the no:of replicas that
required to be added to achieve the given throughput. Instead ComputeActionPlan
must only request it to add a certain no:of replicas (worst case, one at a
time) and observe the result and add another
> AddReplicaSuggester endless loop
>
>
> Key: SOLR-11714
> URL: https://issues.apache.org/jira/browse/SOLR-11714
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: AutoScaling
>Affects Versions: 7.2, master (8.0)
>Reporter: Andrzej Bialecki
>Assignee: Noble Paul
> Attachments: 7.2-disable-search-rate-trigger.diff, SOLR-11714.diff
>
>
> {{SearchRateTrigger}} events are processed by {{ComputePlanAction}} and
> depending on the condition either a MoveReplicaSuggester or
> AddReplicaSuggester is selected.
> When {{AddReplicaSuggester}} is selected there's currently a bug in master,
> due to an API change (Hint.COLL_SHARD should be used instead of Hint.COLL).
> However, after fixing that bug {{ComputePlanAction}} goes into an endless
> loop because the suggester endlessly keeps creating new operations.
> Please see the patch that fixes the Hint.COLL_SHARD issue and modifies the
> unit test to illustrate this failure.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11714) AddReplicaSuggester endless loop
[
https://issues.apache.org/jira/browse/SOLR-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316393#comment-16316393
]
Andrzej Bialecki commented on SOLR-11714:
--
The current behavior of the framework is trappy because user has to modify the
preferences when he adds a {{searchRate}} trigger in order to avoid the loop -
if he forgets to do that he can bring the autoscaling down.
There are two things that we can do here: {{ComputePlanAction}} should be able
to detect infinite (or very long) loops based roughly on the cluster size and
the total number of replicas across the cluster, eg. if we have a cluster of 10
nodes and 20 replicas but the loop generated 1000 operations then something is
definitely wrong.
Also, can we use some default limit, eg. 2 * replication factor, or something
similar, for ADDREPLICA suggester, at least for events produced by
{{searchRate}} trigger? Where do you think this default should be initialized?
> AddReplicaSuggester endless loop
>
>
> Key: SOLR-11714
> URL: https://issues.apache.org/jira/browse/SOLR-11714
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: AutoScaling
>Affects Versions: 7.2, master (8.0)
>Reporter: Andrzej Bialecki
>Assignee: Noble Paul
> Attachments: 7.2-disable-search-rate-trigger.diff, SOLR-11714.diff
>
>
> {{SearchRateTrigger}} events are processed by {{ComputePlanAction}} and
> depending on the condition either a MoveReplicaSuggester or
> AddReplicaSuggester is selected.
> When {{AddReplicaSuggester}} is selected there's currently a bug in master,
> due to an API change (Hint.COLL_SHARD should be used instead of Hint.COLL).
> However, after fixing that bug {{ComputePlanAction}} goes into an endless
> loop because the suggester endlessly keeps creating new operations.
> Please see the patch that fixes the Hint.COLL_SHARD issue and modifies the
> unit test to illustrate this failure.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11714) AddReplicaSuggester endless loop
[
https://issues.apache.org/jira/browse/SOLR-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312123#comment-16312123
]
Noble Paul commented on SOLR-11714:
---
{code}
{"cluster-preferences":[{
"minimize":"cores",
"precision":1}]}
{code}
this is the preferences and there is no policy specified. This means an
infinite no:of replicas can be added without breaking any rules.
the test must add an explicit policy limiting the no:of replicas per node AND
the ComputeAction must check for something more than just relying on the policy
framework to return a {{null}} suggestion
> AddReplicaSuggester endless loop
>
>
> Key: SOLR-11714
> URL: https://issues.apache.org/jira/browse/SOLR-11714
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: AutoScaling
>Affects Versions: 7.2, master (8.0)
>Reporter: Andrzej Bialecki
>Assignee: Noble Paul
> Attachments: 7.2-disable-search-rate-trigger.diff, SOLR-11714.diff
>
>
> {{SearchRateTrigger}} events are processed by {{ComputePlanAction}} and
> depending on the condition either a MoveReplicaSuggester or
> AddReplicaSuggester is selected.
> When {{AddReplicaSuggester}} is selected there's currently a bug in master,
> due to an API change (Hint.COLL_SHARD should be used instead of Hint.COLL).
> However, after fixing that bug {{ComputePlanAction}} goes into an endless
> loop because the suggester endlessly keeps creating new operations.
> Please see the patch that fixes the Hint.COLL_SHARD issue and modifies the
> unit test to illustrate this failure.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11714) AddReplicaSuggester endless loop
[
https://issues.apache.org/jira/browse/SOLR-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311401#comment-16311401
]
Noble Paul commented on SOLR-11714:
---
The infinite loop is because of wrong usage. AddReplica always return non null
operation as long as there are no policy constraints
> AddReplicaSuggester endless loop
>
>
> Key: SOLR-11714
> URL: https://issues.apache.org/jira/browse/SOLR-11714
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: AutoScaling
>Affects Versions: 7.2, master (8.0)
>Reporter: Andrzej Bialecki
>Assignee: Noble Paul
> Attachments: 7.2-disable-search-rate-trigger.diff, SOLR-11714.diff
>
>
> {{SearchRateTrigger}} events are processed by {{ComputePlanAction}} and
> depending on the condition either a MoveReplicaSuggester or
> AddReplicaSuggester is selected.
> When {{AddReplicaSuggester}} is selected there's currently a bug in master,
> due to an API change (Hint.COLL_SHARD should be used instead of Hint.COLL).
> However, after fixing that bug {{ComputePlanAction}} goes into an endless
> loop because the suggester endlessly keeps creating new operations.
> Please see the patch that fixes the Hint.COLL_SHARD issue and modifies the
> unit test to illustrate this failure.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11714) AddReplicaSuggester endless loop
[
https://issues.apache.org/jira/browse/SOLR-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282301#comment-16282301
]
Andrzej Bialecki commented on SOLR-11714:
--
This still needs to be properly fixed for all other affected branches (7x and
master), the commit above is just a quick fix that disables this functionality
in 7.2.
> AddReplicaSuggester endless loop
>
>
> Key: SOLR-11714
> URL: https://issues.apache.org/jira/browse/SOLR-11714
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: AutoScaling
>Affects Versions: 7.2, master (8.0)
>Reporter: Andrzej Bialecki
>Assignee: Noble Paul
> Attachments: 7.2-disable-search-rate-trigger.diff, SOLR-11714.diff
>
>
> {{SearchRateTrigger}} events are processed by {{ComputePlanAction}} and
> depending on the condition either a MoveReplicaSuggester or
> AddReplicaSuggester is selected.
> When {{AddReplicaSuggester}} is selected there's currently a bug in master,
> due to an API change (Hint.COLL_SHARD should be used instead of Hint.COLL).
> However, after fixing that bug {{ComputePlanAction}} goes into an endless
> loop because the suggester endlessly keeps creating new operations.
> Please see the patch that fixes the Hint.COLL_SHARD issue and modifies the
> unit test to illustrate this failure.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11714) AddReplicaSuggester endless loop
[
https://issues.apache.org/jira/browse/SOLR-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282352#comment-16282352
]
Adrien Grand commented on SOLR-11714:
-
OK, thanks for the explanation.
> AddReplicaSuggester endless loop
>
>
> Key: SOLR-11714
> URL: https://issues.apache.org/jira/browse/SOLR-11714
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: AutoScaling
>Affects Versions: 7.2, master (8.0)
>Reporter: Andrzej Bialecki
>Assignee: Noble Paul
> Attachments: 7.2-disable-search-rate-trigger.diff, SOLR-11714.diff
>
>
> {{SearchRateTrigger}} events are processed by {{ComputePlanAction}} and
> depending on the condition either a MoveReplicaSuggester or
> AddReplicaSuggester is selected.
> When {{AddReplicaSuggester}} is selected there's currently a bug in master,
> due to an API change (Hint.COLL_SHARD should be used instead of Hint.COLL).
> However, after fixing that bug {{ComputePlanAction}} goes into an endless
> loop because the suggester endlessly keeps creating new operations.
> Please see the patch that fixes the Hint.COLL_SHARD issue and modifies the
> unit test to illustrate this failure.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11714) AddReplicaSuggester endless loop
[
https://issues.apache.org/jira/browse/SOLR-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282295#comment-16282295
]
Adrien Grand commented on SOLR-11714:
-
[~a...@getopt.org] Can this issue be resolved or is there work left to do?
> AddReplicaSuggester endless loop
>
>
> Key: SOLR-11714
> URL: https://issues.apache.org/jira/browse/SOLR-11714
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: AutoScaling
>Affects Versions: 7.2, master (8.0)
>Reporter: Andrzej Bialecki
>Assignee: Noble Paul
> Attachments: 7.2-disable-search-rate-trigger.diff, SOLR-11714.diff
>
>
> {{SearchRateTrigger}} events are processed by {{ComputePlanAction}} and
> depending on the condition either a MoveReplicaSuggester or
> AddReplicaSuggester is selected.
> When {{AddReplicaSuggester}} is selected there's currently a bug in master,
> due to an API change (Hint.COLL_SHARD should be used instead of Hint.COLL).
> However, after fixing that bug {{ComputePlanAction}} goes into an endless
> loop because the suggester endlessly keeps creating new operations.
> Please see the patch that fixes the Hint.COLL_SHARD issue and modifies the
> unit test to illustrate this failure.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11714) AddReplicaSuggester endless loop
[
https://issues.apache.org/jira/browse/SOLR-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280831#comment-16280831
]
ASF subversion and git services commented on SOLR-11714:
Commit 034daf424c13b467c16629823bc3b94395c738f3 in lucene-solr's branch
refs/heads/branch_7_2 from [~ab]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=034daf4 ]
SOLR-11714: Disable searchRate trigger due to a suggester bug.
> AddReplicaSuggester endless loop
>
>
> Key: SOLR-11714
> URL: https://issues.apache.org/jira/browse/SOLR-11714
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: AutoScaling
>Affects Versions: 7.2, master (8.0)
>Reporter: Andrzej Bialecki
>Assignee: Noble Paul
> Attachments: 7.2-disable-search-rate-trigger.diff, SOLR-11714.diff
>
>
> {{SearchRateTrigger}} events are processed by {{ComputePlanAction}} and
> depending on the condition either a MoveReplicaSuggester or
> AddReplicaSuggester is selected.
> When {{AddReplicaSuggester}} is selected there's currently a bug in master,
> due to an API change (Hint.COLL_SHARD should be used instead of Hint.COLL).
> However, after fixing that bug {{ComputePlanAction}} goes into an endless
> loop because the suggester endlessly keeps creating new operations.
> Please see the patch that fixes the Hint.COLL_SHARD issue and modifies the
> unit test to illustrate this failure.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
