[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre
[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793830#comment-16793830 ] Kevin Risden commented on SOLR-11763: - Side note found the comment about "8.x" fix version while cleaning up 8.x -> 8.1. https://issues.apache.org/jira/browse/SOLR-12999?focusedCommentId=16758679=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16758679 Either way there is only 8.1 version now (we could always rename it back to 8.x). It was bugging me there was both 8.1 and 8.x. > Upgrade Guava to 25.1-jre > - > > Key: SOLR-11763 > URL: https://issues.apache.org/jira/browse/SOLR-11763 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Markus Jelsma >Assignee: Kevin Risden >Priority: Minor > Fix For: 8.1, master (9.0) > > Attachments: SOLR-11763.patch, SOLR-11763.patch, SOLR-11763.patch, > SOLR-11763.patch, SOLR-11763.patch > > Time Spent: 1h 50m > Remaining Estimate: 0h > > Our code is running into version conflicts with Solr's old Guava dependency. > This fixes it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre
[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793797#comment-16793797 ] David Smiley commented on SOLR-11763: - Yeah something like that. Here's what I suggest: # un-assign this version from those that are not Resolved or Closed # un-assign this version from those that are in 8.0. Those issues should be marked Closed, BTW since 8.0 was released. # Assign those remaining to 8.1. These will all be Resolved issues and we know they will be in 8.1. # Delete the version. > Upgrade Guava to 25.1-jre > - > > Key: SOLR-11763 > URL: https://issues.apache.org/jira/browse/SOLR-11763 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Markus Jelsma >Assignee: Kevin Risden >Priority: Minor > Fix For: 8.x, master (9.0) > > Attachments: SOLR-11763.patch, SOLR-11763.patch, SOLR-11763.patch, > SOLR-11763.patch, SOLR-11763.patch > > Time Spent: 1h 50m > Remaining Estimate: 0h > > Our code is running into version conflicts with Solr's old Guava dependency. > This fixes it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre
[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793767#comment-16793767 ] Kevin Risden commented on SOLR-11763: - You might be right. I thought there was an email about using "8.x" and it would be renamed to 8.1 later during the release. I can't seem to find that email right now. FWIW there are quite a few 8.x JIRAs. Might be worth bulk change to 8.1 and delete the 8.x version? > Upgrade Guava to 25.1-jre > - > > Key: SOLR-11763 > URL: https://issues.apache.org/jira/browse/SOLR-11763 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Markus Jelsma >Assignee: Kevin Risden >Priority: Minor > Fix For: 8.x, master (9.0) > > Attachments: SOLR-11763.patch, SOLR-11763.patch, SOLR-11763.patch, > SOLR-11763.patch, SOLR-11763.patch > > Time Spent: 1h 50m > Remaining Estimate: 0h > > Our code is running into version conflicts with Solr's old Guava dependency. > This fixes it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre
[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793758#comment-16793758 ] David Smiley commented on SOLR-11763: - The Fix version here is wrong; it should point to a specific release this is landing in. "8.x" should not exist as a version, I believe. > Upgrade Guava to 25.1-jre > - > > Key: SOLR-11763 > URL: https://issues.apache.org/jira/browse/SOLR-11763 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Markus Jelsma >Assignee: Kevin Risden >Priority: Minor > Fix For: 8.x, master (9.0) > > Attachments: SOLR-11763.patch, SOLR-11763.patch, SOLR-11763.patch, > SOLR-11763.patch, SOLR-11763.patch > > Time Spent: 1h 50m > Remaining Estimate: 0h > > Our code is running into version conflicts with Solr's old Guava dependency. > This fixes it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre
[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772432#comment-16772432 ] Markus Jelsma commented on SOLR-11763: -- Thanks! > Upgrade Guava to 25.1-jre > - > > Key: SOLR-11763 > URL: https://issues.apache.org/jira/browse/SOLR-11763 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Markus Jelsma >Assignee: Kevin Risden >Priority: Minor > Fix For: 8.x, master (9.0) > > Attachments: SOLR-11763.patch, SOLR-11763.patch, SOLR-11763.patch, > SOLR-11763.patch, SOLR-11763.patch > > Time Spent: 1h 50m > Remaining Estimate: 0h > > Our code is running into version conflicts with Solr's old Guava dependency. > This fixes it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre
[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772400#comment-16772400 ] ASF subversion and git services commented on SOLR-11763: Commit cdabcb88d3c9fc056e8edd4da9e912a5e913cc38 in lucene-solr's branch refs/heads/branch_8x from Kevin Risden [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=cdabcb8 ] SOLR-11763: Upgrade Guava to 25.1-jre (Markus Jelsma, Kevin Risden) Signed-off-by: Kevin Risden > Upgrade Guava to 25.1-jre > - > > Key: SOLR-11763 > URL: https://issues.apache.org/jira/browse/SOLR-11763 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Markus Jelsma >Assignee: Kevin Risden >Priority: Minor > Fix For: 8.x, master (9.0) > > Attachments: SOLR-11763.patch, SOLR-11763.patch, SOLR-11763.patch, > SOLR-11763.patch, SOLR-11763.patch > > Time Spent: 1h 50m > Remaining Estimate: 0h > > Our code is running into version conflicts with Solr's old Guava dependency. > This fixes it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre
[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772390#comment-16772390 ] ASF subversion and git services commented on SOLR-11763: Commit af3ff118efd0639abab5fea28744f18442b1e363 in lucene-solr's branch refs/heads/master from Kevin Risden [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=af3ff11 ] SOLR-11763: Upgrade Guava to 25.1-jre (Markus Jelsma, Kevin Risden) Signed-off-by: Kevin Risden > Upgrade Guava to 25.1-jre > - > > Key: SOLR-11763 > URL: https://issues.apache.org/jira/browse/SOLR-11763 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Markus Jelsma >Assignee: Kevin Risden >Priority: Minor > Fix For: 8.x, master (9.0) > > Attachments: SOLR-11763.patch, SOLR-11763.patch, SOLR-11763.patch, > SOLR-11763.patch, SOLR-11763.patch > > Time Spent: 1h 40m > Remaining Estimate: 0h > > Our code is running into version conflicts with Solr's old Guava dependency. > This fixes it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre
[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762805#comment-16762805 ] Uwe Schindler commented on SOLR-11763: -- I am fine with the patch. The new suffix "-jre" on Guava is to have 2 separate versions of Guava, one for Android and one for Java. > Upgrade Guava to 25.1-jre > - > > Key: SOLR-11763 > URL: https://issues.apache.org/jira/browse/SOLR-11763 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Markus Jelsma >Assignee: Kevin Risden >Priority: Minor > Fix For: 8.x, master (9.0) > > Attachments: SOLR-11763.patch, SOLR-11763.patch, SOLR-11763.patch, > SOLR-11763.patch, SOLR-11763.patch > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Our code is running into version conflicts with Solr's old Guava dependency. > This fixes it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre
[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762778#comment-16762778 ] Kevin Risden commented on SOLR-11763: - No worries :) Thanks for checking. I've been trying to track down some test failures but realized they were already badappled. I fixed my jenkins to not run the badappled test to make sure nothing new is broken from this change. From the badapple failures I looked at they don't seem to be related. [~elyograg] [~varunthacker] [~thetaphi] - any comments on this change? > Upgrade Guava to 25.1-jre > - > > Key: SOLR-11763 > URL: https://issues.apache.org/jira/browse/SOLR-11763 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Markus Jelsma >Assignee: Kevin Risden >Priority: Minor > Fix For: 8.x, master (9.0) > > Attachments: SOLR-11763.patch, SOLR-11763.patch, SOLR-11763.patch, > SOLR-11763.patch, SOLR-11763.patch > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Our code is running into version conflicts with Solr's old Guava dependency. > This fixes it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre
[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762540#comment-16762540 ] Markus Jelsma commented on SOLR-11763: -- Sigh, my apologies [~krisden], i didn't notice my revision was not completely fresh. The patch applies nicely! Thanks! > Upgrade Guava to 25.1-jre > - > > Key: SOLR-11763 > URL: https://issues.apache.org/jira/browse/SOLR-11763 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Markus Jelsma >Assignee: Kevin Risden >Priority: Minor > Fix For: 8.x, master (9.0) > > Attachments: SOLR-11763.patch, SOLR-11763.patch, SOLR-11763.patch, > SOLR-11763.patch, SOLR-11763.patch > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Our code is running into version conflicts with Solr's old Guava dependency. > This fixes it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre
[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761796#comment-16761796 ] Kevin Risden commented on SOLR-11763: - [~markus17] - I cloned the lucene-solr repo into a separate directory and the patch applied correctly. Is it possible you have modified ivy-versions.properties separately to upgrade the guava version line? Looks like that is the only line that is failing. > Upgrade Guava to 25.1-jre > - > > Key: SOLR-11763 > URL: https://issues.apache.org/jira/browse/SOLR-11763 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Markus Jelsma >Assignee: Kevin Risden >Priority: Minor > Fix For: 8.x, master (9.0) > > Attachments: SOLR-11763.patch, SOLR-11763.patch, SOLR-11763.patch, > SOLR-11763.patch, SOLR-11763.patch > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Our code is running into version conflicts with Solr's old Guava dependency. > This fixes it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre
[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759947#comment-16759947 ] Markus Jelsma commented on SOLR-11763: -- The patch goes well for all files on master and 7.6 except lucene/ivy-versions.properties. I tried master and 7.6. > Upgrade Guava to 25.1-jre > - > > Key: SOLR-11763 > URL: https://issues.apache.org/jira/browse/SOLR-11763 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Markus Jelsma >Assignee: Kevin Risden >Priority: Minor > Fix For: 8.x, master (9.0) > > Attachments: SOLR-11763.patch, SOLR-11763.patch, SOLR-11763.patch, > SOLR-11763.patch, SOLR-11763.patch > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Our code is running into version conflicts with Solr's old Guava dependency. > This fixes it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre
[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759938#comment-16759938 ] Kevin Risden commented on SOLR-11763: - [~markus17] thanks for the quick check. I'll have to take a look. Not sure why the patch apply would fail. I don't think this will apply to the 7.x lines. I was looking at 8.x and master. > Upgrade Guava to 25.1-jre > - > > Key: SOLR-11763 > URL: https://issues.apache.org/jira/browse/SOLR-11763 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Markus Jelsma >Assignee: Kevin Risden >Priority: Minor > Fix For: 8.x, master (9.0) > > Attachments: SOLR-11763.patch, SOLR-11763.patch, SOLR-11763.patch, > SOLR-11763.patch, SOLR-11763.patch > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Our code is running into version conflicts with Solr's old Guava dependency. > This fixes it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre
[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759934#comment-16759934 ] Markus Jelsma commented on SOLR-11763: -- Hello [~krisden], the patch fails for 7.6 and master: checking file lucene/ivy-versions.properties Hunk #1 FAILED at 24. Hunk #2 succeeded at 33 (offset 1 line). Hunk #4 succeeded at 115 with fuzz 2 (offset -2 lines). Hunk #5 succeeded at 238 with fuzz 2 (offset 15 lines). 1 out of 5 hunks FAILED > Upgrade Guava to 25.1-jre > - > > Key: SOLR-11763 > URL: https://issues.apache.org/jira/browse/SOLR-11763 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Markus Jelsma >Assignee: Kevin Risden >Priority: Minor > Fix For: 8.x, master (9.0) > > Attachments: SOLR-11763.patch, SOLR-11763.patch, SOLR-11763.patch, > SOLR-11763.patch, SOLR-11763.patch > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Our code is running into version conflicts with Solr's old Guava dependency. > This fixes it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre
[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759928#comment-16759928 ] Kevin Risden commented on SOLR-11763: - [~markus17] [~elyograg] [~varunthacker] [~thetaphi] - Any thoughts on the latest patch? > Upgrade Guava to 25.1-jre > - > > Key: SOLR-11763 > URL: https://issues.apache.org/jira/browse/SOLR-11763 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Markus Jelsma >Assignee: Kevin Risden >Priority: Minor > Fix For: 8.x, master (9.0) > > Attachments: SOLR-11763.patch, SOLR-11763.patch, SOLR-11763.patch, > SOLR-11763.patch, SOLR-11763.patch > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Our code is running into version conflicts with Solr's old Guava dependency. > This fixes it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre
[
https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759554#comment-16759554
]
Lucene/Solr QA commented on SOLR-11763:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
42s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 1m 58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check licenses {color} | {color:green}
2m 16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 1m 58s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 41m
29s{color} | {color:green} core in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 48m 26s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-11763 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12957416/SOLR-11763.patch |
| Optional Tests | checklicenses validatesourcepatterns ratsources compile
javac unit checkforbiddenapis |
| uname | Linux lucene1-us-west 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon
Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 1a23ab0 |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 |
| Default Java | 1.8.0_191 |
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/292/testReport/ |
| modules | C: lucene solr solr/core U: . |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/292/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Upgrade Guava to 25.1-jre
> -
>
> Key: SOLR-11763
> URL: https://issues.apache.org/jira/browse/SOLR-11763
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Markus Jelsma
>Assignee: Kevin Risden
>Priority: Minor
> Fix For: 8.x, master (9.0)
>
> Attachments: SOLR-11763.patch, SOLR-11763.patch, SOLR-11763.patch,
> SOLR-11763.patch, SOLR-11763.patch
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Our code is running into version conflicts with Solr's old Guava dependency.
> This fixes it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre
[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759241#comment-16759241 ] Kevin Risden commented on SOLR-11763: - Latest patch upgrades curator and adds license/notice for jayway json-path required by Calcite. > Upgrade Guava to 25.1-jre > - > > Key: SOLR-11763 > URL: https://issues.apache.org/jira/browse/SOLR-11763 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Markus Jelsma >Assignee: Kevin Risden >Priority: Minor > Fix For: 8.x, master (9.0) > > Attachments: SOLR-11763.patch, SOLR-11763.patch, SOLR-11763.patch, > SOLR-11763.patch, SOLR-11763.patch > > Time Spent: 1h > Remaining Estimate: 0h > > Our code is running into version conflicts with Solr's old Guava dependency. > This fixes it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre
[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759239#comment-16759239 ] Kevin Risden commented on SOLR-11763: - Curator uses Guava and in the version we are using it is not shaded. Curator ended up shading guava to shield users of Curator from dealing with issues. Need to upgrade curator to take advantage of this. Will upgrade Curator to 2.13.0 which is what Hadoop 3.2 is using as well. > Upgrade Guava to 25.1-jre > - > > Key: SOLR-11763 > URL: https://issues.apache.org/jira/browse/SOLR-11763 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Markus Jelsma >Assignee: Kevin Risden >Priority: Minor > Attachments: SOLR-11763.patch, SOLR-11763.patch, SOLR-11763.patch, > SOLR-11763.patch > > Time Spent: 1h > Remaining Estimate: 0h > > Our code is running into version conflicts with Solr's old Guava dependency. > This fixes it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre
[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759209#comment-16759209 ] Kevin Risden commented on SOLR-11763: - PR is based on apache branch jira/solr-11763. I have checked that everything compiles so far. I have not checked that tests pass. I'll setup some test runs on this later today to see how things are looking. > Upgrade Guava to 25.1-jre > - > > Key: SOLR-11763 > URL: https://issues.apache.org/jira/browse/SOLR-11763 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Markus Jelsma >Assignee: Kevin Risden >Priority: Minor > Attachments: SOLR-11763.patch, SOLR-11763.patch, SOLR-11763.patch, > SOLR-11763.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Our code is running into version conflicts with Solr's old Guava dependency. > This fixes it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11763) Upgrade Guava to 25.1-jre
[ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759202#comment-16759202 ] Kevin Risden commented on SOLR-11763: - In the Apache Knox project we have integration tests with Hadoop (just like Solr basically) and we were able to upgrade only to 25.1-jre for the Hadoop integration tests. 26.0 had some backwards incompatible changes. Details in KNOX-1611 > Upgrade Guava to 25.1-jre > - > > Key: SOLR-11763 > URL: https://issues.apache.org/jira/browse/SOLR-11763 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 7.1 >Reporter: Markus Jelsma >Assignee: Varun Thacker >Priority: Minor > Attachments: SOLR-11763.patch, SOLR-11763.patch, SOLR-11763.patch > > > Our code is running into version conflicts with Solr's old Guava dependency. > This fixes it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
