[jira] [Commented] (SOLR-11929) TestRecovery failures

2018-04-04 Thread Andrzej Bialecki (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425160#comment-16425160
 ] 

Andrzej Bialecki  commented on SOLR-11929:
--

[~steve_rowe] LGTM, good catch!

> TestRecovery failures
> -
>
> Key: SOLR-11929
> URL: https://issues.apache.org/jira/browse/SOLR-11929
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Steve Rowe
>Priority: Major
> Attachments: SOLR-11929.patch
>
>
> My Jenkins found a branch_7x seed for {{TestRecovery.testBuffering()}} and 
> {{TestRecovery.testCorruptLog()}} that reproduces for me 5/5 times (when I 
> exclude {{-Dtests.method=...}} from the cmdline):
> {noformat}
> Checking out Revision 1ef988a26378137b1e1f022985dacee1f557f4fc 
> (refs/remotes/origin/branch_7x)
> [...]
>[junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=TestRecovery 
> -Dtests.method=testBuffering -Dtests.seed=FC96FD26F8A8CC6F -Dtests.slow=true 
> -Dtests.locale=de-GR -Dtests.timezone=Europe/London -Dtests.asserts=true 
> -Dtests.file.encoding=UTF-8
>[junit4] FAILURE 0.02s J3  | TestRecovery.testBuffering <<<
>[junit4]> Throwable #1: java.lang.AssertionError: expected:<1> but 
> was:<3>
>[junit4]>  at 
> __randomizedtesting.SeedInfo.seed([FC96FD26F8A8CC6F:E178530D59F16D44]:0)
>[junit4]>  at 
> org.apache.solr.search.TestRecovery.testBuffering(TestRecovery.java:494)
>[junit4]>  at java.lang.Thread.run(Thread.java:748)
> [...]
>[junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=TestRecovery 
> -Dtests.method=testCorruptLog -Dtests.seed=FC96FD26F8A8CC6F -Dtests.slow=true 
> -Dtests.locale=de-GR -Dtests.timezone=Europe/London -Dtests.asserts=true 
> -Dtests.file.encoding=UTF-8
>[junit4] ERROR   0.35s J3  | TestRecovery.testCorruptLog <<<
>[junit4]> Throwable #1: java.lang.RuntimeException: mismatch: '3'!='0' 
> @ response/numFound
>[junit4]>  at 
> __randomizedtesting.SeedInfo.seed([FC96FD26F8A8CC6F:E4B49F502909DB3]:0)
>[junit4]>  at 
> org.apache.solr.SolrTestCaseJ4.assertJQ(SolrTestCaseJ4.java:990)
>[junit4]>  at 
> org.apache.solr.SolrTestCaseJ4.assertJQ(SolrTestCaseJ4.java:937)
>[junit4]>  at 
> org.apache.solr.search.TestRecovery.testCorruptLog(TestRecovery.java:1367)
>[junit4]>  at java.lang.Thread.run(Thread.java:748)
> [...]
>[junit4]   2> NOTE: test params are: codec=Asserting(Lucene70): 
> {_root_=PostingsFormat(name=LuceneVarGapFixedInterval), 
> id=PostingsFormat(name=Direct)}, 
> docValues:{_version_=DocValuesFormat(name=Lucene70), 
> val_i_dvo=DocValuesFormat(name=Memory), val_i=DocValuesFormat(name=Memory)}, 
> maxPointsInLeafNode=1937, maxMBSortInHeap=7.529691259992591, 
> sim=RandomSimilarity(queryNorm=false): {}, locale=de-GR, 
> timezone=Europe/London
>[junit4]   2> NOTE: Linux 4.1.0-custom2-amd64 amd64/Oracle Corporation 
> 1.8.0_151 (64-bit)/cpus=16,threads=1,free=217064096,total=530579456
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-11929) TestRecovery failures

2018-04-03 Thread Steve Rowe (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424784#comment-16424784
 ] 

Steve Rowe commented on SOLR-11929:
---

I traced the problem to the {{testReload()}} method being run prior to the 
other failing test methods; when I comment out its body all tests succeed with 
all seeds.  

The NPE in {{testBuffering()}} is caused by the {{TLOG.state}} metric not being 
present, apparently because {{UpdateLog.initializeMetrics()}} is never called 
on core reload.

I've attached a patch that initializes {{UpdateLog}} metrics upon core reload, 
and this allows all tests to pass with the seeds I have for this problem 
(another one not listed above: {{F999698B6BBE3431}}, from 
https://jenkins.thetaphi.de/job/Lucene-Solr-master-MacOSX/4542/ ).

[~ab], can you take a look and see if the patch is doing the right thing here?


> TestRecovery failures
> -
>
> Key: SOLR-11929
> URL: https://issues.apache.org/jira/browse/SOLR-11929
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Steve Rowe
>Priority: Major
> Attachments: SOLR-11929.patch
>
>
> My Jenkins found a branch_7x seed for {{TestRecovery.testBuffering()}} and 
> {{TestRecovery.testCorruptLog()}} that reproduces for me 5/5 times (when I 
> exclude {{-Dtests.method=...}} from the cmdline):
> {noformat}
> Checking out Revision 1ef988a26378137b1e1f022985dacee1f557f4fc 
> (refs/remotes/origin/branch_7x)
> [...]
>[junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=TestRecovery 
> -Dtests.method=testBuffering -Dtests.seed=FC96FD26F8A8CC6F -Dtests.slow=true 
> -Dtests.locale=de-GR -Dtests.timezone=Europe/London -Dtests.asserts=true 
> -Dtests.file.encoding=UTF-8
>[junit4] FAILURE 0.02s J3  | TestRecovery.testBuffering <<<
>[junit4]> Throwable #1: java.lang.AssertionError: expected:<1> but 
> was:<3>
>[junit4]>  at 
> __randomizedtesting.SeedInfo.seed([FC96FD26F8A8CC6F:E178530D59F16D44]:0)
>[junit4]>  at 
> org.apache.solr.search.TestRecovery.testBuffering(TestRecovery.java:494)
>[junit4]>  at java.lang.Thread.run(Thread.java:748)
> [...]
>[junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=TestRecovery 
> -Dtests.method=testCorruptLog -Dtests.seed=FC96FD26F8A8CC6F -Dtests.slow=true 
> -Dtests.locale=de-GR -Dtests.timezone=Europe/London -Dtests.asserts=true 
> -Dtests.file.encoding=UTF-8
>[junit4] ERROR   0.35s J3  | TestRecovery.testCorruptLog <<<
>[junit4]> Throwable #1: java.lang.RuntimeException: mismatch: '3'!='0' 
> @ response/numFound
>[junit4]>  at 
> __randomizedtesting.SeedInfo.seed([FC96FD26F8A8CC6F:E4B49F502909DB3]:0)
>[junit4]>  at 
> org.apache.solr.SolrTestCaseJ4.assertJQ(SolrTestCaseJ4.java:990)
>[junit4]>  at 
> org.apache.solr.SolrTestCaseJ4.assertJQ(SolrTestCaseJ4.java:937)
>[junit4]>  at 
> org.apache.solr.search.TestRecovery.testCorruptLog(TestRecovery.java:1367)
>[junit4]>  at java.lang.Thread.run(Thread.java:748)
> [...]
>[junit4]   2> NOTE: test params are: codec=Asserting(Lucene70): 
> {_root_=PostingsFormat(name=LuceneVarGapFixedInterval), 
> id=PostingsFormat(name=Direct)}, 
> docValues:{_version_=DocValuesFormat(name=Lucene70), 
> val_i_dvo=DocValuesFormat(name=Memory), val_i=DocValuesFormat(name=Memory)}, 
> maxPointsInLeafNode=1937, maxMBSortInHeap=7.529691259992591, 
> sim=RandomSimilarity(queryNorm=false): {}, locale=de-GR, 
> timezone=Europe/London
>[junit4]   2> NOTE: Linux 4.1.0-custom2-amd64 amd64/Oracle Corporation 
> 1.8.0_151 (64-bit)/cpus=16,threads=1,free=217064096,total=530579456
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-11929) TestRecovery failures

2018-03-29 Thread Steve Rowe (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16419428#comment-16419428
 ] 

Steve Rowe commented on SOLR-11929:
---

Another reproducing seed (again without {{\-Dtests.method=...}}), from 
[https://jenkins.thetaphi.de/job/Lucene-Solr-master-Solaris/1769/]:

{noformat}
Checking out Revision 668b81721fa5b539d9286ed2f464426a598c352a 
(refs/remotes/origin/master)
[...]
   [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=TestRecovery 
-Dtests.method=testBuffering -Dtests.seed=D6674863F4F03A58 -Dtests.slow=true 
-Dtests.locale=lt -Dtests.timezone=Africa/Conakry -Dtests.asserts=true 
-Dtests.file.encoding=US-ASCII
   [junit4] ERROR   0.02s J0 | TestRecovery.testBuffering <<<
   [junit4]> Throwable #1: java.lang.NullPointerException
   [junit4]>at 
__randomizedtesting.SeedInfo.seed([D6674863F4F03A58:CB89E64855A99B73]:0)
   [junit4]>at 
org.apache.solr.search.TestRecovery.testBuffering(TestRecovery.java:495)
   [junit4]>at java.lang.Thread.run(Thread.java:748)
[...]
   [junit4]   2> 1992912 ERROR 
(TEST-TestRecovery.testRecoveryMultipleLogs-seed#[D6674863F4F03A58]) [
x:collection1] o.a.s.SolrTestCaseJ4 query failed JSON validation. 
error=mismatch: '6'!='3' @ response/numFound
   [junit4]   2>  expected =/response/numFound==6
   [junit4]   2>  response = {
   [junit4]   2>   "responseHeader":{
   [junit4]   2> "status":0,
   [junit4]   2> "QTime":0},
   [junit4]   2>   "response":{"numFound":3,"start":0,"docs":[
   [junit4]   2>   {
   [junit4]   2> "id":"aa",
   [junit4]   2> "_version_":1596276857454460929},
   [junit4]   2>   {
   [junit4]   2> "id":"bb",
   [junit4]   2> "_version_":1596276857455509504},
   [junit4]   2>   {
   [junit4]   2> "id":"cc",
   [junit4]   2> "_version_":1596276857455509505}]
   [junit4]   2>   }}
   [junit4]   2> 
   [junit4]   2>  request = q=*:*&wt=xml
   [junit4]   2> 1992912 INFO  
(TEST-TestRecovery.testRecoveryMultipleLogs-seed#[D6674863F4F03A58]) [
x:collection1] o.a.s.SolrTestCaseJ4 ###Ending testRecoveryMultipleLogs
   [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=TestRecovery 
-Dtests.method=testRecoveryMultipleLogs -Dtests.seed=D6674863F4F03A58 
-Dtests.slow=true -Dtests.locale=lt -Dtests.timezone=Africa/Conakry 
-Dtests.asserts=true -Dtests.file.encoding=US-ASCII
   [junit4] ERROR   0.36s J0 | TestRecovery.testRecoveryMultipleLogs <<<
   [junit4]> Throwable #1: java.lang.RuntimeException: mismatch: '6'!='3' @ 
response/numFound
   [junit4]>at 
__randomizedtesting.SeedInfo.seed([D6674863F4F03A58:6FF2D052738B7DB1]:0)
   [junit4]>at 
org.apache.solr.SolrTestCaseJ4.assertJQ(SolrTestCaseJ4.java:1002)
   [junit4]>at 
org.apache.solr.SolrTestCaseJ4.assertJQ(SolrTestCaseJ4.java:949)
   [junit4]>at 
org.apache.solr.search.TestRecovery.testRecoveryMultipleLogs(TestRecovery.java:1448)
   [junit4]>at java.lang.Thread.run(Thread.java:748)
[...]
   [junit4]   2> NOTE: test params are: codec=Asserting(Lucene70): 
{_root_=Lucene50(blocksize=128), id=FSTOrd50}, 
docValues:{_version_=DocValuesFormat(name=Lucene70), 
val_i_dvo=DocValuesFormat(name=Asserting)}, maxPointsInLeafNode=647, 
maxMBSortInHeap=6.830494683367925, 
sim=Asserting(org.apache.lucene.search.similarities.AssertingSimilarity@2da1e99a),
 locale=lt, timezone=Africa/Conakry
   [junit4]   2> NOTE: SunOS 5.11 amd64/Oracle Corporation 1.8.0_162 
(64-bit)/cpus=3,threads=1,free=161610624,total=473956352
{noformat}


> TestRecovery failures
> -
>
> Key: SOLR-11929
> URL: https://issues.apache.org/jira/browse/SOLR-11929
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Steve Rowe
>Priority: Major
>
> My Jenkins found a branch_7x seed for {{TestRecovery.testBuffering()}} and 
> {{TestRecovery.testCorruptLog()}} that reproduces for me 5/5 times (when I 
> exclude {{-Dtests.method=...}} from the cmdline):
> {noformat}
> Checking out Revision 1ef988a26378137b1e1f022985dacee1f557f4fc 
> (refs/remotes/origin/branch_7x)
> [...]
>[junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=TestRecovery 
> -Dtests.method=testBuffering -Dtests.seed=FC96FD26F8A8CC6F -Dtests.slow=true 
> -Dtests.locale=de-GR -Dtests.timezone=Europe/London -Dtests.asserts=true 
> -Dtests.file.encoding=UTF-8
>[junit4] FAILURE 0.02s J3  | TestRecovery.testBuffering <<<
>[junit4]> Throwable #1: java.lang.AssertionError: expected:<1> but 
> was:<3>
>[junit4]>  at 
> __randomizedtesting.SeedInfo.seed([FC96FD26F8A8CC6F:E178530D59F16D44]:0)
>[junit4]>  at 
> org.apache.solr.search.TestRecovery.testBuffering(TestRecovery.java:494)
>[