[jira] [Commented] (SOLR-11956) Collapsing on undefined field returns 500
[ https://issues.apache.org/jira/browse/SOLR-11956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631983#comment-16631983 ] Erick Erickson commented on SOLR-11956: --- [~dsmiley] Can we close this one? > Collapsing on undefined field returns 500 > - > > Key: SOLR-11956 > URL: https://issues.apache.org/jira/browse/SOLR-11956 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: query parsers >Reporter: Munendra S N >Priority: Trivial > Attachments: SOLR-11956.patch, SOLR-11956.patch, SOLR-11956.patch > > > When collapsing is specified on the undefined field then, the response > returned has status 500 instead of 400. > This is because of wrapping of SolrException to RuntimeException > https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/search/CollapsingQParserPlugin.java#L377 > Then in request handler base, all RuntimeException are converted to > SolrException with status 500 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11956) Collapsing on undefined field returns 500
[ https://issues.apache.org/jira/browse/SOLR-11956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631980#comment-16631980 ] Munendra S N commented on SOLR-11956: - This issue has been fixed as part of SOLR-6280 > Collapsing on undefined field returns 500 > - > > Key: SOLR-11956 > URL: https://issues.apache.org/jira/browse/SOLR-11956 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: query parsers >Reporter: Munendra S N >Priority: Trivial > Attachments: SOLR-11956.patch, SOLR-11956.patch, SOLR-11956.patch > > > When collapsing is specified on the undefined field then, the response > returned has status 500 instead of 400. > This is because of wrapping of SolrException to RuntimeException > https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/search/CollapsingQParserPlugin.java#L377 > Then in request handler base, all RuntimeException are converted to > SolrException with status 500 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11956) Collapsing on undefined field returns 500
[
https://issues.apache.org/jira/browse/SOLR-11956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499101#comment-16499101
]
Lucene/Solr QA commented on SOLR-11956:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
20s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 2m 17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 2m 17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 2m 17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 75m 42s{color}
| {color:red} core in the patch failed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 84m 28s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | solr.cloud.autoscaling.sim.TestTriggerIntegration |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-11956 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12910321/SOLR-11956.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 3.13.0-88-generic #135-Ubuntu SMP Wed Jun 8
21:10:42 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 3dc4fa1 |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on April 8 2014 |
| Default Java | 1.8.0_172 |
| unit |
https://builds.apache.org/job/PreCommit-SOLR-Build/111/artifact/out/patch-unit-solr_core.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/111/testReport/ |
| modules | C: solr/core U: solr/core |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/111/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Collapsing on undefined field returns 500
> -
>
> Key: SOLR-11956
> URL: https://issues.apache.org/jira/browse/SOLR-11956
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: query parsers
>Reporter: Munendra S N
>Priority: Trivial
> Attachments: SOLR-11956.patch, SOLR-11956.patch, SOLR-11956.patch
>
>
> When collapsing is specified on the undefined field then, the response
> returned has status 500 instead of 400.
> This is because of wrapping of SolrException to RuntimeException
> https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/search/CollapsingQParserPlugin.java#L377
> Then in request handler base, all RuntimeException are converted to
> SolrException with status 500
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11956) Collapsing on undefined field returns 500
[ https://issues.apache.org/jira/browse/SOLR-11956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498030#comment-16498030 ] Munendra S N commented on SOLR-11956: - As with collapsing, expand component also returns 500 when it shouldn't (instead it should return 400). > Collapsing on undefined field returns 500 > - > > Key: SOLR-11956 > URL: https://issues.apache.org/jira/browse/SOLR-11956 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: query parsers >Reporter: Munendra S N >Priority: Trivial > Attachments: SOLR-11956.patch, SOLR-11956.patch, SOLR-11956.patch > > > When collapsing is specified on the undefined field then, the response > returned has status 500 instead of 400. > This is because of wrapping of SolrException to RuntimeException > https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/search/CollapsingQParserPlugin.java#L377 > Then in request handler base, all RuntimeException are converted to > SolrException with status 500 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11956) Collapsing on undefined field returns 500
[
https://issues.apache.org/jira/browse/SOLR-11956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412524#comment-16412524
]
Lucene/Solr QA commented on SOLR-11956:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
17s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 1m 14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 1m 14s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 50m 30s{color}
| {color:red} core in the patch failed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 55m 23s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | solr.cloud.autoscaling.TriggerIntegrationTest |
| | solr.cloud.autoscaling.ComputePlanActionTest |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-11956 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12910321/SOLR-11956.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 3.13.0-88-generic #135-Ubuntu SMP Wed Jun 8
21:10:42 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / ea50409 |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on April 8 2014 |
| Default Java | 1.8.0_144 |
| unit |
https://builds.apache.org/job/PreCommit-SOLR-Build/16/artifact/out/patch-unit-solr_core.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/16/testReport/ |
| modules | C: solr/core U: solr/core |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/16/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Collapsing on undefined field returns 500
> -
>
> Key: SOLR-11956
> URL: https://issues.apache.org/jira/browse/SOLR-11956
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: query parsers
>Reporter: Munendra S N
>Priority: Trivial
> Attachments: SOLR-11956.patch, SOLR-11956.patch, SOLR-11956.patch
>
>
> When collapsing is specified on the undefined field then, the response
> returned has status 500 instead of 400.
> This is because of wrapping of SolrException to RuntimeException
> https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/search/CollapsingQParserPlugin.java#L377
> Then in request handler base, all RuntimeException are converted to
> SolrException with status 500
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11956) Collapsing on undefined field returns 500
[ https://issues.apache.org/jira/browse/SOLR-11956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360994#comment-16360994 ] Munendra S N commented on SOLR-11956: - [^SOLR-11956.patch] Updated patch handles only Checked exception. Also, Throwing SolrException instead of IOException where it suits better. One more, there are many assertions used in Collapse parser but assertions are not enabled by default and assertions would be ignored. I think either assertions should not be used or use of it should be documented > Collapsing on undefined field returns 500 > - > > Key: SOLR-11956 > URL: https://issues.apache.org/jira/browse/SOLR-11956 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Munendra S N >Priority: Trivial > Attachments: SOLR-11956.patch, SOLR-11956.patch > > > When collapsing is specified on the undefined field then, the response > returned has status 500 instead of 400. > This is because of wrapping of SolrException to RuntimeException > https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/search/CollapsingQParserPlugin.java#L377 > Then in request handler base, all RuntimeException are converted to > SolrException with status 500 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11956) Collapsing on undefined field returns 500
[
https://issues.apache.org/jira/browse/SOLR-11956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355538#comment-16355538
]
Munendra S N commented on SOLR-11956:
-
In the patch, If Exception is SolrException then dont wrap in RuntimeException.
{code:java}
try {
SolrIndexSearcher searcher = (SolrIndexSearcher)indexSearcher;
CollectorFactory collectorFactory = new CollectorFactory();
//Deal with boosted docs.
//We have to deal with it here rather then the constructor because
//because the QueryElevationComponent runs after the Queries are
constructed.
IntIntHashMap boostDocsMap = null;
Map context = null;
SolrRequestInfo info = SolrRequestInfo.getRequestInfo();
if(info != null) {
context = info.getReq().getContext();
}
if(this.boosted == null && context != null) {
this.boosted = (Map)context.get(QueryElevationComponent.BOOSTED_PRIORITY);
}
boostDocsMap = getBoostDocs(searcher, this.boosted, context);
return collectorFactory.getCollector(this.collapseField,
this.groupHeadSelector,
this.sortSpec,
this.nullPolicy,
this.hint,
this.needsScores,
this.size,
boostDocsMap,
searcher);
} catch (SolrException e) {
throw e;
} catch (Exception e) {
// catch all individual exceptions, Generic Exception handling is bad
throw new RuntimeException(e);
}
}
{code}
This block could throw IOException(No other Checked Exception). So, instead of
wrapping all Exception in RuntimeException, IOException could be wrapping in
RuntimeException.
> Collapsing on undefined field returns 500
> -
>
> Key: SOLR-11956
> URL: https://issues.apache.org/jira/browse/SOLR-11956
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Munendra S N
>Priority: Trivial
> Attachments: SOLR-11956.patch
>
>
> When collapsing is specified on the undefined field then, the response
> returned has status 500 instead of 400.
> This is because of wrapping of SolrException to RuntimeException
> https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/search/CollapsingQParserPlugin.java#L377
> Then in request handler base, all RuntimeException are converted to
> SolrException with status 500
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
