[jira] [Commented] (SOLR-12133) TriggerIntegrationTest fails too easily.
[ https://issues.apache.org/jira/browse/SOLR-12133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422812#comment-16422812 ] Joel Bernstein commented on SOLR-12133: --- No problem! > TriggerIntegrationTest fails too easily. > > > Key: SOLR-12133 > URL: https://issues.apache.org/jira/browse/SOLR-12133 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Mark Miller >Assignee: Shalin Shekhar Mangar >Priority: Major > Attachments: SOLR-12133-testNodeMarkersRegistration.patch, > SOLR-12133.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12133) TriggerIntegrationTest fails too easily.
[ https://issues.apache.org/jira/browse/SOLR-12133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422790#comment-16422790 ] ASF subversion and git services commented on SOLR-12133: Commit 4d3149d4344efed263d852829273d90d9b0a1c12 in lucene-solr's branch refs/heads/branch_7x from [~joel.bernstein] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4d3149d ] SOLR-12133: Fix precommit > TriggerIntegrationTest fails too easily. > > > Key: SOLR-12133 > URL: https://issues.apache.org/jira/browse/SOLR-12133 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Mark Miller >Assignee: Shalin Shekhar Mangar >Priority: Major > Attachments: SOLR-12133-testNodeMarkersRegistration.patch, > SOLR-12133.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12133) TriggerIntegrationTest fails too easily.
[ https://issues.apache.org/jira/browse/SOLR-12133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422771#comment-16422771 ] Shalin Shekhar Mangar commented on SOLR-12133: -- Thanks Joel! > TriggerIntegrationTest fails too easily. > > > Key: SOLR-12133 > URL: https://issues.apache.org/jira/browse/SOLR-12133 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Mark Miller >Assignee: Shalin Shekhar Mangar >Priority: Major > Attachments: SOLR-12133-testNodeMarkersRegistration.patch, > SOLR-12133.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12133) TriggerIntegrationTest fails too easily.
[ https://issues.apache.org/jira/browse/SOLR-12133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422760#comment-16422760 ] Joel Bernstein commented on SOLR-12133: --- Just pushed a fix for a precommit error related to this ticket. I'll backport as well. > TriggerIntegrationTest fails too easily. > > > Key: SOLR-12133 > URL: https://issues.apache.org/jira/browse/SOLR-12133 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Mark Miller >Assignee: Shalin Shekhar Mangar >Priority: Major > Attachments: SOLR-12133-testNodeMarkersRegistration.patch, > SOLR-12133.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12133) TriggerIntegrationTest fails too easily.
[ https://issues.apache.org/jira/browse/SOLR-12133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422759#comment-16422759 ] ASF subversion and git services commented on SOLR-12133: Commit 269a67694058a6e6b86d5e97b0dc6d579783ceda in lucene-solr's branch refs/heads/master from [~joel.bernstein] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=269a676 ] SOLR-12133: Fix precommit > TriggerIntegrationTest fails too easily. > > > Key: SOLR-12133 > URL: https://issues.apache.org/jira/browse/SOLR-12133 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Mark Miller >Assignee: Shalin Shekhar Mangar >Priority: Major > Attachments: SOLR-12133-testNodeMarkersRegistration.patch, > SOLR-12133.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12133) TriggerIntegrationTest fails too easily.
[ https://issues.apache.org/jira/browse/SOLR-12133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422651#comment-16422651 ] ASF subversion and git services commented on SOLR-12133: Commit 7bc454ad966c35aca16bb67c81a890e3a091cc1d in lucene-solr's branch refs/heads/branch_7x from [~shalinmangar] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7bc454a ] SOLR-12133: Removing BadApple annotation (cherry picked from commit 805438c) > TriggerIntegrationTest fails too easily. > > > Key: SOLR-12133 > URL: https://issues.apache.org/jira/browse/SOLR-12133 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Mark Miller >Assignee: Shalin Shekhar Mangar >Priority: Major > Attachments: SOLR-12133-testNodeMarkersRegistration.patch, > SOLR-12133.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12133) TriggerIntegrationTest fails too easily.
[ https://issues.apache.org/jira/browse/SOLR-12133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422649#comment-16422649 ] ASF subversion and git services commented on SOLR-12133: Commit 805438c59debe995da6c68d55cc4d406f9625e9d in lucene-solr's branch refs/heads/master from [~shalinmangar] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=805438c ] SOLR-12133: Removing BadApple annotation > TriggerIntegrationTest fails too easily. > > > Key: SOLR-12133 > URL: https://issues.apache.org/jira/browse/SOLR-12133 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Mark Miller >Assignee: Shalin Shekhar Mangar >Priority: Major > Attachments: SOLR-12133-testNodeMarkersRegistration.patch, > SOLR-12133.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12133) TriggerIntegrationTest fails too easily.
[ https://issues.apache.org/jira/browse/SOLR-12133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422646#comment-16422646 ] ASF subversion and git services commented on SOLR-12133: Commit 90374bfb15bb88c44a338f4db912653b3cc31d57 in lucene-solr's branch refs/heads/branch_7x from [~shalinmangar] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=90374bf ] SOLR-12133: Fix race conditions that caused NodeMarkersRegistrationTest.testNodeMarkersRegistration to fail (cherry picked from commit 8189e4f) > TriggerIntegrationTest fails too easily. > > > Key: SOLR-12133 > URL: https://issues.apache.org/jira/browse/SOLR-12133 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Mark Miller >Assignee: Shalin Shekhar Mangar >Priority: Major > Attachments: SOLR-12133-testNodeMarkersRegistration.patch, > SOLR-12133.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12133) TriggerIntegrationTest fails too easily.
[ https://issues.apache.org/jira/browse/SOLR-12133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422644#comment-16422644 ] ASF subversion and git services commented on SOLR-12133: Commit 8189e4f9722b8e658214903028635ca0a8fb43ee in lucene-solr's branch refs/heads/master from [~shalinmangar] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8189e4f ] SOLR-12133: Fix race conditions that caused NodeMarkersRegistrationTest.testNodeMarkersRegistration to fail > TriggerIntegrationTest fails too easily. > > > Key: SOLR-12133 > URL: https://issues.apache.org/jira/browse/SOLR-12133 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Mark Miller >Assignee: Shalin Shekhar Mangar >Priority: Major > Attachments: SOLR-12133-testNodeMarkersRegistration.patch, > SOLR-12133.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12133) TriggerIntegrationTest fails too easily.
[ https://issues.apache.org/jira/browse/SOLR-12133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422639#comment-16422639 ] Shalin Shekhar Mangar commented on SOLR-12133: -- Attached a fix for testNodeMarkersRegistration (this was moved to its own class in SOLR-12152). I beasted this 200 times. I had trouble reproducing this failure before too so the only thing I can be sure of is that I haven't broken anything. The test fails only on very fast machines (Steve's jenkins mostly, although I saw 1 failure on policeman jenkins). > TriggerIntegrationTest fails too easily. > > > Key: SOLR-12133 > URL: https://issues.apache.org/jira/browse/SOLR-12133 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Mark Miller >Assignee: Shalin Shekhar Mangar >Priority: Major > Attachments: SOLR-12133-testNodeMarkersRegistration.patch, > SOLR-12133.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12133) TriggerIntegrationTest fails too easily.
[ https://issues.apache.org/jira/browse/SOLR-12133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422243#comment-16422243 ] Mark Miller commented on SOLR-12133: Thanks Shalin, this one was failing a lot on my std dev machine test runs. > TriggerIntegrationTest fails too easily. > > > Key: SOLR-12133 > URL: https://issues.apache.org/jira/browse/SOLR-12133 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Mark Miller >Assignee: Shalin Shekhar Mangar >Priority: Major > Attachments: SOLR-12133.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12133) TriggerIntegrationTest fails too easily.
[ https://issues.apache.org/jira/browse/SOLR-12133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422076#comment-16422076 ] Shalin Shekhar Mangar commented on SOLR-12133: -- The testNodeMarkersRegistration failures are also due to a race condition in the test. The test asserts that a znode is created on node added and node lost events respectively which is then deleted after the trigger fires. But the znode is deleted by the trigger thread whereas the actions are executed by the action executor asynchronously. So sometimes the marker znodes can be deleted even before the test has a chance to assert that they exist. I think we can fix it by using a listener which is executed in the same thread as the trigger and perform the assert there. > TriggerIntegrationTest fails too easily. > > > Key: SOLR-12133 > URL: https://issues.apache.org/jira/browse/SOLR-12133 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Mark Miller >Assignee: Shalin Shekhar Mangar >Priority: Major > Attachments: SOLR-12133.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12133) TriggerIntegrationTest fails too easily.
[ https://issues.apache.org/jira/browse/SOLR-12133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420738#comment-16420738 ] ASF subversion and git services commented on SOLR-12133: Commit 85decabe46966ec3a73e80294fe33cfa862975fd in lucene-solr's branch refs/heads/master from [~shalinmangar] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=85decab ] SOLR-12133: Fix race conditions that caused TriggerIntegrationTest.testEventQueue to fail > TriggerIntegrationTest fails too easily. > > > Key: SOLR-12133 > URL: https://issues.apache.org/jira/browse/SOLR-12133 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Mark Miller >Assignee: Shalin Shekhar Mangar >Priority: Major > Attachments: SOLR-12133.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12133) TriggerIntegrationTest fails too easily.
[ https://issues.apache.org/jira/browse/SOLR-12133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420740#comment-16420740 ] ASF subversion and git services commented on SOLR-12133: Commit 6f2caaad009f87d88e2846d6268350e0ffce648d in lucene-solr's branch refs/heads/branch_7x from [~shalinmangar] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6f2caaa ] SOLR-12133: Fix race conditions that caused TriggerIntegrationTest.testEventQueue to fail (cherry picked from commit 85decab) > TriggerIntegrationTest fails too easily. > > > Key: SOLR-12133 > URL: https://issues.apache.org/jira/browse/SOLR-12133 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Mark Miller >Assignee: Shalin Shekhar Mangar >Priority: Major > Attachments: SOLR-12133.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12133) TriggerIntegrationTest fails too easily.
[ https://issues.apache.org/jira/browse/SOLR-12133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420520#comment-16420520 ] ASF subversion and git services commented on SOLR-12133: Commit 83f77bcb4917a5b9c7cc60cffea29ab8aa0626a8 in lucene-solr's branch refs/heads/branch_7x from [~shalinmangar] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=83f77bc ] SOLR-12133: Fix failures in TriggerIntegrationTest.testEventQueue due to race conditions (cherry picked from commit 83cca5c) > TriggerIntegrationTest fails too easily. > > > Key: SOLR-12133 > URL: https://issues.apache.org/jira/browse/SOLR-12133 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Mark Miller >Assignee: Shalin Shekhar Mangar >Priority: Major > Attachments: SOLR-12133.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12133) TriggerIntegrationTest fails too easily.
[ https://issues.apache.org/jira/browse/SOLR-12133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420394#comment-16420394 ] ASF subversion and git services commented on SOLR-12133: Commit 83cca5cd06aa0fdd9ce98415d6e9a0b1ecdfc7f5 in lucene-solr's branch refs/heads/master from [~shalinmangar] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=83cca5c ] SOLR-12133: Fix failures in TriggerIntegrationTest.testEventQueue due to race conditions > TriggerIntegrationTest fails too easily. > > > Key: SOLR-12133 > URL: https://issues.apache.org/jira/browse/SOLR-12133 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Mark Miller >Assignee: Shalin Shekhar Mangar >Priority: Major > Attachments: SOLR-12133.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12133) TriggerIntegrationTest fails too easily.
[ https://issues.apache.org/jira/browse/SOLR-12133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420391#comment-16420391 ] Shalin Shekhar Mangar commented on SOLR-12133: -- Patch fixes failures in testEventQueue due to race conditions > TriggerIntegrationTest fails too easily. > > > Key: SOLR-12133 > URL: https://issues.apache.org/jira/browse/SOLR-12133 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Mark Miller >Assignee: Shalin Shekhar Mangar >Priority: Major > Attachments: SOLR-12133.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
