[jira] [Commented] (SOLR-12141) Solr does not start on Windows with Java 10
[
https://issues.apache.org/jira/browse/SOLR-12141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415274#comment-16415274
]
Uwe Schindler commented on SOLR-12141:
--
By the way: On Solaris the whole script does not work anyways. At least it
would need to use "gawk". So I don't take care here.
> Solr does not start on Windows with Java 10
> ---
>
> Key: SOLR-12141
> URL: https://issues.apache.org/jira/browse/SOLR-12141
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 7.0, 7.1, 7.2, 7.3
> Environment: Windows 10 with Java 10+
>Reporter: Uwe Schindler
>Assignee: Uwe Schindler
>Priority: Blocker
> Fix For: 7.3
>
> Attachments: SOLR-12141.patch, SOLR-12141.patch, SOLR-12141.patch,
> SOLR-12141.patch, SOLR-12141.patch
>
>
> If you try to start Solr on Windows with Java 10, it fails with the following
> message:
> {noformat}
> C:\Users\Uwe Schindler\Desktop\solr-7.3.0\bin>solr start -e techproducts
> ERROR: Java 1.8 or later is required to run Solr. Current Java version is: 10
> {noformat}
> Java 8 and Java 9 works. I did not try Linux, but the version parsing on
> Windows is so braindead (i tried to fix it for Java 9 already). Windows CMD
> shell does not know any numerical comparisons, so it fails as "10" is
> alphabetically smaller "9".
> I hope this is better on Linux.
> Why do we have the version check at all? Wouldn't it be better to simply wait
> for a useful message by the Java VM on startup because of wrong class file
> format? This is too simply to break, especially as the output of "java
> -version" is not standardized (and changes with Java 10 to also have a date
> code,...). It also may contain "openjdk" instead of "java".
> So please please, let's get rid of the version check!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12141) Solr does not start on Windows with Java 10
[
https://issues.apache.org/jira/browse/SOLR-12141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415273#comment-16415273
]
Uwe Schindler commented on SOLR-12141:
--
Here is the patch. I tested it on Windows and Linux with Java 7, Java 8, Java
9, Java 9.0.4, Java 10 and Java 11-ea. It successfully starts for all versions,
except Java 7 (as expected), printing the following error:
{noformat}
thetaphi@serv1:~/solr-7.3.0/bin$ ./solr start -e techproducts
Your current version of Java is too old to run this version of Solr.
We found major version 7, using command
'/home/jenkins/tools/java/64bit/jdk1.7.0_80/bin/java -version', with response:
java version "1.7.0_80"
Java(TM) SE Runtime Environment (build 1.7.0_80-b15)
Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode)
Please install latest version of Java 8 or set JAVA_HOME properly.
Debug information:
JAVA_HOME: /home/jenkins/tools/java/64bit/jdk1.7.0_80
{noformat}
I will commit this later so we can respin the 7.3 release. Any comments or
suggestions.
In future issues we should really get rid of the version parsing with shell
magic, as this is likely to break. I will open a separate issue.
> Solr does not start on Windows with Java 10
> ---
>
> Key: SOLR-12141
> URL: https://issues.apache.org/jira/browse/SOLR-12141
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 7.0, 7.1, 7.2, 7.3
> Environment: Windows 10 with Java 10+
>Reporter: Uwe Schindler
>Assignee: Uwe Schindler
>Priority: Blocker
> Fix For: 7.3
>
> Attachments: SOLR-12141.patch, SOLR-12141.patch, SOLR-12141.patch,
> SOLR-12141.patch, SOLR-12141.patch
>
>
> If you try to start Solr on Windows with Java 10, it fails with the following
> message:
> {noformat}
> C:\Users\Uwe Schindler\Desktop\solr-7.3.0\bin>solr start -e techproducts
> ERROR: Java 1.8 or later is required to run Solr. Current Java version is: 10
> {noformat}
> Java 8 and Java 9 works. I did not try Linux, but the version parsing on
> Windows is so braindead (i tried to fix it for Java 9 already). Windows CMD
> shell does not know any numerical comparisons, so it fails as "10" is
> alphabetically smaller "9".
> I hope this is better on Linux.
> Why do we have the version check at all? Wouldn't it be better to simply wait
> for a useful message by the Java VM on startup because of wrong class file
> format? This is too simply to break, especially as the output of "java
> -version" is not standardized (and changes with Java 10 to also have a date
> code,...). It also may contain "openjdk" instead of "java".
> So please please, let's get rid of the version check!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12141) Solr does not start on Windows with Java 10
[
https://issues.apache.org/jira/browse/SOLR-12141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415235#comment-16415235
]
Uwe Schindler commented on SOLR-12141:
--
My "simple suggestion "to fix Linux script:
{code:sh}
java -version 2>&1 | head -1 | awk -F '"' '/version/ {print $2}' | sed
-e's/^1\.//' | sed -e's/[.-].*$//'
{code}
This is just an extension of the current code (the AWK). After that it just
strips "1." from beginning of version (for Java 8 compatibility) and then it
removes everything after first "." or "-". The remaining stuff should be the
major version as integer. I will post patch soon.
I was also talking with [~dawid.weiss] and Robert said the same: We should
really replace the version parsing in later Solr versions and repalce by a
simple call to a precompiled class file.
> Solr does not start on Windows with Java 10
> ---
>
> Key: SOLR-12141
> URL: https://issues.apache.org/jira/browse/SOLR-12141
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 7.0, 7.1, 7.2, 7.3
> Environment: Windows 10 with Java 10+
>Reporter: Uwe Schindler
>Assignee: Uwe Schindler
>Priority: Blocker
> Fix For: 7.3
>
> Attachments: SOLR-12141.patch, SOLR-12141.patch, SOLR-12141.patch,
> SOLR-12141.patch
>
>
> If you try to start Solr on Windows with Java 10, it fails with the following
> message:
> {noformat}
> C:\Users\Uwe Schindler\Desktop\solr-7.3.0\bin>solr start -e techproducts
> ERROR: Java 1.8 or later is required to run Solr. Current Java version is: 10
> {noformat}
> Java 8 and Java 9 works. I did not try Linux, but the version parsing on
> Windows is so braindead (i tried to fix it for Java 9 already). Windows CMD
> shell does not know any numerical comparisons, so it fails as "10" is
> alphabetically smaller "9".
> I hope this is better on Linux.
> Why do we have the version check at all? Wouldn't it be better to simply wait
> for a useful message by the Java VM on startup because of wrong class file
> format? This is too simply to break, especially as the output of "java
> -version" is not standardized (and changes with Java 10 to also have a date
> code,...). It also may contain "openjdk" instead of "java".
> So please please, let's get rid of the version check!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12141) Solr does not start on Windows with Java 10
[
https://issues.apache.org/jira/browse/SOLR-12141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415132#comment-16415132
]
Uwe Schindler commented on SOLR-12141:
--
Actually, the current AWK script does not even work with Solaris, this has to
be fixed anyways.
> Solr does not start on Windows with Java 10
> ---
>
> Key: SOLR-12141
> URL: https://issues.apache.org/jira/browse/SOLR-12141
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 7.0, 7.1, 7.2, 7.3
> Environment: Windows 10 with Java 10+
>Reporter: Uwe Schindler
>Assignee: Uwe Schindler
>Priority: Blocker
> Fix For: 7.3
>
> Attachments: SOLR-12141.patch, SOLR-12141.patch, SOLR-12141.patch,
> SOLR-12141.patch
>
>
> If you try to start Solr on Windows with Java 10, it fails with the following
> message:
> {noformat}
> C:\Users\Uwe Schindler\Desktop\solr-7.3.0\bin>solr start -e techproducts
> ERROR: Java 1.8 or later is required to run Solr. Current Java version is: 10
> {noformat}
> Java 8 and Java 9 works. I did not try Linux, but the version parsing on
> Windows is so braindead (i tried to fix it for Java 9 already). Windows CMD
> shell does not know any numerical comparisons, so it fails as "10" is
> alphabetically smaller "9".
> I hope this is better on Linux.
> Why do we have the version check at all? Wouldn't it be better to simply wait
> for a useful message by the Java VM on startup because of wrong class file
> format? This is too simply to break, especially as the output of "java
> -version" is not standardized (and changes with Java 10 to also have a date
> code,...). It also may contain "openjdk" instead of "java".
> So please please, let's get rid of the version check!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12141) Solr does not start on Windows with Java 10
[
https://issues.apache.org/jira/browse/SOLR-12141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414804#comment-16414804
]
Uwe Schindler commented on SOLR-12141:
--
Alternatively this shell command would work to get "major" java version:
{noformat}
thetaphi@serv1:~$ /home/jenkins/tools/java/64bit/jdk1.8.0_162/bin/java -version
2>&1 | head -1 | sed -Ee's/^.*version "(1\.)?([0-9]
+)?.*$/\2/'
8
thetaphi@serv1:~$ /home/jenkins/tools/java/64bit/jdk-9/bin/java -version 2>&1 |
head -1 | sed -Ee's/^.*version "(1\.)?([0-9]+)?.*$/
\2/'
9
thetaphi@serv1:~$ /home/jenkins/tools/java/64bit/jdk-9.0.4/bin/java -version
2>&1 | head -1 | sed -Ee's/^.*version "(1\.)?([0-9]+)?
.*$/\2/'
9
thetaphi@serv1:~$ /home/jenkins/tools/java/64bit/jdk-10/bin/java -version 2>&1
| head -1 | sed -Ee's/^.*version "(1\.)?([0-9]+)?.*$
/\2/'
10
thetaphi@serv1:~$ /home/jenkins/tools/java/64bit/jdk-11-ea+5/bin/java -version
2>&1 | head -1 | sed -Ee's/^.*version "(1\.)?([0-9]+
)?.*$/\2/'
11
{noformat}
Works on Linux and Macintosh, on Solaris it would need "gsed".
> Solr does not start on Windows with Java 10
> ---
>
> Key: SOLR-12141
> URL: https://issues.apache.org/jira/browse/SOLR-12141
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 7.0, 7.1, 7.2, 7.3
> Environment: Windows 10 with Java 10+
>Reporter: Uwe Schindler
>Assignee: Uwe Schindler
>Priority: Blocker
> Fix For: 7.3
>
> Attachments: SOLR-12141.patch, SOLR-12141.patch, SOLR-12141.patch,
> SOLR-12141.patch
>
>
> If you try to start Solr on Windows with Java 10, it fails with the following
> message:
> {noformat}
> C:\Users\Uwe Schindler\Desktop\solr-7.3.0\bin>solr start -e techproducts
> ERROR: Java 1.8 or later is required to run Solr. Current Java version is: 10
> {noformat}
> Java 8 and Java 9 works. I did not try Linux, but the version parsing on
> Windows is so braindead (i tried to fix it for Java 9 already). Windows CMD
> shell does not know any numerical comparisons, so it fails as "10" is
> alphabetically smaller "9".
> I hope this is better on Linux.
> Why do we have the version check at all? Wouldn't it be better to simply wait
> for a useful message by the Java VM on startup because of wrong class file
> format? This is too simply to break, especially as the output of "java
> -version" is not standardized (and changes with Java 10 to also have a date
> code,...). It also may contain "openjdk" instead of "java".
> So please please, let's get rid of the version check!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12141) Solr does not start on Windows with Java 10
[
https://issues.apache.org/jira/browse/SOLR-12141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414775#comment-16414775
]
Uwe Schindler commented on SOLR-12141:
--
+1, I'd do the same on windows. Maybe it should also simply return the major
version number, so the later stuff enabling switches for java 9 and java 10 GC
logging can be simplified.
> Solr does not start on Windows with Java 10
> ---
>
> Key: SOLR-12141
> URL: https://issues.apache.org/jira/browse/SOLR-12141
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 7.0, 7.1, 7.2, 7.3
> Environment: Windows 10 with Java 10+
>Reporter: Uwe Schindler
>Assignee: Uwe Schindler
>Priority: Blocker
> Fix For: 7.3
>
> Attachments: SOLR-12141.patch, SOLR-12141.patch, SOLR-12141.patch,
> SOLR-12141.patch
>
>
> If you try to start Solr on Windows with Java 10, it fails with the following
> message:
> {noformat}
> C:\Users\Uwe Schindler\Desktop\solr-7.3.0\bin>solr start -e techproducts
> ERROR: Java 1.8 or later is required to run Solr. Current Java version is: 10
> {noformat}
> Java 8 and Java 9 works. I did not try Linux, but the version parsing on
> Windows is so braindead (i tried to fix it for Java 9 already). Windows CMD
> shell does not know any numerical comparisons, so it fails as "10" is
> alphabetically smaller "9".
> I hope this is better on Linux.
> Why do we have the version check at all? Wouldn't it be better to simply wait
> for a useful message by the Java VM on startup because of wrong class file
> format? This is too simply to break, especially as the output of "java
> -version" is not standardized (and changes with Java 10 to also have a date
> code,...). It also may contain "openjdk" instead of "java".
> So please please, let's get rid of the version check!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12141) Solr does not start on Windows with Java 10
[
https://issues.apache.org/jira/browse/SOLR-12141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414772#comment-16414772
]
Robert Muir commented on SOLR-12141:
maybe add a simple "no-op" main method class and run it? If it fails with
non-zero exit code, just print an error like "unsupported or broken java: `java
-version`" or whatever. i think it would be a lot less fragile than parsing
version strings which may change in format etc.
> Solr does not start on Windows with Java 10
> ---
>
> Key: SOLR-12141
> URL: https://issues.apache.org/jira/browse/SOLR-12141
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 7.0, 7.1, 7.2, 7.3
> Environment: Windows 10 with Java 10+
>Reporter: Uwe Schindler
>Assignee: Uwe Schindler
>Priority: Blocker
> Fix For: 7.3
>
> Attachments: SOLR-12141.patch, SOLR-12141.patch, SOLR-12141.patch,
> SOLR-12141.patch
>
>
> If you try to start Solr on Windows with Java 10, it fails with the following
> message:
> {noformat}
> C:\Users\Uwe Schindler\Desktop\solr-7.3.0\bin>solr start -e techproducts
> ERROR: Java 1.8 or later is required to run Solr. Current Java version is: 10
> {noformat}
> Java 8 and Java 9 works. I did not try Linux, but the version parsing on
> Windows is so braindead (i tried to fix it for Java 9 already). Windows CMD
> shell does not know any numerical comparisons, so it fails as "10" is
> alphabetically smaller "9".
> I hope this is better on Linux.
> Why do we have the version check at all? Wouldn't it be better to simply wait
> for a useful message by the Java VM on startup because of wrong class file
> format? This is too simply to break, especially as the output of "java
> -version" is not standardized (and changes with Java 10 to also have a date
> code,...). It also may contain "openjdk" instead of "java".
> So please please, let's get rid of the version check!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12141) Solr does not start on Windows with Java 10
[
https://issues.apache.org/jira/browse/SOLR-12141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414697#comment-16414697
]
Uwe Schindler commented on SOLR-12141:
--
Actually on Linux it's even worse, it compares the full version string, so "10"
< "1.8" is always true. BUMMER.
> Solr does not start on Windows with Java 10
> ---
>
> Key: SOLR-12141
> URL: https://issues.apache.org/jira/browse/SOLR-12141
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 7.0, 7.1, 7.2, 7.3
> Environment: Windows 10 with Java 10+
>Reporter: Uwe Schindler
>Assignee: Uwe Schindler
>Priority: Blocker
> Fix For: 7.3
>
> Attachments: SOLR-12141.patch, SOLR-12141.patch, SOLR-12141.patch,
> SOLR-12141.patch
>
>
> If you try to start Solr on Windows with Java 10, it fails with the following
> message:
> {noformat}
> C:\Users\Uwe Schindler\Desktop\solr-7.3.0\bin>solr start -e techproducts
> ERROR: Java 1.8 or later is required to run Solr. Current Java version is: 10
> {noformat}
> Java 8 and Java 9 works. I did not try Linux, but the version parsing on
> Windows is so braindead (i tried to fix it for Java 9 already). Windows CMD
> shell does not know any numerical comparisons, so it fails as "10" is
> alphabetically smaller "9".
> I hope this is better on Linux.
> Why do we have the version check at all? Wouldn't it be better to simply wait
> for a useful message by the Java VM on startup because of wrong class file
> format? This is too simply to break, especially as the output of "java
> -version" is not standardized (and changes with Java 10 to also have a date
> code,...). It also may contain "openjdk" instead of "java".
> So please please, let's get rid of the version check!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12141) Solr does not start on Windows with Java 10
[
https://issues.apache.org/jira/browse/SOLR-12141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414692#comment-16414692
]
Uwe Schindler commented on SOLR-12141:
--
I tested Linux - Same issue (alphabetic comparison, not numeric):
{noformat}
thetaphi@serv1:~/solr-7.3.0/bin$ ./solr start -e techproducts
Your current version of Java is too old to run this version of Solr
We found version 10, using command
'/home/jenkins/tools/java/64bit/jdk-10/bin/java -version', with response:
openjdk version "10" 2018-03-20
OpenJDK Runtime Environment 18.3 (build 10+46)
OpenJDK 64-Bit Server VM 18.3 (build 10+46, mixed mode)
Please install latest version of Java 1.8 or set JAVA_HOME properly.
Debug information:
JAVA_HOME: /home/jenkins/tools/java/64bit/jdk-10
Active Path:
/home/jenkins/tools/java/64bit/jdk-10/bin/:/home/thetaphi/apache-ant-1.8.4/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
{noformat}
> Solr does not start on Windows with Java 10
> ---
>
> Key: SOLR-12141
> URL: https://issues.apache.org/jira/browse/SOLR-12141
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 7.0, 7.1, 7.2, 7.3
> Environment: Windows 10 with Java 10+
>Reporter: Uwe Schindler
>Assignee: Uwe Schindler
>Priority: Blocker
> Fix For: 7.3
>
> Attachments: SOLR-12141.patch, SOLR-12141.patch, SOLR-12141.patch,
> SOLR-12141.patch
>
>
> If you try to start Solr on Windows with Java 10, it fails with the following
> message:
> {noformat}
> C:\Users\Uwe Schindler\Desktop\solr-7.3.0\bin>solr start -e techproducts
> ERROR: Java 1.8 or later is required to run Solr. Current Java version is: 10
> {noformat}
> Java 8 and Java 9 works. I did not try Linux, but the version parsing on
> Windows is so braindead (i tried to fix it for Java 9 already). Windows CMD
> shell does not know any numerical comparisons, so it fails as "10" is
> alphabetically smaller "9".
> I hope this is better on Linux.
> Why do we have the version check at all? Wouldn't it be better to simply wait
> for a useful message by the Java VM on startup because of wrong class file
> format? This is too simply to break, especially as the output of "java
> -version" is not standardized (and changes with Java 10 to also have a date
> code,...). It also may contain "openjdk" instead of "java".
> So please please, let's get rid of the version check!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12141) Solr does not start on Windows with Java 10
[
https://issues.apache.org/jira/browse/SOLR-12141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414658#comment-16414658
]
Uwe Schindler commented on SOLR-12141:
--
New patch fixes 64 bit test (will only be executed on Java 8). Linux is not
affected as it does not have this check.
> Solr does not start on Windows with Java 10
> ---
>
> Key: SOLR-12141
> URL: https://issues.apache.org/jira/browse/SOLR-12141
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 7.0, 7.1, 7.2, 7.3
> Environment: Windows 10 with Java 10+
>Reporter: Uwe Schindler
>Assignee: Uwe Schindler
>Priority: Blocker
> Fix For: 7.3
>
> Attachments: SOLR-12141.patch, SOLR-12141.patch, SOLR-12141.patch,
> SOLR-12141.patch
>
>
> If you try to start Solr on Windows with Java 10, it fails with the following
> message:
> {noformat}
> C:\Users\Uwe Schindler\Desktop\solr-7.3.0\bin>solr start -e techproducts
> ERROR: Java 1.8 or later is required to run Solr. Current Java version is: 10
> {noformat}
> Java 8 and Java 9 works. I did not try Linux, but the version parsing on
> Windows is so braindead (i tried to fix it for Java 9 already). Windows CMD
> shell does not know any numerical comparisons, so it fails as "10" is
> alphabetically smaller "9".
> I hope this is better on Linux.
> Why do we have the version check at all? Wouldn't it be better to simply wait
> for a useful message by the Java VM on startup because of wrong class file
> format? This is too simply to break, especially as the output of "java
> -version" is not standardized (and changes with Java 10 to also have a date
> code,...). It also may contain "openjdk" instead of "java".
> So please please, let's get rid of the version check!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12141) Solr does not start on Windows with Java 10
[
https://issues.apache.org/jira/browse/SOLR-12141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414639#comment-16414639
]
Uwe Schindler commented on SOLR-12141:
--
New patch fixes GC issues by removing obsolete flag.
> Solr does not start on Windows with Java 10
> ---
>
> Key: SOLR-12141
> URL: https://issues.apache.org/jira/browse/SOLR-12141
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 7.0, 7.1, 7.2, 7.3
> Environment: Windows 10 with Java 10+
>Reporter: Uwe Schindler
>Priority: Blocker
> Fix For: 7.3
>
> Attachments: SOLR-12141.patch, SOLR-12141.patch, SOLR-12141.patch
>
>
> If you try to start Solr on Windows with Java 10, it fails with the following
> message:
> {noformat}
> C:\Users\Uwe Schindler\Desktop\solr-7.3.0\bin>solr start -e techproducts
> ERROR: Java 1.8 or later is required to run Solr. Current Java version is: 10
> {noformat}
> Java 8 and Java 9 works. I did not try Linux, but the version parsing on
> Windows is so braindead (i tried to fix it for Java 9 already). Windows CMD
> shell does not know any numerical comparisons, so it fails as "10" is
> alphabetically smaller "9".
> I hope this is better on Linux.
> Why do we have the version check at all? Wouldn't it be better to simply wait
> for a useful message by the Java VM on startup because of wrong class file
> format? This is too simply to break, especially as the output of "java
> -version" is not standardized (and changes with Java 10 to also have a date
> code,...). It also may contain "openjdk" instead of "java".
> So please please, let's get rid of the version check!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12141) Solr does not start on Windows with Java 10
[
https://issues.apache.org/jira/browse/SOLR-12141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414627#comment-16414627
]
Uwe Schindler commented on SOLR-12141:
--
bq. There is a nother problem (this also affects Linux). Java 10 no longer has
-XX:+UseParNewGC, it was removed
This flag was already obsolete in Java 8, as ConcMarkSweepGC automatically
enables ist. So I will simply remove it in both Windows and Linux.
> Solr does not start on Windows with Java 10
> ---
>
> Key: SOLR-12141
> URL: https://issues.apache.org/jira/browse/SOLR-12141
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 7.0, 7.1, 7.2, 7.3
> Environment: Windows 10 with Java 10+
>Reporter: Uwe Schindler
>Priority: Blocker
> Fix For: 7.3
>
> Attachments: SOLR-12141.patch, SOLR-12141.patch
>
>
> If you try to start Solr on Windows with Java 10, it fails with the following
> message:
> {noformat}
> C:\Users\Uwe Schindler\Desktop\solr-7.3.0\bin>solr start -e techproducts
> ERROR: Java 1.8 or later is required to run Solr. Current Java version is: 10
> {noformat}
> Java 8 and Java 9 works. I did not try Linux, but the version parsing on
> Windows is so braindead (i tried to fix it for Java 9 already). Windows CMD
> shell does not know any numerical comparisons, so it fails as "10" is
> alphabetically smaller "9".
> I hope this is better on Linux.
> Why do we have the version check at all? Wouldn't it be better to simply wait
> for a useful message by the Java VM on startup because of wrong class file
> format? This is too simply to break, especially as the output of "java
> -version" is not standardized (and changes with Java 10 to also have a date
> code,...). It also may contain "openjdk" instead of "java".
> So please please, let's get rid of the version check!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12141) Solr does not start on Windows with Java 10
[
https://issues.apache.org/jira/browse/SOLR-12141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414604#comment-16414604
]
Uwe Schindler commented on SOLR-12141:
--
In addition it prints a warning, as it thinks it's 32 bit (although Java 10 is
always 64 bits). The reason is a check using {{-d64}} which is no longer
accepted in Java 10 (it fails, so it thinks that it's not 64 bits).
> Solr does not start on Windows with Java 10
> ---
>
> Key: SOLR-12141
> URL: https://issues.apache.org/jira/browse/SOLR-12141
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 7.0, 7.1, 7.2, 7.3
> Environment: Windows 10 with Java 10+
>Reporter: Uwe Schindler
>Priority: Blocker
> Fix For: 7.3
>
> Attachments: SOLR-12141.patch, SOLR-12141.patch
>
>
> If you try to start Solr on Windows with Java 10, it fails with the following
> message:
> {noformat}
> C:\Users\Uwe Schindler\Desktop\solr-7.3.0\bin>solr start -e techproducts
> ERROR: Java 1.8 or later is required to run Solr. Current Java version is: 10
> {noformat}
> Java 8 and Java 9 works. I did not try Linux, but the version parsing on
> Windows is so braindead (i tried to fix it for Java 9 already). Windows CMD
> shell does not know any numerical comparisons, so it fails as "10" is
> alphabetically smaller "9".
> I hope this is better on Linux.
> Why do we have the version check at all? Wouldn't it be better to simply wait
> for a useful message by the Java VM on startup because of wrong class file
> format? This is too simply to break, especially as the output of "java
> -version" is not standardized (and changes with Java 10 to also have a date
> code,...). It also may contain "openjdk" instead of "java".
> So please please, let's get rid of the version check!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12141) Solr does not start on Windows with Java 10
[
https://issues.apache.org/jira/browse/SOLR-12141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414601#comment-16414601
]
Uwe Schindler commented on SOLR-12141:
--
There is a nother problem (this also affects Linux). Java 10 no longer has
{{-XX:+UseParNewGC}}, it was removed. ConcMarkSweepGC is still there but may
get removed soon.
> Solr does not start on Windows with Java 10
> ---
>
> Key: SOLR-12141
> URL: https://issues.apache.org/jira/browse/SOLR-12141
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 7.0, 7.1, 7.2, 7.3
> Environment: Windows 10 with Java 10+
>Reporter: Uwe Schindler
>Priority: Blocker
> Fix For: 7.3
>
> Attachments: SOLR-12141.patch, SOLR-12141.patch
>
>
> If you try to start Solr on Windows with Java 10, it fails with the following
> message:
> {noformat}
> C:\Users\Uwe Schindler\Desktop\solr-7.3.0\bin>solr start -e techproducts
> ERROR: Java 1.8 or later is required to run Solr. Current Java version is: 10
> {noformat}
> Java 8 and Java 9 works. I did not try Linux, but the version parsing on
> Windows is so braindead (i tried to fix it for Java 9 already). Windows CMD
> shell does not know any numerical comparisons, so it fails as "10" is
> alphabetically smaller "9".
> I hope this is better on Linux.
> Why do we have the version check at all? Wouldn't it be better to simply wait
> for a useful message by the Java VM on startup because of wrong class file
> format? This is too simply to break, especially as the output of "java
> -version" is not standardized (and changes with Java 10 to also have a date
> code,...). It also may contain "openjdk" instead of "java".
> So please please, let's get rid of the version check!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12141) Solr does not start on Windows with Java 10
[
https://issues.apache.org/jira/browse/SOLR-12141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414489#comment-16414489
]
Uwe Schindler commented on SOLR-12141:
--
I added a slightly improved patch that also works with EA versions.
> Solr does not start on Windows with Java 10
> ---
>
> Key: SOLR-12141
> URL: https://issues.apache.org/jira/browse/SOLR-12141
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 7.0, 7.1, 7.2, 7.3
> Environment: Windows 10 with Java 10+
>Reporter: Uwe Schindler
>Priority: Blocker
> Fix For: 7.3
>
> Attachments: SOLR-12141.patch, SOLR-12141.patch
>
>
> If you try to start Solr on Windows with Java 10, it fails with the following
> message:
> {noformat}
> C:\Users\Uwe Schindler\Desktop\solr-7.3.0\bin>solr start -e techproducts
> ERROR: Java 1.8 or later is required to run Solr. Current Java version is: 10
> {noformat}
> Java 8 and Java 9 works. I did not try Linux, but the version parsing on
> Windows is so braindead (i tried to fix it for Java 9 already). Windows CMD
> shell does not know any numerical comparisons, so it fails as "10" is
> alphabetically smaller "9".
> I hope this is better on Linux.
> Why do we have the version check at all? Wouldn't it be better to simply wait
> for a useful message by the Java VM on startup because of wrong class file
> format? This is too simply to break, especially as the output of "java
> -version" is not standardized (and changes with Java 10 to also have a date
> code,...). It also may contain "openjdk" instead of "java".
> So please please, let's get rid of the version check!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12141) Solr does not start on Windows with Java 10
[
https://issues.apache.org/jira/browse/SOLR-12141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414462#comment-16414462
]
Uwe Schindler commented on SOLR-12141:
--
Here is the fix for Windows: [^SOLR-12141.patch]
The reason for borkenness was the quotes around the comparison. If windows
detects a plain number, then it compares it as number. But the quotes caused it
to use alphabetical comparison.
I will quickly test linux, but the WIndows fix should be ready to commit.
> Solr does not start on Windows with Java 10
> ---
>
> Key: SOLR-12141
> URL: https://issues.apache.org/jira/browse/SOLR-12141
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 7.0, 7.1, 7.2, 7.3
> Environment: Windows 10 with Java 10+
>Reporter: Uwe Schindler
>Priority: Blocker
> Fix For: 7.3
>
> Attachments: SOLR-12141.patch
>
>
> If you try to start Solr on Windows with Java 10, it fails with the following
> message:
> {noformat}
> C:\Users\Uwe Schindler\Desktop\solr-7.3.0\bin>solr start -e techproducts
> ERROR: Java 1.8 or later is required to run Solr. Current Java version is: 10
> {noformat}
> Java 8 and Java 9 works. I did not try Linux, but the version parsing on
> Windows is so braindead (i tried to fix it for Java 9 already). Windows CMD
> shell does not know any numerical comparisons, so it fails as "10" is
> alphabetically smaller "9".
> I hope this is better on Linux.
> Why do we have the version check at all? Wouldn't it be better to simply wait
> for a useful message by the Java VM on startup because of wrong class file
> format? This is too simply to break, especially as the output of "java
> -version" is not standardized (and changes with Java 10 to also have a date
> code,...). It also may contain "openjdk" instead of "java".
> So please please, let's get rid of the version check!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
