[jira] [Commented] (SOLR-12364) edismax "boost" is not tested
[ https://issues.apache.org/jira/browse/SOLR-12364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875564#comment-16875564 ] ASF subversion and git services commented on SOLR-12364: Commit 9e40748486f0adb04099f91aa71d4ce995db5346 in lucene-solr's branch refs/heads/branch_8x from Munendra S N [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=9e40748 ] SOLR-12364: add test cases for edismax boost * This adds tests for bf and boosts * Use expectThrows in edismax tests to verify exception > edismax "boost" is not tested > - > > Key: SOLR-12364 > URL: https://issues.apache.org/jira/browse/SOLR-12364 > Project: Solr > Issue Type: Improvement > Components: query parsers >Reporter: David Smiley >Priority: Minor > Attachments: SOLR-12364.patch > > > I see no trace of any test of the "boost" param for edismax. "bq" is tested, > but not "boost". Ouch. The test ought to go here: TestExtendedDismaxParser. > I searched in many ways, not limited to that test file. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12364) edismax "boost" is not tested
[ https://issues.apache.org/jira/browse/SOLR-12364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875558#comment-16875558 ] ASF subversion and git services commented on SOLR-12364: Commit cfd6e1adfaed17f260cd874c02dab7b04acf280c in lucene-solr's branch refs/heads/master from Munendra S N [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=cfd6e1a ] SOLR-12364: add test cases for edismax boost * This adds tests for bf and boosts * Use expectThrows in edismax tests to verify exception > edismax "boost" is not tested > - > > Key: SOLR-12364 > URL: https://issues.apache.org/jira/browse/SOLR-12364 > Project: Solr > Issue Type: Improvement > Components: query parsers >Reporter: David Smiley >Priority: Minor > Attachments: SOLR-12364.patch > > > I see no trace of any test of the "boost" param for edismax. "bq" is tested, > but not "boost". Ouch. The test ought to go here: TestExtendedDismaxParser. > I searched in many ways, not limited to that test file. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12364) edismax "boost" is not tested
[
https://issues.apache.org/jira/browse/SOLR-12364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875474#comment-16875474
]
Lucene/Solr QA commented on SOLR-12364:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
45s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 5m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 5m 6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 5m 6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 5m 6s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 59m
51s{color} | {color:green} core in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 77m 20s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-12364 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12973173/SOLR-12364.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP
Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 8b72e91 |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 |
| Default Java | LTS |
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/467/testReport/ |
| modules | C: solr solr/core U: solr |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/467/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> edismax "boost" is not tested
> -
>
> Key: SOLR-12364
> URL: https://issues.apache.org/jira/browse/SOLR-12364
> Project: Solr
> Issue Type: Improvement
> Components: query parsers
>Reporter: David Smiley
>Priority: Minor
> Attachments: SOLR-12364.patch
>
>
> I see no trace of any test of the "boost" param for edismax. "bq" is tested,
> but not "boost". Ouch. The test ought to go here: TestExtendedDismaxParser.
> I searched in many ways, not limited to that test file.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12364) edismax "boost" is not tested
[ https://issues.apache.org/jira/browse/SOLR-12364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874938#comment-16874938 ] Munendra S N commented on SOLR-12364: - [^SOLR-12364.patch] * Adds test for bf (I couldn't find any test for this too) and boost * Modifies some tests in TestExtendedDismaxParser to use exprectThrows > edismax "boost" is not tested > - > > Key: SOLR-12364 > URL: https://issues.apache.org/jira/browse/SOLR-12364 > Project: Solr > Issue Type: Improvement > Components: query parsers >Reporter: David Smiley >Priority: Minor > Attachments: SOLR-12364.patch > > > I see no trace of any test of the "boost" param for edismax. "bq" is tested, > but not "boost". Ouch. The test ought to go here: TestExtendedDismaxParser. > I searched in many ways, not limited to that test file. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
