[jira] [Commented] (SOLR-12438) Improve status reporting of metrics history API
[
https://issues.apache.org/jira/browse/SOLR-12438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506424#comment-16506424
]
ASF subversion and git services commented on SOLR-12438:
Commit 943e78e7e45e29661fb5ef1a3cb2d315ab348165 in lucene-solr's branch
refs/heads/branch_7_4 from Andrzej Bialecki
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=943e78e ]
SOLR-12438: Improve status reporting of metrics history API.
> Improve status reporting of metrics history API
> ---
>
> Key: SOLR-12438
> URL: https://issues.apache.org/jira/browse/SOLR-12438
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
>Reporter: Andrzej Bialecki
>Assignee: Andrzej Bialecki
>Priority: Major
> Fix For: 7.4, master (8.0)
>
> Attachments: SOLR-12438.patch, SOLR-12438.patch
>
>
> In an offline conversation with [~janhoy] we identified the following areas
> of improvement to the metrics history API in order to increase its
> user-friendliness and provide more details about its status.
>
> * there are three possible states for the API: inactive (when not in cloud
> mode), in-memory only (when {{.system}} collection doesn’t exist), and
> persisted when it’s both active and persisted in Solr. The
> /admin/metrics/history endpoint should give some hint about this status, such
> as "mode":"memory/index", "active": true|false. Or a separate action=status
> just to poll status? Currently when the API is inactive it simply returns 404
> Not Found.
> * when in "memory" mode a call to /admin/metrics/history on a non-overseer
> node should forward the request to the overseer, so that the client does not
> need to care what mode it is in - kind of like how a query works in
> distributed mode.
> * better documentation for the API behavior in each mode.
> * perhaps if mode=memory, there could also be a "message":"Warning, metrics
> history is not being persisted. Please create the .system collection to start
> persisting history"
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12438) Improve status reporting of metrics history API
[
https://issues.apache.org/jira/browse/SOLR-12438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505295#comment-16505295
]
ASF subversion and git services commented on SOLR-12438:
Commit 87c23545a103d16aff19b3623b3985ae9b63a870 in lucene-solr's branch
refs/heads/branch_7x from Andrzej Bialecki
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=87c2354 ]
SOLR-12438: Improve status reporting of metrics history API.
> Improve status reporting of metrics history API
> ---
>
> Key: SOLR-12438
> URL: https://issues.apache.org/jira/browse/SOLR-12438
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
>Reporter: Andrzej Bialecki
>Assignee: Andrzej Bialecki
>Priority: Major
> Fix For: 7.4, master (8.0)
>
> Attachments: SOLR-12438.patch, SOLR-12438.patch
>
>
> In an offline conversation with [~janhoy] we identified the following areas
> of improvement to the metrics history API in order to increase its
> user-friendliness and provide more details about its status.
>
> * there are three possible states for the API: inactive (when not in cloud
> mode), in-memory only (when {{.system}} collection doesn’t exist), and
> persisted when it’s both active and persisted in Solr. The
> /admin/metrics/history endpoint should give some hint about this status, such
> as "mode":"memory/index", "active": true|false. Or a separate action=status
> just to poll status? Currently when the API is inactive it simply returns 404
> Not Found.
> * when in "memory" mode a call to /admin/metrics/history on a non-overseer
> node should forward the request to the overseer, so that the client does not
> need to care what mode it is in - kind of like how a query works in
> distributed mode.
> * better documentation for the API behavior in each mode.
> * perhaps if mode=memory, there could also be a "message":"Warning, metrics
> history is not being persisted. Please create the .system collection to start
> persisting history"
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12438) Improve status reporting of metrics history API
[
https://issues.apache.org/jira/browse/SOLR-12438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505210#comment-16505210
]
ASF subversion and git services commented on SOLR-12438:
Commit 417940cdd76ded0a41906ce794a79f4f09136314 in lucene-solr's branch
refs/heads/master from Andrzej Bialecki
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=417940c ]
SOLR-12438: Improve status reporting of metrics history API.
> Improve status reporting of metrics history API
> ---
>
> Key: SOLR-12438
> URL: https://issues.apache.org/jira/browse/SOLR-12438
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
>Reporter: Andrzej Bialecki
>Assignee: Andrzej Bialecki
>Priority: Major
> Fix For: 7.4, master (8.0)
>
> Attachments: SOLR-12438.patch, SOLR-12438.patch
>
>
> In an offline conversation with [~janhoy] we identified the following areas
> of improvement to the metrics history API in order to increase its
> user-friendliness and provide more details about its status.
>
> * there are three possible states for the API: inactive (when not in cloud
> mode), in-memory only (when {{.system}} collection doesn’t exist), and
> persisted when it’s both active and persisted in Solr. The
> /admin/metrics/history endpoint should give some hint about this status, such
> as "mode":"memory/index", "active": true|false. Or a separate action=status
> just to poll status? Currently when the API is inactive it simply returns 404
> Not Found.
> * when in "memory" mode a call to /admin/metrics/history on a non-overseer
> node should forward the request to the overseer, so that the client does not
> need to care what mode it is in - kind of like how a query works in
> distributed mode.
> * better documentation for the API behavior in each mode.
> * perhaps if mode=memory, there could also be a "message":"Warning, metrics
> history is not being persisted. Please create the .system collection to start
> persisting history"
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12438) Improve status reporting of metrics history API
[
https://issues.apache.org/jira/browse/SOLR-12438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504596#comment-16504596
]
Andrzej Bialecki commented on SOLR-12438:
--
Updated patch with fixes for the serialization bug.
> Improve status reporting of metrics history API
> ---
>
> Key: SOLR-12438
> URL: https://issues.apache.org/jira/browse/SOLR-12438
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
>Reporter: Andrzej Bialecki
>Assignee: Andrzej Bialecki
>Priority: Major
> Fix For: 7.4, master (8.0)
>
> Attachments: SOLR-12438.patch, SOLR-12438.patch
>
>
> In an offline conversation with [~janhoy] we identified the following areas
> of improvement to the metrics history API in order to increase its
> user-friendliness and provide more details about its status.
>
> * there are three possible states for the API: inactive (when not in cloud
> mode), in-memory only (when {{.system}} collection doesn’t exist), and
> persisted when it’s both active and persisted in Solr. The
> /admin/metrics/history endpoint should give some hint about this status, such
> as "mode":"memory/index", "active": true|false. Or a separate action=status
> just to poll status? Currently when the API is inactive it simply returns 404
> Not Found.
> * when in "memory" mode a call to /admin/metrics/history on a non-overseer
> node should forward the request to the overseer, so that the client does not
> need to care what mode it is in - kind of like how a query works in
> distributed mode.
> * better documentation for the API behavior in each mode.
> * perhaps if mode=memory, there could also be a "message":"Warning, metrics
> history is not being persisted. Please create the .system collection to start
> persisting history"
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12438) Improve status reporting of metrics history API
[
https://issues.apache.org/jira/browse/SOLR-12438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504587#comment-16504587
]
Andrzej Bialecki commented on SOLR-12438:
--
I updated this issue to "Bug" because JSON output of the handler was being
serialized in a way that didn't make sense (due to using NamedList-s instead of
SimpleOrderedMap-s).
> Improve status reporting of metrics history API
> ---
>
> Key: SOLR-12438
> URL: https://issues.apache.org/jira/browse/SOLR-12438
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
>Reporter: Andrzej Bialecki
>Assignee: Andrzej Bialecki
>Priority: Major
> Fix For: 7.4, master (8.0)
>
> Attachments: SOLR-12438.patch
>
>
> In an offline conversation with [~janhoy] we identified the following areas
> of improvement to the metrics history API in order to increase its
> user-friendliness and provide more details about its status.
>
> * there are three possible states for the API: inactive (when not in cloud
> mode), in-memory only (when {{.system}} collection doesn’t exist), and
> persisted when it’s both active and persisted in Solr. The
> /admin/metrics/history endpoint should give some hint about this status, such
> as "mode":"memory/index", "active": true|false. Or a separate action=status
> just to poll status? Currently when the API is inactive it simply returns 404
> Not Found.
> * when in "memory" mode a call to /admin/metrics/history on a non-overseer
> node should forward the request to the overseer, so that the client does not
> need to care what mode it is in - kind of like how a query works in
> distributed mode.
> * better documentation for the API behavior in each mode.
> * perhaps if mode=memory, there could also be a "message":"Warning, metrics
> history is not being persisted. Please create the .system collection to start
> persisting history"
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12438) Improve status reporting of metrics history API
[
https://issues.apache.org/jira/browse/SOLR-12438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502397#comment-16502397
]
Andrzej Bialecki commented on SOLR-12438:
--
This patch contains the following changes:
* the API works now also in non-cloud mode.
* report the current "mode" (disabled, memory, index).
* automatically pull in-memory history from Overseer when request is submitted
to any node and when the API is in non-persistent mode (the data is not
available then in the {{.system}} collection)
* report the source node where the data was obtained from. When in "index" mode
the source node is always the one where the request was submitted to.
> Improve status reporting of metrics history API
> ---
>
> Key: SOLR-12438
> URL: https://issues.apache.org/jira/browse/SOLR-12438
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
>Reporter: Andrzej Bialecki
>Assignee: Andrzej Bialecki
>Priority: Major
> Fix For: 7.4, master (8.0)
>
> Attachments: SOLR-12438.patch
>
>
> In an offline conversation with [~janhoy] we identified the following areas
> of improvement to the metrics history API in order to increase its
> user-friendliness and provide more details about its status.
>
> * there are three possible states for the API: inactive (when not in cloud
> mode), in-memory only (when {{.system}} collection doesn’t exist), and
> persisted when it’s both active and persisted in Solr. The
> /admin/metrics/history endpoint should give some hint about this status, such
> as "mode":"memory/index", "active": true|false. Or a separate action=status
> just to poll status? Currently when the API is inactive it simply returns 404
> Not Found.
> * when in "memory" mode a call to /admin/metrics/history on a non-overseer
> node should forward the request to the overseer, so that the client does not
> need to care what mode it is in - kind of like how a query works in
> distributed mode.
> * better documentation for the API behavior in each mode.
> * perhaps if mode=memory, there could also be a "message":"Warning, metrics
> history is not being persisted. Please create the .system collection to start
> persisting history"
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
