[jira] [Commented] (SOLR-12549) Settle a location for the log4j2.xml file
[ https://issues.apache.org/jira/browse/SOLR-12549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619218#comment-16619218 ] Erick Erickson commented on SOLR-12549: --- Makes sense, but I pretty much guarantee I won't do it in time for getting it into 7.5. I'll change it next time I have something to add in CHANGES.txt unless someone beats me to it. > Settle a location for the log4j2.xml file > - > > Key: SOLR-12549 > URL: https://issues.apache.org/jira/browse/SOLR-12549 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: logging >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > Fix For: 7.5, master (8.0) > > Attachments: SOLR-12008-7x-test-fail-fix.patch, SOLR-12008.patch, > SOLR-12008.patch, SOLR-12008.patch, SOLR-12008.patch, SOLR-12008.patch > > > CLONED from SOLR-12008 since 12008 couldn't be closed. > As part of SOLR-11934 I started looking at log4j.properties files. Waaay back > in 2015, the %C in "/solr/server/resources/log4j.properties" was changed to > use %c, but the file in "solr/example/resources/log4j.properties" was not > changed. That got me to looking around and there are a bunch of > log4j.properties files: > ./solr/core/src/test-files/log4j.properties > ./solr/example/resources/log4j.properties > ./solr/solrj/src/test-files/log4j.properties > ./solr/server/resources/log4j.properties > ./solr/server/scripts/cloud-scripts/log4j.properties > ./solr/contrib/dataimporthandler/src/test-files/log4j.properties > ./solr/contrib/clustering/src/test-files/log4j.properties > ./solr/contrib/ltr/src/test-files/log4j.properties > ./solr/test-framework/src/test-files/log4j.properties > Why do we have so many? After the log4j2 ticket gets checked in (SOLR-7887) I > propose the logging configuration files get consolidated. The question is > "how far"? > I at least want to get rid of the one in solr/example, users should use the > one in server/resources. Having to maintain these two separately is asking > for trouble. > [~markrmil...@gmail.com] Do you have any wisdom on the properties file in > server/scripts/cloud-scripts? > Anyone else who has a clue about why the other properties files were created, > especially the ones in contrib? > And what about all the ones in various test-files directories? People didn't > create them for no reason, and I don't want to rediscover that it's a real > pain to try to re-use the one in server/resources for instance. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12549) Settle a location for the log4j2.xml file
[ https://issues.apache.org/jira/browse/SOLR-12549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618037#comment-16618037 ] Alexandre Rafalovitch commented on SOLR-12549: -- 7.5 Release notes still refer to the 12008, but now that it is deleted, nobody would be able to find further details on it. Not sure what the best way to fix it is. Maybe just relink it to this one? > Settle a location for the log4j2.xml file > - > > Key: SOLR-12549 > URL: https://issues.apache.org/jira/browse/SOLR-12549 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: logging >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > Fix For: 7.5, master (8.0) > > Attachments: SOLR-12008-7x-test-fail-fix.patch, SOLR-12008.patch, > SOLR-12008.patch, SOLR-12008.patch, SOLR-12008.patch, SOLR-12008.patch > > > CLONED from SOLR-12008 since 12008 couldn't be closed. > As part of SOLR-11934 I started looking at log4j.properties files. Waaay back > in 2015, the %C in "/solr/server/resources/log4j.properties" was changed to > use %c, but the file in "solr/example/resources/log4j.properties" was not > changed. That got me to looking around and there are a bunch of > log4j.properties files: > ./solr/core/src/test-files/log4j.properties > ./solr/example/resources/log4j.properties > ./solr/solrj/src/test-files/log4j.properties > ./solr/server/resources/log4j.properties > ./solr/server/scripts/cloud-scripts/log4j.properties > ./solr/contrib/dataimporthandler/src/test-files/log4j.properties > ./solr/contrib/clustering/src/test-files/log4j.properties > ./solr/contrib/ltr/src/test-files/log4j.properties > ./solr/test-framework/src/test-files/log4j.properties > Why do we have so many? After the log4j2 ticket gets checked in (SOLR-7887) I > propose the logging configuration files get consolidated. The question is > "how far"? > I at least want to get rid of the one in solr/example, users should use the > one in server/resources. Having to maintain these two separately is asking > for trouble. > [~markrmil...@gmail.com] Do you have any wisdom on the properties file in > server/scripts/cloud-scripts? > Anyone else who has a clue about why the other properties files were created, > especially the ones in contrib? > And what about all the ones in various test-files directories? People didn't > create them for no reason, and I don't want to rediscover that it's a real > pain to try to re-use the one in server/resources for instance. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12549) Settle a location for the log4j2.xml file
[ https://issues.apache.org/jira/browse/SOLR-12549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541846#comment-16541846 ] Erick Erickson commented on SOLR-12549: --- The SHA's associated with 12008, don't quite know why all the comments didn't come over master: 93ae3669b5b4239b09baeb8481024709aee2216e 7x: 4ddb08118245df380c1a6038b53f0f61b9c170b5 > Settle a location for the log4j2.xml file > - > > Key: SOLR-12549 > URL: https://issues.apache.org/jira/browse/SOLR-12549 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: logging >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > Fix For: master (8.0), 7.5 > > Attachments: SOLR-12008-7x-test-fail-fix.patch, SOLR-12008.patch, > SOLR-12008.patch, SOLR-12008.patch, SOLR-12008.patch, SOLR-12008.patch > > > CLONED from SOLR-12008 since 12008 couldn't be closed. > As part of SOLR-11934 I started looking at log4j.properties files. Waaay back > in 2015, the %C in "/solr/server/resources/log4j.properties" was changed to > use %c, but the file in "solr/example/resources/log4j.properties" was not > changed. That got me to looking around and there are a bunch of > log4j.properties files: > ./solr/core/src/test-files/log4j.properties > ./solr/example/resources/log4j.properties > ./solr/solrj/src/test-files/log4j.properties > ./solr/server/resources/log4j.properties > ./solr/server/scripts/cloud-scripts/log4j.properties > ./solr/contrib/dataimporthandler/src/test-files/log4j.properties > ./solr/contrib/clustering/src/test-files/log4j.properties > ./solr/contrib/ltr/src/test-files/log4j.properties > ./solr/test-framework/src/test-files/log4j.properties > Why do we have so many? After the log4j2 ticket gets checked in (SOLR-7887) I > propose the logging configuration files get consolidated. The question is > "how far"? > I at least want to get rid of the one in solr/example, users should use the > one in server/resources. Having to maintain these two separately is asking > for trouble. > [~markrmil...@gmail.com] Do you have any wisdom on the properties file in > server/scripts/cloud-scripts? > Anyone else who has a clue about why the other properties files were created, > especially the ones in contrib? > And what about all the ones in various test-files directories? People didn't > create them for no reason, and I don't want to rediscover that it's a real > pain to try to re-use the one in server/resources for instance. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12549) Settle a location for the log4j2.xml file
[ https://issues.apache.org/jira/browse/SOLR-12549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541841#comment-16541841 ] Erick Erickson commented on SOLR-12549: --- OK, somehow the merge didn't include the log4j2.xml file in the test-files tree. Fixed. > Settle a location for the log4j2.xml file > - > > Key: SOLR-12549 > URL: https://issues.apache.org/jira/browse/SOLR-12549 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: logging >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > Fix For: master (8.0), 7.5 > > Attachments: SOLR-12008-7x-test-fail-fix.patch, SOLR-12008.patch, > SOLR-12008.patch, SOLR-12008.patch, SOLR-12008.patch, SOLR-12008.patch > > > CLONED from SOLR-12008 since 12008 couldn't be closed. > As part of SOLR-11934 I started looking at log4j.properties files. Waaay back > in 2015, the %C in "/solr/server/resources/log4j.properties" was changed to > use %c, but the file in "solr/example/resources/log4j.properties" was not > changed. That got me to looking around and there are a bunch of > log4j.properties files: > ./solr/core/src/test-files/log4j.properties > ./solr/example/resources/log4j.properties > ./solr/solrj/src/test-files/log4j.properties > ./solr/server/resources/log4j.properties > ./solr/server/scripts/cloud-scripts/log4j.properties > ./solr/contrib/dataimporthandler/src/test-files/log4j.properties > ./solr/contrib/clustering/src/test-files/log4j.properties > ./solr/contrib/ltr/src/test-files/log4j.properties > ./solr/test-framework/src/test-files/log4j.properties > Why do we have so many? After the log4j2 ticket gets checked in (SOLR-7887) I > propose the logging configuration files get consolidated. The question is > "how far"? > I at least want to get rid of the one in solr/example, users should use the > one in server/resources. Having to maintain these two separately is asking > for trouble. > [~markrmil...@gmail.com] Do you have any wisdom on the properties file in > server/scripts/cloud-scripts? > Anyone else who has a clue about why the other properties files were created, > especially the ones in contrib? > And what about all the ones in various test-files directories? People didn't > create them for no reason, and I don't want to rediscover that it's a real > pain to try to re-use the one in server/resources for instance. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12549) Settle a location for the log4j2.xml file
[ https://issues.apache.org/jira/browse/SOLR-12549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541838#comment-16541838 ] ASF subversion and git services commented on SOLR-12549: Commit f4c5380137b498079f203c865c6611a99f5765d0 in lucene-solr's branch refs/heads/branch_7x from Erick Erickson [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f4c5380 ] SOLR-12549: CLONE of SOLR-12008, 7x test failure fix > Settle a location for the log4j2.xml file > - > > Key: SOLR-12549 > URL: https://issues.apache.org/jira/browse/SOLR-12549 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: logging >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > Fix For: master (8.0), 7.5 > > Attachments: SOLR-12008-7x-test-fail-fix.patch, SOLR-12008.patch, > SOLR-12008.patch, SOLR-12008.patch, SOLR-12008.patch, SOLR-12008.patch > > > CLONED from SOLR-12008 since 12008 couldn't be closed. > As part of SOLR-11934 I started looking at log4j.properties files. Waaay back > in 2015, the %C in "/solr/server/resources/log4j.properties" was changed to > use %c, but the file in "solr/example/resources/log4j.properties" was not > changed. That got me to looking around and there are a bunch of > log4j.properties files: > ./solr/core/src/test-files/log4j.properties > ./solr/example/resources/log4j.properties > ./solr/solrj/src/test-files/log4j.properties > ./solr/server/resources/log4j.properties > ./solr/server/scripts/cloud-scripts/log4j.properties > ./solr/contrib/dataimporthandler/src/test-files/log4j.properties > ./solr/contrib/clustering/src/test-files/log4j.properties > ./solr/contrib/ltr/src/test-files/log4j.properties > ./solr/test-framework/src/test-files/log4j.properties > Why do we have so many? After the log4j2 ticket gets checked in (SOLR-7887) I > propose the logging configuration files get consolidated. The question is > "how far"? > I at least want to get rid of the one in solr/example, users should use the > one in server/resources. Having to maintain these two separately is asking > for trouble. > [~markrmil...@gmail.com] Do you have any wisdom on the properties file in > server/scripts/cloud-scripts? > Anyone else who has a clue about why the other properties files were created, > especially the ones in contrib? > And what about all the ones in various test-files directories? People didn't > create them for no reason, and I don't want to rediscover that it's a real > pain to try to re-use the one in server/resources for instance. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
