[jira] [Commented] (SOLR-12785) Add test for activation functions in NeuralNetworkModel
[ https://issues.apache.org/jira/browse/SOLR-12785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657890#comment-16657890 ] Kamuela Lau commented on SOLR-12785: Deleted old patches and added new ones to reflect the fact that Leaky Relu and TanH were added in SOLR-12780. A-patch adds tests without changing the implementation of default Activation implementations (via a network with exactly one input and one output node). B-patch changes implementation of default Activation implementations and adds tests for that. > Add test for activation functions in NeuralNetworkModel > --- > > Key: SOLR-12785 > URL: https://issues.apache.org/jira/browse/SOLR-12785 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) > Components: contrib - LTR >Reporter: Kamuela Lau >Priority: Minor > Attachments: SOLR-12785-A.patch, SOLR-12785-B.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12785) Add test for activation functions in NeuralNetworkModel
[ https://issues.apache.org/jira/browse/SOLR-12785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646707#comment-16646707 ] Kamuela Lau commented on SOLR-12785: If changes are accepted for additional activation functions (SOLR-12780), the test in the patch should be changed accordingly; if the tests (and edited implementation of default activation functions) is accepted here, the implementation of the activation functions in SOLR-12780 will have to change accordingly. > Add test for activation functions in NeuralNetworkModel > --- > > Key: SOLR-12785 > URL: https://issues.apache.org/jira/browse/SOLR-12785 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) > Components: contrib - LTR >Reporter: Kamuela Lau >Priority: Minor > Attachments: SOLR-12785.patch, test-no-activation-change.txt > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12785) Add test for activation functions in NeuralNetworkModel
[ https://issues.apache.org/jira/browse/SOLR-12785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622973#comment-16622973 ] Kamuela Lau commented on SOLR-12785: A couple of couple of comments regarding the patch: # I moved the default implementations to the Activation interface, and implemented in enums (this pattern is mentioned in "Effective Java", Item 3). I decided on the enum as activation is just a function; if another layer is created with the same activation as a previous layer, only one object will be created (i.e. if there are three layers with sigmoid activation, one object will be created, instead of three as it is now). Doing this also made it easier to test. If it is preferred that the implementations not be singletons or in an enum class, please let me know; any comments are appreciated. # I also attempted to write the test for the activation functions without changing current implementation of DefaultLayer.setActivation(), however in doing so, I felt that I had to construct a NeuralNetworkModel object (with one input, one output, weight 1 and bias 0). See test-no-activation-change.txt, which I have attached. Any comments or advice would be greatly appreciated! > Add test for activation functions in NeuralNetworkModel > --- > > Key: SOLR-12785 > URL: https://issues.apache.org/jira/browse/SOLR-12785 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) > Components: contrib - LTR >Reporter: Kamuela Lau >Priority: Minor > Attachments: SOLR-12785.patch, test-no-activation-change.txt > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
