[jira] [Commented] (SOLR-13000) log4j-slf4j-impl jar (inadvertently?) missing in solrj/lib
[
https://issues.apache.org/jira/browse/SOLR-13000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707643#comment-16707643
]
Christine Poerschke commented on SOLR-13000:
bq. ... stand-alone tool ... and since it is shipped with Solr, it seems
reasonable for it to use the same logging implementation that Solr uses. ...
Makes sense.
> log4j-slf4j-impl jar (inadvertently?) missing in solrj/lib
> --
>
> Key: SOLR-13000
> URL: https://issues.apache.org/jira/browse/SOLR-13000
> Project: Solr
> Issue Type: Bug
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Attachments: SOLR-13000.patch
>
>
> My colleague [~ajhalani] noticed that declaring a {{solr-solrj}} dependency
> alone when configuring {{-Dlog4j.configurationFile}} for a project is not
> sufficient.
> I looked into further and it seems that the {{log4j-slf4j-impl}} jar is
> (inadvertently?) missing in {{solrj/lib}} in the release?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13000) log4j-slf4j-impl jar (inadvertently?) missing in solrj/lib
[
https://issues.apache.org/jira/browse/SOLR-13000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702871#comment-16702871
]
Daniel Collins commented on SOLR-13000:
---
The Prometheus Exporter is a stand-alone tool so it requires a logging
implementation, and since it is shipped with Solr, it seems reasonable for it
to use the same logging implementation that Solr uses.
So I guess the plan is to withdraw this (I'll confirm with [~cpoerschke] when
she's back from vacation next week)?
> log4j-slf4j-impl jar (inadvertently?) missing in solrj/lib
> --
>
> Key: SOLR-13000
> URL: https://issues.apache.org/jira/browse/SOLR-13000
> Project: Solr
> Issue Type: Bug
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Attachments: SOLR-13000.patch
>
>
> My colleague [~ajhalani] noticed that declaring a {{solr-solrj}} dependency
> alone when configuring {{-Dlog4j.configurationFile}} for a project is not
> sufficient.
> I looked into further and it seems that the {{log4j-slf4j-impl}} jar is
> (inadvertently?) missing in {{solrj/lib}} in the release?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13000) log4j-slf4j-impl jar (inadvertently?) missing in solrj/lib
[
https://issues.apache.org/jira/browse/SOLR-13000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696186#comment-16696186
]
Varun Thacker commented on SOLR-13000:
--
{quote}but for convenience an actual logging implementation is shipped with it?
{quote}
After SOLR-7887 we made it to "compile"
> log4j-slf4j-impl jar (inadvertently?) missing in solrj/lib
> --
>
> Key: SOLR-13000
> URL: https://issues.apache.org/jira/browse/SOLR-13000
> Project: Solr
> Issue Type: Bug
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Attachments: SOLR-13000.patch
>
>
> My colleague [~ajhalani] noticed that declaring a {{solr-solrj}} dependency
> alone when configuring {{-Dlog4j.configurationFile}} for a project is not
> sufficient.
> I looked into further and it seems that the {{log4j-slf4j-impl}} jar is
> (inadvertently?) missing in {{solrj/lib}} in the release?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13000) log4j-slf4j-impl jar (inadvertently?) missing in solrj/lib
[
https://issues.apache.org/jira/browse/SOLR-13000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693094#comment-16693094
]
Christine Poerschke commented on SOLR-13000:
In researching this ticket I came across [~varunthacker]'s SOLR-7887 question
{quote}... In solr/contrib/prometheus-exporter/ivy.xml , why is the
"log4j-slf4j-impl" dependency "test" and not "compile" ? ...
{quote}
If for SolrJ we allow flexibility of choice of logging implementation, could
the same theoretically apply to the [Prometheus
exporter|https://lucene.apache.org/solr/guide/7_5/monitoring-solr-with-prometheus-and-grafana.html]
too but for convenience an actual logging implementation is shipped with it?
> log4j-slf4j-impl jar (inadvertently?) missing in solrj/lib
> --
>
> Key: SOLR-13000
> URL: https://issues.apache.org/jira/browse/SOLR-13000
> Project: Solr
> Issue Type: Bug
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Attachments: SOLR-13000.patch
>
>
> My colleague [~ajhalani] noticed that declaring a {{solr-solrj}} dependency
> alone when configuring {{-Dlog4j.configurationFile}} for a project is not
> sufficient.
> I looked into further and it seems that the {{log4j-slf4j-impl}} jar is
> (inadvertently?) missing in {{solrj/lib}} in the release?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13000) log4j-slf4j-impl jar (inadvertently?) missing in solrj/lib
[
https://issues.apache.org/jira/browse/SOLR-13000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693083#comment-16693083
]
Christine Poerschke commented on SOLR-13000:
bq. ... should the choice of actual logging implementation be under the control
of the application developer?
bq. ... The implementation should not be included into the dependency. ...
Good to know it's not inadvertently but intentionally missing. :)
bq. ... It's also documented that you need a slf4j implementation JAR file.
Could you share pointer to that part of the documentation? I wonder if we
should sign-post to it from
https://lucene.apache.org/solr/guide/7_5/using-solrj.html page?
> log4j-slf4j-impl jar (inadvertently?) missing in solrj/lib
> --
>
> Key: SOLR-13000
> URL: https://issues.apache.org/jira/browse/SOLR-13000
> Project: Solr
> Issue Type: Bug
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Attachments: SOLR-13000.patch
>
>
> My colleague [~ajhalani] noticed that declaring a {{solr-solrj}} dependency
> alone when configuring {{-Dlog4j.configurationFile}} for a project is not
> sufficient.
> I looked into further and it seems that the {{log4j-slf4j-impl}} jar is
> (inadvertently?) missing in {{solrj/lib}} in the release?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13000) log4j-slf4j-impl jar (inadvertently?) missing in solrj/lib
[
https://issues.apache.org/jira/browse/SOLR-13000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692992#comment-16692992
]
Uwe Schindler commented on SOLR-13000:
--
I agree with [~dancollins]. The implementation should not be included into the
dependency. Solr itsself is using log4j2, but the Solrj library SHOULD NOT DO
THIS. It's up to the application developer to use the logging framework that is
intended for the application. Theoretically you can also use Solrj with
commons-loggin or log4j1 if you like. So the dependency is not added.
This is not a bug, it allows flexibility. It's also documented that you need a
slf4j implementation JAR file.
> log4j-slf4j-impl jar (inadvertently?) missing in solrj/lib
> --
>
> Key: SOLR-13000
> URL: https://issues.apache.org/jira/browse/SOLR-13000
> Project: Solr
> Issue Type: Bug
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Attachments: SOLR-13000.patch
>
>
> My colleague [~ajhalani] noticed that declaring a {{solr-solrj}} dependency
> alone when configuring {{-Dlog4j.configurationFile}} for a project is not
> sufficient.
> I looked into further and it seems that the {{log4j-slf4j-impl}} jar is
> (inadvertently?) missing in {{solrj/lib}} in the release?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13000) log4j-slf4j-impl jar (inadvertently?) missing in solrj/lib
[
https://issues.apache.org/jira/browse/SOLR-13000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692972#comment-16692972
]
Daniel Collins commented on SOLR-13000:
---
Log4J2 is a stated requirement for Solr server, since it is a standalone
application. SolrJ is a library that is expected to be embedded in a larger
application, so should the choice of actual logging implementation be under the
control of the application developer?
> log4j-slf4j-impl jar (inadvertently?) missing in solrj/lib
> --
>
> Key: SOLR-13000
> URL: https://issues.apache.org/jira/browse/SOLR-13000
> Project: Solr
> Issue Type: Bug
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Attachments: SOLR-13000.patch
>
>
> My colleague [~ajhalani] noticed that declaring a {{solr-solrj}} dependency
> alone when configuring {{-Dlog4j.configurationFile}} for a project is not
> sufficient.
> I looked into further and it seems that the {{log4j-slf4j-impl}} jar is
> (inadvertently?) missing in {{solrj/lib}} in the release?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13000) log4j-slf4j-impl jar (inadvertently?) missing in solrj/lib
[
https://issues.apache.org/jira/browse/SOLR-13000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691771#comment-16691771
]
Christine Poerschke commented on SOLR-13000:
Attached proposed patch to change a {{conf="test"}} to a {{conf="compile"}} in
{{solr/solrj/ivy.xml}} file.
> log4j-slf4j-impl jar (inadvertently?) missing in solrj/lib
> --
>
> Key: SOLR-13000
> URL: https://issues.apache.org/jira/browse/SOLR-13000
> Project: Solr
> Issue Type: Bug
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Attachments: SOLR-13000.patch
>
>
> My colleague [~ajhalani] noticed that declaring a {{solr-solrj}} dependency
> alone when configuring {{-Dlog4j.configurationFile}} for a project is not
> sufficient.
> I looked into further and it seems that the {{log4j-slf4j-impl}} jar is
> (inadvertently?) missing in {{solrj/lib}} in the release?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
