[jira] [Commented] (SOLR-13138) Remove deprecated code in master
[ https://issues.apache.org/jira/browse/SOLR-13138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925662#comment-16925662 ] ASF subversion and git services commented on SOLR-13138: Commit 46825ba94d5805b96c376c00d05d16c921cde4ad in lucene-solr's branch refs/heads/master-deprecations from David Smiley [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=46825ba ] SOLR-13138: Spatial removals and deprecations: * Removed GeoHashField. (was deprecated) * Removed LatLonType (was deprecated) * Removed SpatialPointVectorFieldType (was deprecated) * Removed SpatialTermQueryPrefixTreeFieldType (was deprecated) * Deprecated legacy/BBoxStrategy as we will switch to Lucene's. Related to Trie/Points conversion. * Removed spatial fields from some of our examples that don't exercise spatial. > Remove deprecated code in master > > > Key: SOLR-13138 > URL: https://issues.apache.org/jira/browse/SOLR-13138 > Project: Solr > Issue Type: Improvement >Affects Versions: master (9.0) >Reporter: Alan Woodward >Priority: Major > > There are a number of deprecations in master that should be removed. This > issue is to keep track of deprecations as a whole, some individual > deprecations may require their own issues. > > Work on this issue should be pushed to the `master-deprecations` branch on > gitbox. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13138) Remove deprecated code in master
[ https://issues.apache.org/jira/browse/SOLR-13138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925654#comment-16925654 ] David Smiley commented on SOLR-13138: - Two Jira issues but one branch, and thus presumably one commit that spans projects? Ehh; this wouldn't be my preference but I guess it's okay. > Remove deprecated code in master > > > Key: SOLR-13138 > URL: https://issues.apache.org/jira/browse/SOLR-13138 > Project: Solr > Issue Type: Improvement >Affects Versions: master (9.0) >Reporter: Alan Woodward >Priority: Major > > There are a number of deprecations in master that should be removed. This > issue is to keep track of deprecations as a whole, some individual > deprecations may require their own issues. > > Work on this issue should be pushed to the `master-deprecations` branch on > gitbox. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13138) Remove deprecated code in master
[ https://issues.apache.org/jira/browse/SOLR-13138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743626#comment-16743626 ] David Smiley commented on SOLR-13138: - I volunteer for the spatial stuff & highlighting stuff. BTW I think in your description mentioning that the branch is "on gitbox" seems too specific as it is on GitHub too. I think we all know where to find the branches :) > Remove deprecated code in master > > > Key: SOLR-13138 > URL: https://issues.apache.org/jira/browse/SOLR-13138 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: master (9.0) >Reporter: Alan Woodward >Priority: Major > > There are a number of deprecations in master that should be removed. This > issue is to keep track of deprecations as a whole, some individual > deprecations may require their own issues. > > Work on this issue should be pushed to the `master-deprecations` branch on > gitbox. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13138) Remove deprecated code in master
[ https://issues.apache.org/jira/browse/SOLR-13138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742985#comment-16742985 ] Alan Woodward commented on SOLR-13138: -- Related work in lucene is at LUCENE-8638 WordDelimiterFilter, SynonymFilter and LegacyBM25Similarity are all referred to in Solr, but will be deprecated throughout Solr 8.0 and issue warnings whenever they're used, so I think we're safe to just remove all references to them in master. Jaspell is a bit trickier, as it's the default lookup implementation. The JaspellLookupFactory class itself is also not deprecated, so there aren't any warnings emitted when it's used currently (JaspellLookup isn't loaded via a classloader so the normal deprecation checks don't happen there). We should open a separate issue to deal with this in isolation. > Remove deprecated code in master > > > Key: SOLR-13138 > URL: https://issues.apache.org/jira/browse/SOLR-13138 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: master (9.0) >Reporter: Alan Woodward >Priority: Major > > There are a number of deprecations in master that should be removed. This > issue is to keep track of deprecations as a whole, some individual > deprecations may require their own issues. > > Work on this issue should be pushed to the `master-deprecations` branch on > gitbox. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13138) Remove deprecated code in master
[ https://issues.apache.org/jira/browse/SOLR-13138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742971#comment-16742971 ] Alan Woodward commented on SOLR-13138: -- The following files in Solr contain deprecated methods or classes: solr/contrib/analytics/src/java/org/apache/solr/analytics/function/field/DateMultiTrieField.java:30:@Deprecated solr/contrib/analytics/src/java/org/apache/solr/analytics/function/field/DoubleMultiTrieField.java:35:@Deprecated solr/contrib/analytics/src/java/org/apache/solr/analytics/function/field/IntMultiTrieField.java:37:@Deprecated solr/contrib/analytics/src/java/org/apache/solr/analytics/function/field/LongMultiTrieField.java:35:@Deprecated solr/contrib/analytics/src/java/org/apache/solr/analytics/function/field/FloatMultiTrieField.java:36:@Deprecated solr/core/src/test/org/apache/solr/handler/tagger/EmbeddedSolrNoSerializeTest.java:96: // Deprecated in 7.2 but should live on until 8.x solr/core/src/test/org/apache/solr/TestTrie.java:39:@Deprecated solr/core/src/test/org/apache/solr/legacy/TestNumericTokenStream.java:29:@Deprecated solr/core/src/test/org/apache/solr/search/TestTrieFacet.java:28:@Deprecated solr/core/src/test/org/apache/solr/schema/TrieIntPrefixActsAsRangeQueryFieldType.java:29:@Deprecated solr/core/src/test/org/apache/solr/schema/WrappedTrieIntField.java:25:@Deprecated solr/core/src/java/org/apache/solr/handler/StandardRequestHandler.java:21:@Deprecated solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java:151: @Deprecated solr/core/src/java/org/apache/solr/handler/component/HighlightComponent.java:86: @Deprecated // DWS: in 7.0 lets restructure the abstractions/relationships solr/core/src/java/org/apache/solr/handler/component/HighlightComponent.java:93: @Deprecated solr/core/src/java/org/apache/solr/handler/component/HighlightComponent.java:99: @Deprecated solr/core/src/java/org/apache/solr/handler/SnapShooter.java:66: @Deprecated solr/core/src/java/org/apache/solr/core/SolrCore.java:729: @Deprecated solr/core/src/java/org/apache/solr/core/NodeConfig.java:64: @Deprecated solr/core/src/java/org/apache/solr/core/NodeConfig.java:233: @Deprecated solr/core/src/java/org/apache/solr/core/NodeConfig.java:358: @Deprecated solr/core/src/java/org/apache/solr/analysis/LowerCaseTokenizer.java:41:@Deprecated solr/core/src/java/org/apache/solr/analysis/LowerCaseTokenizerFactory.java:45:@Deprecated solr/core/src/java/org/apache/solr/response/DocsStreamer.java:120: @Deprecated solr/core/src/java/org/apache/solr/update/DefaultSolrCoreState.java:89: @Deprecated solr/core/src/java/org/apache/solr/highlight/PostingsSolrHighlighter.java:37:@Deprecated solr/core/src/java/org/apache/solr/internal/csv/CSVStrategy.java:107: @Deprecated solr/core/src/java/org/apache/solr/internal/csv/CSVStrategy.java:118: @Deprecated solr/core/src/java/org/apache/solr/internal/csv/CSVStrategy.java:123: @Deprecated solr/core/src/java/org/apache/solr/internal/csv/CSVStrategy.java:128: @Deprecated solr/core/src/java/org/apache/solr/internal/csv/CSVStrategy.java:134: @Deprecated solr/core/src/java/org/apache/solr/internal/csv/CSVStrategy.java:139: @Deprecated solr/core/src/java/org/apache/solr/internal/csv/CSVStrategy.java:146: @Deprecated solr/core/src/java/org/apache/solr/internal/csv/CSVStrategy.java:153: @Deprecated solr/core/src/java/org/apache/solr/internal/csv/CSVStrategy.java:160: @Deprecated solr/core/src/java/org/apache/solr/internal/csv/CSVStrategy.java:165: @Deprecated solr/core/src/java/org/apache/solr/internal/csv/CSVStrategy.java:174: @Deprecated solr/core/src/java/org/apache/solr/internal/csv/CSVStrategy.java:189:@Deprecated solr/core/src/java/org/apache/solr/legacy/LegacyNumericTokenStream.java:93:@Deprecated solr/core/src/java/org/apache/solr/legacy/LegacyDoubleField.java:115:@Deprecated solr/core/src/java/org/apache/solr/legacy/LegacyIntField.java:114:@Deprecated solr/core/src/java/org/apache/solr/legacy/LegacyFloatField.java:113:@Deprecated solr/core/src/java/org/apache/solr/legacy/LegacyNumericRangeQuery.java:177:@Deprecated solr/core/src/java/org/apache/solr/legacy/LegacyNumericUtils.java:58:@Deprecated solr/core/src/java/org/apache/solr/legacy/PointVectorStrategy.java:85: @Deprecated solr/core/src/java/org/apache/solr/legacy/PointVectorStrategy.java:133: @Deprecated solr/core/src/java/org/apache/solr/legacy/BBoxStrategy.java:88: @Deprecated solr/core/src/java/org/apache/solr/legacy/BBoxStrategy.java:146: @Deprecated solr/core/src/java/org/apache/solr/legacy/LegacyLongField.java:125:@Deprecated solr/core/src/java/org/apache/solr/legacy/LegacyNumericType.java:24:@Deprecated solr/core/src/java/org/apache/solr/legacy/LegacyFieldType.java:26:@Deprecated solr/core/src/java/org/apache/solr/legacy/LegacyFieldType.java:55: @Deprecated solr/core/src/java/org/apache/solr/legacy/LegacyFieldType.java:71: @Deprecated