[jira] [Commented] (SOLR-13404) group.query doesn't work in distrib mode when group.format=simple
[ https://issues.apache.org/jira/browse/SOLR-13404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877093#comment-16877093 ] ASF subversion and git services commented on SOLR-13404: Commit 48b026d5eedcfa2090596639dd5282fac18db40a in lucene-solr's branch refs/heads/SOLR-13105-visual from Munendra S N [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=48b026d ] SOLR-13404: Fix NPE when group=true and no group.field is present * This was introduced in SOLR-12249 > group.query doesn't work in distrib mode when group.format=simple > - > > Key: SOLR-13404 > URL: https://issues.apache.org/jira/browse/SOLR-13404 > Project: Solr > Issue Type: Bug >Reporter: Munendra S N >Assignee: Munendra S N >Priority: Major > Fix For: 8.2 > > Attachments: SOLR-13404.patch, SOLR-13404.patch > > > While working on SOLR-12248, found that for group.query response is returned > only when group.format=grouped(default format) in distrib mode. For > group.main=true, request fails with AIOOE and for group.format=simple, no > grouped is returned -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13404) group.query doesn't work in distrib mode when group.format=simple
[ https://issues.apache.org/jira/browse/SOLR-13404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877091#comment-16877091 ] ASF subversion and git services commented on SOLR-13404: Commit cfd22cd493d3b0feab8f582b6981cc05ee4f31a3 in lucene-solr's branch refs/heads/SOLR-13105-visual from Munendra S N [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=cfd22cd ] SOLR-13404: support group.query in multishard env with group.main=true group.query after execution forms QueryCommandResult. In case of group.main=true or group.format=simple, QueryCommandResult was not consumed in EndResultTransformer. Also, MainEndResultTransformer assumed that always group.field would be specified. When group.field not specified it failed with AIOOBE. After adding suppport for QueryCommandResult in EndResultTransformers and handling AIOOBE, group.query started giving results Working on tests exposed few other issues. Results differed b/w standalone & distributed mode. * One of the reason is that TopGroupShardResponseProcessor doesn't consider correct limit and offset when group format is simple. In case of simple, start and rows should be used as limit and offset instead of group.limit and group.offset. * Secondly, In distributed second phase grouping, computing docsToCollect didn't consider group response format. This issue is again similar to above issue * offset(group.offset or start) not being considered during TopDocs#merge caused different results. The fix was to use to offset in merge process * group.offset doesn't support negative values but there is no checks on the value. In case of negative values AIOOBE. Now, checks are added for negative values and returns proper error message(this change is for both standalone and distrbuted). Validation is done only in case of group.format=grouped as that is only case when group.offset is consumed. Fixing above issues resolved the differences b/w standalone and distributed mode. > group.query doesn't work in distrib mode when group.format=simple > - > > Key: SOLR-13404 > URL: https://issues.apache.org/jira/browse/SOLR-13404 > Project: Solr > Issue Type: Bug >Reporter: Munendra S N >Assignee: Munendra S N >Priority: Major > Fix For: 8.2 > > Attachments: SOLR-13404.patch, SOLR-13404.patch > > > While working on SOLR-12248, found that for group.query response is returned > only when group.format=grouped(default format) in distrib mode. For > group.main=true, request fails with AIOOE and for group.format=simple, no > grouped is returned -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13404) group.query doesn't work in distrib mode when group.format=simple
[ https://issues.apache.org/jira/browse/SOLR-13404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876669#comment-16876669 ] ASF subversion and git services commented on SOLR-13404: Commit 00d931aaa727d3dcf2706f76e9a4938df12afc59 in lucene-solr's branch refs/heads/branch_8x from Munendra S N [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=00d931a ] SOLR-13404: Fix NPE when group=true and no group.field is present * This was introduced in SOLR-12249 > group.query doesn't work in distrib mode when group.format=simple > - > > Key: SOLR-13404 > URL: https://issues.apache.org/jira/browse/SOLR-13404 > Project: Solr > Issue Type: Bug >Reporter: Munendra S N >Assignee: Munendra S N >Priority: Major > Fix For: 8.2 > > Attachments: SOLR-13404.patch, SOLR-13404.patch > > > While working on SOLR-12248, found that for group.query response is returned > only when group.format=grouped(default format) in distrib mode. For > group.main=true, request fails with AIOOE and for group.format=simple, no > grouped is returned -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13404) group.query doesn't work in distrib mode when group.format=simple
[ https://issues.apache.org/jira/browse/SOLR-13404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876664#comment-16876664 ] ASF subversion and git services commented on SOLR-13404: Commit 48b026d5eedcfa2090596639dd5282fac18db40a in lucene-solr's branch refs/heads/master from Munendra S N [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=48b026d ] SOLR-13404: Fix NPE when group=true and no group.field is present * This was introduced in SOLR-12249 > group.query doesn't work in distrib mode when group.format=simple > - > > Key: SOLR-13404 > URL: https://issues.apache.org/jira/browse/SOLR-13404 > Project: Solr > Issue Type: Bug >Reporter: Munendra S N >Assignee: Munendra S N >Priority: Major > Fix For: 8.2 > > Attachments: SOLR-13404.patch, SOLR-13404.patch > > > While working on SOLR-12248, found that for group.query response is returned > only when group.format=grouped(default format) in distrib mode. For > group.main=true, request fails with AIOOE and for group.format=simple, no > grouped is returned -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13404) group.query doesn't work in distrib mode when group.format=simple
[ https://issues.apache.org/jira/browse/SOLR-13404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876628#comment-16876628 ] ASF subversion and git services commented on SOLR-13404: Commit d811f8634252c9567966dc64482ff3bd2abb69ad in lucene-solr's branch refs/heads/branch_8x from Munendra S N [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=d811f86 ] SOLR-13404: support group.query in multishard env with group.main=true group.query after execution forms QueryCommandResult. In case of group.main=true or group.format=simple, QueryCommandResult was not consumed in EndResultTransformer. Also, MainEndResultTransformer assumed that always group.field would be specified. When group.field not specified it failed with AIOOBE. After adding suppport for QueryCommandResult in EndResultTransformers and handling AIOOBE, group.query started giving results Working on tests exposed few other issues. Results differed b/w standalone & distributed mode. * One of the reason is that TopGroupShardResponseProcessor doesn't consider correct limit and offset when group format is simple. In case of simple, start and rows should be used as limit and offset instead of group.limit and group.offset. * Secondly, In distributed second phase grouping, computing docsToCollect didn't consider group response format. This issue is again similar to above issue * offset(group.offset or start) not being considered during TopDocs#merge caused different results. The fix was to use to offset in merge process * group.offset doesn't support negative values but there is no checks on the value. In case of negative values AIOOBE. Now, checks are added for negative values and returns proper error message(this change is for both standalone and distrbuted). Validation is done only in case of group.format=grouped as that is only case when group.offset is consumed. Fixing above issues resolved the differences b/w standalone and distributed mode. > group.query doesn't work in distrib mode when group.format=simple > - > > Key: SOLR-13404 > URL: https://issues.apache.org/jira/browse/SOLR-13404 > Project: Solr > Issue Type: Bug >Reporter: Munendra S N >Priority: Major > Attachments: SOLR-13404.patch, SOLR-13404.patch > > > While working on SOLR-12248, found that for group.query response is returned > only when group.format=grouped(default format) in distrib mode. For > group.main=true, request fails with AIOOE and for group.format=simple, no > grouped is returned -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13404) group.query doesn't work in distrib mode when group.format=simple
[ https://issues.apache.org/jira/browse/SOLR-13404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876619#comment-16876619 ] ASF subversion and git services commented on SOLR-13404: Commit cfd22cd493d3b0feab8f582b6981cc05ee4f31a3 in lucene-solr's branch refs/heads/master from Munendra S N [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=cfd22cd ] SOLR-13404: support group.query in multishard env with group.main=true group.query after execution forms QueryCommandResult. In case of group.main=true or group.format=simple, QueryCommandResult was not consumed in EndResultTransformer. Also, MainEndResultTransformer assumed that always group.field would be specified. When group.field not specified it failed with AIOOBE. After adding suppport for QueryCommandResult in EndResultTransformers and handling AIOOBE, group.query started giving results Working on tests exposed few other issues. Results differed b/w standalone & distributed mode. * One of the reason is that TopGroupShardResponseProcessor doesn't consider correct limit and offset when group format is simple. In case of simple, start and rows should be used as limit and offset instead of group.limit and group.offset. * Secondly, In distributed second phase grouping, computing docsToCollect didn't consider group response format. This issue is again similar to above issue * offset(group.offset or start) not being considered during TopDocs#merge caused different results. The fix was to use to offset in merge process * group.offset doesn't support negative values but there is no checks on the value. In case of negative values AIOOBE. Now, checks are added for negative values and returns proper error message(this change is for both standalone and distrbuted). Validation is done only in case of group.format=grouped as that is only case when group.offset is consumed. Fixing above issues resolved the differences b/w standalone and distributed mode. > group.query doesn't work in distrib mode when group.format=simple > - > > Key: SOLR-13404 > URL: https://issues.apache.org/jira/browse/SOLR-13404 > Project: Solr > Issue Type: Bug >Reporter: Munendra S N >Priority: Major > Attachments: SOLR-13404.patch, SOLR-13404.patch > > > While working on SOLR-12248, found that for group.query response is returned > only when group.format=grouped(default format) in distrib mode. For > group.main=true, request fails with AIOOE and for group.format=simple, no > grouped is returned -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13404) group.query doesn't work in distrib mode when group.format=simple
[ https://issues.apache.org/jira/browse/SOLR-13404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873788#comment-16873788 ] Munendra S N commented on SOLR-13404: - I'm planning to commit this on 30th June/1st July if there are no objections/vetos > group.query doesn't work in distrib mode when group.format=simple > - > > Key: SOLR-13404 > URL: https://issues.apache.org/jira/browse/SOLR-13404 > Project: Solr > Issue Type: Bug >Reporter: Munendra S N >Priority: Major > Attachments: SOLR-13404.patch, SOLR-13404.patch > > > While working on SOLR-12248, found that for group.query response is returned > only when group.format=grouped(default format) in distrib mode. For > group.main=true, request fails with AIOOE and for group.format=simple, no > grouped is returned -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13404) group.query doesn't work in distrib mode when group.format=simple
[
https://issues.apache.org/jira/browse/SOLR-13404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871742#comment-16871742
]
Lucene/Solr QA commented on SOLR-13404:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
55s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 1m 55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 1m 55s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 49m
56s{color} | {color:green} core in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 56m 38s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13404 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12972742/SOLR-13404.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon
Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 9cfba4a |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 |
| Default Java | LTS |
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/457/testReport/ |
| modules | C: solr/core U: solr/core |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/457/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> group.query doesn't work in distrib mode when group.format=simple
> -
>
> Key: SOLR-13404
> URL: https://issues.apache.org/jira/browse/SOLR-13404
> Project: Solr
> Issue Type: Bug
>Reporter: Munendra S N
>Priority: Major
> Attachments: SOLR-13404.patch, SOLR-13404.patch
>
>
> While working on SOLR-12248, found that for group.query response is returned
> only when group.format=grouped(default format) in distrib mode. For
> group.main=true, request fails with AIOOE and for group.format=simple, no
> grouped is returned
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13404) group.query doesn't work in distrib mode when group.format=simple
[ https://issues.apache.org/jira/browse/SOLR-13404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871227#comment-16871227 ] Munendra S N commented on SOLR-13404: - [^SOLR-13404.patch] * Updated patch based on changes in SOLR-13496 * Removed usage of deprecated methods from the patch [~hossman] [~cpoerschke] Could you guys please review this once?? > group.query doesn't work in distrib mode when group.format=simple > - > > Key: SOLR-13404 > URL: https://issues.apache.org/jira/browse/SOLR-13404 > Project: Solr > Issue Type: Bug >Reporter: Munendra S N >Priority: Major > Attachments: SOLR-13404.patch, SOLR-13404.patch > > > While working on SOLR-12248, found that for group.query response is returned > only when group.format=grouped(default format) in distrib mode. For > group.main=true, request fails with AIOOE and for group.format=simple, no > grouped is returned -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13404) group.query doesn't work in distrib mode when group.format=simple
[
https://issues.apache.org/jira/browse/SOLR-13404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823549#comment-16823549
]
Lucene/Solr QA commented on SOLR-13404:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
1s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 1m 51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 1m 51s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 44m
55s{color} | {color:green} core in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 51m 39s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13404 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12966631/SOLR-13404.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon
Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / a95e68e |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 |
| Default Java | LTS |
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/381/testReport/ |
| modules | C: solr/core U: solr/core |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/381/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> group.query doesn't work in distrib mode when group.format=simple
> -
>
> Key: SOLR-13404
> URL: https://issues.apache.org/jira/browse/SOLR-13404
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Munendra S N
>Priority: Major
> Attachments: SOLR-13404.patch
>
>
> While working on SOLR-12248, found that for group.query response is returned
> only when group.format=grouped(default format) in distrib mode. For
> group.main=true, request fails with AIOOE and for group.format=simple, no
> grouped is returned
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13404) group.query doesn't work in distrib mode when group.format=simple
[ https://issues.apache.org/jira/browse/SOLR-13404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823171#comment-16823171 ] Munendra S N commented on SOLR-13404: - [^SOLR-13404.patch] This patch * adds support to return group.query response in distrib mode when group.main=true or group.format=simple * Also, fixes SOLR-4181 * Respects group.limit and group.offset when group.format=grouped and group.query is specified in distrib * handles negative values for group.offset. Currently, AIOOBE is thrown for -ve values With this patch, group.query in distrib mode mimics the behavior of group.query in standalone mode. One case not handled is when rows is -ve which is allowed in grouping. Negative value for rows in distributed grouped doesn't work properly and this issue is not limited group.query(it affects group.field too). Probably, will spinoff new issue for that > group.query doesn't work in distrib mode when group.format=simple > - > > Key: SOLR-13404 > URL: https://issues.apache.org/jira/browse/SOLR-13404 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Munendra S N >Priority: Major > Attachments: SOLR-13404.patch > > > While working on SOLR-12248, found that for group.query response is returned > only when group.format=grouped(default format) in distrib mode. For > group.main=true, request fails with AIOOE and for group.format=simple, no > grouped is returned -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
