[jira] [Commented] (SOLR-13629) Remove trailing whitespace from analytics package
[ https://issues.apache.org/jira/browse/SOLR-13629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894832#comment-16894832 ] Jason Gerlowski commented on SOLR-13629: Thanks for separating out your changes Neal. Merged your path to master and branch_8x. > Remove trailing whitespace from analytics package > - > > Key: SOLR-13629 > URL: https://issues.apache.org/jira/browse/SOLR-13629 > Project: Solr > Issue Type: Task >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Assignee: Jason Gerlowski >Priority: Trivial > Attachments: SOLR-13629.patch > > > I"m making some changes to analytics and noticed that the guidelines ask to > create separate patches for formatting/whitespace changes. This issue is > meant for the patch to remove trailing whitespace, but preserves newlines if > the trailing whitespace was on a line with only whitespace. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13629) Remove trailing whitespace from analytics package
[ https://issues.apache.org/jira/browse/SOLR-13629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894785#comment-16894785 ] ASF subversion and git services commented on SOLR-13629: Commit ca4cd3c7d34acc6a9bdd3527400146e7a6951f70 in lucene-solr's branch refs/heads/branch_8x from Jason Gerlowski [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=ca4cd3c ] SOLR-13629: Cleanup whitespace in analytics contrib > Remove trailing whitespace from analytics package > - > > Key: SOLR-13629 > URL: https://issues.apache.org/jira/browse/SOLR-13629 > Project: Solr > Issue Type: Task >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Trivial > Attachments: SOLR-13629.patch > > > I"m making some changes to analytics and noticed that the guidelines ask to > create separate patches for formatting/whitespace changes. This issue is > meant for the patch to remove trailing whitespace, but preserves newlines if > the trailing whitespace was on a line with only whitespace. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13629) Remove trailing whitespace from analytics package
[ https://issues.apache.org/jira/browse/SOLR-13629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894783#comment-16894783 ] ASF subversion and git services commented on SOLR-13629: Commit cab83772c9e2f6e654a21163025ec87a3635dca6 in lucene-solr's branch refs/heads/master from Jason Gerlowski [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=cab8377 ] SOLR-13629: Cleanup whitespace in analytics contrib > Remove trailing whitespace from analytics package > - > > Key: SOLR-13629 > URL: https://issues.apache.org/jira/browse/SOLR-13629 > Project: Solr > Issue Type: Task >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Trivial > Attachments: SOLR-13629.patch > > > I"m making some changes to analytics and noticed that the guidelines ask to > create separate patches for formatting/whitespace changes. This issue is > meant for the patch to remove trailing whitespace, but preserves newlines if > the trailing whitespace was on a line with only whitespace. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13629) Remove trailing whitespace from analytics package
[
https://issues.apache.org/jira/browse/SOLR-13629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884719#comment-16884719
]
Lucene/Solr QA commented on SOLR-13629:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 79 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
37s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 1m 32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 1m 32s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
7s{color} | {color:green} analytics in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 10m 46s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13629 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12974618/SOLR-13629.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon
Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 1a53d86 |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 |
| Default Java | LTS |
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/488/testReport/ |
| modules | C: solr/contrib/analytics U: solr/contrib/analytics |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/488/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Remove trailing whitespace from analytics package
> -
>
> Key: SOLR-13629
> URL: https://issues.apache.org/jira/browse/SOLR-13629
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
>Affects Versions: 8.1.1
>Reporter: Neal Sidhwaney
>Priority: Trivial
> Attachments: SOLR-13629.patch
>
>
> I"m making some changes to analytics and noticed that the guidelines ask to
> create separate patches for formatting/whitespace changes. This issue is
> meant for the patch to remove trailing whitespace, but preserves newlines if
> the trailing whitespace was on a line with only whitespace.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
