[jira] [Commented] (SOLR-13645) Add analytics function to format/extract components from dates
[ https://issues.apache.org/jira/browse/SOLR-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904402#comment-16904402 ] Neal Sidhwaney commented on SOLR-13645: --- Hi there, Any chance this patch could be reviewed? Thank you. Neal > Add analytics function to format/extract components from dates > -- > > Key: SOLR-13645 > URL: https://issues.apache.org/jira/browse/SOLR-13645 > Project: Solr > Issue Type: New Feature >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Minor > Attachments: SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch > > > It's helpful when running analytics to be able to do manipulation on dates > such as extracting month/day/year, converting to th week of year, etc, and > other formatting as many existing libraries provide. I have a patch going > through final testing that will add this to the analytcs library. > One thing I'm sort of amibvialent about is that it exposes that we use Java > date parsing in the analytics function, because the syntax is the same format > string that SimpleDateFormat accepts. Ideally there would be an abstraction > between the analytics language and what's used on the backend to implement > it. On the other hand, implementing a syntax for time/date formatting is > something that's been done many many times before, and this is not the only > place where Java date particulars show through. It would be good to revisit > this at a later time. > > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13645) Add analytics function to format/extract components from dates
[
https://issues.apache.org/jira/browse/SOLR-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895689#comment-16895689
]
Lucene/Solr QA commented on SOLR-13645:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
4s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 2m 36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 2m 27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 2m 27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate ref guide {color} |
{color:green} 2m 27s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
53s{color} | {color:green} analytics in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 10m 55s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13645 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12976133/SOLR-13645-Analytics-function-for-date-components.patch
|
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns validaterefguide |
| uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP
Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 70a8deb |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 |
| Default Java | LTS |
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/514/testReport/ |
| modules | C: solr/contrib/analytics solr/solr-ref-guide U: solr |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/514/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Add analytics function to format/extract components from dates
> --
>
> Key: SOLR-13645
> URL: https://issues.apache.org/jira/browse/SOLR-13645
> Project: Solr
> Issue Type: New Feature
>Affects Versions: 8.1.1
>Reporter: Neal Sidhwaney
>Priority: Minor
> Attachments: SOLR-13645-Analytics-function-for-date-components.patch,
> SOLR-13645-Analytics-function-for-date-components.patch,
> SOLR-13645-Analytics-function-for-date-components.patch,
> SOLR-13645-Analytics-function-for-date-components.patch,
> SOLR-13645-Analytics-function-for-date-components.patch,
> SOLR-13645-Analytics-function-for-date-components.patch
>
>
> It's helpful when running analytics to be able to do manipulation on dates
> such as extracting month/day/year, converting to th week of year, etc, and
> other formatting as many existing libraries provide. I have a patch going
> through final testing that will add this to the analytcs library.
> One thing I'm sort of amibvialent about is that it exposes that we use Java
> date parsing in the analytics function, because the syntax is the same format
> string that SimpleDateFormat accepts. Ideally there would be an abstraction
> between the analytics language and what's used on the backend to implement
> it. On the other hand, implementing a syntax for time/date formatting is
> something that's been done many many times before, and this is not the only
> place where Java date particulars show through. It would be good to revisit
> this at a later time.
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13645) Add analytics function to format/extract components from dates
[ https://issues.apache.org/jira/browse/SOLR-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895461#comment-16895461 ] Neal Sidhwaney commented on SOLR-13645: --- Just an FYI - I rebased on top of HEAD, no action necessary. THanks, Neal > Add analytics function to format/extract components from dates > -- > > Key: SOLR-13645 > URL: https://issues.apache.org/jira/browse/SOLR-13645 > Project: Solr > Issue Type: New Feature >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Minor > Attachments: SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch > > > It's helpful when running analytics to be able to do manipulation on dates > such as extracting month/day/year, converting to th week of year, etc, and > other formatting as many existing libraries provide. I have a patch going > through final testing that will add this to the analytcs library. > One thing I'm sort of amibvialent about is that it exposes that we use Java > date parsing in the analytics function, because the syntax is the same format > string that SimpleDateFormat accepts. Ideally there would be an abstraction > between the analytics language and what's used on the backend to implement > it. On the other hand, implementing a syntax for time/date formatting is > something that's been done many many times before, and this is not the only > place where Java date particulars show through. It would be good to revisit > this at a later time. > > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13645) Add analytics function to format/extract components from dates
[
https://issues.apache.org/jira/browse/SOLR-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894539#comment-16894539
]
Lucene/Solr QA commented on SOLR-13645:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
29s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 3m 8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 2m 59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 2m 59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate ref guide {color} |
{color:green} 2m 59s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
28s{color} | {color:green} analytics in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 12m 42s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13645 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12976051/SOLR-13645-Analytics-function-for-date-components.patch
|
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns validaterefguide |
| uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP
Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 4050ddc |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 |
| Default Java | LTS |
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/511/testReport/ |
| modules | C: solr/contrib/analytics solr/solr-ref-guide U: solr |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/511/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Add analytics function to format/extract components from dates
> --
>
> Key: SOLR-13645
> URL: https://issues.apache.org/jira/browse/SOLR-13645
> Project: Solr
> Issue Type: New Feature
>Affects Versions: 8.1.1
>Reporter: Neal Sidhwaney
>Priority: Minor
> Attachments: SOLR-13645-Analytics-function-for-date-components.patch,
> SOLR-13645-Analytics-function-for-date-components.patch,
> SOLR-13645-Analytics-function-for-date-components.patch,
> SOLR-13645-Analytics-function-for-date-components.patch,
> SOLR-13645-Analytics-function-for-date-components.patch
>
>
> It's helpful when running analytics to be able to do manipulation on dates
> such as extracting month/day/year, converting to th week of year, etc, and
> other formatting as many existing libraries provide. I have a patch going
> through final testing that will add this to the analytcs library.
> One thing I'm sort of amibvialent about is that it exposes that we use Java
> date parsing in the analytics function, because the syntax is the same format
> string that SimpleDateFormat accepts. Ideally there would be an abstraction
> between the analytics language and what's used on the backend to implement
> it. On the other hand, implementing a syntax for time/date formatting is
> something that's been done many many times before, and this is not the only
> place where Java date particulars show through. It would be good to revisit
> this at a later time.
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13645) Add analytics function to format/extract components from dates
[ https://issues.apache.org/jira/browse/SOLR-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894377#comment-16894377 ] Neal Sidhwaney commented on SOLR-13645: --- Couldn't reproduce the failures, and ditn' see anything jumping out at me when re-reviewing. The changes are independent from SOLR-13643, but my git branch was based off the branch I used for that patch (it was impossible to test with my own build of Solr otherwise), so this time, I created a patch without doing that. > Add analytics function to format/extract components from dates > -- > > Key: SOLR-13645 > URL: https://issues.apache.org/jira/browse/SOLR-13645 > Project: Solr > Issue Type: New Feature >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Minor > Attachments: SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch > > > It's helpful when running analytics to be able to do manipulation on dates > such as extracting month/day/year, converting to th week of year, etc, and > other formatting as many existing libraries provide. I have a patch going > through final testing that will add this to the analytcs library. > One thing I'm sort of amibvialent about is that it exposes that we use Java > date parsing in the analytics function, because the syntax is the same format > string that SimpleDateFormat accepts. Ideally there would be an abstraction > between the analytics language and what's used on the backend to implement > it. On the other hand, implementing a syntax for time/date formatting is > something that's been done many many times before, and this is not the only > place where Java date particulars show through. It would be good to revisit > this at a later time. > > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13645) Add analytics function to format/extract components from dates
[ https://issues.apache.org/jira/browse/SOLR-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894319#comment-16894319 ] Neal Sidhwaney commented on SOLR-13645: --- Woops, not sure how this happened. Will take a look and reupload. Sorry about that! Neal > Add analytics function to format/extract components from dates > -- > > Key: SOLR-13645 > URL: https://issues.apache.org/jira/browse/SOLR-13645 > Project: Solr > Issue Type: New Feature >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Minor > Attachments: SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch > > > It's helpful when running analytics to be able to do manipulation on dates > such as extracting month/day/year, converting to th week of year, etc, and > other formatting as many existing libraries provide. I have a patch going > through final testing that will add this to the analytcs library. > One thing I'm sort of amibvialent about is that it exposes that we use Java > date parsing in the analytics function, because the syntax is the same format > string that SimpleDateFormat accepts. Ideally there would be an abstraction > between the analytics language and what's used on the backend to implement > it. On the other hand, implementing a syntax for time/date formatting is > something that's been done many many times before, and this is not the only > place where Java date particulars show through. It would be good to revisit > this at a later time. > > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13645) Add analytics function to format/extract components from dates
[
https://issues.apache.org/jira/browse/SOLR-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894246#comment-16894246
]
Lucene/Solr QA commented on SOLR-13645:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
36s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 1m 35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 1m 35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate ref guide {color} |
{color:green} 1m 35s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 2m 15s{color}
| {color:red} analytics in the patch failed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 9m 49s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | solr.analytics.function.mapping.DateFormatFunctionTest |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13645 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12976002/SOLR-13645-Analytics-function-for-date-components.patch
|
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns validaterefguide |
| uname | Linux lucene1-us-west 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 4050ddc59b |
| ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 |
| Default Java | LTS |
| unit |
https://builds.apache.org/job/PreCommit-SOLR-Build/508/artifact/out/patch-unit-solr_contrib_analytics.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/508/testReport/ |
| modules | C: solr/contrib/analytics solr/solr-ref-guide U: solr |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/508/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Add analytics function to format/extract components from dates
> --
>
> Key: SOLR-13645
> URL: https://issues.apache.org/jira/browse/SOLR-13645
> Project: Solr
> Issue Type: New Feature
>Affects Versions: 8.1.1
>Reporter: Neal Sidhwaney
>Priority: Minor
> Attachments: SOLR-13645-Analytics-function-for-date-components.patch,
> SOLR-13645-Analytics-function-for-date-components.patch,
> SOLR-13645-Analytics-function-for-date-components.patch,
> SOLR-13645-Analytics-function-for-date-components.patch
>
>
> It's helpful when running analytics to be able to do manipulation on dates
> such as extracting month/day/year, converting to th week of year, etc, and
> other formatting as many existing libraries provide. I have a patch going
> through final testing that will add this to the analytcs library.
> One thing I'm sort of amibvialent about is that it exposes that we use Java
> date parsing in the analytics function, because the syntax is the same format
> string that SimpleDateFormat accepts. Ideally there would be an abstraction
> between the analytics language and what's used on the backend to implement
> it. On the other hand, implementing a syntax for time/date formatting is
> something that's been done many many times before, and this is not the only
> place where Java date particulars show through. It would be good to revisit
> this at a later time.
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail:
[jira] [Commented] (SOLR-13645) Add analytics function to format/extract components from dates
[ https://issues.apache.org/jira/browse/SOLR-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894094#comment-16894094 ] Neal Sidhwaney commented on SOLR-13645: --- FYI(no action necessary) the patch has been updated to apply to HEAD. Thanks! Neal > Add analytics function to format/extract components from dates > -- > > Key: SOLR-13645 > URL: https://issues.apache.org/jira/browse/SOLR-13645 > Project: Solr > Issue Type: New Feature >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Minor > Attachments: SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch > > > It's helpful when running analytics to be able to do manipulation on dates > such as extracting month/day/year, converting to th week of year, etc, and > other formatting as many existing libraries provide. I have a patch going > through final testing that will add this to the analytcs library. > One thing I'm sort of amibvialent about is that it exposes that we use Java > date parsing in the analytics function, because the syntax is the same format > string that SimpleDateFormat accepts. Ideally there would be an abstraction > between the analytics language and what's used on the backend to implement > it. On the other hand, implementing a syntax for time/date formatting is > something that's been done many many times before, and this is not the only > place where Java date particulars show through. It would be good to revisit > this at a later time. > > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13645) Add analytics function to format/extract components from dates
[
https://issues.apache.org/jira/browse/SOLR-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889752#comment-16889752
]
Lucene/Solr QA commented on SOLR-13645:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
39s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 1m 33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 1m 33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate ref guide {color} |
{color:green} 1m 33s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
23s{color} | {color:green} analytics in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 8m 59s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13645 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12975343/SOLR-13645-Analytics-function-for-date-components.patch
|
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns validaterefguide |
| uname | Linux lucene1-us-west 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / c173c2e863 |
| ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 |
| Default Java | LTS |
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/506/testReport/ |
| modules | C: solr/contrib/analytics solr/solr-ref-guide U: solr |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/506/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Add analytics function to format/extract components from dates
> --
>
> Key: SOLR-13645
> URL: https://issues.apache.org/jira/browse/SOLR-13645
> Project: Solr
> Issue Type: New Feature
> Security Level: Public(Default Security Level. Issues are Public)
>Affects Versions: 8.1.1
>Reporter: Neal Sidhwaney
>Priority: Minor
> Attachments: SOLR-13645-Analytics-function-for-date-components.patch,
> SOLR-13645-Analytics-function-for-date-components.patch,
> SOLR-13645-Analytics-function-for-date-components.patch
>
>
> It's helpful when running analytics to be able to do manipulation on dates
> such as extracting month/day/year, converting to th week of year, etc, and
> other formatting as many existing libraries provide. I have a patch going
> through final testing that will add this to the analytcs library.
> One thing I'm sort of amibvialent about is that it exposes that we use Java
> date parsing in the analytics function, because the syntax is the same format
> string that SimpleDateFormat accepts. Ideally there would be an abstraction
> between the analytics language and what's used on the backend to implement
> it. On the other hand, implementing a syntax for time/date formatting is
> something that's been done many many times before, and this is not the only
> place where Java date particulars show through. It would be good to revisit
> this at a later time.
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13645) Add analytics function to format/extract components from dates
[ https://issues.apache.org/jira/browse/SOLR-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889699#comment-16889699 ] Neal Sidhwaney commented on SOLR-13645: --- I removed the use of the APIs that didn't take locales and added ones that called getDefaultLocale. I spent some time making a patch that took the locale as a parameter (so it would add another parameter to the analytics function call from the client) but decided against it for a couple reasons: * The locale for date formatting really only makes sense in the context of using the Java short/medium/long styles, but not when the user is being explicit about the format string. * It ends up exposing more of the Java date interface through the analytics interface It's a judgement call, but, in my opinion, it simplifies the interface and parameters can be added later on if it's deemed necessary to support. Happy to discuss further if anyone feels it should be done differently. > Add analytics function to format/extract components from dates > -- > > Key: SOLR-13645 > URL: https://issues.apache.org/jira/browse/SOLR-13645 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Minor > Attachments: SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch > > > It's helpful when running analytics to be able to do manipulation on dates > such as extracting month/day/year, converting to th week of year, etc, and > other formatting as many existing libraries provide. I have a patch going > through final testing that will add this to the analytcs library. > One thing I'm sort of amibvialent about is that it exposes that we use Java > date parsing in the analytics function, because the syntax is the same format > string that SimpleDateFormat accepts. Ideally there would be an abstraction > between the analytics language and what's used on the backend to implement > it. On the other hand, implementing a syntax for time/date formatting is > something that's been done many many times before, and this is not the only > place where Java date particulars show through. It would be good to revisit > this at a later time. > > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13645) Add analytics function to format/extract components from dates
[
https://issues.apache.org/jira/browse/SOLR-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889524#comment-16889524
]
Lucene/Solr QA commented on SOLR-13645:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
35s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 35s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} Check forbidden APIs {color} | {color:red}
1m 35s{color} | {color:red} Check forbidden APIs check-forbidden-apis failed
{color} |
| {color:red}-1{color} | {color:red} Validate source patterns {color} |
{color:red} 1m 35s{color} | {color:red} Check forbidden APIs
check-forbidden-apis failed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
5s{color} | {color:green} analytics in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 7m 8s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13645 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12975309/SOLR-13645-Analytics-function-for-date-components.patch
|
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / ebeae0c889 |
| ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 |
| Default Java | LTS |
| Check forbidden APIs |
https://builds.apache.org/job/PreCommit-SOLR-Build/503/artifact/out/patch-check-forbidden-apis-solr.txt
|
| Validate source patterns |
https://builds.apache.org/job/PreCommit-SOLR-Build/503/artifact/out/patch-check-forbidden-apis-solr.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/503/testReport/ |
| modules | C: solr/contrib/analytics U: solr/contrib/analytics |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/503/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Add analytics function to format/extract components from dates
> --
>
> Key: SOLR-13645
> URL: https://issues.apache.org/jira/browse/SOLR-13645
> Project: Solr
> Issue Type: New Feature
> Security Level: Public(Default Security Level. Issues are Public)
>Affects Versions: 8.1.1
>Reporter: Neal Sidhwaney
>Priority: Minor
> Attachments: SOLR-13645-Analytics-function-for-date-components.patch
>
>
> It's helpful when running analytics to be able to do manipulation on dates
> such as extracting month/day/year, converting to th week of year, etc, and
> other formatting as many existing libraries provide. I have a patch going
> through final testing that will add this to the analytcs library.
> One thing I'm sort of amibvialent about is that it exposes that we use Java
> date parsing in the analytics function, because the syntax is the same format
> string that SimpleDateFormat accepts. Ideally there would be an abstraction
> between the analytics language and what's used on the backend to implement
> it. On the other hand, implementing a syntax for time/date formatting is
> something that's been done many many times before, and this is not the only
> place where Java date particulars show through. It would be good to revisit
> this at a later time.
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
